)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"cfad61cf77f0605487067e47556ec9d9ffb86083","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Without this fix, provisioning of nodes will stop"},{"line_number":10,"context_line":"after waiting for further informations as IPA"},{"line_number":11,"context_line":"will be using default address (http://127.0.0.1:6585)"},{"line_number":12,"context_line":"because proper value is not present in ironic.conf."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I4c733dba8e65fe624c9de5b9c5722cef2df59109"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_35092adc","line":12,"updated":"2018-09-06 10:49:52.000000000","message":"The default for ironic is to fetch it from keystone. Maybe we do not populate the keystone endpoint list correctly? This fix does not look right to me.","commit_id":"66b2e9a64d2930c9e6f592e8a0469c8931c8e29d"}],"playbooks/roles/bifrost-ironic-install/tasks/keystone_setup.yml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9e289922f580631744a0fa5bae078e5debcd8a40","unresolved":false,"context_lines":[{"line_number":172,"context_line":""},{"line_number":173,"context_line":"- name: \"Setting external Ironic public URL\""},{"line_number":174,"context_line":"  set_fact:"},{"line_number":175,"context_line":"    ironic_public_url: \"{{ ironic.keystone.public_url | default(\u0027http://127.0.0.1:6385/\u0027) | replace(\u0027127.0.0.1\u0027, hostvars[inventory_hostname][\u0027ansible_\u0027 + ans_network_interface][\u0027ipv4\u0027][\u0027address\u0027]) }}\""},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"- name: \"Create ironic public endpoint\""},{"line_number":178,"context_line":"  command: |"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_23719f45","line":175,"updated":"2018-09-11 08:42:44.000000000","message":"what if we set this fact only if use_public_urls is true, otherwise we set a fact similar to the previously used? I\u0027m trying to make line 186 a bit easier to understand.","commit_id":"bcd1ba36d4343821c338849171889b1db033d6dd"},{"author":{"_account_id":19578,"name":"Olivier Bourdon","email":"olivierbourdon38@gmail.com","username":"olivierbourdon38"},"change_message_id":"9e67fea3f7d281db79f7c5a48b01aa71908c3665","unresolved":false,"context_lines":[{"line_number":172,"context_line":""},{"line_number":173,"context_line":"- name: \"Setting external Ironic public URL\""},{"line_number":174,"context_line":"  set_fact:"},{"line_number":175,"context_line":"    ironic_public_url: \"{{ ironic.keystone.public_url | default(\u0027http://127.0.0.1:6385/\u0027) | replace(\u0027127.0.0.1\u0027, hostvars[inventory_hostname][\u0027ansible_\u0027 + ans_network_interface][\u0027ipv4\u0027][\u0027address\u0027]) }}\""},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"- name: \"Create ironic public endpoint\""},{"line_number":178,"context_line":"  command: |"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_e363a740","line":175,"in_reply_to":"3f79a3b5_23719f45","updated":"2018-09-11 08:52:36.000000000","message":"Done","commit_id":"bcd1ba36d4343821c338849171889b1db033d6dd"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"11bf2413e7657b10ce8d6dbee64adf4c9e4fcb0c","unresolved":false,"context_lines":[{"line_number":184,"context_line":"    --os-auth-url \"{{ ironic.service_catalog.auth_url | default(\u0027http://127.0.0.1:5000/\u0027) }}\""},{"line_number":185,"context_line":"    --os-project-name \"{{ keystone.bootstrap.project_name | default(\u0027admin\u0027) }}\""},{"line_number":186,"context_line":"    endpoint create --region \"{{ keystone.bootstrap.region_name | default(\u0027RegionOne\u0027) }}\""},{"line_number":187,"context_line":"    baremetal public \"{{ ironic_public_url | ironic.keystone.public_url | default(\u0027http://127.0.0.1:6385/\u0027) }}\""},{"line_number":188,"context_line":"  no_log: true"},{"line_number":189,"context_line":"  environment: \"{{ bifrost_venv_env if enable_venv else {} }}\""},{"line_number":190,"context_line":"  when: test_ironic_public_endpoint.rc !\u003d 0 or test_ironic_public_endpoint.stdout \u003d\u003d \u0027[]\u0027"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_61d6af56","line":187,"updated":"2018-09-11 10:37:08.000000000","message":"did you mean default(ironic.keystone.public_url) ?","commit_id":"1f1f25631af0a0f235aa8cc984c2e155779ba5df"},{"author":{"_account_id":19578,"name":"Olivier Bourdon","email":"olivierbourdon38@gmail.com","username":"olivierbourdon38"},"change_message_id":"188f0ecf40cfe4f5ff4e3b287865b0729867177b","unresolved":false,"context_lines":[{"line_number":184,"context_line":"    --os-auth-url \"{{ ironic.service_catalog.auth_url | default(\u0027http://127.0.0.1:5000/\u0027) }}\""},{"line_number":185,"context_line":"    --os-project-name \"{{ keystone.bootstrap.project_name | default(\u0027admin\u0027) }}\""},{"line_number":186,"context_line":"    endpoint create --region \"{{ keystone.bootstrap.region_name | default(\u0027RegionOne\u0027) }}\""},{"line_number":187,"context_line":"    baremetal public \"{{ ironic_public_url | ironic.keystone.public_url | default(\u0027http://127.0.0.1:6385/\u0027) }}\""},{"line_number":188,"context_line":"  no_log: true"},{"line_number":189,"context_line":"  environment: \"{{ bifrost_venv_env if enable_venv else {} }}\""},{"line_number":190,"context_line":"  when: test_ironic_public_endpoint.rc !\u003d 0 or test_ironic_public_endpoint.stdout \u003d\u003d \u0027[]\u0027"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_fca82479","line":187,"in_reply_to":"3f79a3b5_61d6af56","updated":"2018-09-11 12:30:18.000000000","message":"Done","commit_id":"1f1f25631af0a0f235aa8cc984c2e155779ba5df"}],"playbooks/roles/bifrost-ironic-install/tasks/keystone_setup_inspector.yml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9e289922f580631744a0fa5bae078e5debcd8a40","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"- name: \"Setting external ironic-inspector public URL\""},{"line_number":152,"context_line":"  set_fact:"},{"line_number":153,"context_line":"    ironic_inspector_public_url: \"{{ ironic_inspector.keystone.public_url | default(\u0027http://127.0.0.1:5050/\u0027) | replace(\u0027127.0.0.1\u0027, hostvars[inventory_hostname][\u0027ansible_\u0027 + ans_network_interface][\u0027ipv4\u0027][\u0027address\u0027]) }}\""},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"# NOTE(TheJulia): This seems like something that should be"},{"line_number":156,"context_line":"# to admin or internal interfaces. Perhaps we should attempt"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_c38b0b15","line":153,"updated":"2018-09-11 08:42:44.000000000","message":"ditto","commit_id":"bcd1ba36d4343821c338849171889b1db033d6dd"},{"author":{"_account_id":19578,"name":"Olivier Bourdon","email":"olivierbourdon38@gmail.com","username":"olivierbourdon38"},"change_message_id":"9e67fea3f7d281db79f7c5a48b01aa71908c3665","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"- name: \"Setting external ironic-inspector public URL\""},{"line_number":152,"context_line":"  set_fact:"},{"line_number":153,"context_line":"    ironic_inspector_public_url: \"{{ ironic_inspector.keystone.public_url | default(\u0027http://127.0.0.1:5050/\u0027) | replace(\u0027127.0.0.1\u0027, hostvars[inventory_hostname][\u0027ansible_\u0027 + ans_network_interface][\u0027ipv4\u0027][\u0027address\u0027]) }}\""},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"# NOTE(TheJulia): This seems like something that should be"},{"line_number":156,"context_line":"# to admin or internal interfaces. Perhaps we should attempt"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_8358b38a","line":153,"in_reply_to":"3f79a3b5_c38b0b15","updated":"2018-09-11 08:52:36.000000000","message":"Done","commit_id":"bcd1ba36d4343821c338849171889b1db033d6dd"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"11bf2413e7657b10ce8d6dbee64adf4c9e4fcb0c","unresolved":false,"context_lines":[{"line_number":165,"context_line":"    --os-auth-url \"{{ ironic.service_catalog.auth_url | default(\u0027http://127.0.0.1:5000/\u0027) }}\""},{"line_number":166,"context_line":"    --os-project-name admin"},{"line_number":167,"context_line":"    endpoint create --region \"{{ keystone.bootstrap.region_name | default(\u0027RegionOne\u0027) }}\""},{"line_number":168,"context_line":"    baremetal-introspection public \"{{ ironic_inspector_public_url | ironic_inspector.keystone.public_url | default(\u0027http://127.0.0.1:5050/\u0027) }}\""},{"line_number":169,"context_line":"  no_log: true"},{"line_number":170,"context_line":"  environment: \"{{ bifrost_venv_env if enable_venv else {} }}\""},{"line_number":171,"context_line":"  when: test_ironic_inspector_public_endpoint.rc !\u003d 0 or test_ironic_inspector_public_endpoint.stdout \u003d\u003d \u0027[]\u0027"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_01e33b36","line":168,"updated":"2018-09-11 10:37:08.000000000","message":"ditto?","commit_id":"1f1f25631af0a0f235aa8cc984c2e155779ba5df"},{"author":{"_account_id":19578,"name":"Olivier Bourdon","email":"olivierbourdon38@gmail.com","username":"olivierbourdon38"},"change_message_id":"188f0ecf40cfe4f5ff4e3b287865b0729867177b","unresolved":false,"context_lines":[{"line_number":165,"context_line":"    --os-auth-url \"{{ ironic.service_catalog.auth_url | default(\u0027http://127.0.0.1:5000/\u0027) }}\""},{"line_number":166,"context_line":"    --os-project-name admin"},{"line_number":167,"context_line":"    endpoint create --region \"{{ keystone.bootstrap.region_name | default(\u0027RegionOne\u0027) }}\""},{"line_number":168,"context_line":"    baremetal-introspection public \"{{ ironic_inspector_public_url | ironic_inspector.keystone.public_url | default(\u0027http://127.0.0.1:5050/\u0027) }}\""},{"line_number":169,"context_line":"  no_log: true"},{"line_number":170,"context_line":"  environment: \"{{ bifrost_venv_env if enable_venv else {} }}\""},{"line_number":171,"context_line":"  when: test_ironic_inspector_public_endpoint.rc !\u003d 0 or test_ironic_inspector_public_endpoint.stdout \u003d\u003d \u0027[]\u0027"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_bcb4ecd5","line":168,"in_reply_to":"3f79a3b5_01e33b36","updated":"2018-09-11 12:30:18.000000000","message":"Done","commit_id":"1f1f25631af0a0f235aa8cc984c2e155779ba5df"}],"playbooks/roles/bifrost-keystone-install/tasks/bootstrap.yml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"11bf2413e7657b10ce8d6dbee64adf4c9e4fcb0c","unresolved":false,"context_lines":[{"line_number":174,"context_line":"    --bootstrap-project-name\u003d\"{{ keystone.bootstrap.project_name }}\""},{"line_number":175,"context_line":"    --bootstrap-service-name\u003d\"keystone\""},{"line_number":176,"context_line":"    --bootstrap-admin-url\u003d\"{{ keystone.bootstrap.admin_url }}\""},{"line_number":177,"context_line":"    --bootstrap-public-url\u003d\"{{ keystone_public_url | keystone.bootstrap.public_url }}\""},{"line_number":178,"context_line":"    --bootstrap-internal-url\u003d\"{{ keystone.bootstrap.internal_url }}\""},{"line_number":179,"context_line":"    --bootstrap-region-id\u003d\"{{ keystone.bootstrap.region_name }}\""},{"line_number":180,"context_line":"  environment: \"{{ bifrost_venv_env if enable_venv else {} }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_21e0b726","line":177,"updated":"2018-09-11 10:37:08.000000000","message":"ditto?","commit_id":"1f1f25631af0a0f235aa8cc984c2e155779ba5df"},{"author":{"_account_id":19578,"name":"Olivier Bourdon","email":"olivierbourdon38@gmail.com","username":"olivierbourdon38"},"change_message_id":"188f0ecf40cfe4f5ff4e3b287865b0729867177b","unresolved":false,"context_lines":[{"line_number":174,"context_line":"    --bootstrap-project-name\u003d\"{{ keystone.bootstrap.project_name }}\""},{"line_number":175,"context_line":"    --bootstrap-service-name\u003d\"keystone\""},{"line_number":176,"context_line":"    --bootstrap-admin-url\u003d\"{{ keystone.bootstrap.admin_url }}\""},{"line_number":177,"context_line":"    --bootstrap-public-url\u003d\"{{ keystone_public_url | keystone.bootstrap.public_url }}\""},{"line_number":178,"context_line":"    --bootstrap-internal-url\u003d\"{{ keystone.bootstrap.internal_url }}\""},{"line_number":179,"context_line":"    --bootstrap-region-id\u003d\"{{ keystone.bootstrap.region_name }}\""},{"line_number":180,"context_line":"  environment: \"{{ bifrost_venv_env if enable_venv else {} }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_dcb9a8cb","line":177,"in_reply_to":"3f79a3b5_21e0b726","updated":"2018-09-11 12:30:18.000000000","message":"Done","commit_id":"1f1f25631af0a0f235aa8cc984c2e155779ba5df"}],"releasenotes/notes/use_public_urls_endpoints-1220a7f4164696c3.yaml":[{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"bfe3f47dfadad7610cd0786abf047a5c4d9a529a","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    By adding extra boolean variable ``-e use_public_urls\u003dtrue``"},{"line_number":5,"context_line":"    Bifrost, if used with Keystone enabled, will configure "},{"line_number":6,"context_line":"    public services endpoints (for Keystone, Ironic and Ironic"},{"line_number":7,"context_line":"    Inspector) to contain the public IP address of the node"},{"line_number":8,"context_line":"    where Bifrost is running in replacement of the default"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_1b2bea81","line":5,"range":{"start_line":5,"start_character":58,"end_line":5,"end_character":59},"updated":"2018-09-20 10:54:44.000000000","message":"nit, extra whitespace","commit_id":"80ab977f2f66874b1054df6868ec0ecf4fad09d7"},{"author":{"_account_id":19578,"name":"Olivier Bourdon","email":"olivierbourdon38@gmail.com","username":"olivierbourdon38"},"change_message_id":"613689a9be1ada685f1ea6ceb5d3f9e07db990e8","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    By adding extra boolean variable ``-e use_public_urls\u003dtrue``"},{"line_number":5,"context_line":"    Bifrost, if used with Keystone enabled, will configure "},{"line_number":6,"context_line":"    public services endpoints (for Keystone, Ironic and Ironic"},{"line_number":7,"context_line":"    Inspector) to contain the public IP address of the node"},{"line_number":8,"context_line":"    where Bifrost is running in replacement of the default"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_46587456","line":5,"range":{"start_line":5,"start_character":58,"end_line":5,"end_character":59},"in_reply_to":"3f79a3b5_1b2bea81","updated":"2018-09-24 08:40:23.000000000","message":"Done","commit_id":"80ab977f2f66874b1054df6868ec0ecf4fad09d7"}]}