)]}'
{"playbooks/roles/bifrost-ironic-install/defaults/main.yml":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"af5e23d8cf015d8d6d55323801645d76d404b9b3","unresolved":false,"context_lines":[{"line_number":42,"context_line":"# documentation at https://ipxe.org/crypto"},{"line_number":43,"context_line":"ipa_file_protocol: \"http\""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"ipa_upstream_release: \"stable/rocky\""},{"line_number":46,"context_line":"ipa_kernel: \"{{http_boot_folder}}/ipa.vmlinuz\""},{"line_number":47,"context_line":"ipa_ramdisk: \"{{http_boot_folder}}/ipa.initramfs\""},{"line_number":48,"context_line":"ipa_kernel_url: \"{{ ipa_file_protocol }}://{{ hostvars[inventory_hostname][\u0027ansible_\u0027 + ans_network_interface][\u0027ipv4\u0027][\u0027address\u0027] }}:{{file_url_port}}/ipa.vmlinuz\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_487fdd15","line":45,"updated":"2018-11-19 12:28:54.000000000","message":"This may need a release note, or be reverted, as the Rocky release notes document that the default for `ipa_upstream_release` is `master`: https://docs.openstack.org/releasenotes/bifrost/rocky.html#new-features","commit_id":"7cb0e526b566a2234cfcf76f362c79e4df0fa157"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0dce5ed08fb04cc080b4b48fb930f4dbbc7fe5b3","unresolved":false,"context_lines":[{"line_number":42,"context_line":"# documentation at https://ipxe.org/crypto"},{"line_number":43,"context_line":"ipa_file_protocol: \"http\""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"ipa_upstream_release: \"stable/rocky\""},{"line_number":46,"context_line":"ipa_kernel: \"{{http_boot_folder}}/ipa.vmlinuz\""},{"line_number":47,"context_line":"ipa_ramdisk: \"{{http_boot_folder}}/ipa.initramfs\""},{"line_number":48,"context_line":"ipa_kernel_url: \"{{ ipa_file_protocol }}://{{ hostvars[inventory_hostname][\u0027ansible_\u0027 + ans_network_interface][\u0027ipv4\u0027][\u0027address\u0027] }}:{{file_url_port}}/ipa.vmlinuz\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_4836fd03","line":45,"in_reply_to":"3f79a3b5_487fdd15","updated":"2018-11-19 13:03:08.000000000","message":"We shouldn\u0027t revert it. The IPA image should be tied to the same version as ironic to ensure long term compatibility.\n\nPerhaps we could add a release note about the dependencies being changed to rocky from master - I don\u0027t think it should be specific to IPA.","commit_id":"7cb0e526b566a2234cfcf76f362c79e4df0fa157"}],"playbooks/roles/bifrost-prep-for-install/README.md":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"452967ec913054ed235a852e617b348ffee94a9b","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"keystone_git_branch: Branch to install, defaults to \"stable/rocky\"."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"dib_git_branch: Branch to install, defaults to \"master\"."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"ironicinspector_git_branch: Branch to install, defaults to \"master\"."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"ironicinspectorclient_git_branch: Branch to install, defaults to \"master\"."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"reqs_git_branch: Branch to install, defaults to \"master\"."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"staging_drivers_git_branch: Branch to install, defaults to \"master\"."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"keystone_git_branch: Branch to install, defaults to \"master\"."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"copy_from_local_path: Boolean value, defaults to false. If set to true,"},{"line_number":75,"context_line":"                      the role will attempt to perform a filesystem copy of"}],"source_content_type":"text/x-gfm","patch_set":1,"id":"3f79a3b5_887f3567","line":72,"range":{"start_line":62,"start_character":0,"end_line":72,"end_character":61},"updated":"2018-11-19 12:05:56.000000000","message":"Shouldn\u0027t you delete these lines?","commit_id":"126466760244f1cfb7655899f89b1bae39362a89"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"6dda749c1a3360f2efded6cb418a9739c731595b","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"keystone_git_branch: Branch to install, defaults to \"stable/rocky\"."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"dib_git_branch: Branch to install, defaults to \"master\"."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"ironicinspector_git_branch: Branch to install, defaults to \"master\"."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"ironicinspectorclient_git_branch: Branch to install, defaults to \"master\"."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"reqs_git_branch: Branch to install, defaults to \"master\"."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"staging_drivers_git_branch: Branch to install, defaults to \"master\"."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"keystone_git_branch: Branch to install, defaults to \"master\"."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"copy_from_local_path: Boolean value, defaults to false. If set to true,"},{"line_number":75,"context_line":"                      the role will attempt to perform a filesystem copy of"}],"source_content_type":"text/x-gfm","patch_set":1,"id":"3f79a3b5_a8deb168","line":72,"range":{"start_line":62,"start_character":0,"end_line":72,"end_character":61},"in_reply_to":"3f79a3b5_887f3567","updated":"2018-11-19 12:08:34.000000000","message":"Looks like the cherry pick went awry.","commit_id":"126466760244f1cfb7655899f89b1bae39362a89"}]}