)]}'
{"playbooks/roles/bifrost-ironic-install/tasks/start.yml":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"0e14a3d309d7d66f137fa4562403e591f5933e2a","unresolved":false,"context_lines":[{"line_number":27,"context_line":"- import_role:"},{"line_number":28,"context_line":"    name: bifrost-rabbitmq"},{"line_number":29,"context_line":"    tasks_from: start"},{"line_number":30,"context_line":"  when: use_rabbitmq"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- name: \"start ironic-inspector\""},{"line_number":33,"context_line":"  include: inspector_start.yml"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5fc1f717_4e72c64b","line":30,"updated":"2019-04-02 07:24:05.000000000","message":"it looks like created a duplicated import:\n\n  ironic-install/main.yml\n    -\u003e rabbitmq/main.yml\n       -\u003e rabbitmq/start.yml\n  ironic-install/start.yml\n    -\u003e rabbitmq/start.yml\n\nmaybe we need to move rabbitmq install task to a install.yml?\n\nwell, maybe it\u0027s not a much trouble considering the famous stateless ansible, but I think a follow up is better if the issue is valid.","commit_id":"0d036d6a7c070a94f04c6ea8e35bb46b384c9c3a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"215ec4c30be453fa302bcc9faf5f905532f2c60a","unresolved":false,"context_lines":[{"line_number":27,"context_line":"- import_role:"},{"line_number":28,"context_line":"    name: bifrost-rabbitmq"},{"line_number":29,"context_line":"    tasks_from: start"},{"line_number":30,"context_line":"  when: use_rabbitmq"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- name: \"start ironic-inspector\""},{"line_number":33,"context_line":"  include: inspector_start.yml"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5fc1f717_e239423f","line":30,"in_reply_to":"5fc1f717_4e72c64b","updated":"2019-04-02 11:29:23.000000000","message":"I\u0027m not sure I understand bifrost well enough, but I assumed that you could use starting separately.","commit_id":"0d036d6a7c070a94f04c6ea8e35bb46b384c9c3a"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"0f7233ad80d78e94a516b255e534d30174034db5","unresolved":false,"context_lines":[{"line_number":27,"context_line":"- import_role:"},{"line_number":28,"context_line":"    name: bifrost-rabbitmq"},{"line_number":29,"context_line":"    tasks_from: start"},{"line_number":30,"context_line":"  when: use_rabbitmq"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- name: \"start ironic-inspector\""},{"line_number":33,"context_line":"  include: inspector_start.yml"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5fc1f717_8e2657ba","line":30,"in_reply_to":"5fc1f717_e239423f","updated":"2019-04-03 02:04:21.000000000","message":"I don\u0027t know how to start separately, rabbitmq is supposed to be started at bootstrap stage, we can skip some stages however, maybe you mean skipping other stages like install/start, which turns out to be executing a single stage, that make sense to me then.\n\nAnother thing: originally the rabbitmq service is under skip_bootstrap, but now the only condition controlling is use_rabbitmq, that probably needs a fix.","commit_id":"0d036d6a7c070a94f04c6ea8e35bb46b384c9c3a"}],"playbooks/roles/bifrost-ironic-install/templates/ironic.conf.j2":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"0e14a3d309d7d66f137fa4562403e591f5933e2a","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"[json_rpc]"},{"line_number":128,"context_line":"{% if enable_keystone is defined and enable_keystone | bool \u003d\u003d true %}"},{"line_number":129,"context_line":"auth_url \u003d {{ ironic.service_catalog.auth_url }}"},{"line_number":130,"context_line":"auth_type \u003d password"},{"line_number":131,"context_line":"project_name \u003d {{ ironic.service_catalog.project_name }}"},{"line_number":132,"context_line":"username \u003d {{ ironic.service_catalog.username }}"},{"line_number":133,"context_line":"password \u003d {{ ironic.service_catalog.password }}"},{"line_number":134,"context_line":"user_domain_id \u003d default"},{"line_number":135,"context_line":"project_domain_id \u003d default"},{"line_number":136,"context_line":"{% else %}"},{"line_number":137,"context_line":"auth_type \u003d none"},{"line_number":138,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"5fc1f717_0ed6fe28","line":135,"range":{"start_line":129,"start_character":0,"end_line":135,"end_character":27},"updated":"2019-04-02 07:24:05.000000000","message":"do we require these options set? it seems json rpc uses credentials from keystone_authtoken:\nhttps://github.com/openstack/ironic/blob/7efbbcc/ironic/common/json_rpc/server.py#L93","commit_id":"0d036d6a7c070a94f04c6ea8e35bb46b384c9c3a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"215ec4c30be453fa302bcc9faf5f905532f2c60a","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"[json_rpc]"},{"line_number":128,"context_line":"{% if enable_keystone is defined and enable_keystone | bool \u003d\u003d true %}"},{"line_number":129,"context_line":"auth_url \u003d {{ ironic.service_catalog.auth_url }}"},{"line_number":130,"context_line":"auth_type \u003d password"},{"line_number":131,"context_line":"project_name \u003d {{ ironic.service_catalog.project_name }}"},{"line_number":132,"context_line":"username \u003d {{ ironic.service_catalog.username }}"},{"line_number":133,"context_line":"password \u003d {{ ironic.service_catalog.password }}"},{"line_number":134,"context_line":"user_domain_id \u003d default"},{"line_number":135,"context_line":"project_domain_id \u003d default"},{"line_number":136,"context_line":"{% else %}"},{"line_number":137,"context_line":"auth_type \u003d none"},{"line_number":138,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"5fc1f717_a2433aaf","line":135,"range":{"start_line":129,"start_character":0,"end_line":135,"end_character":27},"in_reply_to":"5fc1f717_0ed6fe28","updated":"2019-04-02 11:29:23.000000000","message":"Server side - yes. The client side uses these ones.","commit_id":"0d036d6a7c070a94f04c6ea8e35bb46b384c9c3a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2561b1f8c76ccdcf8a0c07516947a0ac9f62e446","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"[json_rpc]"},{"line_number":128,"context_line":"{% if enable_keystone is defined and enable_keystone | bool \u003d\u003d true %}"},{"line_number":129,"context_line":"auth_url \u003d {{ ironic.service_catalog.auth_url }}"},{"line_number":130,"context_line":"auth_type \u003d password"},{"line_number":131,"context_line":"project_name \u003d {{ ironic.service_catalog.project_name }}"},{"line_number":132,"context_line":"username \u003d {{ ironic.service_catalog.username }}"},{"line_number":133,"context_line":"password \u003d {{ ironic.service_catalog.password }}"},{"line_number":134,"context_line":"user_domain_id \u003d default"},{"line_number":135,"context_line":"project_domain_id \u003d default"},{"line_number":136,"context_line":"{% else %}"},{"line_number":137,"context_line":"auth_type \u003d none"},{"line_number":138,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"5fc1f717_4e914a9a","line":135,"range":{"start_line":129,"start_character":0,"end_line":135,"end_character":27},"in_reply_to":"5fc1f717_8bee4989","updated":"2019-04-03 09:16:57.000000000","message":"They\u0027re only identical in simple cases, there are subtle differences.","commit_id":"0d036d6a7c070a94f04c6ea8e35bb46b384c9c3a"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"0f7233ad80d78e94a516b255e534d30174034db5","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"[json_rpc]"},{"line_number":128,"context_line":"{% if enable_keystone is defined and enable_keystone | bool \u003d\u003d true %}"},{"line_number":129,"context_line":"auth_url \u003d {{ ironic.service_catalog.auth_url }}"},{"line_number":130,"context_line":"auth_type \u003d password"},{"line_number":131,"context_line":"project_name \u003d {{ ironic.service_catalog.project_name }}"},{"line_number":132,"context_line":"username \u003d {{ ironic.service_catalog.username }}"},{"line_number":133,"context_line":"password \u003d {{ ironic.service_catalog.password }}"},{"line_number":134,"context_line":"user_domain_id \u003d default"},{"line_number":135,"context_line":"project_domain_id \u003d default"},{"line_number":136,"context_line":"{% else %}"},{"line_number":137,"context_line":"auth_type \u003d none"},{"line_number":138,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"5fc1f717_8bee4989","line":135,"range":{"start_line":129,"start_character":0,"end_line":135,"end_character":27},"in_reply_to":"5fc1f717_a2433aaf","updated":"2019-04-03 02:04:21.000000000","message":"erh.. I suppose they use the same section, is there any consideration why we source options differently for server/client?","commit_id":"0d036d6a7c070a94f04c6ea8e35bb46b384c9c3a"}]}