)]}'
{"scripts/collect-test-info.sh":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"34673536cd56c5d9fbddcf6a7fd05d36fe6149c8","unresolved":false,"context_lines":[{"line_number":27,"context_line":"dmesg \u0026\u003e ${LOG_LOCATION}/dmesg.log"},{"line_number":28,"context_line":"# NOTE(TheJulia): Netstat exits with error code 5 when --version is used."},{"line_number":29,"context_line":"sudo netstat -apn \u0026\u003e ${LOG_LOCATION}/netstat.log"},{"line_number":30,"context_line":"if $(iptables --version \u0026\u003e/dev/null); then"},{"line_number":31,"context_line":"    iptables_dir\u003d\"${LOG_LOCATION}/iptables\""},{"line_number":32,"context_line":"    mkdir ${iptables_dir}"},{"line_number":33,"context_line":"    sudo iptables -S \u0026\u003e ${iptables_dir}/iptables_all_saved_rules.txt"}],"source_content_type":"text/x-sh","patch_set":1,"id":"5fc1f717_4a6004a6","line":30,"updated":"2019-04-08 09:07:40.000000000","message":"This check is false at least on centos, I wonder if we should install iptables..","commit_id":"1d2fee6058ac346e66e766acd4e2821030a6596d"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"c297ddb9f29efb44f70f5ba5734dee81f8e7ed2a","unresolved":false,"context_lines":[{"line_number":27,"context_line":"dmesg \u0026\u003e ${LOG_LOCATION}/dmesg.log"},{"line_number":28,"context_line":"# NOTE(TheJulia): Netstat exits with error code 5 when --version is used."},{"line_number":29,"context_line":"sudo netstat -apn \u0026\u003e ${LOG_LOCATION}/netstat.log"},{"line_number":30,"context_line":"if $(iptables --version \u0026\u003e/dev/null); then"},{"line_number":31,"context_line":"    iptables_dir\u003d\"${LOG_LOCATION}/iptables\""},{"line_number":32,"context_line":"    mkdir ${iptables_dir}"},{"line_number":33,"context_line":"    sudo iptables -S \u0026\u003e ${iptables_dir}/iptables_all_saved_rules.txt"}],"source_content_type":"text/x-sh","patch_set":1,"id":"5fc1f717_a843b03e","line":30,"in_reply_to":"5fc1f717_4a6004a6","updated":"2019-04-08 09:42:00.000000000","message":"weird, iptables should be installed, there are ansible tasks that rely on that and they\u0027re WAI\nmaybe execution permissions are more strict than in ubuntu?\nI will try and call this with sudo","commit_id":"1d2fee6058ac346e66e766acd4e2821030a6596d"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8190bfb5335474ec1dbfac7a928f30723733b3d2","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    mkdir ${iptables_dir}"},{"line_number":33,"context_line":"    sudo iptables -S \u0026\u003e ${iptables_dir}/iptables_all_saved_rules.txt"},{"line_number":34,"context_line":"    for table in filter raw security mangle nat; do"},{"line_number":35,"context_line":"        sudo iptables -L -v -n -t ${table} \u0026\u003e ${iptables_dir}/iptables_${table}.log"},{"line_number":36,"context_line":"    done"},{"line_number":37,"context_line":"fi"},{"line_number":38,"context_line":"if $(ip link \u0026\u003e/dev/null); then"}],"source_content_type":"text/x-sh","patch_set":2,"id":"5fc1f717_c15e1612","line":35,"updated":"2019-04-08 12:59:25.000000000","message":"I usually just go with iptables-save, it prints all rules in all chains in all tables.","commit_id":"a523400fedab98a319aa90f53438d374fb60490e"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"e5979a150e3f332b330e16eb081d7fc9bbd55123","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    mkdir ${iptables_dir}"},{"line_number":33,"context_line":"    sudo iptables -S \u0026\u003e ${iptables_dir}/iptables_all_saved_rules.txt"},{"line_number":34,"context_line":"    for table in filter raw security mangle nat; do"},{"line_number":35,"context_line":"        sudo iptables -L -v -n -t ${table} \u0026\u003e ${iptables_dir}/iptables_${table}.log"},{"line_number":36,"context_line":"    done"},{"line_number":37,"context_line":"fi"},{"line_number":38,"context_line":"if $(ip link \u0026\u003e/dev/null); then"}],"source_content_type":"text/x-sh","patch_set":2,"id":"5fc1f717_f22c349a","line":35,"in_reply_to":"5fc1f717_a18e6a2b","updated":"2019-04-09 02:56:00.000000000","message":"I\u0027m not sure the extra info is needed. It\u0027s more output to save/store and not really sure its that helpful. I\u0027m ok others want to collect this data but could we setup a Collect extra data switch so those like my self could choose not to collect it easily.","commit_id":"a523400fedab98a319aa90f53438d374fb60490e"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"4b73084f3b3f455f13fd4c5f7548902b0227ed69","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    mkdir ${iptables_dir}"},{"line_number":33,"context_line":"    sudo iptables -S \u0026\u003e ${iptables_dir}/iptables_all_saved_rules.txt"},{"line_number":34,"context_line":"    for table in filter raw security mangle nat; do"},{"line_number":35,"context_line":"        sudo iptables -L -v -n -t ${table} \u0026\u003e ${iptables_dir}/iptables_${table}.log"},{"line_number":36,"context_line":"    done"},{"line_number":37,"context_line":"fi"},{"line_number":38,"context_line":"if $(ip link \u0026\u003e/dev/null); then"}],"source_content_type":"text/x-sh","patch_set":2,"id":"5fc1f717_a18e6a2b","line":35,"in_reply_to":"5fc1f717_c15e1612","updated":"2019-04-08 13:16:49.000000000","message":"the reason why I\u0027ve added iptables -L for all tables is because it shows information on traffic (packets/bytes)","commit_id":"a523400fedab98a319aa90f53438d374fb60490e"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"7f72c02b8c0d071fae9cedfc5b526ba93a71ddbe","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    mkdir ${iptables_dir}"},{"line_number":33,"context_line":"    sudo iptables -S \u0026\u003e ${iptables_dir}/iptables_all_saved_rules.txt"},{"line_number":34,"context_line":"    for table in filter raw security mangle nat; do"},{"line_number":35,"context_line":"        sudo iptables -L -v -n -t ${table} \u0026\u003e ${iptables_dir}/iptables_${table}.log"},{"line_number":36,"context_line":"    done"},{"line_number":37,"context_line":"fi"},{"line_number":38,"context_line":"if $(ip link \u0026\u003e/dev/null); then"}],"source_content_type":"text/x-sh","patch_set":2,"id":"5fc1f717_23f6ec5e","line":35,"in_reply_to":"5fc1f717_f22c349a","updated":"2019-04-09 08:14:19.000000000","message":"it\u0027s reasonable, I will add it\nA little bit of context on this:\nI started a test job (https://review.openstack.org/649314) to check how bifrost was behaving on bionic and logging the iptables tables actually shows that there is no traffic on dhcp related rules (http://logs.openstack.org/14/649314/14/check/bifrost-integration-tinyipa-ubuntu-bionic/422c0be/logs/iptables/iptables_filter.log), so I believe the info collected are actually useful, but probably can be restricted for troubleshooting purpose only.","commit_id":"a523400fedab98a319aa90f53438d374fb60490e"}]}