)]}'
{"scripts/collect-test-info.sh":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a72311bf8f043d10611126d2d646ad20b693d1ee","unresolved":false,"context_lines":[{"line_number":67,"context_line":"sudo virsh list --all \u0026\u003e ${LOG_LOCATION}/virsh-list.txt"},{"line_number":68,"context_line":"ps auxf \u0026\u003e ${LOG_LOCATION}/ps.txt"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"sudo cp -rL /etc ${LOG_LOCATION}/"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"sudo chown -R $USER ${LOG_LOCATION}"},{"line_number":73,"context_line":"# In CI scenarios, we want other users to be able to read the logs."}],"source_content_type":"text/x-sh","patch_set":1,"id":"5fc1f717_2acd78b6","line":70,"updated":"2019-04-08 09:05:46.000000000","message":"This breaks the CI, since it copies things like /etc/shadow, which we cannot later read. I suggest you limit this to only files of interest.","commit_id":"d0edfbcf3829ba73d9f55f2371fc9f3ef3e765a6"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"c9a0ada7b88a786f497585209121a773f3c260df","unresolved":false,"context_lines":[{"line_number":67,"context_line":"sudo virsh list --all \u0026\u003e ${LOG_LOCATION}/virsh-list.txt"},{"line_number":68,"context_line":"ps auxf \u0026\u003e ${LOG_LOCATION}/ps.txt"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"sudo cp -rL /etc ${LOG_LOCATION}/"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"sudo chown -R $USER ${LOG_LOCATION}"},{"line_number":73,"context_line":"# In CI scenarios, we want other users to be able to read the logs."}],"source_content_type":"text/x-sh","patch_set":1,"id":"5fc1f717_68c388ee","line":70,"in_reply_to":"5fc1f717_2acd78b6","updated":"2019-04-08 10:05:36.000000000","message":"I\u0027ve modified this to read a list of conf files/dirs that can be interesting for the job analysis.","commit_id":"d0edfbcf3829ba73d9f55f2371fc9f3ef3e765a6"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"546985db7f79a3e4aa4af7cb6dee509ca457b413","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"# Copy relevant conf from etc"},{"line_number":71,"context_line":"mkdir -p ${LOG_LOCATION}/etc/"},{"line_number":72,"context_line":"for CONF in alternatives apparmor.d apparmor dhcp dnsmasq.conf dnsmasq.d-available dnsmasq.d iptables ironic-inspector ironic libvirt qemu sysctl.conf sysctl.d ; do"},{"line_number":73,"context_line":"    sudo cp -rL /etc/${CONF} ${LOG_LOCATION}/etc/"},{"line_number":74,"context_line":"done"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-sh","patch_set":3,"id":"5fc1f717_c1e1362d","line":72,"updated":"2019-04-08 13:03:53.000000000","message":"nginx, rabbitmq, my.cnf?","commit_id":"b5490b9322d2758dddd5837c58b7a9b874e41b13"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"fe6ef6814b5e38b152117f014f0702a72622f8da","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"# Copy relevant conf from etc"},{"line_number":71,"context_line":"mkdir -p ${LOG_LOCATION}/etc/"},{"line_number":72,"context_line":"for CONF in alternatives apparmor.d apparmor dhcp dnsmasq.conf dnsmasq.d-available dnsmasq.d iptables ironic-inspector ironic libvirt qemu sysctl.conf sysctl.d ; do"},{"line_number":73,"context_line":"    sudo cp -rL /etc/${CONF} ${LOG_LOCATION}/etc/"},{"line_number":74,"context_line":"done"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-sh","patch_set":3,"id":"5fc1f717_e1c1d24f","line":72,"in_reply_to":"5fc1f717_c1e1362d","updated":"2019-04-08 13:13:44.000000000","message":"yep, thanks, just skipped them for no reason","commit_id":"b5490b9322d2758dddd5837c58b7a9b874e41b13"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3eb6bbcf6f4fb5e7446a8db0fcc02dd2f96af268","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"# Copy relevant conf from etc"},{"line_number":71,"context_line":"mkdir -p ${LOG_LOCATION}/etc/"},{"line_number":72,"context_line":"for CONF in alternatives apparmor.d apparmor dhcp dnsmasq.conf dnsmasq.d-available dnsmasq.d iptables ironic-inspector ironic libvirt nginx mysql qemu rabbitmq sysctl.conf sysctl.d ; do"},{"line_number":73,"context_line":"    sudo cp -rL /etc/${CONF} ${LOG_LOCATION}/etc/"},{"line_number":74,"context_line":"done"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"3fce034c_ab08fe27","line":72,"range":{"start_line":72,"start_character":25,"end_line":72,"end_character":44},"updated":"2019-04-12 18:49:35.000000000","message":"wouldn\u0027t this stop the rest of the log collection steps in terms of changing the ownership of the files so zuul can read them from the node?","commit_id":"97d75b4eb9ecd6c90240dcb12ea105177f6f560f"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"5c14eca2b23cadab6a399811407b8aedeb42a52c","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"# Copy relevant conf from etc"},{"line_number":71,"context_line":"mkdir -p ${LOG_LOCATION}/etc/"},{"line_number":72,"context_line":"for CONF in alternatives apparmor.d apparmor dhcp dnsmasq.conf dnsmasq.d-available dnsmasq.d iptables ironic-inspector ironic libvirt nginx mysql qemu rabbitmq sysctl.conf sysctl.d ; do"},{"line_number":73,"context_line":"    sudo cp -rL /etc/${CONF} ${LOG_LOCATION}/etc/"},{"line_number":74,"context_line":"done"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"3fce034c_f60ee2e3","line":72,"range":{"start_line":72,"start_character":25,"end_line":72,"end_character":44},"in_reply_to":"3fce034c_ab08fe27","updated":"2019-04-13 16:07:44.000000000","message":"I\u0027m not sure I understand what you mean here, the conf dirs/files are copied under the log location and then the ownership is changed I don\u0027t think that blocks the other log collection steps.\nI don\u0027t see issues in the CI or locally, but maybe I\u0027m missing something?","commit_id":"97d75b4eb9ecd6c90240dcb12ea105177f6f560f"}]}