)]}'
{"bindep.txt":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"83ef87f1b3872db8d47e994881a0e6afeda14d66","unresolved":false,"context_lines":[{"line_number":19,"context_line":"python3-dev          [platform:dpkg]"},{"line_number":20,"context_line":"python3-virtualenv"},{"line_number":21,"context_line":"wget"},{"line_number":22,"context_line":"sudo"}],"source_content_type":"text/plain","patch_set":4,"id":"3fa7e38b_c65ce94d","line":22,"updated":"2020-01-03 00:43:59.000000000","message":"Likely not needed, but maybe better to be explicit?","commit_id":"082303a763a31bef62f04ebadc35f7e553e8a437"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7b18b2b923d25fb8811827c408a7d1c0320e8a6d","unresolved":false,"context_lines":[{"line_number":17,"context_line":"python3-minimal      [platform:dpkg]"},{"line_number":18,"context_line":"python3-devel        [platform:rpm]"},{"line_number":19,"context_line":"python3-dev          [platform:dpkg]"},{"line_number":20,"context_line":"python3-virtualenv"},{"line_number":21,"context_line":"wget"},{"line_number":22,"context_line":"sudo"}],"source_content_type":"text/plain","patch_set":8,"id":"3fa7e38b_5d25ed08","line":20,"updated":"2020-01-08 18:38:25.000000000","message":"We should probably eventually switch to python native venv.","commit_id":"628f7a38e162130302c491af52e9c77f25ef994f"}],"scripts/install-deps.sh":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"07e59be755f32a28599e01167bd0af172f13aff6","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        [net-tools]\u003dnet-tools"},{"line_number":84,"context_line":"        [python]\u003dpython3"},{"line_number":85,"context_line":"        [python-devel]\u003dpython3-devel"},{"line_number":86,"context_line":"        [venv]\u003dpython-virtualenv"},{"line_number":87,"context_line":"        [wget]\u003dwget"},{"line_number":88,"context_line":"    )"},{"line_number":89,"context_line":"    EXTRA_PKG_DEPS\u003d()"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3fa7e38b_ed3a28c2","line":86,"range":{"start_line":86,"start_character":15,"end_line":86,"end_character":32},"updated":"2020-01-02 16:44:40.000000000","message":"this should be python3-virtualenv","commit_id":"3489ec9b22ba9049066827f91e2807e7ce6a30ad"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"07e59be755f32a28599e01167bd0af172f13aff6","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    EXTRA_PKG_DEPS\u003d()"},{"line_number":90,"context_line":"    sudo -E ${PKG_MANAGER} updateinfo"},{"line_number":91,"context_line":"    if $(grep -q Fedora /etc/redhat-release); then"},{"line_number":92,"context_line":"        EXTRA_PKG_DEPS\u003d\"python-dnf redhat-rpm-config\""},{"line_number":93,"context_line":"    fi"},{"line_number":94,"context_line":"    ;;"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"3fa7e38b_2d6e00c8","line":92,"range":{"start_line":92,"start_character":24,"end_line":92,"end_character":34},"updated":"2020-01-02 16:44:40.000000000","message":"we probably want to have python3-dnf here","commit_id":"3489ec9b22ba9049066827f91e2807e7ce6a30ad"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"07e59be755f32a28599e01167bd0af172f13aff6","unresolved":false,"context_lines":[{"line_number":161,"context_line":"# requests, one of our indirect dependencies (bug 1459947)."},{"line_number":162,"context_line":"#"},{"line_number":163,"context_line":"if ! which pip3; then"},{"line_number":164,"context_line":"    wget -O /tmp/get-pip.py https://bootstrap.pypa.io/3.2/get-pip.py"},{"line_number":165,"context_line":"    sudo -H -E ${PYTHON} /tmp/get-pip.py"},{"line_number":166,"context_line":"fi"},{"line_number":167,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"3fa7e38b_cd3decbc","line":164,"range":{"start_line":164,"start_character":54,"end_line":164,"end_character":57},"updated":"2020-01-02 16:44:40.000000000","message":"3.2 contains pip 7.1.2 and I guess we want a more recent version\nI suggest to change this to at least 3.3 that contains pip 10.0.1\n3.4 has 19.1.1\nif we want cutting edge (19.3.1 -\u003e current) we can directly download from the top dir using:\nhttps://bootstrap.pypa.io/get-pip.py","commit_id":"3489ec9b22ba9049066827f91e2807e7ce6a30ad"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"bf7e32235e0c72a4406184cfa22f260325d0f3fe","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        [lsb-release]\u003dlsb-release"},{"line_number":33,"context_line":"        [make]\u003dmake"},{"line_number":34,"context_line":"        [net-tools]\u003dnet-tools"},{"line_number":35,"context_line":"        [python]\u003dpython"},{"line_number":36,"context_line":"        [python-devel]\u003dpython-devel"},{"line_number":37,"context_line":"        [venv]\u003dpython-virtualenv"},{"line_number":38,"context_line":"        [wget]\u003dwget"},{"line_number":39,"context_line":"    )"}],"source_content_type":"text/x-sh","patch_set":4,"id":"3fa7e38b_92a1473d","line":36,"range":{"start_line":35,"start_character":8,"end_line":36,"end_character":23},"updated":"2020-01-03 12:10:00.000000000","message":"at least we would need to update the variables from CHECK_CMD_PKGS, the package we can do latter","commit_id":"082303a763a31bef62f04ebadc35f7e553e8a437"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"bf7e32235e0c72a4406184cfa22f260325d0f3fe","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        [lsb-release]\u003dredhat-lsb"},{"line_number":82,"context_line":"        [make]\u003dmake"},{"line_number":83,"context_line":"        [net-tools]\u003dnet-tools"},{"line_number":84,"context_line":"        [python]\u003dpython3"},{"line_number":85,"context_line":"        [python-devel]\u003dpython3-devel"},{"line_number":86,"context_line":"        [venv]\u003dpython3-virtualenv"},{"line_number":87,"context_line":"        [wget]\u003dwget"}],"source_content_type":"text/x-sh","patch_set":4,"id":"3fa7e38b_b2aec32c","line":84,"range":{"start_line":84,"start_character":8,"end_line":84,"end_character":17},"updated":"2020-01-03 12:10:00.000000000","message":"should change to python3 also since you changed CHECK_CMD_PKGS.","commit_id":"082303a763a31bef62f04ebadc35f7e553e8a437"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"bf7e32235e0c72a4406184cfa22f260325d0f3fe","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        [make]\u003dmake"},{"line_number":83,"context_line":"        [net-tools]\u003dnet-tools"},{"line_number":84,"context_line":"        [python]\u003dpython3"},{"line_number":85,"context_line":"        [python-devel]\u003dpython3-devel"},{"line_number":86,"context_line":"        [venv]\u003dpython3-virtualenv"},{"line_number":87,"context_line":"        [wget]\u003dwget"},{"line_number":88,"context_line":"    )"}],"source_content_type":"text/x-sh","patch_set":4,"id":"3fa7e38b_72a4cb4c","line":85,"range":{"start_line":85,"start_character":8,"end_line":85,"end_character":22},"updated":"2020-01-03 12:10:00.000000000","message":"ditto","commit_id":"082303a763a31bef62f04ebadc35f7e553e8a437"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6b2b21b15e6553ddbe2c77047589bc95aef8fcd9","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        [make]\u003dmake"},{"line_number":83,"context_line":"        [net-tools]\u003dnet-tools"},{"line_number":84,"context_line":"        [python]\u003dpython3"},{"line_number":85,"context_line":"        [python-devel]\u003dpython3-devel"},{"line_number":86,"context_line":"        [venv]\u003dpython3-virtualenv"},{"line_number":87,"context_line":"        [wget]\u003dwget"},{"line_number":88,"context_line":"    )"}],"source_content_type":"text/x-sh","patch_set":4,"id":"3fa7e38b_7e5fb54c","line":85,"range":{"start_line":85,"start_character":8,"end_line":85,"end_character":22},"in_reply_to":"3fa7e38b_72a4cb4c","updated":"2020-01-03 17:15:56.000000000","message":"I\u0027m only doing one distro at a time....","commit_id":"082303a763a31bef62f04ebadc35f7e553e8a437"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"20d8e33385a56ac29b13b6d121ebb69c58a5bf8a","unresolved":false,"context_lines":[{"line_number":160,"context_line":"# older versions of pip are incompatible with"},{"line_number":161,"context_line":"# requests, one of our indirect dependencies (bug 1459947)."},{"line_number":162,"context_line":"#"},{"line_number":163,"context_line":"PIP\u003d$(which pip3)"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"if ! $PIP list; then"},{"line_number":166,"context_line":"    wget -O /tmp/get-pip.py https://bootstrap.pypa.io/3.4/get-pip.py"}],"source_content_type":"text/x-sh","patch_set":7,"id":"3fa7e38b_c2626ed9","line":163,"updated":"2020-01-07 16:24:11.000000000","message":"this command exits with a 1, that means that if PIP is not set it will never reach the next command since we set -e\nwe could integrate the check in the if command instead","commit_id":"10701343be9be8cf3435fb0fb045ecd242409507"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"488f0d4b33cbfc69689c1a858252803b087a5cee","unresolved":false,"context_lines":[{"line_number":160,"context_line":"# older versions of pip are incompatible with"},{"line_number":161,"context_line":"# requests, one of our indirect dependencies (bug 1459947)."},{"line_number":162,"context_line":"#"},{"line_number":163,"context_line":"PIP\u003d$(which pip3)"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"if ! $PIP list; then"},{"line_number":166,"context_line":"    wget -O /tmp/get-pip.py https://bootstrap.pypa.io/3.4/get-pip.py"}],"source_content_type":"text/x-sh","patch_set":7,"id":"3fa7e38b_0e9665f0","line":163,"in_reply_to":"3fa7e38b_823d562a","updated":"2020-01-08 14:21:40.000000000","message":"I tested this again and I\u0027m seeing the error, env-setup actually calls this script so if which command fails, exiting with 1, this script exits before reaching the test at L165\nthis is because of set -e on top, which makes sense\nmaybe would be better to check the version of pip if really needed, or again as I suggested before change the logic of the test","commit_id":"10701343be9be8cf3435fb0fb045ecd242409507"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"2f9c11b2122ce1a4b95df7d0bba36be9a15f693d","unresolved":false,"context_lines":[{"line_number":160,"context_line":"# older versions of pip are incompatible with"},{"line_number":161,"context_line":"# requests, one of our indirect dependencies (bug 1459947)."},{"line_number":162,"context_line":"#"},{"line_number":163,"context_line":"PIP\u003d$(which pip3)"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"if ! $PIP list; then"},{"line_number":166,"context_line":"    wget -O /tmp/get-pip.py https://bootstrap.pypa.io/3.4/get-pip.py"}],"source_content_type":"text/x-sh","patch_set":7,"id":"3fa7e38b_823d562a","line":163,"in_reply_to":"3fa7e38b_c2626ed9","updated":"2020-01-07 17:05:18.000000000","message":"nvm, this should be taken care of by the env-setup script","commit_id":"10701343be9be8cf3435fb0fb045ecd242409507"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"9a314d4740880170827acd43679fa0ac6d33af57","unresolved":false,"context_lines":[{"line_number":162,"context_line":"#"},{"line_number":163,"context_line":"PIP\u003d$(which pip3)"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"if ! $PIP list; then"},{"line_number":166,"context_line":"    wget -O /tmp/get-pip.py https://bootstrap.pypa.io/3.4/get-pip.py"},{"line_number":167,"context_line":"    sudo -H -E ${PYTHON} /tmp/get-pip.py"},{"line_number":168,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":7,"id":"3fa7e38b_9f0b6f29","line":165,"range":{"start_line":165,"start_character":3,"end_line":165,"end_character":14},"updated":"2020-01-07 16:15:24.000000000","message":"this should be [ ! $PIP ]","commit_id":"10701343be9be8cf3435fb0fb045ecd242409507"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"91738f15fbf2390ee037e7b3742f6091504a3a79","unresolved":false,"context_lines":[{"line_number":162,"context_line":"#"},{"line_number":163,"context_line":"PIP\u003d$(which pip3)"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"if ! $PIP list; then"},{"line_number":166,"context_line":"    wget -O /tmp/get-pip.py https://bootstrap.pypa.io/3.4/get-pip.py"},{"line_number":167,"context_line":"    sudo -H -E ${PYTHON} /tmp/get-pip.py"},{"line_number":168,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":7,"id":"3fa7e38b_39d05053","line":165,"range":{"start_line":165,"start_character":3,"end_line":165,"end_character":14},"in_reply_to":"3fa7e38b_9f0b6f29","updated":"2020-01-08 03:57:55.000000000","message":"This also works, just print packages, would be good do as Riccardo suggested or redirect the output to null. This patch doesn\u0027t change old things so I think it\u0027s ok to do it in a followup.","commit_id":"10701343be9be8cf3435fb0fb045ecd242409507"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"20d8e33385a56ac29b13b6d121ebb69c58a5bf8a","unresolved":false,"context_lines":[{"line_number":162,"context_line":"#"},{"line_number":163,"context_line":"PIP\u003d$(which pip3)"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"if ! $PIP list; then"},{"line_number":166,"context_line":"    wget -O /tmp/get-pip.py https://bootstrap.pypa.io/3.4/get-pip.py"},{"line_number":167,"context_line":"    sudo -H -E ${PYTHON} /tmp/get-pip.py"},{"line_number":168,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":7,"id":"3fa7e38b_8258f624","line":165,"range":{"start_line":165,"start_character":3,"end_line":165,"end_character":14},"in_reply_to":"3fa7e38b_9f0b6f29","updated":"2020-01-07 16:24:11.000000000","message":"or better integrate the check on L163","commit_id":"10701343be9be8cf3435fb0fb045ecd242409507"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7b18b2b923d25fb8811827c408a7d1c0320e8a6d","unresolved":false,"context_lines":[{"line_number":161,"context_line":"# requests, one of our indirect dependencies (bug 1459947)."},{"line_number":162,"context_line":"#"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"if [ ! $($PYTHON -m pip upgrade pip) ]; then"},{"line_number":165,"context_line":"    wget -O /tmp/get-pip.py https://bootstrap.pypa.io/3.4/get-pip.py"},{"line_number":166,"context_line":"    sudo -H -E ${PYTHON} /tmp/get-pip.py"},{"line_number":167,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":8,"id":"3fa7e38b_9d07e570","line":164,"updated":"2020-01-08 18:38:25.000000000","message":"Is it a real command? I\u0027m getting \u0027Unknown command \"upgrade\"\u0027 locally. Did you mean \u0027install -U\u0027?","commit_id":"628f7a38e162130302c491af52e9c77f25ef994f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7b18b2b923d25fb8811827c408a7d1c0320e8a6d","unresolved":false,"context_lines":[{"line_number":166,"context_line":"    sudo -H -E ${PYTHON} /tmp/get-pip.py"},{"line_number":167,"context_line":"fi"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"PIP\u003d$(which pip3)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"if [ \"$OS_FAMILY\" \u003d\u003d \"RedHat\" ]; then"},{"line_number":172,"context_line":"    sudo -H -E ${PIP} freeze"}],"source_content_type":"text/x-sh","patch_set":8,"id":"3fa7e38b_bd0ae174","line":169,"updated":"2020-01-08 18:38:25.000000000","message":"python3 -m pip?","commit_id":"628f7a38e162130302c491af52e9c77f25ef994f"}]}