)]}'
{"playbooks/test-bifrost.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fccdc2c9c1733e6d393e4ac5d8d3b9bd5a6c4929","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    - name: \"List introspection rules using openstack client\""},{"line_number":115,"context_line":"      command: openstack baremetal introspection rule list"},{"line_number":116,"context_line":"      environment:"},{"line_number":117,"context_line":"        OS_CLOUD: \"{% if enable_keystone | default(false) | bool \u003d\u003d true %}bifrost{% else %}bifrost-inspector{% endif %}\""},{"line_number":118,"context_line":"      when: enable_inspector | bool"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"- hosts: baremetal"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_758d4e33","line":117,"updated":"2020-01-09 15:52:11.000000000","message":"Ugh :( Is it really the only way? What if we remove \"| bool\"? Also is \"false\" correct in ansible or we need False like in Python?","commit_id":"9e6dcb20c7e0e9fb6a55f91626a889670ac5a7e4"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"ed16df43f285222bf603f1e741f776ec53286028","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    - name: \"List introspection rules using openstack client\""},{"line_number":115,"context_line":"      command: openstack baremetal introspection rule list"},{"line_number":116,"context_line":"      environment:"},{"line_number":117,"context_line":"        OS_CLOUD: \"{% if enable_keystone | default(false) | bool \u003d\u003d true %}bifrost{% else %}bifrost-inspector{% endif %}\""},{"line_number":118,"context_line":"      when: enable_inspector | bool"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"- hosts: baremetal"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_f2e37f04","line":117,"in_reply_to":"3fa7e38b_061f0809","updated":"2020-01-10 18:05:00.000000000","message":"Switching over to python3 I\u0027ve run into all sorts of conditional weirdness. :\\","commit_id":"9e6dcb20c7e0e9fb6a55f91626a889670ac5a7e4"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"9885087ef7e25add832c6dcddbc1416f0eb6d61f","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    - name: \"List introspection rules using openstack client\""},{"line_number":115,"context_line":"      command: openstack baremetal introspection rule list"},{"line_number":116,"context_line":"      environment:"},{"line_number":117,"context_line":"        OS_CLOUD: \"{% if enable_keystone | default(false) | bool \u003d\u003d true %}bifrost{% else %}bifrost-inspector{% endif %}\""},{"line_number":118,"context_line":"      when: enable_inspector | bool"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"- hosts: baremetal"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_0e370cde","line":117,"in_reply_to":"3fa7e38b_2ba43ab8","updated":"2020-01-13 10:48:25.000000000","message":"I believe this is the correct way, at least looking at other implementations, docs and codebase.\nThis happens because the code of the bool filter doesn\u0027t use Python conversion to bool, but implements its own logic to be compatible with what YAML accepts for values.\nhttps://github.com/ansible/ansible/blob/devel/lib/ansible/plugins/filter/core.py#L91","commit_id":"9e6dcb20c7e0e9fb6a55f91626a889670ac5a7e4"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8fc53e4a7f879dfc691eefb483c3787d64fd8019","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    - name: \"List introspection rules using openstack client\""},{"line_number":115,"context_line":"      command: openstack baremetal introspection rule list"},{"line_number":116,"context_line":"      environment:"},{"line_number":117,"context_line":"        OS_CLOUD: \"{% if enable_keystone | default(false) | bool \u003d\u003d true %}bifrost{% else %}bifrost-inspector{% endif %}\""},{"line_number":118,"context_line":"      when: enable_inspector | bool"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"- hosts: baremetal"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_ca634018","line":117,"in_reply_to":"3fa7e38b_758d4e33","updated":"2020-01-09 17:51:06.000000000","message":"AIUI, it gets re-parsed to \"False\" in the re-processing. It seems like it it. Always cast it as a boolean operator and depending on level we seem to need to actually compare it instead of treat it python native...  This may be a matter of just removing default or removing bool, but I think the only way to get both is to have such a statement :\\","commit_id":"9e6dcb20c7e0e9fb6a55f91626a889670ac5a7e4"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0a0af102147d7da5a604c7ddfd3cea04a78d3bdc","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    - name: \"List introspection rules using openstack client\""},{"line_number":115,"context_line":"      command: openstack baremetal introspection rule list"},{"line_number":116,"context_line":"      environment:"},{"line_number":117,"context_line":"        OS_CLOUD: \"{% if enable_keystone | default(false) | bool \u003d\u003d true %}bifrost{% else %}bifrost-inspector{% endif %}\""},{"line_number":118,"context_line":"      when: enable_inspector | bool"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"- hosts: baremetal"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_061f0809","line":117,"in_reply_to":"3fa7e38b_ca634018","updated":"2020-01-10 11:16:34.000000000","message":"Weird, I\u0027ve never needed to do this before. | bool should yield a boolean, as should \u003d\u003d.","commit_id":"9e6dcb20c7e0e9fb6a55f91626a889670ac5a7e4"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"092dc62b29b7c1329b4b12639510eacdc0442e59","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    - name: \"List introspection rules using openstack client\""},{"line_number":115,"context_line":"      command: openstack baremetal introspection rule list"},{"line_number":116,"context_line":"      environment:"},{"line_number":117,"context_line":"        OS_CLOUD: \"{% if enable_keystone | default(false) | bool \u003d\u003d true %}bifrost{% else %}bifrost-inspector{% endif %}\""},{"line_number":118,"context_line":"      when: enable_inspector | bool"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"- hosts: baremetal"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_2ba43ab8","line":117,"in_reply_to":"3fa7e38b_f2e37f04","updated":"2020-01-13 10:09:09.000000000","message":"Looks like a job for https://github.com/markgoddard/ansible-experiments. (PRs welcome :))","commit_id":"9e6dcb20c7e0e9fb6a55f91626a889670ac5a7e4"}],"scripts/test-bifrost.sh":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"854b05f80d1c45ef47dbd4693ffa4a7605a17ae9","unresolved":false,"context_lines":[{"line_number":33,"context_line":"TESTING_USER\u003dcirros"},{"line_number":34,"context_line":"TEST_PLAYBOOK\u003d\"test-bifrost.yaml\""},{"line_number":35,"context_line":"# NOTE(TheJulia): Temproary disable of inspector until we sort"},{"line_number":36,"context_line":"# out issues related to https://storyboard.openstack.org/#!/story/2007076"},{"line_number":37,"context_line":"USE_INSPECTOR\u003dfalse"},{"line_number":38,"context_line":"INSPECT_NODES\u003dfalse"},{"line_number":39,"context_line":"INVENTORY_DHCP\u003dfalse"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3fa7e38b_a476453e","line":36,"updated":"2020-01-09 01:28:42.000000000","message":"this bug seems weird, I don\u0027t see we return 404 for listing rules, besides that, inspector api entries are wrapped, which should have an \u0027error\u0027 field.","commit_id":"13aee0ff480c31305efad642d5786a79d1cc4797"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b2401f976f8a3aad89273b38f7cb93b5bc424060","unresolved":false,"context_lines":[{"line_number":33,"context_line":"TESTING_USER\u003dcirros"},{"line_number":34,"context_line":"TEST_PLAYBOOK\u003d\"test-bifrost.yaml\""},{"line_number":35,"context_line":"# NOTE(TheJulia): Temproary disable of inspector until we sort"},{"line_number":36,"context_line":"# out issues related to https://storyboard.openstack.org/#!/story/2007076"},{"line_number":37,"context_line":"USE_INSPECTOR\u003dfalse"},{"line_number":38,"context_line":"INSPECT_NODES\u003dfalse"},{"line_number":39,"context_line":"INVENTORY_DHCP\u003dfalse"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3fa7e38b_8fb1dd93","line":36,"in_reply_to":"3fa7e38b_a476453e","updated":"2020-01-09 14:19:54.000000000","message":"I figured out what the issue was... I need to update this patch. :(","commit_id":"13aee0ff480c31305efad642d5786a79d1cc4797"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fccdc2c9c1733e6d393e4ac5d8d3b9bd5a6c4929","unresolved":false,"context_lines":[{"line_number":33,"context_line":"TESTING_USER\u003dcirros"},{"line_number":34,"context_line":"TEST_PLAYBOOK\u003d\"test-bifrost.yaml\""},{"line_number":35,"context_line":"# NOTE(TheJulia): Temproary disable of inspector until we sort"},{"line_number":36,"context_line":"# out issues related to https://storyboard.openstack.org/#!/story/2007076"},{"line_number":37,"context_line":"USE_INSPECTOR\u003dtrue"},{"line_number":38,"context_line":"INSPECT_NODES\u003dtrue"},{"line_number":39,"context_line":"INVENTORY_DHCP\u003dfalse"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3fa7e38b_15989a73","line":36,"updated":"2020-01-09 15:52:11.000000000","message":"No longer needed","commit_id":"9e6dcb20c7e0e9fb6a55f91626a889670ac5a7e4"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8fc53e4a7f879dfc691eefb483c3787d64fd8019","unresolved":false,"context_lines":[{"line_number":33,"context_line":"TESTING_USER\u003dcirros"},{"line_number":34,"context_line":"TEST_PLAYBOOK\u003d\"test-bifrost.yaml\""},{"line_number":35,"context_line":"# NOTE(TheJulia): Temproary disable of inspector until we sort"},{"line_number":36,"context_line":"# out issues related to https://storyboard.openstack.org/#!/story/2007076"},{"line_number":37,"context_line":"USE_INSPECTOR\u003dtrue"},{"line_number":38,"context_line":"INSPECT_NODES\u003dtrue"},{"line_number":39,"context_line":"INVENTORY_DHCP\u003dfalse"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3fa7e38b_8a69c8f7","line":36,"in_reply_to":"3fa7e38b_15989a73","updated":"2020-01-09 17:51:06.000000000","message":"yup, sorry!","commit_id":"9e6dcb20c7e0e9fb6a55f91626a889670ac5a7e4"}]}