)]}'
{"playbooks/roles/bifrost-ironic-install/tasks/install.yml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8b440737aec1dc64e849a4e21651ae1c6be2fbb6","unresolved":false,"context_lines":[{"line_number":102,"context_line":"  include: pip_install.yml"},{"line_number":103,"context_line":"    package\u003dpymysql"},{"line_number":104,"context_line":"  when:"},{"line_number":105,"context_line":"    - skip_install is not defined"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"- name: \"Install extra packages for ironic\""},{"line_number":108,"context_line":"  include: pip_install.yml"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3fa7e38b_a8a99378","line":105,"updated":"2020-01-21 11:16:22.000000000","message":"I\u0027d prefer we don\u0027t make \"break it and fix at some point later\" a common approach for dealing with things :-/","commit_id":"355e998f1f197cdfe26ed4b14782f7983c831387"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"8f16f90633043495eea6b9439f609e1df4fa7e9f","unresolved":false,"context_lines":[{"line_number":102,"context_line":"  include: pip_install.yml"},{"line_number":103,"context_line":"    package\u003dpymysql"},{"line_number":104,"context_line":"  when:"},{"line_number":105,"context_line":"    - skip_install is not defined"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"- name: \"Install extra packages for ironic\""},{"line_number":108,"context_line":"  include: pip_install.yml"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3fa7e38b_2eb5b219","line":105,"updated":"2020-01-21 03:00:06.000000000","message":"Not expert on this, but logically thinking, should we keep \"enable_venv | bool \u003d\u003d false\" here? If we are installing anyway, why we don\u0027t remove this task and L99 as well.","commit_id":"355e998f1f197cdfe26ed4b14782f7983c831387"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"4069b6ec51c53c6ce2d0cb93df128d64baaee627","unresolved":false,"context_lines":[{"line_number":102,"context_line":"  include: pip_install.yml"},{"line_number":103,"context_line":"    package\u003dpymysql"},{"line_number":104,"context_line":"  when:"},{"line_number":105,"context_line":"    - skip_install is not defined"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"- name: \"Install extra packages for ironic\""},{"line_number":108,"context_line":"  include: pip_install.yml"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3fa7e38b_7abe0101","line":105,"in_reply_to":"3fa7e38b_2eb5b219","updated":"2020-01-21 08:58:49.000000000","message":"Kaifeng is right, but considering we\u0027re running CI in venv at the moment, we can correct this (and other small things) in a follow up?","commit_id":"355e998f1f197cdfe26ed4b14782f7983c831387"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"8f16f90633043495eea6b9439f609e1df4fa7e9f","unresolved":false,"context_lines":[{"line_number":143,"context_line":"# logic is largely going into openstacksdk as time goes on."},{"line_number":144,"context_line":"- block:"},{"line_number":145,"context_line":"  - name: install openstacksdk from PyPI"},{"line_number":146,"context_line":"    command: \"pip3 pip install openstacksdk\""},{"line_number":147,"context_line":"    when: openstacksdk_source_install | default(false) | bool \u003d\u003d false"},{"line_number":148,"context_line":"  - name: install openstacksdk from source"},{"line_number":149,"context_line":"    command: \"pip3 install {{ openstacksdk_git_folder }}\""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3fa7e38b_0e4f9635","line":146,"range":{"start_line":146,"start_character":19,"end_line":146,"end_character":23},"updated":"2020-01-21 03:00:06.000000000","message":"this seems a typo to me.","commit_id":"355e998f1f197cdfe26ed4b14782f7983c831387"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"4069b6ec51c53c6ce2d0cb93df128d64baaee627","unresolved":false,"context_lines":[{"line_number":143,"context_line":"# logic is largely going into openstacksdk as time goes on."},{"line_number":144,"context_line":"- block:"},{"line_number":145,"context_line":"  - name: install openstacksdk from PyPI"},{"line_number":146,"context_line":"    command: \"pip3 pip install openstacksdk\""},{"line_number":147,"context_line":"    when: openstacksdk_source_install | default(false) | bool \u003d\u003d false"},{"line_number":148,"context_line":"  - name: install openstacksdk from source"},{"line_number":149,"context_line":"    command: \"pip3 install {{ openstacksdk_git_folder }}\""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3fa7e38b_5ad8e57e","line":146,"range":{"start_line":146,"start_character":19,"end_line":146,"end_character":23},"in_reply_to":"3fa7e38b_0e4f9635","updated":"2020-01-21 08:58:49.000000000","message":"it looks like it\nthis is also skipped in CI (we\u0027re installing from source if I\u0027m not mistaken), so maybe we can also fix this in a follow up and make the CI happy again ?","commit_id":"355e998f1f197cdfe26ed4b14782f7983c831387"}]}