)]}'
{"bindep.txt":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ccb7cb01458301906078cfd2cbe6a35156df6a4e","unresolved":false,"context_lines":[{"line_number":18,"context_line":"python3-minimal      [platform:dpkg]"},{"line_number":19,"context_line":"python3-devel        [platform:rpm]"},{"line_number":20,"context_line":"python3-dev          [platform:dpkg]"},{"line_number":21,"context_line":"python3-venv"},{"line_number":22,"context_line":"wget"},{"line_number":23,"context_line":"sudo"},{"line_number":24,"context_line":"ebtables"}],"source_content_type":"text/plain","patch_set":23,"id":"3fa7e38b_154cf3c7","line":21,"updated":"2020-01-13 17:13:14.000000000","message":"This doesn\u0027t seem to be a thing on Fedora/CentOS, `python3 -mvenv` works without installing anything.","commit_id":"252af05444dfc1d7bb193f7ccb1052a0156a1b69"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"20a712462cf85cca38d06cb2251847089c5b53b0","unresolved":false,"context_lines":[{"line_number":18,"context_line":"python3-minimal      [platform:dpkg]"},{"line_number":19,"context_line":"python3-devel        [platform:rpm]"},{"line_number":20,"context_line":"python3-dev          [platform:dpkg]"},{"line_number":21,"context_line":"python3-venv"},{"line_number":22,"context_line":"wget"},{"line_number":23,"context_line":"sudo"},{"line_number":24,"context_line":"ebtables"}],"source_content_type":"text/plain","patch_set":24,"id":"3fa7e38b_71abed70","line":21,"updated":"2020-01-14 12:14:16.000000000","message":"This needs [platform:dpkg] I guess?","commit_id":"26d81353bded094c048f74cf5a5e3eba79174d30"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"af96dc90370f94e953d23897dd2529ae6850113f","unresolved":false,"context_lines":[{"line_number":18,"context_line":"python3-minimal      [platform:dpkg]"},{"line_number":19,"context_line":"python3-devel        [platform:rpm]"},{"line_number":20,"context_line":"python3-dev          [platform:dpkg]"},{"line_number":21,"context_line":"python3-venv"},{"line_number":22,"context_line":"wget"},{"line_number":23,"context_line":"sudo"},{"line_number":24,"context_line":"ebtables"}],"source_content_type":"text/plain","patch_set":24,"id":"3fa7e38b_877c2b72","line":21,"in_reply_to":"3fa7e38b_71abed70","updated":"2020-01-14 13:37:24.000000000","message":"yeah, this is debian/ubuntu only\nshould add python3-virtualenv for rpm platforms","commit_id":"26d81353bded094c048f74cf5a5e3eba79174d30"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8bc0b4d88b5de82ea1fb905096a0d4012da731eb","unresolved":false,"context_lines":[{"line_number":19,"context_line":"python3-devel        [platform:rpm]"},{"line_number":20,"context_line":"python3-dev          [platform:dpkg]"},{"line_number":21,"context_line":"python3-venv         [platform:dpkg]"},{"line_number":22,"context_line":"python3-virtualenv   [platform:rpm]"},{"line_number":23,"context_line":"wget"},{"line_number":24,"context_line":"sudo"},{"line_number":25,"context_line":"ebtables"}],"source_content_type":"text/plain","patch_set":25,"id":"3fa7e38b_68fd3f3b","line":22,"updated":"2020-01-14 15:12:09.000000000","message":"This is not needed, we no longer use the old virtualenv. Just leave the RPM side empty, I guess?","commit_id":"38ebda6bd96847de125686023ceee3d8e6b1a4b4"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8e4a7f3a9d4dbb941cc5f7bac79cdb39f1df456e","unresolved":false,"context_lines":[{"line_number":19,"context_line":"python3-devel        [platform:rpm]"},{"line_number":20,"context_line":"python3-dev          [platform:dpkg]"},{"line_number":21,"context_line":"python3-venv         [platform:dpkg]"},{"line_number":22,"context_line":"python3-virtualenv   [platform:rpm]"},{"line_number":23,"context_line":"wget"},{"line_number":24,"context_line":"sudo"},{"line_number":25,"context_line":"ebtables"}],"source_content_type":"text/plain","patch_set":25,"id":"3fa7e38b_bad120cd","line":22,"in_reply_to":"3fa7e38b_4ef96bc3","updated":"2020-01-15 17:18:03.000000000","message":"Guys, only changed it because of your last rev\u0027s comments... :( One OS one path at a time please.","commit_id":"38ebda6bd96847de125686023ceee3d8e6b1a4b4"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"555d00b53ce515f2b89a243b3a90380f1dcc279b","unresolved":false,"context_lines":[{"line_number":19,"context_line":"python3-devel        [platform:rpm]"},{"line_number":20,"context_line":"python3-dev          [platform:dpkg]"},{"line_number":21,"context_line":"python3-venv         [platform:dpkg]"},{"line_number":22,"context_line":"python3-virtualenv   [platform:rpm]"},{"line_number":23,"context_line":"wget"},{"line_number":24,"context_line":"sudo"},{"line_number":25,"context_line":"ebtables"}],"source_content_type":"text/plain","patch_set":25,"id":"3fa7e38b_4ef96bc3","line":22,"in_reply_to":"3fa7e38b_68fd3f3b","updated":"2020-01-14 16:06:15.000000000","message":"right, cause we\u0027re using \u0027python3 -m venv\u0027, which should not require additional packages on python3/rpm based distros","commit_id":"38ebda6bd96847de125686023ceee3d8e6b1a4b4"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"075e8de6da22167786f88912b82ee4b7d8979336","unresolved":false,"context_lines":[{"line_number":19,"context_line":"python3-devel        [platform:rpm]"},{"line_number":20,"context_line":"python3-dev          [platform:dpkg]"},{"line_number":21,"context_line":"python3-venv         [platform:dpkg]"},{"line_number":22,"context_line":"python3-virtualenv   [platform:rpm]"},{"line_number":23,"context_line":"wget"},{"line_number":24,"context_line":"sudo"},{"line_number":25,"context_line":"ebtables"}],"source_content_type":"text/plain","patch_set":25,"id":"3fa7e38b_c6ef37b0","line":22,"in_reply_to":"3fa7e38b_b509312a","updated":"2020-01-20 01:47:06.000000000","message":"Yeah, I realized the clarity of your statement I clicked post. As more test scenarios get turned back on I have this sneaking suspicion some we\u0027re going to have to undo some of the changes... I had to manually install python3-venv... at least on vagrant... but actually I think that makes sense. Gah, too many things.","commit_id":"38ebda6bd96847de125686023ceee3d8e6b1a4b4"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"de60042452568bcf072364a6a5368ab38bfe4ff8","unresolved":false,"context_lines":[{"line_number":19,"context_line":"python3-devel        [platform:rpm]"},{"line_number":20,"context_line":"python3-dev          [platform:dpkg]"},{"line_number":21,"context_line":"python3-venv         [platform:dpkg]"},{"line_number":22,"context_line":"python3-virtualenv   [platform:rpm]"},{"line_number":23,"context_line":"wget"},{"line_number":24,"context_line":"sudo"},{"line_number":25,"context_line":"ebtables"}],"source_content_type":"text/plain","patch_set":25,"id":"3fa7e38b_b509312a","line":22,"in_reply_to":"3fa7e38b_bad120cd","updated":"2020-01-15 17:34:43.000000000","message":"Well, I suggested removing it completely for RPM-based OS since venv is built-in there. The current variant is acceptable since it won\u0027t cause a failure, just a redundant package.","commit_id":"38ebda6bd96847de125686023ceee3d8e6b1a4b4"}],"playbooks/ci/run.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ccb7cb01458301906078cfd2cbe6a35156df6a4e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- hosts: all"},{"line_number":2,"context_line":"  tasks:"},{"line_number":3,"context_line":"    - shell:"},{"line_number":4,"context_line":"        cmd: bash scripts/test-bifrost.sh"},{"line_number":5,"context_line":"        chdir: \"{{ ansible_user_dir }}/{{ zuul.projects[\u0027opendev.org/openstack/bifrost\u0027].src_dir }}\""},{"line_number":6,"context_line":"      environment:"},{"line_number":7,"context_line":"        BUILD_IMAGE: \"{{ build_image | default(false) | bool | lower }}\""}],"source_content_type":"text/x-yaml","patch_set":23,"id":"3fa7e38b_75c0c7fa","line":4,"updated":"2020-01-13 17:13:14.000000000","message":"Seems unnecessary and should probably be done through the \u0027executable\u0027 ansible parameter.","commit_id":"252af05444dfc1d7bb193f7ccb1052a0156a1b69"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e9139c417fff3c4cce4291bd30680fdabaaebe38","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- hosts: all"},{"line_number":2,"context_line":"  tasks:"},{"line_number":3,"context_line":"    - shell:"},{"line_number":4,"context_line":"        cmd: bash scripts/test-bifrost.sh"},{"line_number":5,"context_line":"        chdir: \"{{ ansible_user_dir }}/{{ zuul.projects[\u0027opendev.org/openstack/bifrost\u0027].src_dir }}\""},{"line_number":6,"context_line":"      environment:"},{"line_number":7,"context_line":"        BUILD_IMAGE: \"{{ build_image | default(false) | bool | lower }}\""}],"source_content_type":"text/x-yaml","patch_set":23,"id":"3fa7e38b_5f7da51c","line":4,"in_reply_to":"3fa7e38b_75c0c7fa","updated":"2020-01-13 22:56:52.000000000","message":"I feel like this was an explicit workaround ash\u003c-\u003ebash. Bottom line, lets get this working and then back try changing.","commit_id":"252af05444dfc1d7bb193f7ccb1052a0156a1b69"}],"playbooks/roles/bifrost-create-vm-nodes/tasks/prepare_libvirt.yml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ccb7cb01458301906078cfd2cbe6a35156df6a4e","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    - lxml"},{"line_number":30,"context_line":"  when: enable_venv | bool \u003d\u003d false"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- name: install libvirt-python and lxml with virutalenv"},{"line_number":33,"context_line":"  pip:"},{"line_number":34,"context_line":"    name: \"{{ item }}\""},{"line_number":35,"context_line":"    state: present"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"3fa7e38b_55e82b7a","line":32,"range":{"start_line":32,"start_character":45,"end_line":32,"end_character":55},"updated":"2020-01-13 17:13:14.000000000","message":"nit: virtualenv","commit_id":"252af05444dfc1d7bb193f7ccb1052a0156a1b69"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ccb7cb01458301906078cfd2cbe6a35156df6a4e","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  with_items:"},{"line_number":39,"context_line":"    - libvirt-python"},{"line_number":40,"context_line":"    - lxml"},{"line_number":41,"context_line":"  when: enable_venv | default(false) | bool"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"- name: \"Restart libvirt service\""},{"line_number":44,"context_line":"  service: name\u003d\"{{libvirt_service_name}}\" state\u003drestarted"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"3fa7e38b_75e9a780","line":41,"updated":"2020-01-13 17:13:14.000000000","message":"do you need `bool \u003d\u003d true` here? I don\u0027t understand why we have to use it, but we\u0027ve been adding it everywhere so far.","commit_id":"252af05444dfc1d7bb193f7ccb1052a0156a1b69"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e9139c417fff3c4cce4291bd30680fdabaaebe38","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  with_items:"},{"line_number":39,"context_line":"    - libvirt-python"},{"line_number":40,"context_line":"    - lxml"},{"line_number":41,"context_line":"  when: enable_venv | default(false) | bool"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"- name: \"Restart libvirt service\""},{"line_number":44,"context_line":"  service: name\u003d\"{{libvirt_service_name}}\" state\u003drestarted"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"3fa7e38b_3f99c96a","line":41,"in_reply_to":"3fa7e38b_75e9a780","updated":"2020-01-13 22:56:52.000000000","message":"It _seems_ that the template expansion is requiring slightly different syntax at differing levels. In the main test-bifrost.yaml, it seem to be a hard requirement. I suspect things are different if we update ansible :\\","commit_id":"252af05444dfc1d7bb193f7ccb1052a0156a1b69"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"ac7ccef45624dea99f7bece67b4a561fe4bf40cf","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  with_items:"},{"line_number":39,"context_line":"    - libvirt-python"},{"line_number":40,"context_line":"    - lxml"},{"line_number":41,"context_line":"  when: enable_venv | default(false) | bool"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"- name: \"Restart libvirt service\""},{"line_number":44,"context_line":"  service: name\u003d\"{{libvirt_service_name}}\" state\u003drestarted"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"3fa7e38b_13b64127","line":41,"range":{"start_line":41,"start_character":39,"end_line":41,"end_character":43},"updated":"2020-01-14 10:15:40.000000000","message":"maybe we should change this to `bool \u003d\u003d true` anyway as next step I guess is moving to a more recent version of Ansible","commit_id":"26d81353bded094c048f74cf5a5e3eba79174d30"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8e4a7f3a9d4dbb941cc5f7bac79cdb39f1df456e","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  with_items:"},{"line_number":39,"context_line":"    - libvirt-python"},{"line_number":40,"context_line":"    - lxml"},{"line_number":41,"context_line":"  when: enable_venv | default(false) | bool"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"- name: \"Restart libvirt service\""},{"line_number":44,"context_line":"  service: name\u003d\"{{libvirt_service_name}}\" state\u003drestarted"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"3fa7e38b_6266bd2b","line":41,"range":{"start_line":41,"start_character":39,"end_line":41,"end_character":43},"in_reply_to":"3fa7e38b_13b64127","updated":"2020-01-15 17:18:03.000000000","message":"I believe I tried that and it didn\u0027t parse at this level. It is a bit maddening.","commit_id":"26d81353bded094c048f74cf5a5e3eba79174d30"}],"playbooks/roles/bifrost-ironic-install/tasks/start.yml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ccb7cb01458301906078cfd2cbe6a35156df6a4e","unresolved":false,"context_lines":[{"line_number":64,"context_line":"  when: testing | bool \u003d\u003d true and include_dhcp_server | bool \u003d\u003d true"},{"line_number":65,"context_line":"  ignore_errors: yes"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"- name: \"Kill unbound if running\""},{"line_number":68,"context_line":"  command: killall -9 -w unbound"},{"line_number":69,"context_line":"  when: testing|bool \u003d\u003d true and include_dhcp_server | bool \u003d\u003d true"},{"line_number":70,"context_line":"  ignore_errors: yes"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"3fa7e38b_758e87d8","line":67,"range":{"start_line":67,"start_character":0,"end_line":67,"end_character":33},"updated":"2020-01-13 17:13:14.000000000","message":"This should have gone into the previous patch..","commit_id":"252af05444dfc1d7bb193f7ccb1052a0156a1b69"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e9139c417fff3c4cce4291bd30680fdabaaebe38","unresolved":false,"context_lines":[{"line_number":64,"context_line":"  when: testing | bool \u003d\u003d true and include_dhcp_server | bool \u003d\u003d true"},{"line_number":65,"context_line":"  ignore_errors: yes"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"- name: \"Kill unbound if running\""},{"line_number":68,"context_line":"  command: killall -9 -w unbound"},{"line_number":69,"context_line":"  when: testing|bool \u003d\u003d true and include_dhcp_server | bool \u003d\u003d true"},{"line_number":70,"context_line":"  ignore_errors: yes"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"3fa7e38b_5fab6570","line":67,"range":{"start_line":67,"start_character":0,"end_line":67,"end_character":33},"in_reply_to":"3fa7e38b_758e87d8","updated":"2020-01-13 22:56:52.000000000","message":"Yeah, merge conflict. Seems like this is not required since we have another setting that handles this case.","commit_id":"252af05444dfc1d7bb193f7ccb1052a0156a1b69"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ccb7cb01458301906078cfd2cbe6a35156df6a4e","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"- name: \"Kill unbound if running\""},{"line_number":68,"context_line":"  command: killall -9 -w unbound"},{"line_number":69,"context_line":"  when: testing|bool \u003d\u003d true and include_dhcp_server | bool \u003d\u003d true"},{"line_number":70,"context_line":"  ignore_errors: yes"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"- name: \"Ensure dnsmasq is running with current config\""}],"source_content_type":"text/x-yaml","patch_set":23,"id":"3fa7e38b_f58117a3","line":69,"updated":"2020-01-13 17:13:14.000000000","message":"Do we need to check for openstack-ci-testing? Otherwise we\u0027re risking killing something on someone\u0027s system..","commit_id":"252af05444dfc1d7bb193f7ccb1052a0156a1b69"}],"scripts/install-deps.sh":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"b2f25f6adca724394133611e9a06260542f904b2","unresolved":false,"context_lines":[{"line_number":171,"context_line":"    sudo -H -E ${PIP} freeze"},{"line_number":172,"context_line":"    sudo -H -E ${PIP} install --ignore-installed pyparsing ipaddress"},{"line_number":173,"context_line":"fi"},{"line_number":174,"context_line":"if [ \"$OS_FAMILY\" \u003d\u003d \"Denian\" ]; then"},{"line_number":175,"context_line":"    sudo ${PIP} install --ignore-installed --root\u003d/${VENV-} apt"},{"line_number":176,"context_line":"fi"},{"line_number":177,"context_line":"sudo -H -E ${PIP} install -r \"$(dirname $0)/../requirements.txt\""}],"source_content_type":"text/x-sh","patch_set":3,"id":"3fa7e38b_b4242c60","line":174,"range":{"start_line":174,"start_character":22,"end_line":174,"end_character":28},"updated":"2020-01-09 13:28:15.000000000","message":"Debian","commit_id":"5dfc5542275c7ff238ea0474f7ae0f329964cce1"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ccb7cb01458301906078cfd2cbe6a35156df6a4e","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        [net-tools]\u003dnet-tools"},{"line_number":84,"context_line":"        [python]\u003dpython3"},{"line_number":85,"context_line":"        [python-devel]\u003dpython3-devel"},{"line_number":86,"context_line":"        [venv]\u003dpython3-virtualenv"},{"line_number":87,"context_line":"        [wget]\u003dwget"},{"line_number":88,"context_line":"    )"},{"line_number":89,"context_line":"    EXTRA_PKG_DEPS\u003d()"}],"source_content_type":"text/x-sh","patch_set":23,"id":"3fa7e38b_35b1ef92","line":86,"updated":"2020-01-13 17:13:14.000000000","message":"remove?","commit_id":"252af05444dfc1d7bb193f7ccb1052a0156a1b69"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8e4a7f3a9d4dbb941cc5f7bac79cdb39f1df456e","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        [net-tools]\u003dnet-tools"},{"line_number":84,"context_line":"        [python]\u003dpython3"},{"line_number":85,"context_line":"        [python-devel]\u003dpython3-devel"},{"line_number":86,"context_line":"        [venv]\u003dpython3-virtualenv"},{"line_number":87,"context_line":"        [wget]\u003dwget"},{"line_number":88,"context_line":"    )"},{"line_number":89,"context_line":"    EXTRA_PKG_DEPS\u003d()"}],"source_content_type":"text/x-sh","patch_set":23,"id":"3fa7e38b_1f708ddb","line":86,"in_reply_to":"3fa7e38b_35b1ef92","updated":"2020-01-15 17:18:03.000000000","message":"Done","commit_id":"252af05444dfc1d7bb193f7ccb1052a0156a1b69"}]}