)]}'
{"id":"openstack%2Fbifrost~704113","triplet_id":"openstack%2Fbifrost~master~I294ef9dce53d7404f4d9285506f1504afabe833f","project":"openstack/bifrost","branch":"master","topic":"check-bin-venv-only","hashtags":[],"change_id":"I294ef9dce53d7404f4d9285506f1504afabe833f","subject":"Fix variable checks in install-deps","status":"MERGED","created":"2020-01-24 09:20:46.000000000","updated":"2020-01-28 12:33:01.000000000","submitted":"2020-01-28 00:25:55.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"704113-1580171156001-159bbb0d","meta_rev_id":"e601201117190561a43fa3aaad09aca4d97b03f0","_number":704113,"virtual_id_number":704113,"owner":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-01-28 00:25:55.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"all":[{"value":2,"date":"2020-01-28 00:08:14.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"all":[{"value":1,"date":"2020-01-28 00:08:14.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-01-24 10:12:10.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2020-01-28 00:08:14.000000000","updated_by":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"reviewer":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"state":"REVIEWER"},{"updated":"2020-01-28 00:25:55.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"a04c9591bc442d3cead50ae510fef3d9e0e515bd","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2020-01-24 09:20:46.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2cd104d9f46c8af85a7a7215861440d25fca4c59","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-24 09:44:10.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/0da24a2352ab441cbd60f3da5cb6d57b : SUCCESS in 4m 23s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/3d3efe8a425f4c359d444895d9e62054 : SUCCESS in 5m 15s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/2e08e4eec5e04d4da7b69419aa9c0f46 : SUCCESS in 5m 13s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/0f872b54ce804d6aa9fa2adc11269ccf : SUCCESS in 9m 09s\n- bifrost-integration-tinyipa-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/e08a05ebd19c4432a7517c9dcf66db69 : SUCCESS in 17m 14s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/f1e792a185b14f49bcdf48f62db15c37 : SUCCESS in 5m 13s\n- bifrost-integration-tinyipa-keystone-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/8e8056f6041c41ea9884b1a5205fb344 : FAILURE in 6m 24s (non-voting)\n- bifrost-integration-dhcp-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/eba6e508c88b440e8606a41d78bf4d84 : FAILURE in 10m 00s (non-voting)\n- bifrost-integration-dibipa-debian-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/3e138065d6d04d589e85fcf1df7d339f : FAILURE in 12m 21s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"497bfc3e3fd18ce9b37f2a8d6f7a15d311c1caa6","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2020-01-24 10:12:10.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"436e84c7169a100386e04c053d5f98057305abed","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2020-01-24 10:19:44.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"d11707956e4de91ca3a6e013886406928325f456","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2020-01-24 12:34:00.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"6a2dd1b48614a02d8a60ad318c79063979c4d567","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-24 12:58:24.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/4d1de5cd41624481b17a53118970dca5 : SUCCESS in 5m 24s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/2a5c27cabb13409ca017008086291769 : SUCCESS in 4m 24s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/6c9bd094adfa478381238967adb68870 : SUCCESS in 4m 46s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b820568d79154bc0a628cb62331cd74c : SUCCESS in 6m 34s\n- bifrost-integration-tinyipa-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/51945900708a49d8aa12f0d3014e7a54 : SUCCESS in 18m 51s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/48e135e992864419a04e86745dbf24e0 : SUCCESS in 4m 57s\n- bifrost-integration-tinyipa-keystone-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/7eadab78de37438a8cfb2b4c935f8934 : FAILURE in 8m 15s (non-voting)\n- bifrost-integration-dhcp-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/3326c90111fd4bacbcbc3d8de9d5b0f7 : FAILURE in 6m 24s (non-voting)\n- bifrost-integration-dibipa-debian-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/227d098ced5147119b89d9097ebc4bbb : FAILURE in 11m 07s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"f5f6ea899dae7853f73434f7fecda5a1e54241ed","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2020-01-28 00:08:14.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\n(1 comment)\n\nSingle core approving to just get this merged.","accounts_in_message":[],"_revision_number":2},{"id":"4ad65299b9fb3f6cc2b24ba8a744041225255b7d","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-28 00:08:26.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"5b56c86edb7f11addf48df6d2ec3bfcd8ee09243","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-28 00:25:55.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b69bdaee846f47eba676dead458150a7 : SUCCESS in 4m 00s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/dbbcb9a99ea5460e959a6dda4c5cee46 : SUCCESS in 3m 37s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/e0ca668a46ea472fb564825fbea17290 : SUCCESS in 3m 48s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/a8f818c54c664d7a88cec7245ef8b8e1 : SUCCESS in 3m 45s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/64340b24252d4322aae441626edb945a : SUCCESS in 5m 49s\n- bifrost-integration-tinyipa-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/70d0ced2054245949bd31817f895d0fb : SUCCESS in 16m 28s","accounts_in_message":[],"_revision_number":2},{"id":"7dc42bf0ffebcd2a0d7ade9220a75bd4a8850e93","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-28 00:25:56.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"2fc46a61d2a4a53fcbd482f79fe55d7dc05c23b7","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-28 00:29:44.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/0452934f59c34e1aa4a8fb5060b77a08 : SUCCESS in 1m 08s","accounts_in_message":[],"_revision_number":2},{"id":"37ee7fec1f9d4cd3b1364ee03c270ec647895a9d","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2020-01-28 12:33:01.000000000","message":"Patch Set 2:\n\nDo we need this backported?","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"c0d5c4ccb0bfe8727ed45e7bc431bfcb38807d26","revisions":{"96e68b351311cb8dcf9a89d28ff693eba911469f":{"kind":"REWORK","_number":1,"created":"2020-01-24 09:20:46.000000000","uploader":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"ref":"refs/changes/13/704113/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/bifrost","ref":"refs/changes/13/704113/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/bifrost refs/changes/13/704113/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/bifrost refs/changes/13/704113/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/bifrost refs/changes/13/704113/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/bifrost refs/changes/13/704113/1"}}},"commit":{"parents":[{"commit":"ef9cf1abb9e341b189e0a0377977e38bb2defcb6","subject":"Fix changes leftovers","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/bifrost/commit/ef9cf1abb9e341b189e0a0377977e38bb2defcb6"}]}],"author":{"name":"Riccardo Pittau","email":"elfosardo@gmail.com","date":"2020-01-24 09:19:29.000000000","tz":60},"committer":{"name":"Riccardo Pittau","email":"elfosardo@gmail.com","date":"2020-01-24 09:19:29.000000000","tz":60},"subject":"Check binaries only if in virtualenv","message":"Check binaries only if in virtualenv\n\nWe check the content of the binary dir as debug step, but this\nshould be necessary only when in virtualenv.\nAlso using the correct virtualenv path instead of hardcoding it.\n\nChange-Id: I294ef9dce53d7404f4d9285506f1504afabe833f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/bifrost/commit/96e68b351311cb8dcf9a89d28ff693eba911469f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/bifrost/commit/96e68b351311cb8dcf9a89d28ff693eba911469f"}]},"branch":"refs/heads/master"},"c0d5c4ccb0bfe8727ed45e7bc431bfcb38807d26":{"kind":"REWORK","_number":2,"created":"2020-01-24 12:34:00.000000000","uploader":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"ref":"refs/changes/13/704113/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/bifrost","ref":"refs/changes/13/704113/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/bifrost refs/changes/13/704113/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/bifrost refs/changes/13/704113/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/bifrost refs/changes/13/704113/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/bifrost refs/changes/13/704113/2"}}},"commit":{"parents":[{"commit":"ef9cf1abb9e341b189e0a0377977e38bb2defcb6","subject":"Fix changes leftovers","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/bifrost/commit/ef9cf1abb9e341b189e0a0377977e38bb2defcb6"}]}],"author":{"name":"Riccardo Pittau","email":"elfosardo@gmail.com","date":"2020-01-24 09:19:29.000000000","tz":60},"committer":{"name":"Riccardo Pittau","email":"elfosardo@gmail.com","date":"2020-01-24 10:30:16.000000000","tz":60},"subject":"Fix variable checks in install-deps","message":"Fix variable checks in install-deps\n\nA couple of fixes:\n- We check the content of the binary dir as debug step, but this\nshould be necessary only when in virtualenv.\nAlso using the correct virtualenv path instead of hardcoding it,\nand removing - character after variable name.\n- EXTRA_PKG_DEPS is an array and we should treat it like that\nwhen we check if it\u0027s empty or not.\n\nChange-Id: I294ef9dce53d7404f4d9285506f1504afabe833f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/bifrost/commit/c0d5c4ccb0bfe8727ed45e7bc431bfcb38807d26"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/bifrost/commit/c0d5c4ccb0bfe8727ed45e7bc431bfcb38807d26"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}