)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"d547764ab0b9e92239f93d6848ad7256b69838ae","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"(WIP) Fix the pre-installation scripts"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Pre-installation scripts such as env-setup.sh and install-deps.sh are now not fully compatible with some platforms such as CentOS 7 or RHEL 7 due to migrating to Python 3 and need fixing."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I2421d7ac925fdeb0a408cf8efb887ca30145835a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_06f5c8cb","line":9,"updated":"2020-01-29 11:03:16.000000000","message":"please respect the 80 characters limit in commit message too","commit_id":"c3ef3d7e95a8e26e0ab14911a402b7ffdbde7a80"}],"scripts/install-deps.sh":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"4f6300779a40b2db189a2445424c4194418ec0b4","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    done"},{"line_number":130,"context_line":"fi"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"if [ -n \"${VENV+x}\" ]; then"},{"line_number":133,"context_line":"    echo \"NOTICE: Using virtualenv for this installation.\""},{"line_number":134,"context_line":"    if [ ! -f ${VENV}/bin/activate ]; then"},{"line_number":135,"context_line":"        # only create venv if one doesn\u0027t exist"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3fa7e38b_069f0851","line":132,"range":{"start_line":132,"start_character":15,"end_line":132,"end_character":17},"updated":"2020-01-29 11:11:01.000000000","message":"I\u0027m not sure this is what we want, can you please explain what you want to achieve here?","commit_id":"c3ef3d7e95a8e26e0ab14911a402b7ffdbde7a80"},{"author":{"_account_id":31556,"name":"Georgy Karataev","email":"georgkarat@gmail.com","username":"gkarat"},"change_message_id":"8d67a4d2f8c659e9be0034b3a02886baf088ddfa","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    done"},{"line_number":130,"context_line":"fi"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"if [ -n \"${VENV+x}\" ]; then"},{"line_number":133,"context_line":"    echo \"NOTICE: Using virtualenv for this installation.\""},{"line_number":134,"context_line":"    if [ ! -f ${VENV}/bin/activate ]; then"},{"line_number":135,"context_line":"        # only create venv if one doesn\u0027t exist"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3fa7e38b_01f5b2cb","line":132,"range":{"start_line":132,"start_character":15,"end_line":132,"end_character":17},"in_reply_to":"3fa7e38b_069f0851","updated":"2020-01-29 12:09:21.000000000","message":"The ${VENV+x} will return nothing and the script will continue, if VENV variable is not set (and what is not required). Otherwise using old version script will fail: \nline 132: VENV: unbound variable","commit_id":"c3ef3d7e95a8e26e0ab14911a402b7ffdbde7a80"}]}