)]}'
{"id":"openstack%2Fbifrost~704956","triplet_id":"openstack%2Fbifrost~stable%2Ftrain~I294ef9dce53d7404f4d9285506f1504afabe833f","project":"openstack/bifrost","branch":"stable/train","hashtags":[],"change_id":"I294ef9dce53d7404f4d9285506f1504afabe833f","subject":"Fix variable checks in install-deps","status":"MERGED","created":"2020-01-30 10:23:01.000000000","updated":"2020-02-03 14:43:30.000000000","submitted":"2020-02-03 14:40:18.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"704956-1580740818711-04bc3352","meta_rev_id":"5fc739a9026458389e721c0c1eae4d4a0be2cecc","_number":704956,"virtual_id_number":704956,"owner":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-02-03 14:40:18.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"all":[{"value":2,"date":"2020-02-03 14:09:45.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2020-01-31 10:48:05.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"all":[{"value":1,"date":"2020-02-03 14:09:45.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-01-31 10:48:05.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2020-02-03 14:09:45.000000000","updated_by":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"reviewer":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"state":"REVIEWER"},{"updated":"2020-02-03 14:40:18.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"86ba3a1427fd8de146351ce3d9bba72cdcfde060","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2020-01-30 10:23:01.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"fa0cd296610e154e282aed9b153d26b3566ab019","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2020-01-30 10:30:34.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"f91306cc60f90fcd01f5353be3b8975b14020270","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-30 11:05:12.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a863343bafe3439980805c5cc6ef40b6 : SUCCESS in 5m 13s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/a44621e49845418d9736cd1e29f1236c : SUCCESS in 7m 10s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/258ba55ca46a4e96980fec810dd7f8d5 : SUCCESS in 7m 33s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/dc65cad887d24987950b226c1f2cf055 : SUCCESS in 7m 47s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/af87520f00aa4f559bcdf9f994780031 : SUCCESS in 10m 35s\n- bifrost-integration-tinyipa-ubuntu-xenial https://zuul.opendev.org/t/openstack/build/1e2a5f4ef57740bd8f2aba1670b3ce7a : FAILURE in 7m 08s\n- bifrost-integration-tinyipa-keystone-ubuntu-xenial https://zuul.opendev.org/t/openstack/build/7fa52e4ff9bd4a7bb930bbe2230fecd4 : FAILURE in 2m 51s\n- bifrost-integration-tinyipa-opensuse-15 https://zuul.opendev.org/t/openstack/build/d27a3eb1fbb043358b024e7bd6d94b70 : SUCCESS in 22m 50s\n- bifrost-integration-dhcp-ubuntu-xenial https://zuul.opendev.org/t/openstack/build/e3151e275de64e74b6072af282b7859e : FAILURE in 3m 53s (non-voting)\n- bifrost-integration-dhcp-opensuse-15 https://zuul.opendev.org/t/openstack/build/e73d7953b8fd475199cddba44350a725 : FAILURE in 28m 48s (non-voting)\n- bifrost-integration-dhcp-centos-7 https://zuul.opendev.org/t/openstack/build/08e03833e6eb4e488051e0d6ea26a940 : FAILURE in 4m 08s (non-voting)\n- bifrost-integration-dibipa-debian-centos-7 https://zuul.opendev.org/t/openstack/build/298d01e80cac4570b0140a8d5c517cc5 : FAILURE in 5m 02s (non-voting)\n- bifrost-integration-dibipa-debian-ubuntu-xenial https://zuul.opendev.org/t/openstack/build/773e63fec97f4286935b95e6a9f4a8fc : FAILURE in 4m 20s (non-voting)\n- bifrost-integration-dibipa-debian-opensuse-15 https://zuul.opendev.org/t/openstack/build/e548df1b1af547d6aa2cd45358e30c55 : SUCCESS in 36m 18s (non-voting)\n- bifrost-integration-tinyipa-centos-7 https://zuul.opendev.org/t/openstack/build/432a3fa162d74ab4bbbf41591192f53c : FAILURE in 5m 32s (non-voting)\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/9164619d04df4e769309fdf80fe2445e : SUCCESS in 4m 24s","accounts_in_message":[],"_revision_number":1},{"id":"ccbcf05419397fd518dfb861f1db24e761d1549d","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2020-01-30 13:27:28.000000000","message":"Patch Set 1:\n\nmmm I was a bit afraid of this issue, VENV is not defined here, so I guess we can simply keep the test for the array, or reintroduce the parameter expansion to default to empty string if the variable is unset","accounts_in_message":[],"_revision_number":1},{"id":"0f9f062b71d60edcf3b63ee00f27deba1e5b301c","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2020-01-31 09:56:31.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"c43b2a88a69f73ebda20d3c6177da7d01b8d3e14","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-31 10:39:21.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/1cbb8092752643e9bf7bdbf7d23cd01a : SUCCESS in 5m 20s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/fc7e4035773b4d8b9d1601259628e49d : SUCCESS in 5m 53s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/0d2e2066da2745bc93f0b2d6dff8a883 : SUCCESS in 4m 01s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/bfa171985107400d86ba85b038dd0ff2 : SUCCESS in 6m 05s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2efa6dda1f9142ad9edf756d60078b07 : SUCCESS in 7m 45s\n- bifrost-integration-tinyipa-ubuntu-xenial https://zuul.opendev.org/t/openstack/build/633d280da68c44d2b6d6f04ce07e59c9 : SUCCESS in 24m 05s\n- bifrost-integration-tinyipa-keystone-ubuntu-xenial https://zuul.opendev.org/t/openstack/build/3dc27f465cde45d6b27de315a87a1989 : SUCCESS in 26m 56s\n- bifrost-integration-tinyipa-opensuse-15 https://zuul.opendev.org/t/openstack/build/8071e7a3c7484d55833721cebe109c6c : SUCCESS in 20m 43s\n- bifrost-integration-dhcp-ubuntu-xenial https://zuul.opendev.org/t/openstack/build/8b12767c1d844e8cb8868b2760db69f5 : FAILURE in 30m 25s (non-voting)\n- bifrost-integration-dhcp-opensuse-15 https://zuul.opendev.org/t/openstack/build/3d31e5965a054b7ea8c6aba9eabd28d5 : FAILURE in 31m 19s (non-voting)\n- bifrost-integration-dhcp-centos-7 https://zuul.opendev.org/t/openstack/build/71202ce765de4cf989cf407bee37e407 : FAILURE in 30m 39s (non-voting)\n- bifrost-integration-dibipa-debian-centos-7 https://zuul.opendev.org/t/openstack/build/99128f2762e340348c3709d42629d473 : SUCCESS in 36m 46s (non-voting)\n- bifrost-integration-dibipa-debian-ubuntu-xenial https://zuul.opendev.org/t/openstack/build/effcea2e5e3f4b6885d66df782a3b789 : SUCCESS in 35m 32s (non-voting)\n- bifrost-integration-dibipa-debian-opensuse-15 https://zuul.opendev.org/t/openstack/build/fe1b1b6a1b904d0e8010848f795809ea : SUCCESS in 37m 18s (non-voting)\n- bifrost-integration-tinyipa-centos-7 https://zuul.opendev.org/t/openstack/build/a378deac34c4467aa36225be4ac9bbb5 : SUCCESS in 27m 33s (non-voting)\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/407ec5d2343742df874e8562d19fc444 : SUCCESS in 4m 36s","accounts_in_message":[],"_revision_number":2},{"id":"0951363e8eae6caadf94b0b0c6c4b49ea011ccbc","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2020-01-31 10:48:05.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"7e7bdf98839e1ba82172e52751328c9392d159ae","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2020-02-03 14:09:45.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"956a7df2612a45bd39fe7d0a88e9af7a96dc556b","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-03 14:09:57.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"9d9d79a9ba982bdd77e53d5400cafcf3f0635308","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-03 14:40:18.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a8e7cb30af724f679eefe558d79e829d : SUCCESS in 4m 43s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/2ebd6c014e244a48acb395b7366d06ad : SUCCESS in 4m 14s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/e18fa537bae74a83a352b735fd632272 : SUCCESS in 4m 06s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/a9de6fb96bbb463aa5ce1c744a450dab : SUCCESS in 5m 08s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7406c11eb2194ed6be2cb1f16c8ee719 : SUCCESS in 6m 22s\n- bifrost-integration-tinyipa-ubuntu-xenial https://zuul.opendev.org/t/openstack/build/a789ebeba3514e209c590b593f3e5b38 : SUCCESS in 22m 53s\n- bifrost-integration-tinyipa-keystone-ubuntu-xenial https://zuul.opendev.org/t/openstack/build/2150fc09ce144d478572fc62c8382051 : SUCCESS in 23m 10s\n- bifrost-integration-tinyipa-opensuse-15 https://zuul.opendev.org/t/openstack/build/41e48722717446f0979ece55296549f0 : SUCCESS in 22m 30s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/387f5ef239954984a44d6eab3b2a5a04 : SUCCESS in 4m 11s","accounts_in_message":[],"_revision_number":2},{"id":"cedff3cb88fae91db8232aca5da610198cf87c5e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-03 14:40:18.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"5fc739a9026458389e721c0c1eae4d4a0be2cecc","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-03 14:43:30.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2ca445e0e2774124b095074bcacdf430 : SUCCESS in 2m 39s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"1de5bb6fa04ad4631b75d950ca978cc7bcbfb4dc","revisions":{"fbb70aacf5717a681069f51874b8d6a30ef2319d":{"kind":"REWORK","_number":1,"created":"2020-01-30 10:23:01.000000000","uploader":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"ref":"refs/changes/56/704956/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/bifrost","ref":"refs/changes/56/704956/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/bifrost refs/changes/56/704956/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/bifrost refs/changes/56/704956/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/bifrost refs/changes/56/704956/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/bifrost refs/changes/56/704956/1"}}},"commit":{"parents":[{"commit":"a418620c57e068c1edbd800f87d04137a43423e5","subject":"Check out global requirements when creating test VMs","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/bifrost/commit/a418620c57e068c1edbd800f87d04137a43423e5"}]}],"author":{"name":"Riccardo Pittau","email":"elfosardo@gmail.com","date":"2020-01-24 09:19:29.000000000","tz":60},"committer":{"name":"Riccardo Pittau","email":"elfosardo@gmail.com","date":"2020-01-30 10:22:44.000000000","tz":60},"subject":"Fix variable checks in install-deps","message":"Fix variable checks in install-deps\n\nA couple of fixes:\n- We check the content of the binary dir as debug step, but this\nshould be necessary only when in virtualenv.\nAlso using the correct virtualenv path instead of hardcoding it,\nand removing - character after variable name.\n- EXTRA_PKG_DEPS is an array and we should treat it like that\nwhen we check if it\u0027s empty or not.\n\nChange-Id: I294ef9dce53d7404f4d9285506f1504afabe833f\n(cherry picked from commit c0d5c4ccb0bfe8727ed45e7bc431bfcb38807d26)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/bifrost/commit/fbb70aacf5717a681069f51874b8d6a30ef2319d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/bifrost/commit/fbb70aacf5717a681069f51874b8d6a30ef2319d"}]},"branch":"refs/heads/stable/train"},"1de5bb6fa04ad4631b75d950ca978cc7bcbfb4dc":{"kind":"REWORK","_number":2,"created":"2020-01-31 09:56:31.000000000","uploader":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"ref":"refs/changes/56/704956/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/bifrost","ref":"refs/changes/56/704956/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/bifrost refs/changes/56/704956/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/bifrost refs/changes/56/704956/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/bifrost refs/changes/56/704956/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/bifrost refs/changes/56/704956/2"}}},"commit":{"parents":[{"commit":"a418620c57e068c1edbd800f87d04137a43423e5","subject":"Check out global requirements when creating test VMs","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/bifrost/commit/a418620c57e068c1edbd800f87d04137a43423e5"}]}],"author":{"name":"Riccardo Pittau","email":"elfosardo@gmail.com","date":"2020-01-24 09:19:29.000000000","tz":60},"committer":{"name":"Riccardo Pittau","email":"elfosardo@gmail.com","date":"2020-01-31 09:56:22.000000000","tz":60},"subject":"Fix variable checks in install-deps","message":"Fix variable checks in install-deps\n\nA couple of fixes:\n- We check the content of the binary dir as debug step, but this\nshould be necessary only when in virtualenv.\nAlso using the correct virtualenv path instead of hardcoding it,\nand removing - character after variable name.\n- EXTRA_PKG_DEPS is an array and we should treat it like that\nwhen we check if it\u0027s empty or not.\n\nChange-Id: I294ef9dce53d7404f4d9285506f1504afabe833f\n(cherry picked from commit c0d5c4ccb0bfe8727ed45e7bc431bfcb38807d26)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/bifrost/commit/1de5bb6fa04ad4631b75d950ca978cc7bcbfb4dc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/bifrost/commit/1de5bb6fa04ad4631b75d950ca978cc7bcbfb4dc"}]},"branch":"refs/heads/stable/train"}},"requirements":[],"submit_records":[],"submit_requirements":[]}