)]}'
{"scripts/env-setup.sh":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"3296590fd2b0b6dbca5b83f9d1995baef189b584","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# NOTE(pas-ha) the above exports some useful variables like"},{"line_number":6,"context_line":"# $PYTHON , $PIP and $VENV depending on venv install or not"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"ANSIBLE_PIP_VERSION\u003d${ANSIBLE_PIP_VERSION:-\u0027ansible!\u003d2.8.9,\u003c2.9\u0027}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"if [ -n \"${VENV-}\" ]; then"},{"line_number":11,"context_line":"    sudo ${PIP} install --ignore-installed \"${ANSIBLE_PIP_VERSION}\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"1fa4df85_64be2800","line":8,"range":{"start_line":8,"start_character":22,"end_line":8,"end_character":41},"updated":"2020-03-06 10:21:34.000000000","message":"Previously this didn\u0027t include the \u0027ansible\u0027 part. We should be able to just add that below instead. Or were you thinking you could provide a full source link?","commit_id":"0f27966bc3cfb678080b53e6c48848e5fcf73339"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9e0eec8c2467f2c8ab246bcda90935dcb697821f","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# NOTE(pas-ha) the above exports some useful variables like"},{"line_number":6,"context_line":"# $PYTHON , $PIP and $VENV depending on venv install or not"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"ANSIBLE_PIP_VERSION\u003d${ANSIBLE_PIP_VERSION:-\u0027ansible!\u003d2.8.9,\u003c2.9\u0027}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"if [ -n \"${VENV-}\" ]; then"},{"line_number":11,"context_line":"    sudo ${PIP} install --ignore-installed \"${ANSIBLE_PIP_VERSION}\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"1fa4df85_e4977839","line":8,"range":{"start_line":8,"start_character":22,"end_line":8,"end_character":41},"in_reply_to":"1fa4df85_44668cc3","updated":"2020-03-06 10:37:04.000000000","message":"Maybe grep for \u0027ansible\u0027 in the version and prepend if it\u0027s not there?","commit_id":"0f27966bc3cfb678080b53e6c48848e5fcf73339"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"73160ab7822224862e3578db8499aa32468ab2dc","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# NOTE(pas-ha) the above exports some useful variables like"},{"line_number":6,"context_line":"# $PYTHON , $PIP and $VENV depending on venv install or not"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"ANSIBLE_PIP_VERSION\u003d${ANSIBLE_PIP_VERSION:-\u0027ansible!\u003d2.8.9,\u003c2.9\u0027}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"if [ -n \"${VENV-}\" ]; then"},{"line_number":11,"context_line":"    sudo ${PIP} install --ignore-installed \"${ANSIBLE_PIP_VERSION}\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"1fa4df85_44668cc3","line":8,"range":{"start_line":8,"start_character":22,"end_line":8,"end_character":41},"in_reply_to":"1fa4df85_64be2800","updated":"2020-03-06 10:25:58.000000000","message":"the idea is to provide whatever link, path or version you want\nfor example for git something like:\nANSIBLE_PIP_VERSION\u003d\u0027git+https://github.com/ansible/ansible.git@{branch}\u0027","commit_id":"0f27966bc3cfb678080b53e6c48848e5fcf73339"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"4cf2e0630a8a480c9079135c5705f0929d6fc39c","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# NOTE(pas-ha) the above exports some useful variables like"},{"line_number":6,"context_line":"# $PYTHON , $PIP and $VENV depending on venv install or not"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"ANSIBLE_PIP_VERSION\u003d${ANSIBLE_PIP_VERSION:-\u0027ansible!\u003d2.8.9,\u003c2.9\u0027}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"if [ -n \"${VENV-}\" ]; then"},{"line_number":11,"context_line":"    sudo ${PIP} install --ignore-installed \"${ANSIBLE_PIP_VERSION}\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"1fa4df85_44376c00","line":8,"range":{"start_line":8,"start_character":22,"end_line":8,"end_character":41},"in_reply_to":"1fa4df85_64f2a89c","updated":"2020-03-06 10:55:54.000000000","message":"Or we allow overriding in two ways:\n\nANSIBLE_PIP_VERSION\u003d${ANSIBLE_PIP_VERSION:-\u0027!\u003d2.8.9,\u003c2.9\u0027}\nANSIBLE_PIP_STRING\u003d${ANSIBLE_PIP_STRING:-ansible${ANSIBLE_PIP_VERSION}}\n\nMight be nice to also break out the default version to make updates to it clearer:\n\nDEFAULT_ANSIBLE_PIP_VERSION\u003d\u0027!\u003d2.8.9,\u003c2.9\u0027","commit_id":"0f27966bc3cfb678080b53e6c48848e5fcf73339"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"2f8973876db162f77fa4d5177a0c00cb046c8816","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# NOTE(pas-ha) the above exports some useful variables like"},{"line_number":6,"context_line":"# $PYTHON , $PIP and $VENV depending on venv install or not"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"ANSIBLE_PIP_VERSION\u003d${ANSIBLE_PIP_VERSION:-\u0027ansible!\u003d2.8.9,\u003c2.9\u0027}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"if [ -n \"${VENV-}\" ]; then"},{"line_number":11,"context_line":"    sudo ${PIP} install --ignore-installed \"${ANSIBLE_PIP_VERSION}\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"1fa4df85_64f2a89c","line":8,"range":{"start_line":8,"start_character":22,"end_line":8,"end_character":41},"in_reply_to":"1fa4df85_e4977839","updated":"2020-03-06 10:44:42.000000000","message":"That would require to add logic that might prevent to use all the possible ways to install ansible.\nFor example a path, or even a remote url, might not contain the word ansible, and that will require logic to check if that\u0027s a path or a remote url so we don\u0027t prepend the word ansible, or we need to prepend it only if there\u0027s a certain pattern in the version, like numbers with dots or weird symbols :)\nThe idea is to simplify and just give the final user the possibility to specify whatever they want.\nDangerous, but simple.\nOne thing that we could do is adding a variable that we know it will be a path or a url, like ANSIBLE_SOURCE_PATH, and in that case we ignore the version but just install from the path/url provided.\nwdyt?","commit_id":"0f27966bc3cfb678080b53e6c48848e5fcf73339"}]}