)]}'
{"scripts/install-deps.sh":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"097111a50e0475aea1d2beee37221febdeeb1383","unresolved":false,"context_lines":[{"line_number":176,"context_line":"  ls -la ${VENV}/bin"},{"line_number":177,"context_line":"fi"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"PIP\u003d$(which pip3)"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"if [ \"$OS_FAMILY\" \u003d\u003d \"RedHat\" ]; then"},{"line_number":182,"context_line":"    sudo -H -E ${PIP} freeze"}],"source_content_type":"text/x-sh","patch_set":1,"id":"ff570b3c_7cf9d54b","line":179,"updated":"2020-05-25 08:33:18.000000000","message":"maybe just use pip3 everywhere then? why do we need a full path?","commit_id":"9814ecddfd4aaaa34a1bb056ae721ac150bc8eda"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"ff18990bb9cb9d99f706755e128326b12301b78e","unresolved":false,"context_lines":[{"line_number":176,"context_line":"  ls -la ${VENV}/bin"},{"line_number":177,"context_line":"fi"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"PIP\u003d$(which pip3)"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"if [ \"$OS_FAMILY\" \u003d\u003d \"RedHat\" ]; then"},{"line_number":182,"context_line":"    sudo -H -E ${PIP} freeze"}],"source_content_type":"text/x-sh","patch_set":1,"id":"ff570b3c_bf651f48","line":179,"in_reply_to":"ff570b3c_5f3de32a","updated":"2020-05-25 09:26:33.000000000","message":"actually.... I will just put pip3 here and keep the variable","commit_id":"9814ecddfd4aaaa34a1bb056ae721ac150bc8eda"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"afc4183706f8c7633daa95850bf5ae35b8b0d421","unresolved":false,"context_lines":[{"line_number":176,"context_line":"  ls -la ${VENV}/bin"},{"line_number":177,"context_line":"fi"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"PIP\u003d$(which pip3)"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"if [ \"$OS_FAMILY\" \u003d\u003d \"RedHat\" ]; then"},{"line_number":182,"context_line":"    sudo -H -E ${PIP} freeze"}],"source_content_type":"text/x-sh","patch_set":1,"id":"ff570b3c_5f3de32a","line":179,"in_reply_to":"ff570b3c_7cf9d54b","updated":"2020-05-25 09:20:12.000000000","message":"I think a deeper review is needed on this script, I was going step by step, but I can just convert to use pip3 everywhere and then move on with the rest of the changes.\nIt just requires a much bigger first step :)","commit_id":"9814ecddfd4aaaa34a1bb056ae721ac150bc8eda"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8118305a8307cdf0d9d951c298f70b48db6909a9","unresolved":false,"context_lines":[{"line_number":126,"context_line":"  ls -la ${VENV}/bin"},{"line_number":127,"context_line":"fi"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"PIP\u003d\"pip3\""},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"# Install the rest of required packages using bindep"},{"line_number":132,"context_line":"sudo -H -E ${PIP} install bindep"}],"source_content_type":"text/x-sh","patch_set":4,"id":"ff570b3c_9375a4cf","line":129,"updated":"2020-05-26 13:03:38.000000000","message":"Why not \"$PYTHON -m pip\" to make absolutely sure they match?","commit_id":"533dcea14a1b0a13e2439ac24482140342f229a2"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"952d6e11b4a1e3c9d27673440d373c7b29889fae","unresolved":false,"context_lines":[{"line_number":126,"context_line":"  ls -la ${VENV}/bin"},{"line_number":127,"context_line":"fi"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"PIP\u003d\"pip3\""},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"# Install the rest of required packages using bindep"},{"line_number":132,"context_line":"sudo -H -E ${PIP} install bindep"}],"source_content_type":"text/x-sh","patch_set":4,"id":"ff570b3c_3e0d7f37","line":129,"in_reply_to":"ff570b3c_9375a4cf","updated":"2020-05-26 13:09:01.000000000","message":"yes, thanks, I\u0027m also testing this, but I think it will require more changes anyway","commit_id":"533dcea14a1b0a13e2439ac24482140342f229a2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e069a02d368f4e8c57b0e79c7a0e7320ba26b4ab","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    echo \"NOTICE: Using virtualenv for this installation.\""},{"line_number":98,"context_line":"    if [ ! -f ${VENV}/bin/activate ]; then"},{"line_number":99,"context_line":"        # only create venv if one doesn\u0027t exist"},{"line_number":100,"context_line":"        sudo python3 -m venv --system-site-packages ${VENV}"},{"line_number":101,"context_line":"        sudo chown -R ${USER} ${VENV}"},{"line_number":102,"context_line":"    fi"},{"line_number":103,"context_line":"    # Note(cinerama): activate is not compatible with \"set -u\";"}],"source_content_type":"text/x-sh","patch_set":6,"id":"ff570b3c_bf597836","line":100,"updated":"2020-05-27 09:17:08.000000000","message":"Why removing -H and -E here? Maybe clarify in the commit message?","commit_id":"4d08b865f3a432d0e294b899a813f453b78c2bab"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"8bf027a437fdf1ad22ee94075e9d717749521d91","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    echo \"NOTICE: Using virtualenv for this installation.\""},{"line_number":98,"context_line":"    if [ ! -f ${VENV}/bin/activate ]; then"},{"line_number":99,"context_line":"        # only create venv if one doesn\u0027t exist"},{"line_number":100,"context_line":"        sudo python3 -m venv --system-site-packages ${VENV}"},{"line_number":101,"context_line":"        sudo chown -R ${USER} ${VENV}"},{"line_number":102,"context_line":"    fi"},{"line_number":103,"context_line":"    # Note(cinerama): activate is not compatible with \"set -u\";"}],"source_content_type":"text/x-sh","patch_set":6,"id":"ff570b3c_df342c4d","line":100,"in_reply_to":"ff570b3c_bf597836","updated":"2020-05-27 09:46:19.000000000","message":"no reason, just forgotten also in the next line, thanks!","commit_id":"4d08b865f3a432d0e294b899a813f453b78c2bab"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e069a02d368f4e8c57b0e79c7a0e7320ba26b4ab","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"# If we\u0027re using a venv, we need to work around sudo not"},{"line_number":114,"context_line":"# keeping the path even with -E."},{"line_number":115,"context_line":"PYTHON\u003d$(which python3)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"ls $PYTHON"},{"line_number":118,"context_line":"$PYTHON \u003c\u003c EOF"}],"source_content_type":"text/x-sh","patch_set":6,"id":"ff570b3c_1f406435","line":115,"updated":"2020-05-27 09:17:08.000000000","message":"If we use pip3 later on, we should just use python3 here.","commit_id":"4d08b865f3a432d0e294b899a813f453b78c2bab"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"8bf027a437fdf1ad22ee94075e9d717749521d91","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"# If we\u0027re using a venv, we need to work around sudo not"},{"line_number":114,"context_line":"# keeping the path even with -E."},{"line_number":115,"context_line":"PYTHON\u003d$(which python3)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"ls $PYTHON"},{"line_number":118,"context_line":"$PYTHON \u003c\u003c EOF"}],"source_content_type":"text/x-sh","patch_set":6,"id":"ff570b3c_7f16c0a9","line":115,"in_reply_to":"ff570b3c_1f406435","updated":"2020-05-27 09:46:19.000000000","message":"that is idea, I will do the change in the next patch in the chain if that\u0027s ok","commit_id":"4d08b865f3a432d0e294b899a813f453b78c2bab"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e069a02d368f4e8c57b0e79c7a0e7320ba26b4ab","unresolved":false,"context_lines":[{"line_number":127,"context_line":"  ls -la ${VENV}/bin"},{"line_number":128,"context_line":"fi"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"PIP\u003d\"pip3\""},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"# Install the rest of required packages using bindep"},{"line_number":133,"context_line":"sudo -H -E ${PIP} install bindep"}],"source_content_type":"text/x-sh","patch_set":6,"id":"ff570b3c_ff3ad0c1","line":130,"updated":"2020-05-27 09:17:08.000000000","message":"Let\u0027s remove it now?\n\nAlso what are the reasons not to use \"$PYTHON -m pip\" which is supposed to always do the right thing?","commit_id":"4d08b865f3a432d0e294b899a813f453b78c2bab"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"8bf027a437fdf1ad22ee94075e9d717749521d91","unresolved":false,"context_lines":[{"line_number":127,"context_line":"  ls -la ${VENV}/bin"},{"line_number":128,"context_line":"fi"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"PIP\u003d\"pip3\""},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"# Install the rest of required packages using bindep"},{"line_number":133,"context_line":"sudo -H -E ${PIP} install bindep"}],"source_content_type":"text/x-sh","patch_set":6,"id":"ff570b3c_3f71e80d","line":130,"in_reply_to":"ff570b3c_ff3ad0c1","updated":"2020-05-27 09:46:19.000000000","message":"what do you mean \"remove it\" ?\n\nI\u0027ll change it to \"$PYTHON -m pip\"","commit_id":"4d08b865f3a432d0e294b899a813f453b78c2bab"}]}