)]}'
{"id":"openstack%2Fbifrost~731493","triplet_id":"openstack%2Fbifrost~master~I35be662c4a60b4085b22d7e01b1691597f82c732","project":"openstack/bifrost","branch":"master","topic":"venv-var","hashtags":[],"change_id":"I35be662c4a60b4085b22d7e01b1691597f82c732","subject":"Correct handling enable_venv in pip_install.yml","status":"MERGED","created":"2020-05-28 10:40:06.000000000","updated":"2020-06-02 10:03:32.000000000","submitted":"2020-06-02 09:30:33.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"731493-1591090233970-dea03b6f","meta_rev_id":"cbe16fb4cc33482b36adf6e2f701219dfb2d40df","_number":731493,"virtual_id_number":731493,"owner":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-06-02 09:30:33.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"all":[{"value":2,"date":"2020-06-01 23:40:48.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2020-06-02 09:04:40.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"all":[{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2020-06-02 09:04:40.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-06-01 23:40:48.000000000","updated_by":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"reviewer":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"state":"REVIEWER"},{"updated":"2020-06-02 09:04:40.000000000","updated_by":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"reviewer":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"state":"REVIEWER"},{"updated":"2020-06-02 09:30:33.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"3e8d931c2566d8bd8ed5e08de520b213137cde5f","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2020-05-28 10:40:06.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"038e163daa5c34818b63dc8564eae60d0f5155e1","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-05-28 11:18:33.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/4cb29e865b0b4b3e9238b3b46ac2bc06 : SUCCESS in 4m 11s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/8bda929697424d11a6f73d76f81751bd : SUCCESS in 5m 19s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/50daf58624754fbf91c9e36c21626ac0 : SUCCESS in 5m 09s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/9450e45a26164fc0896338a4c6a46eed : SUCCESS in 4m 30s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f3d3645fb63940e5bf688f76dc2728ed : SUCCESS in 7m 38s\n- bifrost-integration-tinyipa-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/cc6dc7468ea749e780000e0937967fa8 : SUCCESS in 16m 43s\n- bifrost-integration-tinyipa-centos-8 https://zuul.opendev.org/t/openstack/build/929bcf30651f42c3ae88c3ac4f216ac8 : SUCCESS in 22m 35s\n- bifrost-integration-tinyipa-keystone-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/678c2f21d2944fa9977b10d3214c815e : SUCCESS in 24m 42s\n- bifrost-integration-tinyipa-opensuse-15 https://zuul.opendev.org/t/openstack/build/60977374deb948ae86b649557cec3dc9 : SUCCESS in 19m 32s (non-voting)\n- bifrost-integration-dhcp-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/f19c9a8160dd4c2086d0516929e686c3 : SUCCESS in 21m 59s (non-voting)\n- bifrost-integration-dibipa-debian-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/48186b86f01c482e97b924f564215136 : FAILURE in 11m 06s (non-voting)\n- bifrost-integration-dhcp-centos-8 https://zuul.opendev.org/t/openstack/build/6c115b23678c4a0487cd87b85b4d71cc : FAILURE in 33m 45s (non-voting)\n- bifrost-integration-dibipa-debian-centos-8 https://zuul.opendev.org/t/openstack/build/bd7737f814e0436c9f0383deeef50751 : FAILURE in 13m 51s (non-voting)\n- bifrost-integration-dhcp-opensuse-15 https://zuul.opendev.org/t/openstack/build/f227ee2d6a274d59a2c9da6ea459b4d7 : FAILURE in 32m 10s (non-voting)\n- bifrost-integration-dibipa-debian-opensuse-15 https://zuul.opendev.org/t/openstack/build/410dea8645cd4adab75e5365013174bc : FAILURE in 13m 09s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"0b59f1cb255c24f9f9eff1b3f88cb505dce84de6","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2020-06-01 23:40:48.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"4b62446bdbe4dde5f974094f15edc244b8872ead","author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"date":"2020-06-02 09:04:40.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"afc5ef1240e1a31a8dabd43533705256f80e94f1","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-02 09:04:51.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"e270ef56eba5994c14c4dffba5a8fb8cd75b1d90","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-02 09:30:33.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"bad769c8213c7a9717abcd0e942d58338ffc12a8","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-02 09:30:33.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/f3780441555841168938ce2ec65f0ba5 : SUCCESS in 5m 40s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/80a56ebe69f14206933a4287b5a2609e : SUCCESS in 6m 16s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/6fe368f86dde4674bce0c65b8dacac31 : SUCCESS in 6m 40s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/9dd1132e8ed048e0a77cb864b835c948 : SUCCESS in 5m 28s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/62ecfbc82067450c9c88b1ee42c17c43 : SUCCESS in 5m 56s\n- bifrost-integration-tinyipa-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/283c6f3487174ddcad926e0453133812 : SUCCESS in 15m 33s\n- bifrost-integration-tinyipa-centos-8 https://zuul.opendev.org/t/openstack/build/e3a8b3f9d5d8498399bb4e79b076cea3 : SUCCESS in 19m 22s\n- bifrost-integration-tinyipa-keystone-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/920c5115b94e47e4a30febac6855631a : SUCCESS in 19m 29s","accounts_in_message":[],"_revision_number":1},{"id":"efe9c981cc0ebb3d1e376b7ae7ff991cbfa1e969","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-02 09:32:29.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9d76c8ab369d4b7ab501f1715710f7a9 : SUCCESS in 1m 21s","accounts_in_message":[],"_revision_number":1},{"id":"f1e55eaa8954e714b41adb070ac38e73e029ba87","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2020-06-02 10:03:32.000000000","message":"Patch Set 1: Cherry Picked\n\nThis patchset was cherry picked to branch stable/ussuri as commit a9beb963c200505f3f4a43d0e90dd0cbbc704e40","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"bb807b2288551bae02dab4f34da29226b3eba5b2","revisions":{"bb807b2288551bae02dab4f34da29226b3eba5b2":{"kind":"REWORK","_number":1,"created":"2020-05-28 10:40:06.000000000","uploader":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"ref":"refs/changes/93/731493/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/bifrost","ref":"refs/changes/93/731493/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/bifrost refs/changes/93/731493/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/bifrost refs/changes/93/731493/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/bifrost refs/changes/93/731493/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/bifrost refs/changes/93/731493/1"}}},"commit":{"parents":[{"commit":"a381b0f9c0a82e6afbe23989fae0c7e017479500","subject":"install-deps: use system pip and bindep for installing dependencies","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/bifrost/commit/a381b0f9c0a82e6afbe23989fae0c7e017479500"}]}],"author":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2020-05-28 10:35:37.000000000","tz":120},"committer":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2020-05-28 10:39:01.000000000","tz":120},"subject":"Correct handling enable_venv in pip_install.yml","message":"Correct handling enable_venv in pip_install.yml\n\nThe way we pass it, it is a string, not a boolean. While ansible\nis handling this situation for now, it\u0027s deprecated and should\nnot be relied on. Convert enable_venv to boolean explicitly.\n\nRemove a redundant fact setting and redundant default() from\nenable_venv (it is set in role defaults).\n\nAlso synchronize pip_install.yml to bifrost-keystone-install.\n\nChange-Id: I35be662c4a60b4085b22d7e01b1691597f82c732\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/bifrost/commit/bb807b2288551bae02dab4f34da29226b3eba5b2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/bifrost/commit/bb807b2288551bae02dab4f34da29226b3eba5b2"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}