)]}'
{"id":"openstack%2Fbifrost~732515","triplet_id":"openstack%2Fbifrost~stable%2Fussuri~I35be662c4a60b4085b22d7e01b1691597f82c732","project":"openstack/bifrost","branch":"stable/ussuri","topic":"venv-var-stable/ussuri","hashtags":[],"change_id":"I35be662c4a60b4085b22d7e01b1691597f82c732","subject":"Correct handling enable_venv in pip_install.yml","status":"MERGED","created":"2020-06-02 10:03:32.000000000","updated":"2020-06-08 10:16:56.000000000","submitted":"2020-06-08 10:14:57.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"732515-1591611298162-90931dd6","meta_rev_id":"edd6756a0850ec2c4282112015548ef5df09e6aa","_number":732515,"virtual_id_number":732515,"owner":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-06-08 10:14:57.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2020-06-03 07:04:20.000000000","_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"all":[{"value":2,"date":"2020-06-08 09:39:55.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"all":[{"value":1,"date":"2020-06-08 09:39:55.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-06-08 09:39:55.000000000","updated_by":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"reviewer":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"state":"REVIEWER"},{"updated":"2020-06-08 10:14:57.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"f036e0f55b78ca5d8ffbbfd9d1fd5c882dd9e116","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2020-06-02 10:03:32.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"3dd76df95e4b582644696f0980a1adc7e158d079","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2020-06-03 07:04:20.000000000","message":"Patch Set 1:\n\nrecheck hello?","accounts_in_message":[],"_revision_number":1},{"id":"e9c2327e0ec459b49424b4c0e4247980f7a0cc63","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-03 07:49:34.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/062b45f94fa547c1bc13feedc7e21517 : SUCCESS in 6m 17s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/4b40e9ad133c418e901a59a89268c363 : SUCCESS in 3m 58s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/0727ae85ae6d45198b714e50770dbce2 : SUCCESS in 4m 38s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/23f7fe2901e0499f9a82e8711e2cf7cb : SUCCESS in 6m 24s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/51af35fd5c1f4935b687164804593557 : SUCCESS in 6m 02s\n- bifrost-integration-tinyipa-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/3a2fcd9029e44886b3ac50b51c5c46ad : SUCCESS in 19m 17s\n- bifrost-integration-tinyipa-centos-8 https://zuul.opendev.org/t/openstack/build/2f76edc7cfb04ceda8732a699a2d5491 : SUCCESS in 20m 24s\n- bifrost-integration-tinyipa-keystone-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/2968958900ff4b6d98d760e7e2a1d6c3 : SUCCESS in 19m 23s\n- bifrost-integration-tinyipa-opensuse-15 https://zuul.opendev.org/t/openstack/build/a28ea77616e64c0d94152aa525021c66 : SUCCESS in 18m 42s (non-voting)\n- bifrost-integration-tinyipa-fedora-latest https://zuul.opendev.org/t/openstack/build/a9f60d0c95394848bcac2daa857122f6 : FAILURE in 9m 19s (non-voting)\n- bifrost-integration-dhcp-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/91acfc4233d44bb49bc4da9e70192ab1 : FAILURE in 29m 23s (non-voting)\n- bifrost-integration-dibipa-debian-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/2c33f69a5bc04162b15c0cd3df185a28 : FAILURE in 10m 31s (non-voting)\n- bifrost-integration-dhcp-centos-8 https://zuul.opendev.org/t/openstack/build/42437293f4dd49568de3960f454933e4 : FAILURE in 33m 47s (non-voting)\n- bifrost-integration-dibipa-debian-centos-8 https://zuul.opendev.org/t/openstack/build/e991f7a1ed3a4ebab0bd1617943c7c3a : FAILURE in 13m 43s (non-voting)\n- bifrost-integration-dhcp-opensuse-15 https://zuul.opendev.org/t/openstack/build/4cb80a890b83463e8d7b9422dca1a7b6 : FAILURE in 32m 30s (non-voting)\n- bifrost-integration-dibipa-debian-opensuse-15 https://zuul.opendev.org/t/openstack/build/5603109578a6416db85f60ecd51c27f6 : FAILURE in 12m 44s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"ec4aaf6e36a7dd7cd838af99dd2936f3ffac5792","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2020-06-08 09:39:55.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"17648a36863d2c251748573e391fa3ad04f1c05e","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-08 09:40:06.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"7421bf66d5cc906525fcde2e12ea19914f501fc3","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-08 10:14:57.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/65ea2a88ec0c494cbdd897633716fde1 : SUCCESS in 3m 42s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/c37c1faaaba946deb08e02dc4e75ad2c : SUCCESS in 4m 45s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/8987dc57f60d4fad994abdb805d08d61 : SUCCESS in 5m 40s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/ae74ff8be7ca44d28e4898f246f96e36 : SUCCESS in 4m 57s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/8972f82108bb4ac384fde7f3d2cff0b8 : SUCCESS in 6m 52s\n- bifrost-integration-tinyipa-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/98ae560572e64c909914909c6faa6878 : SUCCESS in 15m 50s\n- bifrost-integration-tinyipa-centos-8 https://zuul.opendev.org/t/openstack/build/a5c613221a8e4b0ab0a08a7bad292833 : SUCCESS in 19m 35s\n- bifrost-integration-tinyipa-keystone-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/e5b50c453638471492f3e410c7360e70 : SUCCESS in 19m 26s\n- bifrost-integration-tinyipa-keystone-centos-8 https://zuul.opendev.org/t/openstack/build/f552e563890b4a9faede668b6aeb2287 : SUCCESS in 33m 26s","accounts_in_message":[],"_revision_number":1},{"id":"71667d82db65211e716ea09cf8c227e76bf2b19f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-08 10:14:58.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"a8614e6e0455cea522b72d1bc9f7fd79d7633418","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-08 10:16:56.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/071461835fb04ee19f956dad14b259cd : SUCCESS in 1m 34s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"a9beb963c200505f3f4a43d0e90dd0cbbc704e40","revisions":{"a9beb963c200505f3f4a43d0e90dd0cbbc704e40":{"kind":"REWORK","_number":1,"created":"2020-06-02 10:03:32.000000000","uploader":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"ref":"refs/changes/15/732515/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/bifrost","ref":"refs/changes/15/732515/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/bifrost refs/changes/15/732515/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/bifrost refs/changes/15/732515/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/bifrost refs/changes/15/732515/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/bifrost refs/changes/15/732515/1"}}},"commit":{"parents":[{"commit":"15a6367ef5e60151da90091ccb577e060682ae40","subject":"Merge \"Fix detection of mkisofs\" into stable/ussuri","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/bifrost/commit/15a6367ef5e60151da90091ccb577e060682ae40"}]}],"author":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2020-05-28 10:35:37.000000000","tz":120},"committer":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2020-06-02 10:03:32.000000000","tz":0},"subject":"Correct handling enable_venv in pip_install.yml","message":"Correct handling enable_venv in pip_install.yml\n\nThe way we pass it, it is a string, not a boolean. While ansible\nis handling this situation for now, it\u0027s deprecated and should\nnot be relied on. Convert enable_venv to boolean explicitly.\n\nRemove a redundant fact setting and redundant default() from\nenable_venv (it is set in role defaults).\n\nAlso synchronize pip_install.yml to bifrost-keystone-install.\n\nChange-Id: I35be662c4a60b4085b22d7e01b1691597f82c732\n(cherry picked from commit bb807b2288551bae02dab4f34da29226b3eba5b2)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/bifrost/commit/a9beb963c200505f3f4a43d0e90dd0cbbc704e40"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/bifrost/commit/a9beb963c200505f3f4a43d0e90dd0cbbc704e40"}]},"branch":"refs/heads/stable/ussuri"}},"requirements":[],"submit_records":[],"submit_requirements":[]}