)]}'
{"playbooks/roles/bifrost-ironic-install/tasks/bootstrap.yml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"4185f15f2851cfa8722b9c78d000deb041c98897","unresolved":false,"context_lines":[{"line_number":60,"context_line":"- name: Setting MySQL socket fact"},{"line_number":61,"context_line":"  set_fact:"},{"line_number":62,"context_line":"    mysql_socket_path: \"/var/{% if ansible_os_family | lower \u003d\u003d \u0027redhat\u0027 %}lib{% else %}run{% endif %}/{% if ansible_os_family | lower \u003d\u003d \u0027debian\u0027 %}mysqld/mysqld.sock{% else %}mysql/mysql.sock{% endif %}\""},{"line_number":63,"context_line":"  when: ansible_version.full is version(\u00272.6.5\u0027, \u0027\u003e\u003d\u0027)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"- name: \"MySQL - Creating DB\""},{"line_number":66,"context_line":"  mysql_db:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ff570b3c_ce9e9c52","line":63,"range":{"start_line":63,"start_character":0,"end_line":63,"end_character":54},"updated":"2020-06-05 10:02:37.000000000","message":"The whole condition can be removed?","commit_id":"2e397d2e8347faeb8fe68cd3b3eaaebba91c190b"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"1b16e9f1499ee62595953f8f8986a226fe5084e8","unresolved":false,"context_lines":[{"line_number":60,"context_line":"- name: Setting MySQL socket fact"},{"line_number":61,"context_line":"  set_fact:"},{"line_number":62,"context_line":"    mysql_socket_path: \"/var/{% if ansible_os_family | lower \u003d\u003d \u0027redhat\u0027 %}lib{% else %}run{% endif %}/{% if ansible_os_family | lower \u003d\u003d \u0027debian\u0027 %}mysqld/mysqld.sock{% else %}mysql/mysql.sock{% endif %}\""},{"line_number":63,"context_line":"  when: ansible_version.full is version(\u00272.6.5\u0027, \u0027\u003e\u003d\u0027)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"- name: \"MySQL - Creating DB\""},{"line_number":66,"context_line":"  mysql_db:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ff570b3c_3fa94423","line":63,"range":{"start_line":63,"start_character":0,"end_line":63,"end_character":54},"in_reply_to":"ff570b3c_2e2c78aa","updated":"2020-06-05 12:19:55.000000000","message":"yep, sorry, the all condition can be removed, thanks!","commit_id":"2e397d2e8347faeb8fe68cd3b3eaaebba91c190b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2d6501f9128269984148cd008a9d6423a42c2cf5","unresolved":false,"context_lines":[{"line_number":60,"context_line":"- name: Setting MySQL socket fact"},{"line_number":61,"context_line":"  set_fact:"},{"line_number":62,"context_line":"    mysql_socket_path: \"/var/{% if ansible_os_family | lower \u003d\u003d \u0027redhat\u0027 %}lib{% else %}run{% endif %}/{% if ansible_os_family | lower \u003d\u003d \u0027debian\u0027 %}mysqld/mysqld.sock{% else %}mysql/mysql.sock{% endif %}\""},{"line_number":63,"context_line":"  when: ansible_version.full is version(\u00272.6.5\u0027, \u0027\u003e\u003d\u0027)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"- name: \"MySQL - Creating DB\""},{"line_number":66,"context_line":"  mysql_db:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ff570b3c_2e2c78aa","line":63,"range":{"start_line":63,"start_character":0,"end_line":63,"end_character":54},"in_reply_to":"ff570b3c_6e7af0f0","updated":"2020-06-05 10:29:26.000000000","message":"What I\u0027m trying to say is that this condition is always true now that we require 2.9.","commit_id":"2e397d2e8347faeb8fe68cd3b3eaaebba91c190b"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"0eb34b1c9098306ed9ebc757e3b73808c10e9383","unresolved":false,"context_lines":[{"line_number":60,"context_line":"- name: Setting MySQL socket fact"},{"line_number":61,"context_line":"  set_fact:"},{"line_number":62,"context_line":"    mysql_socket_path: \"/var/{% if ansible_os_family | lower \u003d\u003d \u0027redhat\u0027 %}lib{% else %}run{% endif %}/{% if ansible_os_family | lower \u003d\u003d \u0027debian\u0027 %}mysqld/mysqld.sock{% else %}mysql/mysql.sock{% endif %}\""},{"line_number":63,"context_line":"  when: ansible_version.full is version(\u00272.6.5\u0027, \u0027\u003e\u003d\u0027)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"- name: \"MySQL - Creating DB\""},{"line_number":66,"context_line":"  mysql_db:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ff570b3c_6e7af0f0","line":63,"range":{"start_line":63,"start_character":0,"end_line":63,"end_character":54},"in_reply_to":"ff570b3c_ce9e9c52","updated":"2020-06-05 10:09:06.000000000","message":"Maybe, I removed since according to Riccardo comment in https://review.opendev.org/#/c/733479/2/playbooks/roles/bifrost-keystone-install/tasks/bootstrap.yml it may not be necessary.\n\n@Riccardo do you think it was ok to remove here or only in the keystone install?","commit_id":"2e397d2e8347faeb8fe68cd3b3eaaebba91c190b"}],"playbooks/roles/bifrost-keystone-install/tasks/bootstrap.yml":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"11d973cb988e96ef18117500e16442acf641ad5b","unresolved":false,"context_lines":[{"line_number":49,"context_line":"- name: Setting MySQL socket fact"},{"line_number":50,"context_line":"  set_fact:"},{"line_number":51,"context_line":"    mysql_socket_path: \"/var/{% if ansible_os_family | lower \u003d\u003d \u0027redhat\u0027 %}lib{% else %}run{% endif %}/{% if ansible_os_family | lower \u003d\u003d \u0027debian\u0027 %}mysqld/mysqld.sock{% else %}mysql/mysql.sock{% endif %}\""},{"line_number":52,"context_line":"  when: ansible_version.full is version(\u00272.6.5\u0027, \u0027\u003e\u003d\u0027)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"- name: \"MySQL - Creating DB\""},{"line_number":55,"context_line":"  mysql_db:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ff570b3c_b8e452e1","line":52,"updated":"2020-06-05 07:58:14.000000000","message":"we can probably remove this since we\u0027re pinning at ansible 2.9","commit_id":"9d94fffb73c7c6e95b345f56398e8f76ce413337"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"d9452af56e0b9953490e68175f8036591cbf2ebb","unresolved":false,"context_lines":[{"line_number":49,"context_line":"- name: Setting MySQL socket fact"},{"line_number":50,"context_line":"  set_fact:"},{"line_number":51,"context_line":"    mysql_socket_path: \"/var/{% if ansible_os_family | lower \u003d\u003d \u0027redhat\u0027 %}lib{% else %}run{% endif %}/{% if ansible_os_family | lower \u003d\u003d \u0027debian\u0027 %}mysqld/mysqld.sock{% else %}mysql/mysql.sock{% endif %}\""},{"line_number":52,"context_line":"  when: ansible_version.full is version(\u00272.6.5\u0027, \u0027\u003e\u003d\u0027)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"- name: \"MySQL - Creating DB\""},{"line_number":55,"context_line":"  mysql_db:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ff570b3c_582ff6f4","line":52,"in_reply_to":"ff570b3c_b8e452e1","updated":"2020-06-05 09:31:08.000000000","message":"Ack I will update in the next patchset","commit_id":"9d94fffb73c7c6e95b345f56398e8f76ce413337"}]}