)]}'
{"doc/source/install/index.rst":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c908654c6f3689c934eb5554e9146ede801384a2","unresolved":false,"context_lines":[{"line_number":210,"context_line":".. note::"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"   If you are using a virtual environment ANSIBLE_COLLECTIONS_PATHS is"},{"line_number":213,"context_line":"   automatically set."},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"The ``env-setup.sh`` script automatically invokes ``install-deps.sh`` and"},{"line_number":216,"context_line":"creates a virtual environment for you:"}],"source_content_type":"text/x-rst","patch_set":6,"id":"bf51134e_77c7ca65","line":213,"updated":"2020-06-21 12:30:59.000000000","message":"What exactly is setting that? The \u0027activate\u0027 script only sets PATH, is it enough?","commit_id":"fa1b8ea9a02771f32198f891f9c40b42025e4356"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7fbc2bf9a73f2fea2032b7be3da1b73bb2dc1efa","unresolved":false,"context_lines":[{"line_number":210,"context_line":".. note::"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"   If you are using a virtual environment ANSIBLE_COLLECTIONS_PATHS is"},{"line_number":213,"context_line":"   automatically set."},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"The ``env-setup.sh`` script automatically invokes ``install-deps.sh`` and"},{"line_number":216,"context_line":"creates a virtual environment for you:"}],"source_content_type":"text/x-rst","patch_set":6,"id":"bf51134e_f2b805e6","line":213,"in_reply_to":"bf51134e_62fd4ab0","updated":"2020-06-22 08:13:00.000000000","message":"Well, we\u0027re installing collections into a non-default location, right? So we need to instruct a user how to use the collections we install.\n\nProbably all this stuff needs updating to use the new variable. https://docs.openstack.org/bifrost/latest/user/howto.html#how-this-works","commit_id":"fa1b8ea9a02771f32198f891f9c40b42025e4356"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"888cf5d8d74cb9cbae22a53fb8683606786dae6a","unresolved":false,"context_lines":[{"line_number":210,"context_line":".. note::"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"   If you are using a virtual environment ANSIBLE_COLLECTIONS_PATHS is"},{"line_number":213,"context_line":"   automatically set."},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"The ``env-setup.sh`` script automatically invokes ``install-deps.sh`` and"},{"line_number":216,"context_line":"creates a virtual environment for you:"}],"source_content_type":"text/x-rst","patch_set":6,"id":"bf51134e_f70bda79","line":213,"in_reply_to":"bf51134e_77c7ca65","updated":"2020-06-21 13:59:17.000000000","message":"env-setup.sh will automatically set if the user is using a venv. \nin [1] you can see where the collections will be installed for the test cases I did. I was able to run the test script in F30 and it worked.\n\n[1] http://paste.openstack.org/show/794991/","commit_id":"fa1b8ea9a02771f32198f891f9c40b42025e4356"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"c9209a5de2f93bb755d9f7da54907c33bf3c9431","unresolved":false,"context_lines":[{"line_number":210,"context_line":".. note::"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"   If you are using a virtual environment ANSIBLE_COLLECTIONS_PATHS is"},{"line_number":213,"context_line":"   automatically set."},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"The ``env-setup.sh`` script automatically invokes ``install-deps.sh`` and"},{"line_number":216,"context_line":"creates a virtual environment for you:"}],"source_content_type":"text/x-rst","patch_set":6,"id":"bf51134e_62fd4ab0","line":213,"in_reply_to":"bf51134e_d7ba166c","updated":"2020-06-21 19:36:20.000000000","message":"If the personal playbooks  makes use of collections and it was installed in a non default location the user would need to set the ANSIBLE_COLLECTIONS_PATHS.\n\nOr you want some documentation that explains how the user can update their playbooks to create a node using the collection? (for example)","commit_id":"fa1b8ea9a02771f32198f891f9c40b42025e4356"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"508e0f26ef9590db48838945c09981c58faacd55","unresolved":false,"context_lines":[{"line_number":210,"context_line":".. note::"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"   If you are using a virtual environment ANSIBLE_COLLECTIONS_PATHS is"},{"line_number":213,"context_line":"   automatically set."},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"The ``env-setup.sh`` script automatically invokes ``install-deps.sh`` and"},{"line_number":216,"context_line":"creates a virtual environment for you:"}],"source_content_type":"text/x-rst","patch_set":6,"id":"bf51134e_d7ba166c","line":213,"in_reply_to":"bf51134e_f70bda79","updated":"2020-06-21 15:18:33.000000000","message":"env-setup.sh is only run once, when the env is installed.\n\nokay, I think I understand the confusion. this chapter is talking about installation, so you\u0027re right, everything is set correctly.\n\nbut we also need a documentation update that says how to use the new collection. E.g. I have bifrost and my own playbooks, how do I run it. Currently setting PATH is enough, I suspect with your change we need to instruct people to set the new variable too?","commit_id":"fa1b8ea9a02771f32198f891f9c40b42025e4356"}],"scripts/env-setup.sh":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"49be52d3d0b436df445901307c3ae315f05bf1c5","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"echo \"Installing ansible collections\""},{"line_number":44,"context_line":"${ANSIBLE_GALAXY} collection install -r ${ANSIBLE_COLLECTION_REQ} -p ${ANSIBLE_COLLECTIONS_PATHS}"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"echo"},{"line_number":47,"context_line":"echo \"To use bifrost, do\""}],"source_content_type":"text/x-sh","patch_set":4,"id":"ff570b3c_8a8f292d","line":44,"range":{"start_line":44,"start_character":71,"end_line":44,"end_character":96},"updated":"2020-06-10 08:46:19.000000000","message":"this looks like not defined if VENV is not set","commit_id":"dd89bd1da1033a125496b8c000c369a49893d398"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"1245b59ad788bb7ba54a5dc993531b1d3ce83f63","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"echo \"Installing ansible collections\""},{"line_number":44,"context_line":"${ANSIBLE_GALAXY} collection install -r ${ANSIBLE_COLLECTION_REQ} -p ${ANSIBLE_COLLECTIONS_PATHS}"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"echo"},{"line_number":47,"context_line":"echo \"To use bifrost, do\""}],"source_content_type":"text/x-sh","patch_set":4,"id":"ff570b3c_8d7103e2","line":44,"range":{"start_line":44,"start_character":71,"end_line":44,"end_character":96},"in_reply_to":"ff570b3c_8a8f292d","updated":"2020-06-11 13:27:19.000000000","message":"Done","commit_id":"dd89bd1da1033a125496b8c000c369a49893d398"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"a7496c3ebbccf6d56a84657103844612d6d1e6c3","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    ${PIP} install --user --upgrade \"${ANSIBLE_SOURCE_PATH}\""},{"line_number":25,"context_line":"    ANSIBLE\u003d${HOME}/.local/bin/ansible"},{"line_number":26,"context_line":"    ANSIBLE_GALAXY\u003d${HOME}/.local/bin/ansible-galaxy"},{"line_number":27,"context_line":"fi"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"PLAYBOOKS_LIBRARY_PATH\u003d$(dirname $0)/../playbooks/library"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-sh","patch_set":5,"id":"bf51134e_5ccc8660","line":27,"updated":"2020-06-19 07:26:17.000000000","message":"you might be able to avoid the if at L46 if you set ANSIBLE_COLLECTIONS_PATHS equal to BIFROST_COLLECTIONS_PATHS here","commit_id":"94cff7a8e47feb8e85a1bac89ffede1740f692b2"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"a7496c3ebbccf6d56a84657103844612d6d1e6c3","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    echo \"Installing ansible collections on default collections path\""},{"line_number":49,"context_line":"    ${ANSIBLE_GALAXY} collection install -r ${ANSIBLE_COLLECTION_REQ}"},{"line_number":50,"context_line":"else"},{"line_number":51,"context_line":"    echo \"Installing ansible collections on $ANSIBLE_COLLECTIONS_PATHS\""},{"line_number":52,"context_line":"    ${ANSIBLE_GALAXY} collection install -r ${ANSIBLE_COLLECTION_REQ} -p ${ANSIBLE_COLLECTIONS_PATHS}"},{"line_number":53,"context_line":"fi"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-sh","patch_set":5,"id":"bf51134e_3ce8b2b2","line":51,"range":{"start_line":51,"start_character":44,"end_line":51,"end_character":70},"updated":"2020-06-19 07:26:17.000000000","message":"shouldn\u0027t this be $BIFROST_COLLECTIONS_PATHS ?","commit_id":"94cff7a8e47feb8e85a1bac89ffede1740f692b2"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"a7496c3ebbccf6d56a84657103844612d6d1e6c3","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    ${ANSIBLE_GALAXY} collection install -r ${ANSIBLE_COLLECTION_REQ}"},{"line_number":50,"context_line":"else"},{"line_number":51,"context_line":"    echo \"Installing ansible collections on $ANSIBLE_COLLECTIONS_PATHS\""},{"line_number":52,"context_line":"    ${ANSIBLE_GALAXY} collection install -r ${ANSIBLE_COLLECTION_REQ} -p ${ANSIBLE_COLLECTIONS_PATHS}"},{"line_number":53,"context_line":"fi"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""}],"source_content_type":"text/x-sh","patch_set":5,"id":"bf51134e_1ceb2eb0","line":52,"range":{"start_line":52,"start_character":70,"end_line":52,"end_character":101},"updated":"2020-06-19 07:26:17.000000000","message":"ditto","commit_id":"94cff7a8e47feb8e85a1bac89ffede1740f692b2"}],"scripts/test-bifrost.sh":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"31cba838e1712e6196c53dd3fad93e14ce16f870","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    set -u"},{"line_number":63,"context_line":"    ANSIBLE\u003d${VENV}/bin/ansible-playbook"},{"line_number":64,"context_line":"    ANSIBLE_PYTHON_INTERP\u003d${VENV}/bin/python3"},{"line_number":65,"context_line":"    export ANSIBLE_COLLECTIONS_PATHS\u003d$BIFROST_HOME/collections"},{"line_number":66,"context_line":"else"},{"line_number":67,"context_line":"    ANSIBLE\u003d${HOME}/.local/bin/ansible-playbook"},{"line_number":68,"context_line":"    ANSIBLE_PYTHON_INTERP\u003d$(which python3)"}],"source_content_type":"text/x-sh","patch_set":4,"id":"ff570b3c_cac48162","line":65,"updated":"2020-06-10 08:44:23.000000000","message":"can we move this outside the if-else block since it\u0027s the same as L69 ?","commit_id":"dd89bd1da1033a125496b8c000c369a49893d398"}]}