)]}'
{"playbooks/roles/bifrost-prep-for-install/defaults/main.yml":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"043b9c507e95c0dd3809cab3fe2babee3b631a7a","unresolved":false,"context_lines":[{"line_number":49,"context_line":"sushy_source_install: false"},{"line_number":50,"context_line":"staging_drivers_source_install: true"},{"line_number":51,"context_line":"enable_keystone: false"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"update_repos: true"},{"line_number":54,"context_line":"force_update_repos: true"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bf51134e_009c3cbe","line":52,"updated":"2020-07-09 13:24:49.000000000","message":"I guess I\u0027m confused by some source installs and some not... :\\","commit_id":"9b1d1d591e8b8fc5eaa4d34ca70667f268adf12c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0e91146a9775ff17c11e8205779b0683016d76a2","unresolved":false,"context_lines":[{"line_number":49,"context_line":"sushy_source_install: false"},{"line_number":50,"context_line":"staging_drivers_source_install: true"},{"line_number":51,"context_line":"enable_keystone: false"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"update_repos: true"},{"line_number":54,"context_line":"force_update_repos: true"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bf51134e_c051a4db","line":52,"in_reply_to":"bf51134e_009c3cbe","updated":"2020-07-09 13:32:35.000000000","message":"It actually matches what we usually do: services from source, libraries from pypi.","commit_id":"9b1d1d591e8b8fc5eaa4d34ca70667f268adf12c"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"852ff0806b60b7f36adbcce9619a654fbddece56","unresolved":false,"context_lines":[{"line_number":49,"context_line":"sushy_source_install: false"},{"line_number":50,"context_line":"staging_drivers_source_install: true"},{"line_number":51,"context_line":"enable_keystone: false"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"update_repos: true"},{"line_number":54,"context_line":"force_update_repos: true"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bf51134e_37fa20bc","line":52,"in_reply_to":"bf51134e_c051a4db","updated":"2020-07-14 22:19:38.000000000","message":"Makes sense, I realize that the original default was a little weird, as I was trying to do libraries as a bit of a mix given some new library code was getting developed in bifrost directly.","commit_id":"9b1d1d591e8b8fc5eaa4d34ca70667f268adf12c"}],"playbooks/roles/bifrost-prep-for-install/tasks/main.yml":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"e76f1d0413a59f2f2a66fb9f196ef7458b9465ec","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    update: \"{{ update_repos | bool }}\""},{"line_number":31,"context_line":"    clone: yes"},{"line_number":32,"context_line":"  loop: \"{{ bifrost_install_sources }}\""},{"line_number":33,"context_line":"  when: ci_testing_zuul | bool \u003d\u003d false and copy_from_local_path | bool \u003d\u003d false and item.source_install | default(true) | bool"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"- name: \"Copy from local path\""},{"line_number":36,"context_line":"  command: cp -a {{ item.git_url }} {{ item.git_folder }} creates\u003d{{ item.git_folder }}"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bf51134e_18caa89f","line":33,"range":{"start_line":33,"start_character":8,"end_line":33,"end_character":127},"updated":"2020-07-15 09:21:20.000000000","message":"we should probably wrap the conditions in parentheses or even better, convert to list, like:\nwhen:\n- condition A\n- condition B","commit_id":"9b1d1d591e8b8fc5eaa4d34ca70667f268adf12c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"45a9c78f5becb57c4cf313822c01d37dc78c7054","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    update: \"{{ update_repos | bool }}\""},{"line_number":31,"context_line":"    clone: yes"},{"line_number":32,"context_line":"  loop: \"{{ bifrost_install_sources }}\""},{"line_number":33,"context_line":"  when: ci_testing_zuul | bool \u003d\u003d false and copy_from_local_path | bool \u003d\u003d false and item.source_install | default(true) | bool"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"- name: \"Copy from local path\""},{"line_number":36,"context_line":"  command: cp -a {{ item.git_url }} {{ item.git_folder }} creates\u003d{{ item.git_folder }}"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bf51134e_6cf4c75b","line":33,"range":{"start_line":33,"start_character":8,"end_line":33,"end_character":127},"in_reply_to":"bf51134e_18caa89f","updated":"2020-07-15 12:30:39.000000000","message":"And conditions do not require parentheses. I agree re \u0027when\u0027, but may I fix this nit in a follow-up rather than respinning the whole chain?","commit_id":"9b1d1d591e8b8fc5eaa4d34ca70667f268adf12c"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"358e45ccae88dd934edad7a97a66639fa01322bb","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    update: \"{{ update_repos | bool }}\""},{"line_number":31,"context_line":"    clone: yes"},{"line_number":32,"context_line":"  loop: \"{{ bifrost_install_sources }}\""},{"line_number":33,"context_line":"  when: ci_testing_zuul | bool \u003d\u003d false and copy_from_local_path | bool \u003d\u003d false and item.source_install | default(true) | bool"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"- name: \"Copy from local path\""},{"line_number":36,"context_line":"  command: cp -a {{ item.git_url }} {{ item.git_folder }} creates\u003d{{ item.git_folder }}"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bf51134e_ef3729e2","line":33,"range":{"start_line":33,"start_character":8,"end_line":33,"end_character":127},"in_reply_to":"bf51134e_6cf4c75b","updated":"2020-07-15 12:42:43.000000000","message":"sounds good","commit_id":"9b1d1d591e8b8fc5eaa4d34ca70667f268adf12c"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"e76f1d0413a59f2f2a66fb9f196ef7458b9465ec","unresolved":false,"context_lines":[{"line_number":35,"context_line":"- name: \"Copy from local path\""},{"line_number":36,"context_line":"  command: cp -a {{ item.git_url }} {{ item.git_folder }} creates\u003d{{ item.git_folder }}"},{"line_number":37,"context_line":"  loop: \"{{ bifrost_install_sources }}\""},{"line_number":38,"context_line":"  when: (ci_testing_zuul | bool \u003d\u003d true or copy_from_local_path | bool \u003d\u003d true) and item.source_install | default(true) | bool"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bf51134e_f8cc14bc","line":38,"range":{"start_line":38,"start_character":0,"end_line":38,"end_character":126},"updated":"2020-07-15 09:21:20.000000000","message":"ditto","commit_id":"9b1d1d591e8b8fc5eaa4d34ca70667f268adf12c"}]}