)]}'
{"playbooks/roles/bifrost-deploy-nodes-dynamic/tasks/main.yml":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"3b64e00d1a1f516bdd98667b492af679ba8a1ec9","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  set_fact:"},{"line_number":26,"context_line":"    auth_type: None"},{"line_number":27,"context_line":"    auth: {}"},{"line_number":28,"context_line":"  when: noauth_mode | bool"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"- name: \"Execute os_client_config to collect facts\""},{"line_number":31,"context_line":"  os_client_config:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bf51134e_405c2218","line":28,"range":{"start_line":28,"start_character":8,"end_line":28,"end_character":26},"updated":"2020-07-15 14:48:30.000000000","message":"this should not need bool conversion as noauth_mode is true or false","commit_id":"68c60bfb42c3fba3fea1a5aac06bd4510ae54ed1"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8b64bd1270b5915866721542eb11b2514ff5fe1a","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  set_fact:"},{"line_number":26,"context_line":"    auth_type: None"},{"line_number":27,"context_line":"    auth: {}"},{"line_number":28,"context_line":"  when: noauth_mode | bool"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"- name: \"Execute os_client_config to collect facts\""},{"line_number":31,"context_line":"  os_client_config:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bf51134e_e0b3b608","line":28,"range":{"start_line":28,"start_character":8,"end_line":28,"end_character":26},"in_reply_to":"bf51134e_405c2218","updated":"2020-07-15 14:55:28.000000000","message":"We\u0027ve hit the issues with it before though. Here is an example: when I run ansible-playbook with `-e auth_mode\u003dtrue`, is true automatically converted to a boolean?","commit_id":"68c60bfb42c3fba3fea1a5aac06bd4510ae54ed1"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"bd2fa881e0667cc9cd092ab13d240cb6938df4de","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  set_fact:"},{"line_number":26,"context_line":"    auth_type: None"},{"line_number":27,"context_line":"    auth: {}"},{"line_number":28,"context_line":"  when: noauth_mode | bool"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"- name: \"Execute os_client_config to collect facts\""},{"line_number":31,"context_line":"  os_client_config:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bf51134e_aa25e6b0","line":28,"range":{"start_line":28,"start_character":8,"end_line":28,"end_character":26},"in_reply_to":"bf51134e_52bb3474","updated":"2020-07-19 14:28:56.000000000","message":"ok, I think for the sake of the sanity of the final users I\u0027m convinced we should keep the |bool filter\nchange to json is utopia at the moment :)","commit_id":"68c60bfb42c3fba3fea1a5aac06bd4510ae54ed1"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d61c0588e3a3ad9516881eb95dbd50456c9a4e60","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  set_fact:"},{"line_number":26,"context_line":"    auth_type: None"},{"line_number":27,"context_line":"    auth: {}"},{"line_number":28,"context_line":"  when: noauth_mode | bool"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"- name: \"Execute os_client_config to collect facts\""},{"line_number":31,"context_line":"  os_client_config:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bf51134e_52bb3474","line":28,"range":{"start_line":28,"start_character":8,"end_line":28,"end_character":26},"in_reply_to":"bf51134e_87a8f08c","updated":"2020-07-17 09:50:09.000000000","message":"Correct. And we use the former syntax in a few places (and can safely expect users to try the same).","commit_id":"68c60bfb42c3fba3fea1a5aac06bd4510ae54ed1"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"d81bb6953397a5a0feede8fe1001694f6ed65caa","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  set_fact:"},{"line_number":26,"context_line":"    auth_type: None"},{"line_number":27,"context_line":"    auth: {}"},{"line_number":28,"context_line":"  when: noauth_mode | bool"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"- name: \"Execute os_client_config to collect facts\""},{"line_number":31,"context_line":"  os_client_config:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bf51134e_87a8f08c","line":28,"range":{"start_line":28,"start_character":8,"end_line":28,"end_character":26},"in_reply_to":"bf51134e_e0b3b608","updated":"2020-07-17 08:12:52.000000000","message":"that\u0027s because of an \"interesting\" ansible behavior:\n- if you pass extra-vars using the key\u003dvalue syntax, they\u0027re interpreted as strings, e.g. --extra-vars \"version\u003d1.2.3 foo\u003dfalse\" -\u003e 1.2.3 and false are strings\n- if you want to pass a pure boolean (or some other non-string format, like integer, float, lists, etc.), you need to use the json syntax, e.g. --extra-vars \"{\u0027foo\u0027: true, \u0027bar\u0027: 1}\" -\u003e true is boolean, 1 is integer","commit_id":"68c60bfb42c3fba3fea1a5aac06bd4510ae54ed1"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"3b64e00d1a1f516bdd98667b492af679ba8a1ec9","unresolved":false,"context_lines":[{"line_number":30,"context_line":"- name: \"Execute os_client_config to collect facts\""},{"line_number":31,"context_line":"  os_client_config:"},{"line_number":32,"context_line":"  no_log: yes"},{"line_number":33,"context_line":"  when: not (noauth_mode | bool)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# NOTE(TheJulia): The first record returned by os_client_config"},{"line_number":36,"context_line":"# is utilized as the default. A user can still define the parameters"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bf51134e_e0a296fb","line":33,"range":{"start_line":33,"start_character":8,"end_line":33,"end_character":32},"updated":"2020-07-15 14:48:30.000000000","message":"ditto, just \u0027not noauth_mode\u0027","commit_id":"68c60bfb42c3fba3fea1a5aac06bd4510ae54ed1"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"3b64e00d1a1f516bdd98667b492af679ba8a1ec9","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    owner: root"},{"line_number":50,"context_line":"    group: root"},{"line_number":51,"context_line":"    mode: 0644"},{"line_number":52,"context_line":"  when: inventory_dhcp | bool"},{"line_number":53,"context_line":"  become: yes"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"- name: \"Setup DNS address for nodes.\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bf51134e_00ab4ad5","line":52,"range":{"start_line":52,"start_character":9,"end_line":52,"end_character":26},"updated":"2020-07-15 14:48:30.000000000","message":"ditto\nif a variable is set as false or true, doesn\u0027t need bool conversion","commit_id":"68c60bfb42c3fba3fea1a5aac06bd4510ae54ed1"}],"playbooks/roles/bifrost-ironic-install/tasks/download_ipa_image.yml":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"3b64e00d1a1f516bdd98667b492af679ba8a1ec9","unresolved":false,"context_lines":[{"line_number":105,"context_line":"         (ipa_ramdisk_download_done is failed and ipa_ramdisk_download_done.status_code is defined and ipa_ramdisk_download_done.status_code \u003d\u003d 404)"},{"line_number":106,"context_line":"  retries: 5"},{"line_number":107,"context_line":"  delay: 10"},{"line_number":108,"context_line":"  when: update_ipa | bool or not test_ipa_image_present.stat.exists"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bf51134e_20c76e98","line":108,"range":{"start_line":108,"start_character":8,"end_line":108,"end_character":67},"updated":"2020-07-15 14:48:30.000000000","message":"parentheses are not needed, but if we want to split the conditions in multiple lines and we have a or, they can help for readability","commit_id":"68c60bfb42c3fba3fea1a5aac06bd4510ae54ed1"}]}