)]}'
{"doc/source/install/index.rst":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"7d04f3a06ad957881862f217964d30cd5f8f1a5c","unresolved":false,"context_lines":[{"line_number":377,"context_line":""},{"line_number":378,"context_line":"Playbook based install provides a greater degree of visibility and control"},{"line_number":379,"context_line":"over the process and is suitable for advanced installation scenarios."},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"For virtual environment based installations it is recommended to provide full"},{"line_number":382,"context_line":"path to the ``ansible-playbook`` command, e.g."},{"line_number":383,"context_line":"``/opt/stack/bifrost/bin/ansible-playbook``."},{"line_number":384,"context_line":"Calling ``ansible-playbook`` without specifying the full path may result in"},{"line_number":385,"context_line":"version mismatch between system-wide and virtual environment specific"},{"line_number":386,"context_line":"installations of ansible. In cases where ansible is only installed in bifrost"},{"line_number":387,"context_line":"virtual environment, ``ansbile-playbook`` may not be in ``$PATH`` and the"},{"line_number":388,"context_line":"command will fail. For the playbooks to work, the command needs to be run from"},{"line_number":389,"context_line":"``playbooks`` subdirectory of cloned bifrost repository."},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"Examples:"},{"line_number":392,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"bf51134e_82df3b39","line":389,"range":{"start_line":380,"start_character":0,"end_line":389,"end_character":56},"updated":"2020-07-17 12:13:22.000000000","message":"To be honest, I don\u0027t entirely agree with this.\nWe explicitly say on L343 that we need to activate the virtualenv before running any playbook, that means that the ansible-playbook binary path in the virtualenv take over on the system ansible-playbook binary path.\nTo verify this, just install ansible system-wide, check the path of ansible-playbook, then create a virtualenv, activate it, install ansible with pip, and check the ansible-playbook binary path again.\nAnother proof is given by the change of the PATH environment variable, when activating the virtualenv the value is modified to include the virtualenv /bin directory as primary binary path.\nThings that we could specify instead are to double-check that the virtualenv is active, that the path of ansible-playbook is the correct one in the virtualenv, and that PATH includes the bin dir inside the virtualenv.\nRunning the binary with full path should not be necessary, unless we do it without activating the virtualenv itself.","commit_id":"2f63556c21fa6bcd291be40c71da01ee38af6a6f"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"a613456ae338055c380e93107fe9e3b96a00ecaa","unresolved":false,"context_lines":[{"line_number":377,"context_line":""},{"line_number":378,"context_line":"Playbook based install provides a greater degree of visibility and control"},{"line_number":379,"context_line":"over the process and is suitable for advanced installation scenarios."},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"For virtual environment based installations it is recommended to provide full"},{"line_number":382,"context_line":"path to the ``ansible-playbook`` command, e.g."},{"line_number":383,"context_line":"``/opt/stack/bifrost/bin/ansible-playbook``."},{"line_number":384,"context_line":"Calling ``ansible-playbook`` without specifying the full path may result in"},{"line_number":385,"context_line":"version mismatch between system-wide and virtual environment specific"},{"line_number":386,"context_line":"installations of ansible. In cases where ansible is only installed in bifrost"},{"line_number":387,"context_line":"virtual environment, ``ansbile-playbook`` may not be in ``$PATH`` and the"},{"line_number":388,"context_line":"command will fail. For the playbooks to work, the command needs to be run from"},{"line_number":389,"context_line":"``playbooks`` subdirectory of cloned bifrost repository."},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"Examples:"},{"line_number":392,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"bf51134e_5e07b3ca","line":389,"range":{"start_line":380,"start_character":0,"end_line":389,"end_character":56},"in_reply_to":"bf51134e_82df3b39","updated":"2020-07-21 10:46:22.000000000","message":"Thank you for your feedback Riccardo. It looks like something wasn\u0027t right with my testing. I like your suggestions, I will apply these.","commit_id":"2f63556c21fa6bcd291be40c71da01ee38af6a6f"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"7d04f3a06ad957881862f217964d30cd5f8f1a5c","unresolved":false,"context_lines":[{"line_number":411,"context_line":"``-e cleaning\u003dtrue`` to the command line or executing the command below::"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"  /opt/stack/bifrost/bin/ansible-playbook -K -vvvv -i inventory/target"},{"line_number":414,"context_line":"  install.yaml -e cleaning\u003dtrue"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"After you have performed an installation, you can edit"},{"line_number":417,"context_line":"``/etc/ironic/ironic.conf`` to enable or disable cleaning as desired."}],"source_content_type":"text/x-rst","patch_set":4,"id":"bf51134e_42eb6311","line":414,"updated":"2020-07-17 12:13:22.000000000","message":"you can keep this on the same line","commit_id":"2f63556c21fa6bcd291be40c71da01ee38af6a6f"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"7d04f3a06ad957881862f217964d30cd5f8f1a5c","unresolved":false,"context_lines":[{"line_number":429,"context_line":"``-e staging_drivers_include\u003dtrue`` when executing the install playbook::"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"  /opt/stack/bifrost/bin/ansible-playbook -K -vvvv -i inventory/target"},{"line_number":432,"context_line":"  install.yaml -e staging_drivers_include\u003dtrue"},{"line_number":433,"context_line":""},{"line_number":434,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":435,"context_line":"Advanced Topics"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bf51134e_a2f07fff","line":432,"updated":"2020-07-17 12:13:22.000000000","message":"ditto","commit_id":"2f63556c21fa6bcd291be40c71da01ee38af6a6f"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"a613456ae338055c380e93107fe9e3b96a00ecaa","unresolved":false,"context_lines":[{"line_number":429,"context_line":"``-e staging_drivers_include\u003dtrue`` when executing the install playbook::"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"  /opt/stack/bifrost/bin/ansible-playbook -K -vvvv -i inventory/target"},{"line_number":432,"context_line":"  install.yaml -e staging_drivers_include\u003dtrue"},{"line_number":433,"context_line":""},{"line_number":434,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":435,"context_line":"Advanced Topics"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bf51134e_fef5e7cd","line":432,"in_reply_to":"bf51134e_a2f07fff","updated":"2020-07-21 10:46:22.000000000","message":"Noted these two comments. Lines will likely get shorter after applying your first recommendation but if not I will move this back to single line.","commit_id":"2f63556c21fa6bcd291be40c71da01ee38af6a6f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"307e77da054db94ff345dfd7435587d6ab848009","unresolved":false,"context_lines":[{"line_number":378,"context_line":"Playbook based install provides a greater degree of visibility and control"},{"line_number":379,"context_line":"over the process and is suitable for advanced installation scenarios."},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"Examples:"},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"First, make sure that the virtual environment is active (the example below"},{"line_number":384,"context_line":"assumes that bifrost venv is installed into the default path"}],"source_content_type":"text/x-rst","patch_set":9,"id":"bf51134e_4e02fe3f","line":381,"updated":"2020-07-24 09:37:54.000000000","message":"nit: I\u0027d remove","commit_id":"e3f5984209b3d565f501dc37d0b4a274a1625a22"}]}