)]}'
{"playbooks/roles/bifrost-ironic-install/defaults/main.yml":[{"author":{"_account_id":31643,"name":"Noor Muhammad Malik","email":"noormuhammadmalik95@gmail.com","username":"noor_muhammad_dell"},"change_message_id":"67d9f648171e9d426f398bafcec0ba1bb6f83142","unresolved":false,"context_lines":[{"line_number":43,"context_line":"# set to true to skip performing online data migrations"},{"line_number":44,"context_line":"skip_migrations: \"{{ skip_bootstrap }}\""},{"line_number":45,"context_line":"# set to true to skip validating the services"},{"line_number":46,"context_line":"skip_validation: \"{{ skip_start }}\""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"# Default network interface that bifrost will be attached to."},{"line_number":49,"context_line":"# This is used in ipa_* so it must be before"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_c5574602","line":46,"range":{"start_line":46,"start_character":0,"end_line":46,"end_character":15},"updated":"2020-07-29 11:48:59.000000000","message":"do we need this as a general practice? So that in case of rerunning playbooks, one can simply skip this label? or only choose to execute this one?","commit_id":"46a20980f117d63a1d9e6c92f6bc5fabca43b6b0"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5391a0d53c3bec460d04266953c48f160302a48c","unresolved":false,"context_lines":[{"line_number":43,"context_line":"# set to true to skip performing online data migrations"},{"line_number":44,"context_line":"skip_migrations: \"{{ skip_bootstrap }}\""},{"line_number":45,"context_line":"# set to true to skip validating the services"},{"line_number":46,"context_line":"skip_validation: \"{{ skip_start }}\""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"# Default network interface that bifrost will be attached to."},{"line_number":49,"context_line":"# This is used in ipa_* so it must be before"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_a82b072e","line":46,"range":{"start_line":46,"start_character":0,"end_line":46,"end_character":15},"in_reply_to":"9f560f44_c5574602","updated":"2020-07-29 12:36:05.000000000","message":"I\u0027m not sure why we started doing this, but it seemed sensible to continue for now (and maybe switch to tags one day?)","commit_id":"46a20980f117d63a1d9e6c92f6bc5fabca43b6b0"}],"playbooks/roles/bifrost-ironic-install/tasks/main.yml":[{"author":{"_account_id":31643,"name":"Noor Muhammad Malik","email":"noormuhammadmalik95@gmail.com","username":"noor_muhammad_dell"},"change_message_id":"67d9f648171e9d426f398bafcec0ba1bb6f83142","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"- name: \"Validate deployment\""},{"line_number":76,"context_line":"  include: validate.yml"},{"line_number":77,"context_line":"  when: not skip_validation | bool"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_65791a92","line":77,"range":{"start_line":77,"start_character":8,"end_line":77,"end_character":34},"updated":"2020-07-29 11:48:59.000000000","message":"Looking at the previous conditionals, I\u0027m curious why do we not write \"skip_migrations | bool !\u003d True\" here?","commit_id":"46a20980f117d63a1d9e6c92f6bc5fabca43b6b0"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5391a0d53c3bec460d04266953c48f160302a48c","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"- name: \"Validate deployment\""},{"line_number":76,"context_line":"  include: validate.yml"},{"line_number":77,"context_line":"  when: not skip_validation | bool"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_e81cdf14","line":77,"range":{"start_line":77,"start_character":8,"end_line":77,"end_character":34},"in_reply_to":"9f560f44_65791a92","updated":"2020-07-29 12:36:05.000000000","message":"\"!\u003d True\" is redundant, but we have it everywhere. I intend to clean up it one day.","commit_id":"46a20980f117d63a1d9e6c92f6bc5fabca43b6b0"}],"playbooks/roles/bifrost-ironic-install/tasks/validate.yml":[{"author":{"_account_id":31643,"name":"Noor Muhammad Malik","email":"noormuhammadmalik95@gmail.com","username":"noor_muhammad_dell"},"change_message_id":"67d9f648171e9d426f398bafcec0ba1bb6f83142","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  when: noauth_mode | bool"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"- name: \"Validate API access and at least one conductor\""},{"line_number":36,"context_line":"  command: baremetal conductor list -f value -c Hostname"},{"line_number":37,"context_line":"  environment: \"{{ testing_env | combine(bifrost_venv_env if enable_venv else {}) }}\""},{"line_number":38,"context_line":"  register: conductor_list"},{"line_number":39,"context_line":"  failed_when: conductor_list.rc !\u003d 0 or conductor_list.stdout | trim \u003d\u003d \"\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_c5f3c609","line":36,"range":{"start_line":36,"start_character":11,"end_line":36,"end_character":30},"updated":"2020-07-29 11:48:59.000000000","message":"should this be \"openstack baremetal conductor\"? Or do we combine this with the \"openstack\" command elsewhere?","commit_id":"46a20980f117d63a1d9e6c92f6bc5fabca43b6b0"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5391a0d53c3bec460d04266953c48f160302a48c","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  when: noauth_mode | bool"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"- name: \"Validate API access and at least one conductor\""},{"line_number":36,"context_line":"  command: baremetal conductor list -f value -c Hostname"},{"line_number":37,"context_line":"  environment: \"{{ testing_env | combine(bifrost_venv_env if enable_venv else {}) }}\""},{"line_number":38,"context_line":"  register: conductor_list"},{"line_number":39,"context_line":"  failed_when: conductor_list.rc !\u003d 0 or conductor_list.stdout | trim \u003d\u003d \"\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_68d60f2a","line":36,"range":{"start_line":36,"start_character":11,"end_line":36,"end_character":30},"in_reply_to":"9f560f44_c5f3c609","updated":"2020-07-29 12:36:05.000000000","message":"python-ironicclient provides a standalone /usr/bin/baremetal command which is practically equivalent to `openstack baremetal` but does not require python-openstackclient.","commit_id":"46a20980f117d63a1d9e6c92f6bc5fabca43b6b0"},{"author":{"_account_id":31643,"name":"Noor Muhammad Malik","email":"noormuhammadmalik95@gmail.com","username":"noor_muhammad_dell"},"change_message_id":"67d9f648171e9d426f398bafcec0ba1bb6f83142","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  environment: \"{{ testing_env | combine(bifrost_venv_env if enable_venv else {}) }}\""},{"line_number":38,"context_line":"  register: conductor_list"},{"line_number":39,"context_line":"  failed_when: conductor_list.rc !\u003d 0 or conductor_list.stdout | trim \u003d\u003d \"\""},{"line_number":40,"context_line":"  retries: 6"},{"line_number":41,"context_line":"  delay: 5"},{"line_number":42,"context_line":"  until: conductor_list is not failed"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_05981ebe","line":40,"range":{"start_line":40,"start_character":2,"end_line":40,"end_character":12},"updated":"2020-07-29 11:48:59.000000000","message":"is this a general practice to have such a high retry count?","commit_id":"46a20980f117d63a1d9e6c92f6bc5fabca43b6b0"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5391a0d53c3bec460d04266953c48f160302a48c","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  environment: \"{{ testing_env | combine(bifrost_venv_env if enable_venv else {}) }}\""},{"line_number":38,"context_line":"  register: conductor_list"},{"line_number":39,"context_line":"  failed_when: conductor_list.rc !\u003d 0 or conductor_list.stdout | trim \u003d\u003d \"\""},{"line_number":40,"context_line":"  retries: 6"},{"line_number":41,"context_line":"  delay: 5"},{"line_number":42,"context_line":"  until: conductor_list is not failed"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_08e79314","line":40,"range":{"start_line":40,"start_character":2,"end_line":40,"end_character":12},"in_reply_to":"9f560f44_05981ebe","updated":"2020-07-29 12:36:05.000000000","message":"Well, here my expectation is that the conductor can take some time to start and initialize. 30 seconds is a bit of an overkill, but it may be running on a VM in the CI, so..","commit_id":"46a20980f117d63a1d9e6c92f6bc5fabca43b6b0"},{"author":{"_account_id":31643,"name":"Noor Muhammad Malik","email":"noormuhammadmalik95@gmail.com","username":"noor_muhammad_dell"},"change_message_id":"67d9f648171e9d426f398bafcec0ba1bb6f83142","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    - enable_inspector | bool"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"- name: \"Validate introspection API access\""},{"line_number":54,"context_line":"  command: baremetal introspection list"},{"line_number":55,"context_line":"  environment: \"{{ testing_env | combine(bifrost_venv_env if enable_venv else {}) }}\""},{"line_number":56,"context_line":"  register: introspection_list"},{"line_number":57,"context_line":"  retries: 6"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_05ddbe6f","line":54,"range":{"start_line":54,"start_character":11,"end_line":54,"end_character":34},"updated":"2020-07-29 11:48:59.000000000","message":"same question here","commit_id":"46a20980f117d63a1d9e6c92f6bc5fabca43b6b0"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5391a0d53c3bec460d04266953c48f160302a48c","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    - enable_inspector | bool"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"- name: \"Validate introspection API access\""},{"line_number":54,"context_line":"  command: baremetal introspection list"},{"line_number":55,"context_line":"  environment: \"{{ testing_env | combine(bifrost_venv_env if enable_venv else {}) }}\""},{"line_number":56,"context_line":"  register: introspection_list"},{"line_number":57,"context_line":"  retries: 6"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_48f18bcd","line":54,"range":{"start_line":54,"start_character":11,"end_line":54,"end_character":34},"in_reply_to":"9f560f44_05ddbe6f","updated":"2020-07-29 12:36:05.000000000","message":"same answer: https://docs.openstack.org/python-ironicclient/latest/cli/standalone.html","commit_id":"46a20980f117d63a1d9e6c92f6bc5fabca43b6b0"}]}