)]}'
{"id":"openstack%2Fbifrost~747437","triplet_id":"openstack%2Fbifrost~master~I204c539824319908098f67a49a8b15a24ba2cf6a","project":"openstack/bifrost","branch":"master","topic":"firewalld","hashtags":[],"change_id":"I204c539824319908098f67a49a8b15a24ba2cf6a","subject":"Explicitly enable DHCP services on baremetal CentOS/RHEL","status":"MERGED","created":"2020-08-21 16:04:26.000000000","updated":"2020-08-24 08:35:54.000000000","submitted":"2020-08-24 08:26:02.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"747437-1598257562643-187197d0","meta_rev_id":"6d3439fe68a48ce14400f97cdefebe93df9f0e7f","_number":747437,"virtual_id_number":747437,"owner":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-08-24 08:26:02.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2020-08-23 14:00:10.000000000","_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":0,"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"all":[{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":2,"date":"2020-08-24 07:50:31.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":2,"date":"2020-08-24 07:26:28.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"all":[{"value":0,"date":"2020-08-23 13:59:57.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":1,"date":"2020-08-24 07:50:31.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":0,"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-08-23 13:59:57.000000000","updated_by":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"reviewer":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"state":"REVIEWER"},{"updated":"2020-08-24 07:26:28.000000000","updated_by":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"reviewer":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"state":"REVIEWER"},{"updated":"2020-08-24 07:50:31.000000000","updated_by":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"reviewer":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"state":"REVIEWER"},{"updated":"2020-08-24 08:26:02.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"36a3c053f6896027f833b5c1af72511207afac16","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2020-08-21 16:04:26.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"394fb5605fed85eaeff052eae9aeaec42425c114","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2020-08-21 16:15:24.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"8e29f87c7d4b7be0b4f835d811b426ea19545999","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-21 17:07:29.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b3ce85c0a6554305b2a9e5d0087b805f : SUCCESS in 5m 24s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/1df8b5305d2345e89cb922fd86d45ba6 : SUCCESS in 6m 26s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/82b645e020944999aaf0adac1f586f9b : SUCCESS in 5m 48s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/459c1d7a4c5d441c8ba252a6d777f78e : SUCCESS in 5m 22s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/71a9e266e5dc4d9a9369c7ec0eb02201 : SUCCESS in 8m 08s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/143272eb42dc49c99081d12d8a02562f : SUCCESS in 5m 11s\n- bifrost-integration-tinyipa-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/ad64372c8d694c07bfc15f69855aa9c5 : SUCCESS in 24m 05s\n- bifrost-integration-tinyipa-centos-8 https://zuul.opendev.org/t/openstack/build/25f9e0ed344f4db0a35d54ff0bdfac3f : SUCCESS in 27m 05s\n- bifrost-integration-tinyipa-keystone-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/e5cde959269c40ddb2951bbc5221fa6f : SUCCESS in 26m 35s\n- bifrost-integration-tinyipa-keystone-centos-8 https://zuul.opendev.org/t/openstack/build/67e1710a95264020b92a6d432bab753c : SUCCESS in 29m 46s\n- bifrost-integration-tinyipa-ubuntu-focal https://zuul.opendev.org/t/openstack/build/3a38fbf18b884bc09a73e5c8bce7bc8f : SUCCESS in 23m 48s (non-voting)\n- bifrost-integration-tinyipa-opensuse-15 https://zuul.opendev.org/t/openstack/build/36e52ae932bb4c25b52a7d54bc2e0046 : SUCCESS in 22m 51s (non-voting)\n- bifrost-integration-tinyipa-fedora-latest https://zuul.opendev.org/t/openstack/build/b066836d2f404dc5a9877be985bfd69e : SUCCESS in 27m 18s (non-voting)\n- bifrost-integration-tinyipa-debian-buster https://zuul.opendev.org/t/openstack/build/4e78b575273248e2aa837ed8cb3f6b69 : SUCCESS in 20m 40s (non-voting)\n- bifrost-integration-dhcp-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/1e805911b6994841a1e6c93440a23eb9 : SUCCESS in 20m 30s (non-voting)\n- bifrost-integration-dhcp-centos-8 https://zuul.opendev.org/t/openstack/build/4df5c13f77634a80bc92c8c4624f0cbb : SUCCESS in 24m 04s (non-voting)\n- bifrost-integration-dibipa-debian-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/c319265d5b13442ea0875e31aa5cda5b : SUCCESS in 34m 04s (non-voting)\n- bifrost-integration-dibipa-debian-centos-8 https://zuul.opendev.org/t/openstack/build/62be3032700347c6a33982a363688f8d : SUCCESS in 43m 11s (non-voting)\n- bifrost-cli-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/d1b2ee96b7884e62b960db58cf869108 : SUCCESS in 28m 04s (non-voting)\n- bifrost-collections-src https://zuul.opendev.org/t/openstack/build/baee3316e0694eb1851215d8e029508b : SUCCESS in 23m 09s (non-voting)\n- bifrost-keystone-collections-src https://zuul.opendev.org/t/openstack/build/b171e41cfecc49bbb9097287be938c71 : SUCCESS in 23m 57s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"1a26db0f64f24ecff0de0da9fd61c5084923a9a8","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2020-08-23 14:00:10.000000000","message":"Patch Set 2:\n\nAnother candidate for bugfix/8.3","accounts_in_message":[],"_revision_number":2},{"id":"1e1a2676a6afbfe4eb8b9f9f9255fa1db032594f","author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"date":"2020-08-24 07:26:28.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"e371881e73fa4e35d30102617a9ce63680811fff","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2020-08-24 07:50:31.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"b94105e10858e2a802377e18581721c7514d6a4d","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-24 07:50:43.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"33e99a19eae6d62cedb0f3e226c462a9f6bffc8b","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-24 08:26:02.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/0a33526cb41a4d90a4b9ca59688f064e : SUCCESS in 4m 18s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/7d96f722bb4b4159b51a233accb404f4 : SUCCESS in 4m 19s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/632c06974ffc4a7692ca86a90a18698b : SUCCESS in 4m 05s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/5a6f45cb0c414110b258b2496a350784 : SUCCESS in 4m 32s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/91cad64386294f949131b04d192943db : SUCCESS in 6m 38s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/cf4ceb38a5364d1eacbbbacb6df8195a : SUCCESS in 4m 25s\n- bifrost-integration-tinyipa-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/ed6e2fa9b83f432aa3d9d48873352623 : SUCCESS in 24m 52s\n- bifrost-integration-tinyipa-centos-8 https://zuul.opendev.org/t/openstack/build/08918831b4934a43be8071a4d9c5e3fe : SUCCESS in 27m 01s\n- bifrost-integration-tinyipa-keystone-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/3625ac1f3fe24ab0ac2d3018e4f1bf7a : SUCCESS in 25m 00s\n- bifrost-integration-tinyipa-keystone-centos-8 https://zuul.opendev.org/t/openstack/build/ead9076bc53e459695ae6bb52bc02233 : SUCCESS in 30m 37s","accounts_in_message":[],"_revision_number":2},{"id":"6553b9870cc484a5759c3b82086d6d0d13699907","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-24 08:26:02.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"37cfe4af7e5e678bb688dd5f7d992b473ee2a680","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-24 08:27:40.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/58ad1dafebdf426eab0e1d928ad0de60 : SUCCESS in 58s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/08c529dc5e684ccbbe5fa30e93d62b25 : SUCCESS in 1m 06s","accounts_in_message":[],"_revision_number":2},{"id":"0ab8966bef684f9d0ddbbde6f8578f0d0486030f","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2020-08-24 08:35:54.000000000","message":"Patch Set 2: Cherry Picked\n\nThis patchset was cherry picked to branch bugfix/8.3 as commit fd76b62f045f6e8ea1557acfe9814e4e31d550e0","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"6e1bae9de43e95ea18bb7c93e6b35b22659a166c","revisions":{"ff622da8d155179e25883bc4ec303ac158bef736":{"kind":"REWORK","_number":1,"created":"2020-08-21 16:04:26.000000000","uploader":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"ref":"refs/changes/37/747437/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/bifrost","ref":"refs/changes/37/747437/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/bifrost refs/changes/37/747437/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/bifrost refs/changes/37/747437/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/bifrost refs/changes/37/747437/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/bifrost refs/changes/37/747437/1"}}},"commit":{"parents":[{"commit":"3a7ca4768018f6ad2a45a78a32b03c6094cf7a2a","subject":"Merge \"Validate that the services are running after installation\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/bifrost/commit/3a7ca4768018f6ad2a45a78a32b03c6094cf7a2a"}]}],"author":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2020-08-21 16:03:47.000000000","tz":120},"committer":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2020-08-21 16:04:08.000000000","tz":120},"subject":"[WIP] Explicitly enable DHCP services on baremetal CentOS/RHEL","message":"[WIP] Explicitly enable DHCP services on baremetal CentOS/RHEL\n\nChange-Id: I204c539824319908098f67a49a8b15a24ba2cf6a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/bifrost/commit/ff622da8d155179e25883bc4ec303ac158bef736"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/bifrost/commit/ff622da8d155179e25883bc4ec303ac158bef736"}]},"branch":"refs/heads/master"},"6e1bae9de43e95ea18bb7c93e6b35b22659a166c":{"kind":"REWORK","_number":2,"created":"2020-08-21 16:15:24.000000000","uploader":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"ref":"refs/changes/37/747437/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/bifrost","ref":"refs/changes/37/747437/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/bifrost refs/changes/37/747437/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/bifrost refs/changes/37/747437/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/bifrost refs/changes/37/747437/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/bifrost refs/changes/37/747437/2"}}},"commit":{"parents":[{"commit":"3a7ca4768018f6ad2a45a78a32b03c6094cf7a2a","subject":"Merge \"Validate that the services are running after installation\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/bifrost/commit/3a7ca4768018f6ad2a45a78a32b03c6094cf7a2a"}]}],"author":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2020-08-21 16:03:47.000000000","tz":120},"committer":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2020-08-21 16:13:57.000000000","tz":120},"subject":"Explicitly enable DHCP services on baremetal CentOS/RHEL","message":"Explicitly enable DHCP services on baremetal CentOS/RHEL\n\nApparently, we missed them when migrating to firewalld. The CI is not\naffected because these services are enabled in the libvirt zone, but\nchanging the testing code as well for consistency.\n\nAlso make sure the testing variable is treated as boolean.\n\nChange-Id: I204c539824319908098f67a49a8b15a24ba2cf6a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/bifrost/commit/6e1bae9de43e95ea18bb7c93e6b35b22659a166c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/bifrost/commit/6e1bae9de43e95ea18bb7c93e6b35b22659a166c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}