)]}'
{"id":"openstack%2Fbifrost~747644","triplet_id":"openstack%2Fbifrost~bugfix%2F8.3~I204c539824319908098f67a49a8b15a24ba2cf6a","project":"openstack/bifrost","branch":"bugfix/8.3","topic":"firewalld-bugfix/8.3","hashtags":[],"change_id":"I204c539824319908098f67a49a8b15a24ba2cf6a","subject":"Explicitly enable DHCP services on baremetal CentOS/RHEL","status":"MERGED","created":"2020-08-24 08:35:54.000000000","updated":"2020-08-24 10:02:01.000000000","submitted":"2020-08-24 09:59:56.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"747644-1598263197168-e6cdcfc5","meta_rev_id":"4eb5cb9d93e56739d2b208871430dbef3bdc5b6b","_number":747644,"virtual_id_number":747644,"owner":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-08-24 09:59:56.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2020-08-24 09:15:58.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2020-08-24 09:15:58.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-08-24 09:15:58.000000000","updated_by":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"reviewer":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"state":"REVIEWER"},{"updated":"2020-08-24 09:59:56.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"f9b510aa2ff8f61cbd97eb7a24db3defc135f9ad","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2020-08-24 08:35:54.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"9968554f377e445b6a3ffb7e4ce531d5476b7d9a","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2020-08-24 09:15:58.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"1239143346b6a86027ace4eb70696131d058483d","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-24 09:21:15.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/93649ef8b2274b748621e5101aca9d0e : SUCCESS in 3m 41s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/cc2acd0836774860ac11ae324ea8bf37 : SUCCESS in 4m 31s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/91d8c2dba50b446fbb0d5622953c9553 : SUCCESS in 4m 07s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/4607f24563704a7491f637c855fa3b13 : SUCCESS in 4m 19s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/0770337003fd4708a9d9117b014597fe : SUCCESS in 7m 37s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/0621f3c3a1ab4816bb32ccace2b7ae5e : SUCCESS in 5m 18s\n- bifrost-integration-tinyipa-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/50d0c7b9cf204eaaa25fe4e85f2c3453 : SUCCESS in 23m 31s\n- bifrost-integration-tinyipa-centos-8 https://zuul.opendev.org/t/openstack/build/4472dd03b6c74608a0a67fad71af2b8b : SUCCESS in 26m 54s\n- bifrost-integration-tinyipa-keystone-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/f221d9558c2b4c9488de9c8739c5086b : SUCCESS in 24m 38s\n- bifrost-integration-tinyipa-keystone-centos-8 https://zuul.opendev.org/t/openstack/build/0454c280e4284df292b7c073046e570b : SUCCESS in 28m 10s\n- bifrost-integration-tinyipa-ubuntu-focal https://zuul.opendev.org/t/openstack/build/22fb9404f56449f6b0bee69f37033cca : SUCCESS in 22m 16s (non-voting)\n- bifrost-integration-tinyipa-opensuse-15 https://zuul.opendev.org/t/openstack/build/23d78d46502b4bf6925ac13082d2ded1 : SUCCESS in 18m 03s (non-voting)\n- bifrost-integration-tinyipa-fedora-latest https://zuul.opendev.org/t/openstack/build/5652af1e3fa842ef9c3dd348c685d60c : SUCCESS in 23m 14s (non-voting)\n- bifrost-integration-tinyipa-debian-buster https://zuul.opendev.org/t/openstack/build/70d6a0cce80b4762ad5e74d608a7b4ae : SUCCESS in 21m 37s (non-voting)\n- bifrost-integration-dhcp-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/2d9fccd36a26439590c7c31c3308f382 : SUCCESS in 23m 22s (non-voting)\n- bifrost-integration-dhcp-centos-8 https://zuul.opendev.org/t/openstack/build/d0fd5ecc7bf9473ea380cba661b16ae0 : SUCCESS in 28m 31s (non-voting)\n- bifrost-integration-dibipa-debian-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/6a4610f9446b4d8a9160fcb65e872a5d : SUCCESS in 34m 38s (non-voting)\n- bifrost-integration-dibipa-debian-centos-8 https://zuul.opendev.org/t/openstack/build/f004d233c9564b95b5d3193d6569b63b : SUCCESS in 36m 32s (non-voting)\n- bifrost-cli-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/f4ed392d35fa4c968905fa688f39cab5 : SUCCESS in 22m 24s (non-voting)\n- bifrost-collections-src https://zuul.opendev.org/t/openstack/build/7134f66e07ea4fc58779aa7d3412b8f3 : SUCCESS in 19m 37s (non-voting)\n- bifrost-keystone-collections-src https://zuul.opendev.org/t/openstack/build/0507c04ce47941ec9852583079eb8f50 : SUCCESS in 24m 49s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"b188080deccd6776a773d489372c02bc5e6bf087","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-24 09:21:29.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"0b12f22312100047c7eba283357984d876e5ef7d","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-24 09:59:56.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ceb555bf94b249999f2d574a5e427fcc : SUCCESS in 3m 33s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/307d4c58a2614545ae82c0bcdb94f0a5 : SUCCESS in 4m 22s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/dcaa85bcabc34006924745f9ee44a594 : SUCCESS in 5m 35s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/ffcff092ac8d4f3eab12f56ce8d1a94a : SUCCESS in 4m 10s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b52a90ed3b304114a3156f6fac99b097 : SUCCESS in 6m 27s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/13ce28d6b96a44beb58cc6a012d364fc : SUCCESS in 4m 04s\n- bifrost-integration-tinyipa-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/214919677e404e4baf0798dbf45c7fdb : SUCCESS in 24m 01s\n- bifrost-integration-tinyipa-centos-8 https://zuul.opendev.org/t/openstack/build/ecee306fc8d4457bbea2089f9e6c7b99 : SUCCESS in 24m 53s\n- bifrost-integration-tinyipa-keystone-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/bd5801f687ff4dbf906c96ae059b514a : SUCCESS in 24m 18s\n- bifrost-integration-tinyipa-keystone-centos-8 https://zuul.opendev.org/t/openstack/build/fc48a041ae0741699e44b3fa4952c678 : SUCCESS in 32m 18s","accounts_in_message":[],"_revision_number":1},{"id":"a44e55bedb4fc1511d4fdd179c4780173d68e88c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-24 09:59:57.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"b89e913223cc82a74d9682f20d1892ba0c27df7b","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-24 10:02:01.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7d8293f5a767451f8cde6398f7f9dd72 : SUCCESS in 55s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/d7d84f468cb642d19ae1d165bdec5f3b : SUCCESS in 1m 37s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"fd76b62f045f6e8ea1557acfe9814e4e31d550e0","revisions":{"fd76b62f045f6e8ea1557acfe9814e4e31d550e0":{"kind":"REWORK","_number":1,"created":"2020-08-24 08:35:54.000000000","uploader":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"ref":"refs/changes/44/747644/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/bifrost","ref":"refs/changes/44/747644/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/bifrost refs/changes/44/747644/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/bifrost refs/changes/44/747644/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/bifrost refs/changes/44/747644/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/bifrost refs/changes/44/747644/1"}}},"commit":{"parents":[{"commit":"e1ee057d8e0074408960386c7d22044f531018dc","subject":"Make the iPXE and PXE boot files world-readable","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/bifrost/commit/e1ee057d8e0074408960386c7d22044f531018dc"}]}],"author":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2020-08-21 16:03:47.000000000","tz":120},"committer":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2020-08-24 08:35:54.000000000","tz":0},"subject":"Explicitly enable DHCP services on baremetal CentOS/RHEL","message":"Explicitly enable DHCP services on baremetal CentOS/RHEL\n\nApparently, we missed them when migrating to firewalld. The CI is not\naffected because these services are enabled in the libvirt zone, but\nchanging the testing code as well for consistency.\n\nAlso make sure the testing variable is treated as boolean.\n\nChange-Id: I204c539824319908098f67a49a8b15a24ba2cf6a\n(cherry picked from commit 6e1bae9de43e95ea18bb7c93e6b35b22659a166c)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/bifrost/commit/fd76b62f045f6e8ea1557acfe9814e4e31d550e0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/bifrost/commit/fd76b62f045f6e8ea1557acfe9814e4e31d550e0"}]},"branch":"refs/heads/bugfix/8.3"}},"requirements":[],"submit_records":[],"submit_requirements":[]}