)]}'
{"id":"openstack%2Fbifrost~747646","triplet_id":"openstack%2Fbifrost~stable%2Fussuri~I204c539824319908098f67a49a8b15a24ba2cf6a","project":"openstack/bifrost","branch":"stable/ussuri","topic":"firewalld-stable/ussuri","hashtags":[],"change_id":"I204c539824319908098f67a49a8b15a24ba2cf6a","subject":"Explicitly enable DHCP services on baremetal CentOS/RHEL","status":"MERGED","created":"2020-08-24 08:37:55.000000000","updated":"2020-08-24 10:04:10.000000000","submitted":"2020-08-24 09:59:58.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"747646-1598263198763-a24c6aaa","meta_rev_id":"7f5168794c6680f4a00d48ff30cc791fd30efb17","_number":747646,"virtual_id_number":747646,"owner":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-08-24 09:59:58.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"all":[{"value":2,"date":"2020-08-24 09:16:07.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"all":[{"value":1,"date":"2020-08-24 09:16:07.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-08-24 09:16:07.000000000","updated_by":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"reviewer":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"state":"REVIEWER"},{"updated":"2020-08-24 09:59:58.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"3b9a895640ea1f5288e334218e778a2bccafd899","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2020-08-24 08:37:55.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9bb4d4267070feacba6097d42cfd7640ae02ae32","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2020-08-24 09:16:07.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"1a09430d9e6664cb45ebc6303de7c12b95debd1b","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-24 09:21:51.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a7bbe29296aa46d4ad4b60a084e4e5d9 : SUCCESS in 6m 35s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/a1804e42d2f84492beaa67f15e966545 : SUCCESS in 7m 24s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/abee1358d50040648115b4b37e778967 : SUCCESS in 6m 16s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/ebc8916c63e0469398e4cd0da9d9c2bb : SUCCESS in 6m 01s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/636df62bc6744e0ebe08058089ba2c25 : SUCCESS in 9m 34s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/1326b607759948289a128b5b7b59708d : SUCCESS in 5m 22s\n- bifrost-integration-tinyipa-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/8eb83ca9ccaa49709397a8a4786cd6c6 : SUCCESS in 19m 06s\n- bifrost-integration-tinyipa-centos-8 https://zuul.opendev.org/t/openstack/build/f2ddc5b4eca845f2b5992269c8d10d01 : SUCCESS in 21m 26s\n- bifrost-integration-tinyipa-keystone-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/8ac626b581d24991b5fa8a3b1d4e2580 : SUCCESS in 22m 01s\n- bifrost-integration-tinyipa-keystone-centos-8 https://zuul.opendev.org/t/openstack/build/723d1a0022924a66b1f4311cc1d8c75b : SUCCESS in 24m 47s\n- bifrost-integration-tinyipa-ubuntu-focal https://zuul.opendev.org/t/openstack/build/93e271974588465e9fcdb86343829733 : SUCCESS in 17m 38s (non-voting)\n- bifrost-integration-tinyipa-opensuse-15 https://zuul.opendev.org/t/openstack/build/ee3003187b5d47619ef0daa06201bfe0 : SUCCESS in 24m 36s (non-voting)\n- bifrost-integration-tinyipa-fedora-latest https://zuul.opendev.org/t/openstack/build/02f35b552e5d47e18732adac9e69b1d8 : SUCCESS in 22m 44s (non-voting)\n- bifrost-integration-tinyipa-debian-buster https://zuul.opendev.org/t/openstack/build/3b9a183383ec4b8586b9e585b3164b46 : SUCCESS in 18m 02s (non-voting)\n- bifrost-integration-dhcp-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/a0e0ecd9dbc849e1b37604d0f8b863ed : FAILURE in 18m 36s (non-voting)\n- bifrost-integration-dibipa-debian-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/02b1912c59024abb90189dd4b583d836 : FAILURE in 28m 40s (non-voting)\n- bifrost-integration-dhcp-centos-8 https://zuul.opendev.org/t/openstack/build/6c777aab33ce455fb044a1489702c5c4 : FAILURE in 20m 15s (non-voting)\n- bifrost-integration-dibipa-debian-centos-8 https://zuul.opendev.org/t/openstack/build/e5fd536b90ae4cfc8abe683e827caf89 : FAILURE in 31m 53s (non-voting)\n- bifrost-integration-dhcp-opensuse-15 https://zuul.opendev.org/t/openstack/build/33e737f48873430c96954fbed717c7dc : FAILURE in 18m 02s (non-voting)\n- bifrost-integration-dibipa-debian-opensuse-15 https://zuul.opendev.org/t/openstack/build/dab8ca15dc454254991cb8d85dd8a410 : FAILURE in 16m 05s (non-voting)\n- bifrost-integration-dhcp-debian-buster https://zuul.opendev.org/t/openstack/build/88a20a36cb124835803afbd8dbea2cbf : FAILURE in 19m 51s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"0f19e365a89dc893082e7321b92f5cab4d6231e6","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-24 09:22:27.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"c7a16133258c8bec1497831fbdb4dcb79770fc6e","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-24 09:59:58.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a27db99be19b4b38a2035508bfc343b6 : SUCCESS in 5m 03s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/a179b39b47314aaaaf000520cbc35935 : SUCCESS in 5m 29s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/458856c9cf5943758f337b32485c4d1d : SUCCESS in 5m 06s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/e261e0da85834cd89561d4b6b3115925 : SUCCESS in 5m 11s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/47b8cb3d1e05453092ae523093c588b9 : SUCCESS in 6m 55s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/f471931a714f4937a707e932587cf7b6 : SUCCESS in 3m 36s\n- bifrost-integration-tinyipa-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/b0a75834e8a04f609c38402ef682f072 : SUCCESS in 19m 06s\n- bifrost-integration-tinyipa-centos-8 https://zuul.opendev.org/t/openstack/build/c336b03339164e9ba3fcd7a90ffe3474 : SUCCESS in 20m 28s\n- bifrost-integration-tinyipa-keystone-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/54fbb13158ef4ce89216622b957ef68b : SUCCESS in 20m 06s\n- bifrost-integration-tinyipa-keystone-centos-8 https://zuul.opendev.org/t/openstack/build/01ce4a0456264044a938aa089ec51449 : SUCCESS in 24m 14s","accounts_in_message":[],"_revision_number":1},{"id":"dd2d5af7a30e619c441abe1ebd4a75a55815a6f9","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-24 09:59:58.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"eff5665adefd621edf9c47cc2bab4497c79be995","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-24 10:04:10.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/24cf1ef9469045f289e96ae04d5e7c05 : SUCCESS in 57s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/95cecc27faeb446abd023424127732e3 : SUCCESS in 57s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"334809957e7db31dcc93ca2c4676f2f051717751","revisions":{"334809957e7db31dcc93ca2c4676f2f051717751":{"kind":"REWORK","_number":1,"created":"2020-08-24 08:37:55.000000000","uploader":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"ref":"refs/changes/46/747646/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/bifrost","ref":"refs/changes/46/747646/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/bifrost refs/changes/46/747646/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/bifrost refs/changes/46/747646/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/bifrost refs/changes/46/747646/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/bifrost refs/changes/46/747646/1"}}},"commit":{"parents":[{"commit":"55f7ad386282182954d00fcac86217619c5bf437","subject":"Use firewalld to open ports on CentOS and RHEL.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/bifrost/commit/55f7ad386282182954d00fcac86217619c5bf437"}]}],"author":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2020-08-21 16:03:47.000000000","tz":120},"committer":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2020-08-24 08:37:41.000000000","tz":120},"subject":"Explicitly enable DHCP services on baremetal CentOS/RHEL","message":"Explicitly enable DHCP services on baremetal CentOS/RHEL\n\nApparently, we missed them when migrating to firewalld. The CI is not\naffected because these services are enabled in the libvirt zone, but\nchanging the testing code as well for consistency.\n\nAlso make sure the testing variable is treated as boolean.\n\nChange-Id: I204c539824319908098f67a49a8b15a24ba2cf6a\n(cherry picked from commit 6e1bae9de43e95ea18bb7c93e6b35b22659a166c)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/bifrost/commit/334809957e7db31dcc93ca2c4676f2f051717751"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/bifrost/commit/334809957e7db31dcc93ca2c4676f2f051717751"}]},"branch":"refs/heads/stable/ussuri"}},"requirements":[],"submit_records":[],"submit_requirements":[]}