)]}'
{"playbooks/roles/bifrost-ironic-install/tasks/bootstrap.yml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6fde3f172d825435267c95e66aab1b0439077470","unresolved":false,"context_lines":[{"line_number":355,"context_line":"  get_url:"},{"line_number":356,"context_line":"    url: \"{{ cirros_deploy_image_upstream_url }}\""},{"line_number":357,"context_line":"    dest: \"{{ deploy_image }}\""},{"line_number":358,"context_line":"    mode: 0644"},{"line_number":359,"context_line":"  when: use_cirros | bool \u003d\u003d true"},{"line_number":360,"context_line":"- name: \"Create a checksum file for cirros\""},{"line_number":361,"context_line":"  shell: md5sum {{ deploy_image_filename }} \u003e {{ deploy_image_filename }}.CHECKSUMS"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9f560f44_d8e204a0","line":358,"updated":"2020-08-25 10:51:36.000000000","message":"let\u0027s also set owner/group to ironic:ironic (applies everywhere in this patch)","commit_id":"2af4dcfaa2fd417dc2c1869135f44f2e0549e56d"}],"playbooks/roles/bifrost-ironic-install/tasks/create_tftpboot.yml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6fde3f172d825435267c95e66aab1b0439077470","unresolved":false,"context_lines":[{"line_number":40,"context_line":"  when: download_ipxe | bool \u003d\u003d true"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"- name: \"Copy iPXE image into place\""},{"line_number":43,"context_line":"  copy: src\u003d{{ ipxe_dir }}/undionly.kpxe dest\u003d/tftpboot/ mode\u003d0644 remote_src\u003dtrue"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"# NOTE(TheJulia): Copy full iPXE chain loader images in case they are required."},{"line_number":46,"context_line":"- name: \"Copy full iPXE image into {{ http_boot_folder }}/\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9f560f44_78d778c0","line":43,"updated":"2020-08-25 10:51:36.000000000","message":"let\u0027s please convert to the modern calling standard\n\n copy:\n   src: ...","commit_id":"2af4dcfaa2fd417dc2c1869135f44f2e0549e56d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"41a452e1ad7121148ada67a0054949c265dfa5ba","unresolved":false,"context_lines":[{"line_number":40,"context_line":"  when: download_ipxe | bool \u003d\u003d true"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"- name: \"Copy iPXE image into place\""},{"line_number":43,"context_line":"  copy: "},{"line_number":44,"context_line":"    src: {{ ipxe_dir }}/undionly.kpxe "},{"line_number":45,"context_line":"    dest: /tftpboot/"},{"line_number":46,"context_line":"    owner: ironic"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9f560f44_db483e5d","line":43,"updated":"2020-08-25 11:15:56.000000000","message":"nit: trailing spaces here and there","commit_id":"bf10e3103bf3970df08c611fa607c3872d981703"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"41a452e1ad7121148ada67a0054949c265dfa5ba","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    mode: 0644"},{"line_number":68,"context_line":"    remote_src: true"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"- name: Make boot files owned by ironic and world-readable"},{"line_number":71,"context_line":"  file:"},{"line_number":72,"context_line":"    path: \"{{ item }}\""},{"line_number":73,"context_line":"    mode: 0644"},{"line_number":74,"context_line":"    owner: ironic"},{"line_number":75,"context_line":"    group: ironic"},{"line_number":76,"context_line":"  loop:"},{"line_number":77,"context_line":"    - /tftpboot/undionly.kpxe"},{"line_number":78,"context_line":"    - \"/tftpboot/{{ ipxe_full_binary }}\""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"- name: \"Set up iPXE for EFI booting\""},{"line_number":81,"context_line":"  block:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9f560f44_1b78f68d","line":78,"range":{"start_line":70,"start_character":0,"end_line":78,"end_character":40},"updated":"2020-08-25 11:15:56.000000000","message":"can now be removed","commit_id":"bf10e3103bf3970df08c611fa607c3872d981703"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"41a452e1ad7121148ada67a0054949c265dfa5ba","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        mode: 0644"},{"line_number":114,"context_line":"        remote_src: true"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    - name: Make UEFI boot files owned by ironic and world-readable"},{"line_number":117,"context_line":"      file:"},{"line_number":118,"context_line":"        path: \"{{ item }}\""},{"line_number":119,"context_line":"        mode: 0644"},{"line_number":120,"context_line":"        owner: ironic"},{"line_number":121,"context_line":"        group: ironic"},{"line_number":122,"context_line":"      loop:"},{"line_number":123,"context_line":"        - \"/tftpboot/{{ ipxe_efi_binary }}\""},{"line_number":124,"context_line":"        - \"{{ http_boot_folder }}/{{ ipxe_efi_binary }}\""},{"line_number":125,"context_line":"  when: enable_uefi_ipxe | bool \u003d\u003d true"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"# Similar logic to below can be utilized to retrieve files"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9f560f44_5b6eeec8","line":124,"range":{"start_line":116,"start_character":0,"end_line":124,"end_character":56},"updated":"2020-08-25 11:15:56.000000000","message":"same, can be removed","commit_id":"bf10e3103bf3970df08c611fa607c3872d981703"}],"releasenotes/notes/releasenote-341a5eebe6168aea.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6fde3f172d825435267c95e66aab1b0439077470","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added explicit setting of file access permissions to get_url calls in"},{"line_number":5,"context_line":"    bifrost ansible playbooks to ensure that the contents of /httpboot are"},{"line_number":6,"context_line":"    world-readable independently of which Ansible version is in use."},{"line_number":7,"context_line":"fixes:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9f560f44_f8cb881a","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":9},"updated":"2020-08-25 10:51:36.000000000","message":"We tend to use present tense for release notes.","commit_id":"2af4dcfaa2fd417dc2c1869135f44f2e0549e56d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6fde3f172d825435267c95e66aab1b0439077470","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added explicit setting of file access permissions to get_url calls in"},{"line_number":5,"context_line":"    bifrost ansible playbooks to ensure that the contents of /httpboot are"},{"line_number":6,"context_line":"    world-readable independently of which Ansible version is in use."},{"line_number":7,"context_line":"fixes:"},{"line_number":8,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9f560f44_98dc0ce5","line":5,"updated":"2020-08-25 10:51:36.000000000","message":"nit: ``/httpboot``","commit_id":"2af4dcfaa2fd417dc2c1869135f44f2e0549e56d"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"0247af3ecda2e4eb0a46398d2d36c7271dde79ab","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds the explicit setting of file access permissions to get_url calls in"},{"line_number":5,"context_line":"    bifrost ansible playbooks to ensure that the contents of \"/httpboot\" are"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9f560f44_6e0fb22d","line":2,"updated":"2020-08-25 12:17:22.000000000","message":"I don\u0027t see it as an upgrade, it can be mentioned directly in the \"fixes\" section","commit_id":"1f37c414130d58e64ba6d9d2fc9cc9f7e690453f"}]}