)]}'
{"id":"openstack%2Fbifrost~748272","triplet_id":"openstack%2Fbifrost~master~I539ffbfc5d4d004d27aaae0f83fef649f0e5be8c","project":"openstack/bifrost","branch":"master","topic":"dnsmasq","hashtags":[],"change_id":"I539ffbfc5d4d004d27aaae0f83fef649f0e5be8c","subject":"Disable DHCP on the libvirt network rather than doing `killall dnsmasq`","status":"MERGED","created":"2020-08-26 16:30:39.000000000","updated":"2020-08-31 11:20:10.000000000","submitted":"2020-08-31 11:18:30.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"748272-1598872710353-210ac784","meta_rev_id":"0a767b694c8a67e167b76c32758f0018e7c16701","_number":748272,"virtual_id_number":748272,"owner":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-08-31 11:18:30.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2020-08-27 07:48:43.000000000","_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":0,"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":2,"date":"2020-08-31 10:47:13.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},{"value":2,"date":"2020-08-28 12:39:24.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":1,"date":"2020-08-27 10:30:53.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":1,"date":"2020-08-31 10:47:13.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-08-27 10:30:53.000000000","updated_by":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"reviewer":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"state":"REVIEWER"},{"updated":"2020-08-28 12:39:24.000000000","updated_by":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"reviewer":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"state":"REVIEWER"},{"updated":"2020-08-31 10:47:13.000000000","updated_by":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"reviewer":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"state":"REVIEWER"},{"updated":"2020-08-31 11:18:30.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"4b024a9592aa415f4aeba9083b2d4a1d188f2f17","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2020-08-26 16:30:39.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0b0c22e2d24e673e3e4fc4f04b8b131e05062252","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-26 17:38:49.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/2c8c8f36c4994763869b935c19faf859 : SUCCESS in 4m 30s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/93685ea84b8d4ea392130dc1f4ebbf4e : SUCCESS in 5m 16s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/fefcc51338ac4ff6b3e347aef20a81da : SUCCESS in 5m 30s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/dd3241935e4c4199a49894848dd5cd23 : SUCCESS in 5m 10s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/109fb7fda6fc4e8b9773b236c754b83b : SUCCESS in 6m 53s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/47484480b694437c9efb0e5294ae7a8f : SUCCESS in 4m 49s\n- bifrost-tox-linters https://zuul.opendev.org/t/openstack/build/3d13cdd11e1b43b5b30d99c186883038 : SUCCESS in 6m 34s\n- bifrost-integration-tinyipa-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/905412d36476431a9d566b0fd0b8a35e : SUCCESS in 23m 38s\n- bifrost-integration-tinyipa-centos-8 https://zuul.opendev.org/t/openstack/build/3c7e54c0056d4a9f85d2b72cb2036813 : SUCCESS in 27m 07s\n- bifrost-integration-tinyipa-keystone-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/cfc02ed980a942c1ab47c0e6c3639a19 : SUCCESS in 25m 50s\n- bifrost-integration-tinyipa-keystone-centos-8 https://zuul.opendev.org/t/openstack/build/d6a778bc256443e49933f018c6f2d813 : SUCCESS in 31m 06s\n- bifrost-integration-tinyipa-ubuntu-focal https://zuul.opendev.org/t/openstack/build/6376e14e1f0849f0b292ec4caeb7a0f7 : SUCCESS in 25m 20s (non-voting)\n- bifrost-integration-tinyipa-opensuse-15 https://zuul.opendev.org/t/openstack/build/f35eccfd27ff43c4a3307dcc72b81e52 : SUCCESS in 27m 30s (non-voting)\n- bifrost-integration-tinyipa-fedora-latest https://zuul.opendev.org/t/openstack/build/4b78841024e64a0cb6abe802fe503be1 : SUCCESS in 28m 25s (non-voting)\n- bifrost-integration-tinyipa-debian-buster https://zuul.opendev.org/t/openstack/build/6416111ad5e64dbca15dd3d38efcc3f9 : SUCCESS in 26m 39s (non-voting)\n- bifrost-integration-dhcp-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/e378bfc9990b4f248d877acca07e126d : SUCCESS in 21m 37s (non-voting)\n- bifrost-integration-dhcp-centos-8 https://zuul.opendev.org/t/openstack/build/51a7a10c95544e129eb1ccdd0d530e6b : SUCCESS in 24m 10s (non-voting)\n- bifrost-integration-dibipa-debian-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/9d7b14dcd8a94e2b9219d374ea0b232a : SUCCESS in 35m 47s (non-voting)\n- bifrost-integration-dibipa-debian-centos-8 https://zuul.opendev.org/t/openstack/build/85ad38bb96da4142a2eceb90e02c5843 : SUCCESS in 38m 36s (non-voting)\n- bifrost-cli-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/5fc81be11baf418e9c89485c2f85cff1 : SUCCESS in 24m 24s (non-voting)\n- bifrost-collections-src https://zuul.opendev.org/t/openstack/build/75f115e9061e48e793894c153edbcff5 : SUCCESS in 22m 41s (non-voting)\n- bifrost-keystone-collections-src https://zuul.opendev.org/t/openstack/build/fea957664d0043839e9d7b6f3f616f6c : SUCCESS in 23m 09s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"6ccbc9efe7b447d4acb4038154f22eeaf258c86e","author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"date":"2020-08-27 01:14:49.000000000","message":"Patch Set 1:\n\nI had a look at (and tested) the change as this issue is relevant to my work, I hit issues with multiple dnsmasqs breaking PXE several times. Hence it\u0027s great to see this being improved. While testing I noticed that there is a libvirt dnsmasq running anyway - I suspected it\u0027s auto-started during libvirt installation: http://paste.openstack.org/show/797195/ (I removed all the libvirt and dnsmasq packages prior to bifrost installation and razed all the leftover /etc and /var directories). the VMs deployed cleanly in my test though. If this feedback is useful let\u0027s discuss further.","accounts_in_message":[],"_revision_number":1},{"id":"52add9c99c71f505b2091a9ec3dc8926a1b1e538","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2020-08-27 07:48:43.000000000","message":"Patch Set 1:\n\nThanks for testing Jacob! A running dnsmasq from libvirt is fine as long as it does not interfere with our DHCP.\n\nThe problem with \u0027killall dnsmasq\u0027 is that it does not survive reboot or even libvirt restart.","accounts_in_message":[],"_revision_number":1},{"id":"d4175415b2ca175fbf581a44abc90535d238a809","author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"date":"2020-08-27 10:30:53.000000000","message":"Patch Set 1: Code-Review+1\n\nThank you Dmitry. Great work fixing this, too!","accounts_in_message":[],"_revision_number":1},{"id":"6bd9049f4d104be078952a23135d347baa400eac","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2020-08-28 12:39:24.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"c6008676c9784ca1907208d362f9caeb0a77e2e8","author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"date":"2020-08-31 10:47:13.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"6605f73a762c8881e5a732262b02e105b8c39324","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-31 10:47:25.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"b4cf54a971c1383e3247e7feaeb7233ee64bcfdf","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-31 11:18:30.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c6273174713a40fd9acc7cdcccdca9cc : SUCCESS in 4m 14s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/0c0bfed5126341e397d0065c1bdac1d4 : SUCCESS in 4m 34s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/09a8420d085e45699e8e0b8ac855b4eb : SUCCESS in 3m 15s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/f8b324059f174468a541cce6b016150c : SUCCESS in 3m 02s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/162b00e8a8674dbaa0d08566834d2016 : SUCCESS in 4m 50s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/a51a05bb82e24705be1526034364d628 : SUCCESS in 3m 22s\n- bifrost-tox-linters https://zuul.opendev.org/t/openstack/build/a83db1775a7e4ce29e89d5e738554505 : SUCCESS in 4m 15s\n- bifrost-integration-tinyipa-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/9dc10ae79cd349b09f826d1f683bd4ca : SUCCESS in 22m 57s\n- bifrost-integration-tinyipa-centos-8 https://zuul.opendev.org/t/openstack/build/3920316e2a4f438fa1f8721e0cb95c07 : SUCCESS in 25m 15s\n- bifrost-integration-tinyipa-keystone-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/ed9e11ca9b7d477aab2074c8268d491a : SUCCESS in 22m 36s\n- bifrost-integration-tinyipa-keystone-centos-8 https://zuul.opendev.org/t/openstack/build/a865e481e0aa4b88bbdc9f50db6de4f7 : SUCCESS in 26m 12s","accounts_in_message":[],"_revision_number":1},{"id":"357a9004132495e9d1bde697b8efc56b08d1afab","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-31 11:18:30.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"949aa3587b042d3d28572358d4acb97265c07001","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-31 11:20:10.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/bde2cc93b9f0425db41c40cb9a61d7ad : SUCCESS in 57s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/5e11c3b531ba41bfb0bccc54b0e70fcc : SUCCESS in 1m 14s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"5befa87e9d847fc9387192caa7196a763f86dff1","revisions":{"5befa87e9d847fc9387192caa7196a763f86dff1":{"kind":"REWORK","_number":1,"created":"2020-08-26 16:30:39.000000000","uploader":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"ref":"refs/changes/72/748272/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/bifrost","ref":"refs/changes/72/748272/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/bifrost refs/changes/72/748272/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/bifrost refs/changes/72/748272/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/bifrost refs/changes/72/748272/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/bifrost refs/changes/72/748272/1"}}},"commit":{"parents":[{"commit":"1f37c414130d58e64ba6d9d2fc9cc9f7e690453f","subject":"Explicitly set permissions on /httpboot contents","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/bifrost/commit/1f37c414130d58e64ba6d9d2fc9cc9f7e690453f"}]}],"author":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2020-08-26 16:25:50.000000000","tz":120},"committer":{"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","date":"2020-08-26 16:29:56.000000000","tz":120},"subject":"Disable DHCP on the libvirt network rather than doing `killall dnsmasq`","message":"Disable DHCP on the libvirt network rather than doing `killall dnsmasq`\n\nWe\u0027re doing a weird thing: first we enable DHCP in libvirt, then we killall\ndnsmasq to stop it. Just don\u0027t enable it in the first plac\n\nChange-Id: I539ffbfc5d4d004d27aaae0f83fef649f0e5be8c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/bifrost/commit/5befa87e9d847fc9387192caa7196a763f86dff1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/bifrost/commit/5befa87e9d847fc9387192caa7196a763f86dff1"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}