)]}'
{"playbooks/example-deploy-all-available-nodes.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a4abd1a8aeeaaee223bb803fce93e53dae93e078","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  connection: local"},{"line_number":28,"context_line":"  roles:"},{"line_number":29,"context_line":"    - { role: bifrost-configdrives-dynamic,"},{"line_number":30,"context_line":"        when: (provision_state \u003d\u003d \"available\") and (maintenance | bool) }"},{"line_number":31,"context_line":"    - { role: bifrost-deploy-nodes-dynamic,"},{"line_number":32,"context_line":"        when: (provision_state \u003d\u003d \"available\") and (maintenance | bool) }"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_febe50fe","line":30,"updated":"2020-09-02 09:00:04.000000000","message":"nit: get rid of brackets","commit_id":"aba6617159819d131dff0cfaaded010315979973"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a4abd1a8aeeaaee223bb803fce93e53dae93e078","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  connection: local"},{"line_number":28,"context_line":"  roles:"},{"line_number":29,"context_line":"    - { role: bifrost-configdrives-dynamic,"},{"line_number":30,"context_line":"        when: (provision_state \u003d\u003d \"available\") and (maintenance | bool) }"},{"line_number":31,"context_line":"    - { role: bifrost-deploy-nodes-dynamic,"},{"line_number":32,"context_line":"        when: (provision_state \u003d\u003d \"available\") and (maintenance | bool) }"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_1ec4e491","line":30,"updated":"2020-09-02 09:00:04.000000000","message":"nit: no need for brackets around \u003d\u003d and | (yes, counter-intuitive)","commit_id":"aba6617159819d131dff0cfaaded010315979973"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"4aee2c96b00742be59c759297bf3bace62d73023","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  connection: local"},{"line_number":28,"context_line":"  roles:"},{"line_number":29,"context_line":"    - { role: bifrost-configdrives-dynamic,"},{"line_number":30,"context_line":"        when: (provision_state \u003d\u003d \"available\") and (maintenance | bool) }"},{"line_number":31,"context_line":"    - { role: bifrost-deploy-nodes-dynamic,"},{"line_number":32,"context_line":"        when: (provision_state \u003d\u003d \"available\") and (maintenance | bool) }"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_5ee3fca4","line":30,"in_reply_to":"9f560f44_1ec4e491","updated":"2020-09-02 09:34:55.000000000","message":"Done","commit_id":"aba6617159819d131dff0cfaaded010315979973"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"4aee2c96b00742be59c759297bf3bace62d73023","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  connection: local"},{"line_number":28,"context_line":"  roles:"},{"line_number":29,"context_line":"    - { role: bifrost-configdrives-dynamic,"},{"line_number":30,"context_line":"        when: (provision_state \u003d\u003d \"available\") and (maintenance | bool) }"},{"line_number":31,"context_line":"    - { role: bifrost-deploy-nodes-dynamic,"},{"line_number":32,"context_line":"        when: (provision_state \u003d\u003d \"available\") and (maintenance | bool) }"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_3ede08da","line":30,"in_reply_to":"9f560f44_febe50fe","updated":"2020-09-02 09:34:55.000000000","message":"Done","commit_id":"aba6617159819d131dff0cfaaded010315979973"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"88e2f040c7390ee7cac5d03aafb6aa34c5c45b6f","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  connection: local"},{"line_number":28,"context_line":"  roles:"},{"line_number":29,"context_line":"    - { role: bifrost-configdrives-dynamic,"},{"line_number":30,"context_line":"        when: provision_state \u003d\u003d \"available\" and maintenance | bool }"},{"line_number":31,"context_line":"    - { role: bifrost-deploy-nodes-dynamic,"},{"line_number":32,"context_line":"        when: provision_state \u003d\u003d \"available\" and maintenance | bool }"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9f560f44_b7c51b0d","line":30,"updated":"2020-09-02 12:46:10.000000000","message":"nit: remove brackets, use a list instead of and","commit_id":"e4d0325b2fb02a6ff94cc3157b06139f5f3c4a63"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"d519c1fdead128cf44254c1ad73707ff9ba470a4","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  connection: local"},{"line_number":28,"context_line":"  roles:"},{"line_number":29,"context_line":"    - { role: bifrost-configdrives-dynamic,"},{"line_number":30,"context_line":"        when: provision_state \u003d\u003d \"available\" and maintenance | bool }"},{"line_number":31,"context_line":"    - { role: bifrost-deploy-nodes-dynamic,"},{"line_number":32,"context_line":"        when: provision_state \u003d\u003d \"available\" and maintenance | bool }"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9f560f44_971bb77e","line":30,"in_reply_to":"9f560f44_b7c51b0d","updated":"2020-09-02 12:51:22.000000000","message":"weird, I tried using a list but it was confusing ansible for some reason, probably because of the brackets","commit_id":"e4d0325b2fb02a6ff94cc3157b06139f5f3c4a63"}],"playbooks/redeploy-dynamic.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"88e2f040c7390ee7cac5d03aafb6aa34c5c45b6f","unresolved":false,"context_lines":[{"line_number":39,"context_line":"      register: node_info"},{"line_number":40,"context_line":"  roles:"},{"line_number":41,"context_line":"    - { role: bifrost-unprovision-node-dynamic,"},{"line_number":42,"context_line":"        when: (provision_state \u003d\u003d \"active\""},{"line_number":43,"context_line":"          or provision_state \u003d\u003d \"deploy failed\""},{"line_number":44,"context_line":"          or provision_state \u003d\u003d \"error\")"},{"line_number":45,"context_line":"          and (not maintenance | bool) }"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9f560f44_97c8d721","line":42,"updated":"2020-09-02 12:46:10.000000000","message":"nit: redundant brackets","commit_id":"e4d0325b2fb02a6ff94cc3157b06139f5f3c4a63"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"88e2f040c7390ee7cac5d03aafb6aa34c5c45b6f","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    - { role: bifrost-configdrives-dynamic,"},{"line_number":64,"context_line":"        when: (provision_state \u003d\u003d \"available\") and (not maintenance | bool) }"},{"line_number":65,"context_line":"    - { role: bifrost-deploy-nodes-dynamic,"},{"line_number":66,"context_line":"        when: (provision_state \u003d\u003d \"available\") and (not maintenance | bool) }"},{"line_number":67,"context_line":"  post_tasks:"},{"line_number":68,"context_line":"    - name: \"Pull ironic facts until provision state active\""},{"line_number":69,"context_line":"      os_ironic_node_info:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9f560f44_f7cf9326","line":66,"updated":"2020-09-02 12:46:10.000000000","message":"ditto re brackets/when","commit_id":"e4d0325b2fb02a6ff94cc3157b06139f5f3c4a63"}],"playbooks/roles/bifrost-configdrives-dynamic/tasks/ssh_public_key_path.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"88e2f040c7390ee7cac5d03aafb6aa34c5c45b6f","unresolved":false,"context_lines":[{"line_number":22,"context_line":"- name: \"Defined ssh_public_key_path - Error if ssh_public_key_path is not valid\""},{"line_number":23,"context_line":"  fail:"},{"line_number":24,"context_line":"    msg: \"ssh_public_key_path is not valid.\""},{"line_number":25,"context_line":"  when: not test_ssh_public_key_path.stat.exists | bool"},{"line_number":26,"context_line":"  delegate_to: localhost"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- name: \"Defined ssh_public_key_path - Read SSH public key in\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9f560f44_d7d24fd1","line":25,"updated":"2020-09-02 12:46:10.000000000","message":"nit: no need for |bool","commit_id":"e4d0325b2fb02a6ff94cc3157b06139f5f3c4a63"}],"playbooks/roles/bifrost-create-bootable-image/tasks/main.yml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"88e2f040c7390ee7cac5d03aafb6aa34c5c45b6f","unresolved":false,"context_lines":[{"line_number":18,"context_line":"  register: test_image_present"},{"line_number":19,"context_line":"- name: \"Create bootable image\""},{"line_number":20,"context_line":"  include: create_bootable_image.yml"},{"line_number":21,"context_line":"  when: test_image_present.stat.exists | bool"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9f560f44_37d90bf4","line":21,"updated":"2020-09-02 12:46:10.000000000","message":"nit: no need for |bool","commit_id":"e4d0325b2fb02a6ff94cc3157b06139f5f3c4a63"}],"playbooks/roles/bifrost-create-dib-image/tasks/main.yml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a4abd1a8aeeaaee223bb803fce93e53dae93e078","unresolved":false,"context_lines":[{"line_number":191,"context_line":"    state: present"},{"line_number":192,"context_line":"  when:"},{"line_number":193,"context_line":"    - not test_image_present.stat.exists | bool"},{"line_number":194,"context_line":"    - test_image_dib_present.stat.exists | bool"},{"line_number":195,"context_line":"    - test_image_initramfs_present.stat.exists | bool"},{"line_number":196,"context_line":"    - (\"debian\" in dib_os_element or \"ubuntu\" in dib_os_element)"},{"line_number":197,"context_line":"- name: \"Initiate image build\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_5ebe5cff","line":194,"updated":"2020-09-02 09:00:04.000000000","message":"not","commit_id":"aba6617159819d131dff0cfaaded010315979973"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"4aee2c96b00742be59c759297bf3bace62d73023","unresolved":false,"context_lines":[{"line_number":191,"context_line":"    state: present"},{"line_number":192,"context_line":"  when:"},{"line_number":193,"context_line":"    - not test_image_present.stat.exists | bool"},{"line_number":194,"context_line":"    - test_image_dib_present.stat.exists | bool"},{"line_number":195,"context_line":"    - test_image_initramfs_present.stat.exists | bool"},{"line_number":196,"context_line":"    - (\"debian\" in dib_os_element or \"ubuntu\" in dib_os_element)"},{"line_number":197,"context_line":"- name: \"Initiate image build\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_5efc9c3d","line":194,"in_reply_to":"9f560f44_5ebe5cff","updated":"2020-09-02 09:34:55.000000000","message":"Done","commit_id":"aba6617159819d131dff0cfaaded010315979973"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a4abd1a8aeeaaee223bb803fce93e53dae93e078","unresolved":false,"context_lines":[{"line_number":192,"context_line":"  when:"},{"line_number":193,"context_line":"    - not test_image_present.stat.exists | bool"},{"line_number":194,"context_line":"    - test_image_dib_present.stat.exists | bool"},{"line_number":195,"context_line":"    - test_image_initramfs_present.stat.exists | bool"},{"line_number":196,"context_line":"    - (\"debian\" in dib_os_element or \"ubuntu\" in dib_os_element)"},{"line_number":197,"context_line":"- name: \"Initiate image build\""},{"line_number":198,"context_line":"  command: disk-image-create {{ dib_arglist }}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_3eb9e814","line":195,"updated":"2020-09-02 09:00:04.000000000","message":"not","commit_id":"aba6617159819d131dff0cfaaded010315979973"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"4aee2c96b00742be59c759297bf3bace62d73023","unresolved":false,"context_lines":[{"line_number":192,"context_line":"  when:"},{"line_number":193,"context_line":"    - not test_image_present.stat.exists | bool"},{"line_number":194,"context_line":"    - test_image_dib_present.stat.exists | bool"},{"line_number":195,"context_line":"    - test_image_initramfs_present.stat.exists | bool"},{"line_number":196,"context_line":"    - (\"debian\" in dib_os_element or \"ubuntu\" in dib_os_element)"},{"line_number":197,"context_line":"- name: \"Initiate image build\""},{"line_number":198,"context_line":"  command: disk-image-create {{ dib_arglist }}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_3ef7285c","line":195,"in_reply_to":"9f560f44_3eb9e814","updated":"2020-09-02 09:34:55.000000000","message":"Done","commit_id":"aba6617159819d131dff0cfaaded010315979973"}],"playbooks/roles/bifrost-create-vm-nodes/tasks/prepare_libvirt.yml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"88e2f040c7390ee7cac5d03aafb6aa34c5c45b6f","unresolved":false,"context_lines":[{"line_number":58,"context_line":"- name: \"Place sgabios.bin\""},{"line_number":59,"context_line":"  command: cp /usr/share/misc/sgabios.bin /usr/share/qemu/sgabios.bin"},{"line_number":60,"context_line":"  when:"},{"line_number":61,"context_line":"    - not test_sgabios_qemu | bool"},{"line_number":62,"context_line":"    - test_sgabios_misc | bool"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"# NOTE(TheJulia): In order to prevent conflicts, stop"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9f560f44_17d4c7ba","line":61,"updated":"2020-09-02 12:46:10.000000000","message":"Not your fault, but this is plainly wrong: has to use .exists (and no |bool)\n\nActually, I wonder how |bool behaves when applied to a result","commit_id":"e4d0325b2fb02a6ff94cc3157b06139f5f3c4a63"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"d519c1fdead128cf44254c1ad73707ff9ba470a4","unresolved":false,"context_lines":[{"line_number":58,"context_line":"- name: \"Place sgabios.bin\""},{"line_number":59,"context_line":"  command: cp /usr/share/misc/sgabios.bin /usr/share/qemu/sgabios.bin"},{"line_number":60,"context_line":"  when:"},{"line_number":61,"context_line":"    - not test_sgabios_qemu | bool"},{"line_number":62,"context_line":"    - test_sgabios_misc | bool"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"# NOTE(TheJulia): In order to prevent conflicts, stop"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9f560f44_974d779b","line":61,"in_reply_to":"9f560f44_17d4c7ba","updated":"2020-09-02 12:51:22.000000000","message":"I was actually not sure about this and I left it as it was","commit_id":"e4d0325b2fb02a6ff94cc3157b06139f5f3c4a63"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"88e2f040c7390ee7cac5d03aafb6aa34c5c45b6f","unresolved":false,"context_lines":[{"line_number":59,"context_line":"  command: cp /usr/share/misc/sgabios.bin /usr/share/qemu/sgabios.bin"},{"line_number":60,"context_line":"  when:"},{"line_number":61,"context_line":"    - not test_sgabios_qemu | bool"},{"line_number":62,"context_line":"    - test_sgabios_misc | bool"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"# NOTE(TheJulia): In order to prevent conflicts, stop"},{"line_number":65,"context_line":"# dnsmasq to prevent conflicts with libvirt restarting."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9f560f44_77e383a5","line":62,"updated":"2020-09-02 12:46:10.000000000","message":"same","commit_id":"e4d0325b2fb02a6ff94cc3157b06139f5f3c4a63"}],"playbooks/roles/bifrost-deploy-nodes-dynamic/tasks/main.yml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a4abd1a8aeeaaee223bb803fce93e53dae93e078","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    name: dnsmasq"},{"line_number":50,"context_line":"    state: restarted"},{"line_number":51,"context_line":"  become: yes"},{"line_number":52,"context_line":"  when: (inventory_dhcp | bool) or (inventory_dns | bool)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"- name: \"Deploy to hardware - Using custom instance_info.\""},{"line_number":55,"context_line":"  openstack.cloud.baremetal_node_action:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_9e3594ab","line":52,"updated":"2020-09-02 09:00:04.000000000","message":"nit: I\u0027d get rid of brackets","commit_id":"aba6617159819d131dff0cfaaded010315979973"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"4aee2c96b00742be59c759297bf3bace62d73023","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    name: dnsmasq"},{"line_number":50,"context_line":"    state: restarted"},{"line_number":51,"context_line":"  become: yes"},{"line_number":52,"context_line":"  when: (inventory_dhcp | bool) or (inventory_dns | bool)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"- name: \"Deploy to hardware - Using custom instance_info.\""},{"line_number":55,"context_line":"  openstack.cloud.baremetal_node_action:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_1e87c4b8","line":52,"in_reply_to":"9f560f44_9e3594ab","updated":"2020-09-02 09:34:55.000000000","message":"Done","commit_id":"aba6617159819d131dff0cfaaded010315979973"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a4abd1a8aeeaaee223bb803fce93e53dae93e078","unresolved":false,"context_lines":[{"line_number":77,"context_line":"- name: \"Error if deploy_image is not present, and instance_info is not defined\""},{"line_number":78,"context_line":"  fail: msg\u003d\"The user-defined deploy_image, which is the image to be written to the remote node(s) upon deployment, was not found. Cannot proceed.\""},{"line_number":79,"context_line":"  when:"},{"line_number":80,"context_line":"    - instance_info is not defined"},{"line_number":81,"context_line":"    - not test_deploy_image.stat.exists"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"- name: \"Deploy to hardware - bifrost default\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_7e38809e","line":80,"updated":"2020-09-02 09:00:04.000000000","message":"nit: is undefined","commit_id":"aba6617159819d131dff0cfaaded010315979973"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"4aee2c96b00742be59c759297bf3bace62d73023","unresolved":false,"context_lines":[{"line_number":77,"context_line":"- name: \"Error if deploy_image is not present, and instance_info is not defined\""},{"line_number":78,"context_line":"  fail: msg\u003d\"The user-defined deploy_image, which is the image to be written to the remote node(s) upon deployment, was not found. Cannot proceed.\""},{"line_number":79,"context_line":"  when:"},{"line_number":80,"context_line":"    - instance_info is not defined"},{"line_number":81,"context_line":"    - not test_deploy_image.stat.exists"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"- name: \"Deploy to hardware - bifrost default\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_5eaadc18","line":80,"in_reply_to":"9f560f44_7e38809e","updated":"2020-09-02 09:34:55.000000000","message":"according to ansible docs you could use both, I used \u0027not defined\u0027 as we\u0027re doing that in the rest of the module","commit_id":"aba6617159819d131dff0cfaaded010315979973"}],"playbooks/roles/bifrost-ironic-install/tasks/bootstrap.yml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a4abd1a8aeeaaee223bb803fce93e53dae93e078","unresolved":false,"context_lines":[{"line_number":20,"context_line":"      Please set one to \"false\"."},{"line_number":21,"context_line":"  when:"},{"line_number":22,"context_line":"    - noauth_mode | bool"},{"line_number":23,"context_line":"    - enable_keystone is defined"},{"line_number":24,"context_line":"    - enable_keystone | bool"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"- block:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_de3f0c85","line":23,"updated":"2020-09-02 09:00:04.000000000","message":"nit: always defined (in defaults)","commit_id":"aba6617159819d131dff0cfaaded010315979973"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"4aee2c96b00742be59c759297bf3bace62d73023","unresolved":false,"context_lines":[{"line_number":20,"context_line":"      Please set one to \"false\"."},{"line_number":21,"context_line":"  when:"},{"line_number":22,"context_line":"    - noauth_mode | bool"},{"line_number":23,"context_line":"    - enable_keystone is defined"},{"line_number":24,"context_line":"    - enable_keystone | bool"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"- block:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_7e640022","line":23,"in_reply_to":"9f560f44_de3f0c85","updated":"2020-09-02 09:34:55.000000000","message":"right, I\u0027ll remove it","commit_id":"aba6617159819d131dff0cfaaded010315979973"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a4abd1a8aeeaaee223bb803fce93e53dae93e078","unresolved":false,"context_lines":[{"line_number":163,"context_line":"- name: \"Populate keystone for Bifrost\""},{"line_number":164,"context_line":"  include: keystone_setup.yml"},{"line_number":165,"context_line":"  when:"},{"line_number":166,"context_line":"    - enable_keystone is defined"},{"line_number":167,"context_line":"    - enable_keystone | bool"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"# NOTE(pas-ha) needed to e.g. pick up new interfaces after libvirt install"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_be42180e","line":166,"updated":"2020-09-02 09:00:04.000000000","message":"ditto","commit_id":"aba6617159819d131dff0cfaaded010315979973"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"4aee2c96b00742be59c759297bf3bace62d73023","unresolved":false,"context_lines":[{"line_number":163,"context_line":"- name: \"Populate keystone for Bifrost\""},{"line_number":164,"context_line":"  include: keystone_setup.yml"},{"line_number":165,"context_line":"  when:"},{"line_number":166,"context_line":"    - enable_keystone is defined"},{"line_number":167,"context_line":"    - enable_keystone | bool"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"# NOTE(pas-ha) needed to e.g. pick up new interfaces after libvirt install"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_1e7504cd","line":166,"in_reply_to":"9f560f44_be42180e","updated":"2020-09-02 09:34:55.000000000","message":"yup","commit_id":"aba6617159819d131dff0cfaaded010315979973"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"88e2f040c7390ee7cac5d03aafb6aa34c5c45b6f","unresolved":false,"context_lines":[{"line_number":162,"context_line":"- name: \"Populate keystone for Bifrost\""},{"line_number":163,"context_line":"  include: keystone_setup.yml"},{"line_number":164,"context_line":"  when:"},{"line_number":165,"context_line":"    - enable_keystone | bool"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"# NOTE(pas-ha) needed to e.g. pick up new interfaces after libvirt install"},{"line_number":168,"context_line":"- name: \"Refresh facts\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9f560f44_57de3fda","line":165,"updated":"2020-09-02 12:46:10.000000000","message":"nit: no need for a list","commit_id":"e4d0325b2fb02a6ff94cc3157b06139f5f3c4a63"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"88e2f040c7390ee7cac5d03aafb6aa34c5c45b6f","unresolved":false,"context_lines":[{"line_number":189,"context_line":"  environment: \"{{ bifrost_venv_env }}\""},{"line_number":190,"context_line":"  when:"},{"line_number":191,"context_line":"    - ironic.database.host \u003d\u003d \u0027localhost\u0027"},{"line_number":192,"context_line":"    - test_created_db.changed | bool"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"- name: \"Upgrade ironic DB Schema\""},{"line_number":195,"context_line":"  command: ironic-dbsync --config-file /etc/ironic/ironic.conf upgrade"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9f560f44_b7eebb88","line":192,"updated":"2020-09-02 12:46:10.000000000","message":"nit: no need for |bool with changed","commit_id":"e4d0325b2fb02a6ff94cc3157b06139f5f3c4a63"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"88e2f040c7390ee7cac5d03aafb6aa34c5c45b6f","unresolved":false,"context_lines":[{"line_number":196,"context_line":"  environment: \"{{ bifrost_venv_env }}\""},{"line_number":197,"context_line":"  when: \u003e"},{"line_number":198,"context_line":"      ironic.database.host !\u003d \u0027localhost\u0027 or"},{"line_number":199,"context_line":"      not test_created_db.changed | bool"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"- name: \"Create service folder\""},{"line_number":202,"context_line":"  file:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9f560f44_97f1f76d","line":199,"updated":"2020-09-02 12:46:10.000000000","message":"ditto","commit_id":"e4d0325b2fb02a6ff94cc3157b06139f5f3c4a63"}],"playbooks/roles/bifrost-ironic-install/tasks/create_tftpboot.yml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a4abd1a8aeeaaee223bb803fce93e53dae93e078","unresolved":false,"context_lines":[{"line_number":88,"context_line":"          at the {{ ipxe_dir }} location.  Please place this file or consider"},{"line_number":89,"context_line":"          re-running with download_ipxe set to a value of true."},{"line_number":90,"context_line":"      when:"},{"line_number":91,"context_line":"        - not test_ipxe_efi_binary_path.stat.exists | bool"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    - name: \"Copy iPXE EFI image into {{ http_boot_folder }}/\""},{"line_number":94,"context_line":"      copy:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_1e498431","line":91,"updated":"2020-09-02 09:00:04.000000000","message":"nit: no need for |bool","commit_id":"aba6617159819d131dff0cfaaded010315979973"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"4aee2c96b00742be59c759297bf3bace62d73023","unresolved":false,"context_lines":[{"line_number":88,"context_line":"          at the {{ ipxe_dir }} location.  Please place this file or consider"},{"line_number":89,"context_line":"          re-running with download_ipxe set to a value of true."},{"line_number":90,"context_line":"      when:"},{"line_number":91,"context_line":"        - not test_ipxe_efi_binary_path.stat.exists | bool"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    - name: \"Copy iPXE EFI image into {{ http_boot_folder }}/\""},{"line_number":94,"context_line":"      copy:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_7e4d2098","line":91,"in_reply_to":"9f560f44_1e498431","updated":"2020-09-02 09:34:55.000000000","message":"Done","commit_id":"aba6617159819d131dff0cfaaded010315979973"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a4abd1a8aeeaaee223bb803fce93e53dae93e078","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"- name: \"Create master_images folder\""},{"line_number":119,"context_line":"  file: name\u003d\"{{ ironic_tftp_master_path }}\" state\u003ddirectory owner\u003dironic group\u003dironic"},{"line_number":120,"context_line":"  when: not test_master_images.stat.exists | bool"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"# TODO(TheJulia): The pxelinux folder is statically coded in ironic."},{"line_number":123,"context_line":"# For now, we need to use it, but we can patch that."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_fe43f00f","line":120,"updated":"2020-09-02 09:00:04.000000000","message":"nit: no need for |bool","commit_id":"aba6617159819d131dff0cfaaded010315979973"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"4aee2c96b00742be59c759297bf3bace62d73023","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"- name: \"Create master_images folder\""},{"line_number":119,"context_line":"  file: name\u003d\"{{ ironic_tftp_master_path }}\" state\u003ddirectory owner\u003dironic group\u003dironic"},{"line_number":120,"context_line":"  when: not test_master_images.stat.exists | bool"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"# TODO(TheJulia): The pxelinux folder is statically coded in ironic."},{"line_number":123,"context_line":"# For now, we need to use it, but we can patch that."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_be47b877","line":120,"in_reply_to":"9f560f44_fe43f00f","updated":"2020-09-02 09:34:55.000000000","message":"Done","commit_id":"aba6617159819d131dff0cfaaded010315979973"}],"playbooks/roles/bifrost-ironic-install/tasks/download_ipa_image.yml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a4abd1a8aeeaaee223bb803fce93e53dae93e078","unresolved":false,"context_lines":[{"line_number":141,"context_line":"  delay: 10"},{"line_number":142,"context_line":"  when:"},{"line_number":143,"context_line":"    - update_ipa | bool or"},{"line_number":144,"context_line":"      not test_ipa_image_present.stat.exists | bool"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_5e53fce2","line":144,"updated":"2020-09-02 09:00:04.000000000","message":"nit: no need for |bool, this is coming from ansible","commit_id":"aba6617159819d131dff0cfaaded010315979973"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"4aee2c96b00742be59c759297bf3bace62d73023","unresolved":false,"context_lines":[{"line_number":141,"context_line":"  delay: 10"},{"line_number":142,"context_line":"  when:"},{"line_number":143,"context_line":"    - update_ipa | bool or"},{"line_number":144,"context_line":"      not test_ipa_image_present.stat.exists | bool"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_1e5ea444","line":144,"in_reply_to":"9f560f44_5e53fce2","updated":"2020-09-02 09:34:55.000000000","message":"Done","commit_id":"aba6617159819d131dff0cfaaded010315979973"}],"playbooks/roles/bifrost-ironic-install/tasks/inspector_bootstrap.yml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a4abd1a8aeeaaee223bb803fce93e53dae93e078","unresolved":false,"context_lines":[{"line_number":95,"context_line":"- name: \"Populate keystone for ironic-inspector \""},{"line_number":96,"context_line":"  include: keystone_setup_inspector.yml"},{"line_number":97,"context_line":"  when:"},{"line_number":98,"context_line":"    - enable_keystone is defined"},{"line_number":99,"context_line":"    - enable_keystone | bool"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"- name: \"Inspector - Place Configuration\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_3e4e0838","line":98,"updated":"2020-09-02 09:00:04.000000000","message":"nit: always defined","commit_id":"aba6617159819d131dff0cfaaded010315979973"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"4aee2c96b00742be59c759297bf3bace62d73023","unresolved":false,"context_lines":[{"line_number":95,"context_line":"- name: \"Populate keystone for ironic-inspector \""},{"line_number":96,"context_line":"  include: keystone_setup_inspector.yml"},{"line_number":97,"context_line":"  when:"},{"line_number":98,"context_line":"    - enable_keystone is defined"},{"line_number":99,"context_line":"    - enable_keystone | bool"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"- name: \"Inspector - Place Configuration\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_5e581c55","line":98,"in_reply_to":"9f560f44_3e4e0838","updated":"2020-09-02 09:34:55.000000000","message":"Done","commit_id":"aba6617159819d131dff0cfaaded010315979973"}],"playbooks/roles/bifrost-ironic-install/tasks/set_ssh_private_key.yml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a4abd1a8aeeaaee223bb803fce93e53dae93e078","unresolved":false,"context_lines":[{"line_number":8,"context_line":"- name: \"Defined ssh_private_key_path - Error if ssh_private_key_path is not valid\""},{"line_number":9,"context_line":"  fail:"},{"line_number":10,"context_line":"    msg: \"ssh_private_key_path is not valid.\""},{"line_number":11,"context_line":"  when: not test_ssh_private_key_path.stat.exists | bool"},{"line_number":12,"context_line":"  delegate_to: localhost"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- name: \"Defined ssh_private_key_path - Read SSH private key in\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_9e5e34e7","line":11,"updated":"2020-09-02 09:00:04.000000000","message":"nit: no need for |bool, this is coming from ansible","commit_id":"aba6617159819d131dff0cfaaded010315979973"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"4aee2c96b00742be59c759297bf3bace62d73023","unresolved":false,"context_lines":[{"line_number":8,"context_line":"- name: \"Defined ssh_private_key_path - Error if ssh_private_key_path is not valid\""},{"line_number":9,"context_line":"  fail:"},{"line_number":10,"context_line":"    msg: \"ssh_private_key_path is not valid.\""},{"line_number":11,"context_line":"  when: not test_ssh_private_key_path.stat.exists | bool"},{"line_number":12,"context_line":"  delegate_to: localhost"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- name: \"Defined ssh_private_key_path - Read SSH private key in\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_9e2f54a6","line":11,"in_reply_to":"9f560f44_9e5e34e7","updated":"2020-09-02 09:34:55.000000000","message":"Done","commit_id":"aba6617159819d131dff0cfaaded010315979973"}],"playbooks/roles/bifrost-keystone-install/tasks/bootstrap.yml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a4abd1a8aeeaaee223bb803fce93e53dae93e078","unresolved":false,"context_lines":[{"line_number":141,"context_line":"    --bootstrap-region-id\u003d\"{{ keystone.bootstrap.region_name }}\""},{"line_number":142,"context_line":"  environment: \"{{ bifrost_venv_env }}\""},{"line_number":143,"context_line":"  when:"},{"line_number":144,"context_line":"    - test_created_keystone_db.changed | bool"},{"line_number":145,"context_line":"    - keystone.bootstrap.enabled | bool"},{"line_number":146,"context_line":"    - keystone.database.host \u003d\u003d \u0027localhost\u0027"},{"line_number":147,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_7e61a0a8","line":144,"updated":"2020-09-02 09:00:04.000000000","message":"ditto re |bool","commit_id":"aba6617159819d131dff0cfaaded010315979973"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"4aee2c96b00742be59c759297bf3bace62d73023","unresolved":false,"context_lines":[{"line_number":141,"context_line":"    --bootstrap-region-id\u003d\"{{ keystone.bootstrap.region_name }}\""},{"line_number":142,"context_line":"  environment: \"{{ bifrost_venv_env }}\""},{"line_number":143,"context_line":"  when:"},{"line_number":144,"context_line":"    - test_created_keystone_db.changed | bool"},{"line_number":145,"context_line":"    - keystone.bootstrap.enabled | bool"},{"line_number":146,"context_line":"    - keystone.database.host \u003d\u003d \u0027localhost\u0027"},{"line_number":147,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_be3cd8e1","line":144,"in_reply_to":"9f560f44_7e61a0a8","updated":"2020-09-02 09:34:55.000000000","message":"Done","commit_id":"aba6617159819d131dff0cfaaded010315979973"}],"playbooks/roles/bifrost-keystone-install/tasks/main.yml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a4abd1a8aeeaaee223bb803fce93e53dae93e078","unresolved":false,"context_lines":[{"line_number":36,"context_line":"- name: \"Install Keystone\""},{"line_number":37,"context_line":"  include: install.yml"},{"line_number":38,"context_line":"  when:"},{"line_number":39,"context_line":"    - enable_keystone is defined"},{"line_number":40,"context_line":"    - enable_keystone | bool"},{"line_number":41,"context_line":"    - not skip_package_install | bool"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_de58acfb","line":39,"updated":"2020-09-02 09:00:04.000000000","message":"nit: always defined (same below)","commit_id":"aba6617159819d131dff0cfaaded010315979973"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"4aee2c96b00742be59c759297bf3bace62d73023","unresolved":false,"context_lines":[{"line_number":36,"context_line":"- name: \"Install Keystone\""},{"line_number":37,"context_line":"  include: install.yml"},{"line_number":38,"context_line":"  when:"},{"line_number":39,"context_line":"    - enable_keystone is defined"},{"line_number":40,"context_line":"    - enable_keystone | bool"},{"line_number":41,"context_line":"    - not skip_package_install | bool"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_fe1db077","line":39,"in_reply_to":"9f560f44_de58acfb","updated":"2020-09-02 09:34:55.000000000","message":"Done","commit_id":"aba6617159819d131dff0cfaaded010315979973"}],"playbooks/roles/bifrost-prepare-for-test-dynamic/tasks/main.yml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a4abd1a8aeeaaee223bb803fce93e53dae93e078","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    state: started"},{"line_number":44,"context_line":"    port: 22"},{"line_number":45,"context_line":"    host: \"{{ ipv4_address }}\""},{"line_number":46,"context_line":"  when: ipv4_address is defined and multinode_testing | bool"},{"line_number":47,"context_line":"- name: \u003e"},{"line_number":48,"context_line":"    Additional SSH startup pause when performing multi-node testing"},{"line_number":49,"context_line":"  pause:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_be5b38f4","line":46,"updated":"2020-09-02 09:00:04.000000000","message":"nit: use a list instead of and","commit_id":"aba6617159819d131dff0cfaaded010315979973"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"4aee2c96b00742be59c759297bf3bace62d73023","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    state: started"},{"line_number":44,"context_line":"    port: 22"},{"line_number":45,"context_line":"    host: \"{{ ipv4_address }}\""},{"line_number":46,"context_line":"  when: ipv4_address is defined and multinode_testing | bool"},{"line_number":47,"context_line":"- name: \u003e"},{"line_number":48,"context_line":"    Additional SSH startup pause when performing multi-node testing"},{"line_number":49,"context_line":"  pause:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_1e0ce440","line":46,"in_reply_to":"9f560f44_be5b38f4","updated":"2020-09-02 09:34:55.000000000","message":"Done","commit_id":"aba6617159819d131dff0cfaaded010315979973"}]}