)]}'
{"doc/source/install/index.rst":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"dc11ebeef197720bdb9334912dc98e5c725d3eb6","unresolved":false,"context_lines":[{"line_number":63,"context_line":"* The network interface you\u0027re going to use for communication between the bare"},{"line_number":64,"context_line":"  metal machines and the Bifrost services."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"  On systems using firewalld (CentOS and RHEL currently), a new zone"},{"line_number":67,"context_line":"  ``bifrost`` will be created, and the network interface will be moved to it."},{"line_number":68,"context_line":"  DHCP, PXE and API services will only be added to this zone. If you need any"},{"line_number":69,"context_line":"  of them available in other zones, you need to configure firewall yourself."}],"source_content_type":"text/x-rst","patch_set":2,"id":"9f560f44_de6eecc7","line":66,"updated":"2020-09-02 08:53:41.000000000","message":"We don\u0027t use firewalld on Fedora yet, I\u0027ve encountered issues with F30","commit_id":"710e0db06885b13b398d6fe209893cc732a43d41"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"4eb2c3880656846725152de9abb3b4411b22c75c","unresolved":false,"context_lines":[{"line_number":63,"context_line":"* The network interface you\u0027re going to use for communication between the bare"},{"line_number":64,"context_line":"  metal machines and the Bifrost services."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"  On systems using firewalld (CentOS and RHEL currently), a new zone"},{"line_number":67,"context_line":"  ``bifrost`` will be created, and the network interface will be moved to it."},{"line_number":68,"context_line":"  DHCP, PXE and API services will only be added to this zone. If you need any"},{"line_number":69,"context_line":"  of them available in other zones, you need to configure firewall yourself."}],"source_content_type":"text/x-rst","patch_set":2,"id":"9f560f44_ab4adc7f","line":66,"range":{"start_line":66,"start_character":30,"end_line":66,"end_character":55},"updated":"2020-09-02 08:47:32.000000000","message":"nit: Fedora?","commit_id":"710e0db06885b13b398d6fe209893cc732a43d41"}],"playbooks/roles/bifrost-ironic-install/tasks/bootstrap.yml":[{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"5a61470fddb3c373495322a4acbb85cbf7de4132","unresolved":false,"context_lines":[{"line_number":386,"context_line":"        zone: \"{{ firewalld_internal_zone }}\""},{"line_number":387,"context_line":"        interface: \"{{ network_interface }}\""},{"line_number":388,"context_line":"        state: enabled"},{"line_number":389,"context_line":"        permanent: yes"},{"line_number":390,"context_line":"      when: not testing | bool"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"    - name: \"Enable services in firewalld\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f560f44_0572de7c","line":389,"updated":"2020-09-01 20:57:15.000000000","message":"I needed to add this to have it take affect:\n       immediate: yes","commit_id":"90a465746d54750011891a3e01c74c57d6d822b8"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fa65fc4c00f1627869e9e84bde69dc81422bfbff","unresolved":false,"context_lines":[{"line_number":386,"context_line":"        zone: \"{{ firewalld_internal_zone }}\""},{"line_number":387,"context_line":"        interface: \"{{ network_interface }}\""},{"line_number":388,"context_line":"        state: enabled"},{"line_number":389,"context_line":"        permanent: yes"},{"line_number":390,"context_line":"      when: not testing | bool"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"    - name: \"Enable services in firewalld\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f560f44_2bca4c4e","line":389,"in_reply_to":"9f560f44_0572de7c","updated":"2020-09-02 08:35:15.000000000","message":"Done","commit_id":"90a465746d54750011891a3e01c74c57d6d822b8"}],"playbooks/roles/bifrost-ironic-install/tasks/inspector_bootstrap.yml":[{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"5a61470fddb3c373495322a4acbb85cbf7de4132","unresolved":false,"context_lines":[{"line_number":147,"context_line":"- name: \"Inspector - Enable port in firewalld\""},{"line_number":148,"context_line":"  firewalld:"},{"line_number":149,"context_line":"    port: \"5050/tcp\""},{"line_number":150,"context_line":"    zone: \"{{ \u0027libvirt\u0027 if testing else firewalld_internal_zone }}\""},{"line_number":151,"context_line":"    state: enabled"},{"line_number":152,"context_line":"    permanent: yes"},{"line_number":153,"context_line":"    immediate: yes"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f560f44_65075a83","line":150,"updated":"2020-09-01 20:57:15.000000000","message":"Needs to be:\nzone: \"{{ \u0027libvirt\u0027 if testing | bool else firewalld_internal_zone }}\"\n\nAlso, on a new install it attempts to use this zone before it\u0027s been created since inspector_baremetal is included here: https://github.com/openstack/bifrost/blob/master/playbooks/roles/bifrost-ironic-install/tasks/bootstrap.yml#L207\n\nSo will need to change the ordering.","commit_id":"90a465746d54750011891a3e01c74c57d6d822b8"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fa65fc4c00f1627869e9e84bde69dc81422bfbff","unresolved":false,"context_lines":[{"line_number":147,"context_line":"- name: \"Inspector - Enable port in firewalld\""},{"line_number":148,"context_line":"  firewalld:"},{"line_number":149,"context_line":"    port: \"5050/tcp\""},{"line_number":150,"context_line":"    zone: \"{{ \u0027libvirt\u0027 if testing else firewalld_internal_zone }}\""},{"line_number":151,"context_line":"    state: enabled"},{"line_number":152,"context_line":"    permanent: yes"},{"line_number":153,"context_line":"    immediate: yes"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f560f44_abdbfc1e","line":150,"in_reply_to":"9f560f44_65075a83","updated":"2020-09-02 08:35:15.000000000","message":"Done","commit_id":"90a465746d54750011891a3e01c74c57d6d822b8"}],"playbooks/roles/bifrost-ironic-install/tasks/install.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"96fb9e0fc30441a340f30f4d07ea7f8b8e2ef707","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    name: \"{{ required_packages }}\""},{"line_number":23,"context_line":"    state: present"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- name: \"Ask systemd to reload configuration\""},{"line_number":26,"context_line":"  systemd:"},{"line_number":27,"context_line":"    daemon_reload: yes"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f560f44_640d533d","line":25,"updated":"2020-09-07 10:06:44.000000000","message":"one cannot assume systemd is being used during installation; moreover, package installations normally reload systemd themselves if they need to; this broke kolla already","commit_id":"710e0db06885b13b398d6fe209893cc732a43d41"}]}