)]}'
{"playbooks/enroll-dynamic.yaml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"dd9373e08cc2d8b663b193fba3bd0f6c5dc847c8","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    - role: ironic-inspect-node"},{"line_number":10,"context_line":"      when: inspect_nodes | default(\u0027false\u0027) | bool"},{"line_number":11,"context_line":"      delegate_to: \"{{ groups[\u0027target\u0027][0] if groups[\u0027target\u0027] is defined else \u0027localhost\u0027 }}\""},{"line_number":12,"context_line":"    - role: bifrost-test-inspection"},{"line_number":13,"context_line":"      when:"},{"line_number":14,"context_line":"        - testing | default(false) | bool"},{"line_number":15,"context_line":"        - inspect_nodes | default(false) | bool"},{"line_number":16,"context_line":"      delegate_to: \"{{ groups[\u0027target\u0027][0] if groups[\u0027target\u0027] is defined else \u0027localhost\u0027 }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9f560f44_e61a90c4","line":16,"range":{"start_line":12,"start_character":0,"end_line":16,"end_character":94},"updated":"2020-09-14 10:46:23.000000000","message":"Could put this in a separate play inside the test playbook?","commit_id":"f32d3eff32231c1586565832326cce0f250865ad"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"332f14ba235654117c5f1c8a21af16da36d909b6","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    - role: ironic-inspect-node"},{"line_number":10,"context_line":"      when: inspect_nodes | default(\u0027false\u0027) | bool"},{"line_number":11,"context_line":"      delegate_to: \"{{ groups[\u0027target\u0027][0] if groups[\u0027target\u0027] is defined else \u0027localhost\u0027 }}\""},{"line_number":12,"context_line":"    - role: bifrost-test-inspection"},{"line_number":13,"context_line":"      when:"},{"line_number":14,"context_line":"        - testing | default(false) | bool"},{"line_number":15,"context_line":"        - inspect_nodes | default(false) | bool"},{"line_number":16,"context_line":"      delegate_to: \"{{ groups[\u0027target\u0027][0] if groups[\u0027target\u0027] is defined else \u0027localhost\u0027 }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9f560f44_b1c45043","line":16,"range":{"start_line":12,"start_character":0,"end_line":16,"end_character":94},"in_reply_to":"9f560f44_e61a90c4","updated":"2020-09-14 11:39:23.000000000","message":"Probably yes. I\u0027m fine either way.","commit_id":"f32d3eff32231c1586565832326cce0f250865ad"}],"playbooks/test-bifrost.yaml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"dd9373e08cc2d8b663b193fba3bd0f6c5dc847c8","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    - name: \"Add localhost to the target group\""},{"line_number":16,"context_line":"      add_host:"},{"line_number":17,"context_line":"        name: localhost"},{"line_number":18,"context_line":"        groups: target"},{"line_number":19,"context_line":"        ansible_connection: local"},{"line_number":20,"context_line":"    - name: \"Set variables if we are running in upstream OpenStack CI\""},{"line_number":21,"context_line":"      set_fact:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9f560f44_2663e843","line":18,"range":{"start_line":18,"start_character":8,"end_line":18,"end_character":22},"updated":"2020-09-14 10:46:23.000000000","message":"Could this just be added to the inventory file?","commit_id":"f32d3eff32231c1586565832326cce0f250865ad"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d0be14263825d226d933ebe65d18b32b9f8a02b7","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    - name: \"Add localhost to the target group\""},{"line_number":16,"context_line":"      add_host:"},{"line_number":17,"context_line":"        name: localhost"},{"line_number":18,"context_line":"        groups: target"},{"line_number":19,"context_line":"        ansible_connection: local"},{"line_number":20,"context_line":"    - name: \"Set variables if we are running in upstream OpenStack CI\""},{"line_number":21,"context_line":"      set_fact:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9f560f44_031b31ca","line":18,"range":{"start_line":18,"start_character":8,"end_line":18,"end_character":22},"in_reply_to":"9f560f44_008cc7d5","updated":"2020-09-14 13:59:14.000000000","message":"Right, we should probably get rid of test-bifrost completely, but that\u0027s an ambitious goal (and contradicts the other your suggestion). I tried that and got stuck into too many things to move around, so I\u0027m trying smaller steps.","commit_id":"f32d3eff32231c1586565832326cce0f250865ad"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"ce407459f101d3c732593ade351238fdbcae9319","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    - name: \"Add localhost to the target group\""},{"line_number":16,"context_line":"      add_host:"},{"line_number":17,"context_line":"        name: localhost"},{"line_number":18,"context_line":"        groups: target"},{"line_number":19,"context_line":"        ansible_connection: local"},{"line_number":20,"context_line":"    - name: \"Set variables if we are running in upstream OpenStack CI\""},{"line_number":21,"context_line":"      set_fact:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9f560f44_008cc7d5","line":18,"range":{"start_line":18,"start_character":8,"end_line":18,"end_character":22},"in_reply_to":"9f560f44_00a687ac","updated":"2020-09-14 13:24:31.000000000","message":"Users would execute a sequence of commands, such as:\n\nansible-playbook -vvvv -i inventory/target install.yaml\n\nexport BIFROST_INVENTORY_SOURCE\u003d/tmp/baremetal.json\nansible-playbook -vvvv -i inventory/bifrost_inventory.py enroll-dynamic.yaml\n\nansible-playbook -vvvv -i inventory/bifrost_inventory.py deploy-dynamic.yaml","commit_id":"f32d3eff32231c1586565832326cce0f250865ad"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"d570696a6dfc80b2642f58e85a4e5aeaeb911fc3","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    - name: \"Add localhost to the target group\""},{"line_number":16,"context_line":"      add_host:"},{"line_number":17,"context_line":"        name: localhost"},{"line_number":18,"context_line":"        groups: target"},{"line_number":19,"context_line":"        ansible_connection: local"},{"line_number":20,"context_line":"    - name: \"Set variables if we are running in upstream OpenStack CI\""},{"line_number":21,"context_line":"      set_fact:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9f560f44_f6007905","line":18,"range":{"start_line":18,"start_character":8,"end_line":18,"end_character":22},"in_reply_to":"9f560f44_031b31ca","updated":"2020-09-14 14:37:14.000000000","message":"I wouldn\u0027t say it contradicts the other suggestion. We would just have a set of separate test playbooks that get executed at the correct stage.\n\nUnderstood about evolving. In that case, could we simply add an extra -i inventory/target instead of add_host?","commit_id":"f32d3eff32231c1586565832326cce0f250865ad"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"332f14ba235654117c5f1c8a21af16da36d909b6","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    - name: \"Add localhost to the target group\""},{"line_number":16,"context_line":"      add_host:"},{"line_number":17,"context_line":"        name: localhost"},{"line_number":18,"context_line":"        groups: target"},{"line_number":19,"context_line":"        ansible_connection: local"},{"line_number":20,"context_line":"    - name: \"Set variables if we are running in upstream OpenStack CI\""},{"line_number":21,"context_line":"      set_fact:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9f560f44_f1a528a1","line":18,"range":{"start_line":18,"start_character":8,"end_line":18,"end_character":22},"in_reply_to":"9f560f44_2663e843","updated":"2020-09-14 11:39:23.000000000","message":"You mean, update bifrost_inventory.py? Could be done, although I\u0027m not sure about potential side effects on people using bifrost_inventory.py in their playbooks. Thoughts?","commit_id":"f32d3eff32231c1586565832326cce0f250865ad"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d01f2fd66814d5f810b71caddff566d1d8346c73","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    - name: \"Add localhost to the target group\""},{"line_number":16,"context_line":"      add_host:"},{"line_number":17,"context_line":"        name: localhost"},{"line_number":18,"context_line":"        groups: target"},{"line_number":19,"context_line":"        ansible_connection: local"},{"line_number":20,"context_line":"    - name: \"Set variables if we are running in upstream OpenStack CI\""},{"line_number":21,"context_line":"      set_fact:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9f560f44_00a687ac","line":18,"range":{"start_line":18,"start_character":8,"end_line":18,"end_character":22},"in_reply_to":"9f560f44_e0cb9370","updated":"2020-09-14 13:12:00.000000000","message":"Well, what I have here is the closest to what users would do (i.e. define target to something).","commit_id":"f32d3eff32231c1586565832326cce0f250865ad"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"ac3a8719bbd08270a7f120cde8af3950ffa17d2d","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    - name: \"Add localhost to the target group\""},{"line_number":16,"context_line":"      add_host:"},{"line_number":17,"context_line":"        name: localhost"},{"line_number":18,"context_line":"        groups: target"},{"line_number":19,"context_line":"        ansible_connection: local"},{"line_number":20,"context_line":"    - name: \"Set variables if we are running in upstream OpenStack CI\""},{"line_number":21,"context_line":"      set_fact:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9f560f44_e0cb9370","line":18,"range":{"start_line":18,"start_character":8,"end_line":18,"end_character":22},"in_reply_to":"9f560f44_f1a528a1","updated":"2020-09-14 13:07:07.000000000","message":"We should really test whatever it is that users are expected to do. When using install.yaml, they are instructed to use the inventory in inventory/target. Maybe we need to split this into the separate commands that users would run.","commit_id":"f32d3eff32231c1586565832326cce0f250865ad"}],"scripts/test-bifrost.sh":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"68a253cb42a4e21d63198f9a455197ad015145fb","unresolved":true,"context_lines":[{"line_number":162,"context_line":""},{"line_number":163,"context_line":"${ANSIBLE} -vvvv \\"},{"line_number":164,"context_line":"    -i inventory/bifrost_inventory.py \\"},{"line_number":165,"context_line":"    -i inventory/target \\"},{"line_number":166,"context_line":"    ${TEST_PLAYBOOK} \\"},{"line_number":167,"context_line":"    -e use_cirros\u003d${USE_CIRROS} \\"},{"line_number":168,"context_line":"    -e testing_user\u003d${TESTING_USER} \\"}],"source_content_type":"text/x-sh","patch_set":7,"id":"9760928f_8c744677","line":165,"updated":"2020-11-25 16:56:14.000000000","message":"Appears that this is now a requirement. I guess we should document it.","commit_id":"0c242face70d240f8be134acfbc4d3e2e3825c92"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f396479b3048808de5d0c6a21e26e70cc88abbdf","unresolved":true,"context_lines":[{"line_number":162,"context_line":""},{"line_number":163,"context_line":"${ANSIBLE} -vvvv \\"},{"line_number":164,"context_line":"    -i inventory/bifrost_inventory.py \\"},{"line_number":165,"context_line":"    -i inventory/target \\"},{"line_number":166,"context_line":"    ${TEST_PLAYBOOK} \\"},{"line_number":167,"context_line":"    -e use_cirros\u003d${USE_CIRROS} \\"},{"line_number":168,"context_line":"    -e testing_user\u003d${TESTING_USER} \\"}],"source_content_type":"text/x-sh","patch_set":7,"id":"50f4c232_15c8d384","line":165,"in_reply_to":"9760928f_8c744677","updated":"2020-11-26 16:28:34.000000000","message":"This turned out to be kayobe supplying a limit that didn\u0027t include localhost.","commit_id":"0c242face70d240f8be134acfbc4d3e2e3825c92"}]}