)]}'
{"id":"openstack%2Fbifrost~753968","triplet_id":"openstack%2Fbifrost~master~I4411e4800b2d77a110a5cd854a7d3586759d8f1a","project":"openstack/bifrost","branch":"master","topic":"cli-validate","hashtags":[],"change_id":"I4411e4800b2d77a110a5cd854a7d3586759d8f1a","subject":"Revert \"Move CLI validation to bifrost-keystone-client-config\"","status":"ABANDONED","created":"2020-09-24 08:22:11.000000000","updated":"2020-09-24 11:04:28.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"d009e8f2b8a021cdffc19876bbf39e84e09815ed","_number":753968,"virtual_id_number":753968,"owner":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2020-09-24 09:08:42.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":-1,"date":"2020-09-24 08:24:17.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":0,"date":"2020-09-24 08:22:11.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},{"value":-1,"date":"2020-09-24 08:22:37.000000000","permitted_voting_range":{"min":-1,"max":0},"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},{"value":0,"date":"2020-09-24 08:22:11.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"value":0,"date":"2020-09-24 08:22:11.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-09-24 08:22:11.000000000","updated_by":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"reviewer":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"state":"REVIEWER"},{"updated":"2020-09-24 08:22:11.000000000","updated_by":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"reviewer":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"state":"REVIEWER"},{"updated":"2020-09-24 08:22:11.000000000","updated_by":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"reviewer":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"state":"REVIEWER"},{"updated":"2020-09-24 08:24:17.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2020-09-24 09:08:42.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"9b58c1f75a702d0bfe13d03a4749843e4c1d1534","author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"date":"2020-09-24 08:22:11.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b63a34c6e6d03e90f145624fbbfd00b0d3b6f9a1","author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"date":"2020-09-24 08:22:37.000000000","message":"Patch Set 1: Workflow-1\n\nlet\u0027s see but it should make the kolla job green again","accounts_in_message":[],"_revision_number":1},{"id":"3c1f1507656540459dbccec82f270ef47c0fc68f","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2020-09-24 08:24:17.000000000","message":"Patch Set 1: Code-Review-1\n\nI don\u0027t understand why we should revert it, I think kolla may be doing something wrong.","accounts_in_message":[],"_revision_number":1},{"id":"8aa5ad1fb200976981a8fb9d596549e453c3585b","author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"date":"2020-09-24 08:34:49.000000000","message":"Patch Set 1:\n\n\u003e I don\u0027t understand why we should revert it, I think kolla may be\n \u003e doing something wrong.\n\nYeah, I don\u0027t want to revert it.","accounts_in_message":[],"_revision_number":1},{"id":"efba8e4a5c3f5c78de7d375701b56552252cda3e","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2020-09-24 08:38:12.000000000","message":"Patch Set 1:\n\nOkay, a correction: I\u0027m not sure if kolla is doing anything wrong, but I need to understand more what you\u0027re doing: are you trying to create clouds.yaml in your containers? This is a bit weird for me, but you know better. If it\u0027s not intended, I\u0027d recommend removing this role for your scripts.\n\nIn any case, I\u0027d recommend setting skip_validation\u003dtrue in case we start adding more similar validations in the future.","accounts_in_message":[],"_revision_number":1},{"id":"e5bd04b6535051f721f249673ede747a36294b3a","author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"date":"2020-09-24 09:00:35.000000000","message":"Patch Set 1:\n\n\u003e Okay, a correction: I\u0027m not sure if kolla is doing anything wrong,\n \u003e but I need to understand more what you\u0027re doing: are you trying to\n \u003e create clouds.yaml in your containers? This is a bit weird for me,\n \u003e but you know better. If it\u0027s not intended, I\u0027d recommend removing\n \u003e this role for your scripts.\n \u003e \n \u003e In any case, I\u0027d recommend setting skip_validation\u003dtrue in case we\n \u003e start adding more similar validations in the future.\n\nOk, it seems the other role has this:\n\n    skip_validation: \"{{ skip_start }}\"\n\nso we rely on skip_start to skip_validation too (which is a sane assumption anyhow) - should bifrost maybe move it to a top-level var?","accounts_in_message":[],"_revision_number":1},{"id":"92c76d949ef406165757955d9b5d716e7310f2bb","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-24 09:08:42.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/4b2ae28dee39498eabba9efd1eb459fa : SUCCESS in 3m 37s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/e780622be6384ec8be9d394ed45b2d43 : SUCCESS in 4m 16s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/16d5b3e5dbc4434db6e828d866d0aba6 : SUCCESS in 3m 56s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/1fdf54d62afb4fd0979214c76f35a2dc : SUCCESS in 4m 45s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/0cce1e54d42e47e3a6318c6281a6060f : SUCCESS in 5m 59s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/02adb6de8ad544d0a69b89a9c3e09551 : SUCCESS in 3m 34s\n- bifrost-tox-linters https://zuul.opendev.org/t/openstack/build/f430042745f3422eb24508db1da30a67 : SUCCESS in 5m 07s\n- bifrost-integration-tinyipa-ubuntu-focal https://zuul.opendev.org/t/openstack/build/0c2fd41067464067b6e400c0502590f7 : SUCCESS in 23m 56s\n- bifrost-integration-tinyipa-centos-8 https://zuul.opendev.org/t/openstack/build/4af03a4404c140138a3232a749b15890 : SUCCESS in 27m 57s\n- bifrost-integration-tinyipa-keystone-ubuntu-focal https://zuul.opendev.org/t/openstack/build/af1e02e4cd984c7d90457dabf23b9346 : SUCCESS in 22m 48s\n- bifrost-integration-tinyipa-keystone-centos-8 https://zuul.opendev.org/t/openstack/build/c17df554743b422fbbbb02543c19e4e6 : SUCCESS in 25m 39s\n- bifrost-integration-tinyipa-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/b47c2bb48d1d49218cbc4c5df878d535 : SUCCESS in 22m 22s (non-voting)\n- bifrost-integration-tinyipa-opensuse-15 https://zuul.opendev.org/t/openstack/build/5615e45d3ae84336ac5f5d6e2a6d4a7e : SUCCESS in 24m 21s (non-voting)\n- bifrost-integration-tinyipa-fedora-latest https://zuul.opendev.org/t/openstack/build/66ff3a7fd8e74e8f81e23ab4c4028fbf : SUCCESS in 22m 38s (non-voting)\n- bifrost-integration-tinyipa-debian-buster https://zuul.opendev.org/t/openstack/build/2fbb2900de2b418f92ec6f67c02fbf77 : SUCCESS in 21m 14s (non-voting)\n- bifrost-integration-dhcp-ubuntu-focal https://zuul.opendev.org/t/openstack/build/1cbfaa377db846b19abd704819a83247 : SUCCESS in 28m 09s (non-voting)\n- bifrost-integration-dhcp-centos-8 https://zuul.opendev.org/t/openstack/build/4240ae78af7a44e39fbd6413d081a41c : SUCCESS in 32m 05s (non-voting)\n- bifrost-integration-dibipa-debian-ubuntu-focal https://zuul.opendev.org/t/openstack/build/c5f12401b9154eed9724cee537891974 : SUCCESS in 36m 50s (non-voting)\n- bifrost-integration-dibipa-debian-centos-8 https://zuul.opendev.org/t/openstack/build/d4c82bf2ba11451b9cf386e01ae8eeb7 : SUCCESS in 38m 56s (non-voting)\n- bifrost-cli-ubuntu-focal https://zuul.opendev.org/t/openstack/build/dce9168ce1c44c50be1888eddd6ee0f8 : SUCCESS in 21m 46s (non-voting)\n- bifrost-collections-src https://zuul.opendev.org/t/openstack/build/7af4132151cf4ccab68625ea5d850ab2 : SUCCESS in 24m 02s (non-voting)\n- bifrost-keystone-collections-src https://zuul.opendev.org/t/openstack/build/dc2bac528c9740128e6bc1e5fb46cce3 : SUCCESS in 25m 20s (non-voting)\n- kolla-ansible-centos8-source-bifrost https://zuul.opendev.org/t/openstack/build/4dea7bd4edb34df998ed8896bf7ff63e : SUCCESS in 27m 18s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"e87d2c2455e234dce85f75b9de0feec6e46bb00a","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2020-09-24 09:09:25.000000000","message":"Patch Set 1:\n\nGood call: https://review.opendev.org/#/c/754012/","accounts_in_message":[],"_revision_number":1},{"id":"fe57ad559a87e995702158c34c96a231a3630f23","author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"date":"2020-09-24 11:04:28.000000000","message":"Abandoned\n\nit served its purpose","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"f0c8aa0ad26177e9379ace0a297cf9c24e3a2d6e","revisions":{"f0c8aa0ad26177e9379ace0a297cf9c24e3a2d6e":{"kind":"REWORK","_number":1,"created":"2020-09-24 08:22:11.000000000","uploader":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"ref":"refs/changes/68/753968/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/bifrost","ref":"refs/changes/68/753968/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/bifrost refs/changes/68/753968/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/bifrost refs/changes/68/753968/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/bifrost refs/changes/68/753968/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/bifrost refs/changes/68/753968/1"}}},"commit":{"parents":[{"commit":"90a98d03bf4b6ac14aea0ffafbb2f8e3d41fde3d","subject":"Move CLI validation to bifrost-keystone-client-config","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/bifrost/commit/90a98d03bf4b6ac14aea0ffafbb2f8e3d41fde3d"}]}],"author":{"name":"Radosław Piliszek","email":"radoslaw.piliszek@gmail.com","date":"2020-09-24 08:22:11.000000000","tz":0},"committer":{"name":"Radosław Piliszek","email":"radoslaw.piliszek@gmail.com","date":"2020-09-24 08:22:11.000000000","tz":0},"subject":"Revert \"Move CLI validation to bifrost-keystone-client-config\"","message":"Revert \"Move CLI validation to bifrost-keystone-client-config\"\n\nThis patch being reverted broke Kolla.\n\nThis reverts commit 90a98d03bf4b6ac14aea0ffafbb2f8e3d41fde3d.\n\nChange-Id: I4411e4800b2d77a110a5cd854a7d3586759d8f1a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/bifrost/commit/f0c8aa0ad26177e9379ace0a297cf9c24e3a2d6e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/bifrost/commit/f0c8aa0ad26177e9379ace0a297cf9c24e3a2d6e"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}