)]}'
{"bifrost/inventory.py":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"c6043bf37326b500ee6723ffde8c2b33bfd24e65","unresolved":false,"context_lines":[{"line_number":167,"context_line":"    hostvars \u003d {\"127.0.0.1\": {\"ansible_connection\": \"local\"}}"},{"line_number":168,"context_line":"    groups \u003d {}"},{"line_number":169,"context_line":"    groups.update({\u0027baremetal\u0027: {\u0027hosts\u0027: []}})"},{"line_number":170,"context_line":"    groups.update({\u0027localhost\u0027: {\u0027hosts\u0027: [\"127.0.0.1\"]}})"},{"line_number":171,"context_line":"    return (groups, hostvars)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f681702_ef0d2a91","line":170,"range":{"start_line":170,"start_character":44,"end_line":170,"end_character":53},"updated":"2020-10-19 13:45:52.000000000","message":"it would probably be better to use localhost as the hostname, which is implicitly local. This loopback IP does seem to be littered across bifrost however.","commit_id":"1010a645d07c6acc2d07395dbe977ac08ca7d6f1"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"381b77c44814474b9125fdffc8150ba3a4aced90","unresolved":false,"context_lines":[{"line_number":167,"context_line":"    hostvars \u003d {\"127.0.0.1\": {\"ansible_connection\": \"local\"}}"},{"line_number":168,"context_line":"    groups \u003d {}"},{"line_number":169,"context_line":"    groups.update({\u0027baremetal\u0027: {\u0027hosts\u0027: []}})"},{"line_number":170,"context_line":"    groups.update({\u0027localhost\u0027: {\u0027hosts\u0027: [\"127.0.0.1\"]}})"},{"line_number":171,"context_line":"    return (groups, hostvars)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f65232a_885be785","line":170,"range":{"start_line":170,"start_character":44,"end_line":170,"end_character":53},"in_reply_to":"3f65232a_1d9f17b5","updated":"2020-10-21 09:18:49.000000000","message":"The host doesn\u0027t need to be a member of a group called localhost.\n\nStill, understood about keeping this small.","commit_id":"1010a645d07c6acc2d07395dbe977ac08ca7d6f1"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"c69c5ec5014fafb69fa71bd1d59c0b89b043db2c","unresolved":false,"context_lines":[{"line_number":167,"context_line":"    hostvars \u003d {\"127.0.0.1\": {\"ansible_connection\": \"local\"}}"},{"line_number":168,"context_line":"    groups \u003d {}"},{"line_number":169,"context_line":"    groups.update({\u0027baremetal\u0027: {\u0027hosts\u0027: []}})"},{"line_number":170,"context_line":"    groups.update({\u0027localhost\u0027: {\u0027hosts\u0027: [\"127.0.0.1\"]}})"},{"line_number":171,"context_line":"    return (groups, hostvars)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f65232a_1d9f17b5","line":170,"range":{"start_line":170,"start_character":44,"end_line":170,"end_character":53},"in_reply_to":"5f681702_ef0d2a91","updated":"2020-10-21 07:38:54.000000000","message":"If we do, Ansible will emit this warning, unless we rename the group to something else:\n\n[WARNING]: Found both group and host with same name: localhost\n\nI would prefer to keep this change minimal.","commit_id":"1010a645d07c6acc2d07395dbe977ac08ca7d6f1"}],"bifrost/tests/unit/test_inventory.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"2da454878daef5f9b5a338b7909720dd192fcaac","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        (groups, hostvars) \u003d inventory._prepare_inventory()"},{"line_number":34,"context_line":"        self.assertIn(\"baremetal\", groups)"},{"line_number":35,"context_line":"        self.assertIn(\"localhost\", groups)"},{"line_number":36,"context_line":"        self.assertDictEqual(hostvars, {\u0027127.0.0.1\u0027: {\u0027ansible_connection\u0027: \u0027local\u0027}})"},{"line_number":37,"context_line":"        localhost_value \u003d dict(hosts\u003d[\"127.0.0.1\"])"},{"line_number":38,"context_line":"        self.assertDictEqual(localhost_value, groups[\u0027localhost\u0027])"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f681702_fb204cb3","line":36,"updated":"2020-10-19 17:12:06.000000000","message":"pep8: E501 line too long (86 \u003e 79 characters)","commit_id":"b9782d3c4870b79aba59a1e3a7ff705c7f75e287"}]}