)]}'
{"playbooks/roles/bifrost-ironic-install/defaults/main.yml":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"9de2d675a454b5623eecaedda86b2b47e3b12f14","unresolved":true,"context_lines":[{"line_number":382,"context_line":"  {% if testing | bool %}console\u003dttyS0{% endif %}"},{"line_number":383,"context_line":"  ipa-insecure\u003d1"},{"line_number":384,"context_line":"  {% if ipa_add_ssh_key | bool and ssh_public_key is defined %}"},{"line_number":385,"context_line":"  sshkey\u003d\"{{ ssh_public_key }}\""},{"line_number":386,"context_line":"  {% endif %}"},{"line_number":387,"context_line":"  {{ extra_kernel_options | default(\u0027\u0027) }}"},{"line_number":388,"context_line":"redfish_kernel_params: \"{{ pxe_kernel_params }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"76d201bf_03a9924a","line":385,"updated":"2020-11-30 15:24:15.000000000","message":"on second thought, I am not sure if we need quotes here.\nthe pubkey is in the form of \"ssh-rsa key-content user@host\"","commit_id":"b604f66e3860d103d428a1eb61e2f420bf3ce97e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f55201ee58284df061ff17919e8e040979565ae9","unresolved":true,"context_lines":[{"line_number":382,"context_line":"  {% if testing | bool %}console\u003dttyS0{% endif %}"},{"line_number":383,"context_line":"  ipa-insecure\u003d1"},{"line_number":384,"context_line":"  {% if ipa_add_ssh_key | bool and ssh_public_key is defined %}"},{"line_number":385,"context_line":"  sshkey\u003d\"{{ ssh_public_key }}\""},{"line_number":386,"context_line":"  {% endif %}"},{"line_number":387,"context_line":"  {{ extra_kernel_options | default(\u0027\u0027) }}"},{"line_number":388,"context_line":"redfish_kernel_params: \"{{ pxe_kernel_params }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"f143c69a_bf95cb6d","line":385,"in_reply_to":"76d201bf_03a9924a","updated":"2020-11-30 16:24:39.000000000","message":"Quotes are required for the dynamic-login DIB element, otherwise it won\u0027t pick the key.","commit_id":"b604f66e3860d103d428a1eb61e2f420bf3ce97e"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"78f93d4a644d60eda54fc8c8bc09ef3d7012d313","unresolved":false,"context_lines":[{"line_number":382,"context_line":"  {% if testing | bool %}console\u003dttyS0{% endif %}"},{"line_number":383,"context_line":"  ipa-insecure\u003d1"},{"line_number":384,"context_line":"  {% if ipa_add_ssh_key | bool and ssh_public_key is defined %}"},{"line_number":385,"context_line":"  sshkey\u003d\"{{ ssh_public_key }}\""},{"line_number":386,"context_line":"  {% endif %}"},{"line_number":387,"context_line":"  {{ extra_kernel_options | default(\u0027\u0027) }}"},{"line_number":388,"context_line":"redfish_kernel_params: \"{{ pxe_kernel_params }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"07bdfc93_026cb48d","line":385,"in_reply_to":"f143c69a_bf95cb6d","updated":"2020-11-30 16:36:05.000000000","message":"Ack, quotes are required, I must be fuzzy on thinking \"\\\"{{ }}\\\"\"","commit_id":"b604f66e3860d103d428a1eb61e2f420bf3ce97e"}],"playbooks/roles/bifrost-ironic-install/ssh_public_key_path.yaml":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"6dbde17a4d16dfe62ca79c7b66a2666a6b3247a8","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2015 Hewlett-Packard Development Company, L.P."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ba76d300_3d8a9426","line":1,"updated":"2020-11-27 02:32:03.000000000","message":"This copyright header should be corrected","commit_id":"b604f66e3860d103d428a1eb61e2f420bf3ce97e"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"c583efce9feb8accfcdb8421e15c254fa5388f71","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2015 Hewlett-Packard Development Company, L.P."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"233a5c3b_218dadba","line":1,"in_reply_to":"556b179d_94e6f0fd","updated":"2020-11-27 13:47:00.000000000","message":"My understanding is that in case of Apache 2.0 license, and since this is a copy of another file with small changes, you need to keep the copyright notice, and you could add your own copyright notice for the changes that you applied. This should be fine as it is though.","commit_id":"b604f66e3860d103d428a1eb61e2f420bf3ce97e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8f3438d54c67b32c5eac64f1e34bcc272d7b2241","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2015 Hewlett-Packard Development Company, L.P."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"556b179d_94e6f0fd","line":1,"in_reply_to":"ba76d300_3d8a9426","updated":"2020-11-27 12:44:48.000000000","message":"This is a copy of a file with only minimal changes. I\u0027m not sure I can remove the copyright..","commit_id":"b604f66e3860d103d428a1eb61e2f420bf3ce97e"}]}
