)]}'
{"id":"openstack%2Fbifrost~764357","triplet_id":"openstack%2Fbifrost~master~Ia87c8332994f3b0f037ada953a299987bba246e5","project":"openstack/bifrost","branch":"master","hashtags":[],"change_id":"Ia87c8332994f3b0f037ada953a299987bba246e5","subject":"Fix missing node facts with BIFROST_INVENTORY_SOURCE\u003dironic","status":"MERGED","created":"2020-11-26 15:39:18.000000000","updated":"2020-12-03 22:36:06.000000000","submitted":"2020-12-03 22:34:44.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"764357","meta_rev_id":"0c8d91e1ba54824056670451f3d1d3c3800e2614","_number":764357,"virtual_id_number":764357,"owner":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-12-03 22:34:44.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"all":[{"value":2,"date":"2020-12-03 21:56:48.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"value":2,"date":"2020-12-01 13:48:34.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"all":[{"value":1,"date":"2020-12-03 21:56:48.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"value":0,"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-11-26 16:33:32.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-11-27 02:34:27.000000000","updated_by":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"reviewer":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"state":"REVIEWER"},{"updated":"2020-12-01 08:58:27.000000000","updated_by":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"reviewer":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"state":"CC"},{"updated":"2020-12-01 13:48:34.000000000","updated_by":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"reviewer":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"state":"REVIEWER"}],"messages":[{"id":"599d2fb8e8747ea340e74b9e138896f6c87a0d0c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"date":"2020-11-26 15:39:18.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"aebd4f3a91f7367c12d191c32dcf6463d07b1c48","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"date":"2020-11-26 15:39:54.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"7210b3efe5ff530f86d82b4a8b5c958000018b66","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-26 16:33:32.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/5ee02bf7352d4ac0a187258f0f81f675 : SUCCESS in 3m 40s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/122e8fe818894141bff74bc6e676e763 : FAILURE in 3m 41s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/a75eed6d391546328b9bd3f76d1f0003 : FAILURE in 3m 33s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/3ee6ced034234ba7a729019de3b80255 : FAILURE in 4m 59s (non-voting)\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/28b5d2f89d38409e971e6885c2db2513 : FAILURE in 4m 04s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7ad4a6d4e7f24c94810c9dc948b50c3c : SUCCESS in 7m 07s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/cba1e875dd5a47c0840bf024dbf6ef6a : SUCCESS in 3m 58s\n- bifrost-tox-linters https://zuul.opendev.org/t/openstack/build/0f49b826d3ef45c987e66ae1c89726dc : SUCCESS in 7m 23s\n- bifrost-integration-tinyipa-ubuntu-focal https://zuul.opendev.org/t/openstack/build/11c343425e6941618dee228b8d4dc9b4 : SUCCESS in 22m 36s\n- bifrost-integration-tinyipa-centos-8 https://zuul.opendev.org/t/openstack/build/2bd271b1c6794923a1c8de5a8baa953a : SUCCESS in 28m 10s\n- bifrost-integration-tinyipa-keystone-ubuntu-focal https://zuul.opendev.org/t/openstack/build/d70073d28e0b4936a0cd254cb4c26d78 : SUCCESS in 24m 06s\n- bifrost-integration-tinyipa-keystone-centos-8 https://zuul.opendev.org/t/openstack/build/0908bfd73d5c4dfea37d660c92cd500b : SUCCESS in 31m 24s\n- bifrost-integration-redfish-vmedia-uefi-ubuntu-focal https://zuul.opendev.org/t/openstack/build/e0f3055e198a4adca21adeedfdc95b97 : SUCCESS in 23m 50s\n- bifrost-integration-redfish-vmedia-uefi-centos-8 https://zuul.opendev.org/t/openstack/build/6e861ae86780469c9a3fc4b59d6ca5e5 : SUCCESS in 30m 35s\n- bifrost-integration-tinyipa-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/118526db34f84fd0a52e93d9159dc1cb : SUCCESS in 24m 29s (non-voting)\n- bifrost-integration-tinyipa-opensuse-15 https://zuul.opendev.org/t/openstack/build/68ececec2e2b48d28dbf3be0c87b86d6 : SUCCESS in 22m 05s (non-voting)\n- bifrost-integration-tinyipa-fedora-latest https://zuul.opendev.org/t/openstack/build/234b1b61c10b437bbed9bcfed254665a : SUCCESS in 27m 19s (non-voting)\n- bifrost-integration-tinyipa-debian-buster https://zuul.opendev.org/t/openstack/build/aed9040de15540fab9b0f9d6b3637021 : SUCCESS in 33m 28s (non-voting)\n- bifrost-integration-redfish-uefi-fedora-latest https://zuul.opendev.org/t/openstack/build/54d87fd203284c52b9244ece0eabc660 : SUCCESS in 39m 54s (non-voting)\n- bifrost-integration-dhcp-ubuntu-focal https://zuul.opendev.org/t/openstack/build/5b04ef9c3232476b9d3a200027093591 : SUCCESS in 34m 31s (non-voting)\n- bifrost-integration-dhcp-centos-8 https://zuul.opendev.org/t/openstack/build/e6d104454dd34f29b56d69c21a6e9b62 : SUCCESS in 31m 43s (non-voting)\n- bifrost-integration-dibipa-debian-ubuntu-focal https://zuul.opendev.org/t/openstack/build/ddc4fec998a947c9bfa0e9a2adc25f1c : SUCCESS in 42m 30s (non-voting)\n- bifrost-integration-dibipa-debian-centos-8 https://zuul.opendev.org/t/openstack/build/76fe86aee466473abd7feb48e1e8fa49 : SUCCESS in 38m 31s (non-voting)\n- bifrost-cli-ubuntu-focal https://zuul.opendev.org/t/openstack/build/740b2886aa4d48ba921f2f8c04ff7ac5 : SUCCESS in 29m 54s (non-voting)\n- bifrost-collections-src https://zuul.opendev.org/t/openstack/build/040f614b2e8f4f18aed74a0c947db060 : SUCCESS in 24m 00s (non-voting)\n- bifrost-keystone-collections-src https://zuul.opendev.org/t/openstack/build/85ca92d205294574860763a99adc5c01 : SUCCESS in 32m 37s (non-voting)\n- kolla-ansible-centos8-source-bifrost https://zuul.opendev.org/t/openstack/build/a395c4b24a474541b3e31974b48b9c69 : SUCCESS in 29m 51s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"c04ed865f345ac061670002a6d29ca97620603f0","author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"date":"2020-11-27 02:34:27.000000000","message":"Patch Set 2: Code-Review-1\n\nThe unit test failures look related","accounts_in_message":[],"_revision_number":2},{"id":"651f9bf87d8a4fcc17600c0fb90bc2c9037a9afb","author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"date":"2020-11-27 12:20:10.000000000","message":"Patch Set 2:\n\n\u003e Patch Set 2: Code-Review-1\n\u003e \n\u003e The unit test failures look related\n\ndoh","accounts_in_message":[],"_revision_number":2},{"id":"fb29e24f97e9ce3085bb317b2984bb8184ca8546","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"date":"2020-11-27 12:20:51.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"318f77057677b0f9148cf8046f6f111ba7f1ee5a","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-27 13:23:47.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/1fe6dd62c1d8446bb973a2a8f3f784b7 : SUCCESS in 3m 16s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/a1e7d556d067462f913ada740857a736 : SUCCESS in 3m 36s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/ec5f9f6008f24838862a707936e58d3f : SUCCESS in 5m 53s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/d00ed30dc9f14a50ad7144b2f1eb77c4 : SUCCESS in 3m 41s (non-voting)\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/0d6d25417be14558aec9aff5ecf44acf : SUCCESS in 3m 37s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5565c762df07433a8592d210d625a910 : SUCCESS in 5m 33s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/a8f941ec7ed14dce9e48fcecc5b5ccb4 : SUCCESS in 3m 27s\n- bifrost-tox-linters https://zuul.opendev.org/t/openstack/build/95817131c2614d46bf66946a1874b447 : SUCCESS in 6m 31s\n- bifrost-integration-tinyipa-ubuntu-focal https://zuul.opendev.org/t/openstack/build/ed3e5cbb8dd24b19a67dbc2da0c3b5c9 : SUCCESS in 23m 16s\n- bifrost-integration-tinyipa-centos-8 https://zuul.opendev.org/t/openstack/build/50e39927c95d497081ad5b7e48f2e0d5 : SUCCESS in 26m 24s\n- bifrost-integration-tinyipa-keystone-ubuntu-focal https://zuul.opendev.org/t/openstack/build/0e486dc6203c4bfb8e286312000cb566 : SUCCESS in 25m 47s\n- bifrost-integration-tinyipa-keystone-centos-8 https://zuul.opendev.org/t/openstack/build/822a3e4ac4f9496b9ce8bb8da919e5d2 : SUCCESS in 31m 09s\n- bifrost-integration-redfish-vmedia-uefi-ubuntu-focal https://zuul.opendev.org/t/openstack/build/8534ce4293fe447aab7d18e24ea4bc6b : SUCCESS in 22m 44s\n- bifrost-integration-redfish-vmedia-uefi-centos-8 https://zuul.opendev.org/t/openstack/build/9d75cdd5826a45a4baeeb99516b38c61 : SUCCESS in 28m 49s\n- bifrost-integration-tinyipa-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/88d15fb8da4149ecac85242f003d293c : SUCCESS in 23m 47s (non-voting)\n- bifrost-integration-tinyipa-opensuse-15 https://zuul.opendev.org/t/openstack/build/6a5b0302c5ac464fbfd0f05f2a62252a : SUCCESS in 24m 38s (non-voting)\n- bifrost-integration-tinyipa-fedora-latest https://zuul.opendev.org/t/openstack/build/68e31062456c403fb1814342cc9a1288 : SUCCESS in 26m 55s (non-voting)\n- bifrost-integration-tinyipa-debian-buster https://zuul.opendev.org/t/openstack/build/4975995aa42744119ae91d69d1c21838 : SUCCESS in 25m 27s (non-voting)\n- bifrost-integration-redfish-uefi-fedora-latest https://zuul.opendev.org/t/openstack/build/6c59b73d513d4e629bb6320d4db24c2a : FAILURE in 44m 52s (non-voting)\n- bifrost-integration-dhcp-ubuntu-focal https://zuul.opendev.org/t/openstack/build/f9d592c5562d4bd6b33e161ebfae874a : SUCCESS in 28m 26s (non-voting)\n- bifrost-integration-dhcp-centos-8 https://zuul.opendev.org/t/openstack/build/f793d5c7081a423bbbe5a32055273d86 : FAILURE in 58m 04s (non-voting)\n- bifrost-integration-dibipa-debian-ubuntu-focal https://zuul.opendev.org/t/openstack/build/2871af746ab5472887f3b6a6c8004395 : SUCCESS in 39m 50s (non-voting)\n- bifrost-integration-dibipa-debian-centos-8 https://zuul.opendev.org/t/openstack/build/b2cb09511f424b51a641c65e6e0795eb : SUCCESS in 43m 26s (non-voting)\n- bifrost-cli-ubuntu-focal https://zuul.opendev.org/t/openstack/build/84916fe1f5fa4947a03ee391f1c306c0 : SUCCESS in 21m 56s (non-voting)\n- bifrost-collections-src https://zuul.opendev.org/t/openstack/build/5bc5a7e33f8546a7adce15aa9a2d4280 : SUCCESS in 22m 38s (non-voting)\n- bifrost-keystone-collections-src https://zuul.opendev.org/t/openstack/build/05ff8db3f8c944f3becc1a184933bb3d : SUCCESS in 26m 04s (non-voting)\n- kolla-ansible-centos8-source-bifrost https://zuul.opendev.org/t/openstack/build/35c44b1424ec4219afea97b919b2d116 : SUCCESS in 34m 18s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"585547b7ed4ca62603d51e120ce9f380dfcdd2bd","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2020-12-01 08:58:27.000000000","message":"Patch Set 3:\n\nrecheck it looks ok, just want to verify centos8 and fedora jobs one more time","accounts_in_message":[],"_revision_number":3},{"id":"d83f3215269fd5a5fe4b80a14a2d3f7e38a9e040","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-12-01 09:44:59.000000000","message":"Patch Set 3:\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/4ba291a2b62f45449075f83742c8a78f : SUCCESS in 2m 44s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/f1a00bc186f24da8a28aab0c0bab55ae : SUCCESS in 5m 12s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/0e2e88d4d4394bf7956c2604acd7804f : SUCCESS in 4m 29s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/9a4d80d402b84d38a86111c78bd0ab76 : SUCCESS in 4m 06s (non-voting)\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/598515e3cda24dd4b2330706b364e255 : SUCCESS in 3m 22s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e228df2a78d64248948f1fd965d3692b : SUCCESS in 6m 36s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/f5ef3c44f9dd48f594ca4b85f519c881 : SUCCESS in 4m 48s\n- bifrost-tox-linters https://zuul.opendev.org/t/openstack/build/7901a4e283e94210a06040f3b98ee8f2 : SUCCESS in 7m 04s\n- bifrost-integration-tinyipa-ubuntu-focal https://zuul.opendev.org/t/openstack/build/098390e4f7494248b343a463cf21b766 : SUCCESS in 21m 22s\n- bifrost-integration-tinyipa-centos-8 https://zuul.opendev.org/t/openstack/build/3da58d84f1944c8ba8e2cb2b3f607834 : SUCCESS in 26m 12s\n- bifrost-integration-tinyipa-keystone-ubuntu-focal https://zuul.opendev.org/t/openstack/build/e02114a3b40746789de1c924f70a4684 : SUCCESS in 25m 06s\n- bifrost-integration-tinyipa-keystone-centos-8 https://zuul.opendev.org/t/openstack/build/42b539d1198a49f1a9404851bcea436f : SUCCESS in 27m 43s\n- bifrost-integration-redfish-vmedia-uefi-ubuntu-focal https://zuul.opendev.org/t/openstack/build/9c94c25392cd45e0b73cd295e81627d6 : SUCCESS in 17m 05s\n- bifrost-integration-redfish-vmedia-uefi-centos-8 https://zuul.opendev.org/t/openstack/build/64b5d27c388648ffb0a71537e0ffce57 : SUCCESS in 23m 59s\n- bifrost-integration-tinyipa-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/4fe4c0ef03c14456938ac393d21b1483 : SUCCESS in 24m 39s (non-voting)\n- bifrost-integration-tinyipa-opensuse-15 https://zuul.opendev.org/t/openstack/build/ebfa25e4650a43408367004bd509af54 : SUCCESS in 21m 49s (non-voting)\n- bifrost-integration-tinyipa-fedora-latest https://zuul.opendev.org/t/openstack/build/d7dde03d77c34ae8bf7e282e0e0918c6 : SUCCESS in 21m 48s (non-voting)\n- bifrost-integration-tinyipa-debian-buster https://zuul.opendev.org/t/openstack/build/89f32e198a2c46629047dc3251e8d042 : SUCCESS in 24m 22s (non-voting)\n- bifrost-integration-redfish-uefi-fedora-latest https://zuul.opendev.org/t/openstack/build/8a4a7a5cf1314f35a3a34d0526231033 : SUCCESS in 25m 27s (non-voting)\n- bifrost-integration-dhcp-ubuntu-focal https://zuul.opendev.org/t/openstack/build/2e03fd3458864e7983d8e99fbda9ab25 : SUCCESS in 28m 15s (non-voting)\n- bifrost-integration-dhcp-centos-8 https://zuul.opendev.org/t/openstack/build/3aba8801e2f547448cf9726ecbe3c982 : SUCCESS in 32m 16s (non-voting)\n- bifrost-integration-dibipa-debian-ubuntu-focal https://zuul.opendev.org/t/openstack/build/41ef5334187643e2bfd300df285d237d : SUCCESS in 35m 35s (non-voting)\n- bifrost-integration-dibipa-debian-centos-8 https://zuul.opendev.org/t/openstack/build/43e55e0ff2974f22a6a6b4f29b8dfa68 : SUCCESS in 40m 47s (non-voting)\n- bifrost-cli-ubuntu-focal https://zuul.opendev.org/t/openstack/build/064bc653c6a9431caa17d76a55ab35d6 : SUCCESS in 23m 29s (non-voting)\n- bifrost-collections-src https://zuul.opendev.org/t/openstack/build/dba46cf1283c4a468d0469b08eb8eb6b : SUCCESS in 25m 58s (non-voting)\n- bifrost-keystone-collections-src https://zuul.opendev.org/t/openstack/build/14082837f881454988cf429326eede85 : SUCCESS in 25m 25s (non-voting)\n- kolla-ansible-centos8-source-bifrost https://zuul.opendev.org/t/openstack/build/87137933f0474cf086bcce4b7f8d291b : SUCCESS in 32m 51s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"b4e95c4fc4ba078ef6ab5000e42a169d07afba7a","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2020-12-01 13:48:34.000000000","message":"Patch Set 3: Code-Review+2\n\nthanks!","accounts_in_message":[],"_revision_number":3},{"id":"ed0cdd2e3fe51dd36ea90e075cf673d92cf04bcf","author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"date":"2020-12-03 21:56:48.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"8c61b137c4072e56a2a4f1d0f1b60bcf1578370b","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-12-03 21:57:02.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"cc453e3e07a5a1975fd8d85c1d94cc55b2835c66","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-12-03 22:34:44.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/44ef2da969f94741a21a336158f1e54b : SUCCESS in 3m 18s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/77f0376b05604060b4e619ff935c8aaa : SUCCESS in 3m 46s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/b9b5ac60828d4c36a0e52a91383653b7 : SUCCESS in 4m 15s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/13b5af6fd68a41df99c247e75e29b566 : SUCCESS in 5m 01s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/61153d245a7340089316a1d0492231ac : SUCCESS in 5m 18s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/0c9273452698419f8fb0901b8b130e77 : SUCCESS in 9m 37s\n- bifrost-tox-linters https://zuul.opendev.org/t/openstack/build/5258f1780b5a48cfb16f4f8073d6205d : SUCCESS in 7m 51s\n- bifrost-integration-tinyipa-ubuntu-focal https://zuul.opendev.org/t/openstack/build/3482f5dd8d414267a6a966e1c9e48cb7 : SUCCESS in 23m 53s\n- bifrost-integration-tinyipa-centos-8 https://zuul.opendev.org/t/openstack/build/cb8aae713845420cb32ac80561e57be9 : SUCCESS in 27m 29s\n- bifrost-integration-tinyipa-keystone-ubuntu-focal https://zuul.opendev.org/t/openstack/build/0bba17656ca34b458abffd37711839fa : SUCCESS in 27m 59s\n- bifrost-integration-tinyipa-keystone-centos-8 https://zuul.opendev.org/t/openstack/build/4ada3bb60b65431991663436d207c4cc : SUCCESS in 30m 50s","accounts_in_message":[],"_revision_number":3},{"id":"cf2cadee4b0a967dcfa5e3dceff7e099680b45ae","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-12-03 22:34:44.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3},{"id":"0c8d91e1ba54824056670451f3d1d3c3800e2614","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-12-03 22:36:06.000000000","message":"Patch Set 3:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5bef8d038c1a42d7befa8d6bd8570e17 : SUCCESS in 57s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/f8527614c8ea4976bc2d7d5205ea21ce : SUCCESS in 55s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"71e26d17283bfce7deebb36e0980b0d92f285abf","revisions":{"1e95603e7fca668d59282487e35210d80df2e3cb":{"kind":"REWORK","_number":1,"created":"2020-11-26 15:39:18.000000000","uploader":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"ref":"refs/changes/57/764357/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/bifrost","ref":"refs/changes/57/764357/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/bifrost refs/changes/57/764357/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/bifrost refs/changes/57/764357/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/bifrost refs/changes/57/764357/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/bifrost refs/changes/57/764357/1"}}},"commit":{"parents":[{"commit":"b5e21287a5b1d4d03c700152991374dc1bb317d6","subject":"Merge \"Support UEFI in bifrost-cli and document it\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/bifrost/commit/b5e21287a5b1d4d03c700152991374dc1bb317d6"}]}],"author":{"name":"Mark Goddard","email":"mark@stackhpc.com","date":"2020-11-26 15:34:01.000000000","tz":0},"committer":{"name":"Mark Goddard","email":"mark@stackhpc.com","date":"2020-11-26 15:37:42.000000000","tz":0},"subject":"Fix missing node facts with BIFROST_INVENTORY_SOURCE\u003dironic","message":"Fix missing node facts with BIFROST_INVENTORY_SOURCE\u003dironic\n\nIn Ussuri and earlier releases, the Bifrost custom inventory returns all\nnode fields as facts. Currently, most of these are returned as null.\nThis happened following the switch to openstacksdk. The plugin checks\nfor the presence of a properties field, and gets detailed node\ninformation if it is missing. This worked with shade, but with\nopenstacksdk, the returned node object has most fields present but set\nto null.\n\nOne of the most obvious consequences is that provisioning fails, since\nit tries to use the instance_info value of null.\n\nThis change fixes the issue by removing the check and always getting the\ndetailed node information.\n\nChange-Id: Ia87c8332994f3b0f037ada953a299987bba246e5\nStory: 2008394\nTask: 41321\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/bifrost/commit/1e95603e7fca668d59282487e35210d80df2e3cb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/bifrost/commit/1e95603e7fca668d59282487e35210d80df2e3cb"}]},"branch":"refs/heads/master"},"e64ea5c0b64721144238579f46282893643a4efb":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2020-11-26 15:39:54.000000000","uploader":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"ref":"refs/changes/57/764357/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/bifrost","ref":"refs/changes/57/764357/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/bifrost refs/changes/57/764357/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/bifrost refs/changes/57/764357/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/bifrost refs/changes/57/764357/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/bifrost refs/changes/57/764357/2"}}},"commit":{"parents":[{"commit":"b5e21287a5b1d4d03c700152991374dc1bb317d6","subject":"Merge \"Support UEFI in bifrost-cli and document it\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/bifrost/commit/b5e21287a5b1d4d03c700152991374dc1bb317d6"}]}],"author":{"name":"Mark Goddard","email":"mark@stackhpc.com","date":"2020-11-26 15:34:01.000000000","tz":0},"committer":{"name":"Mark Goddard","email":"mark@stackhpc.com","date":"2020-11-26 15:39:26.000000000","tz":0},"subject":"Fix missing node facts with BIFROST_INVENTORY_SOURCE\u003dironic","message":"Fix missing node facts with BIFROST_INVENTORY_SOURCE\u003dironic\n\nIn Ussuri and earlier releases, the Bifrost custom inventory returns all\nnode fields as facts. Currently, most of these are returned as null.\nThis happened following the switch to openstacksdk. The plugin checks\nfor the presence of a properties field, and gets detailed node\ninformation if it is missing. This worked with shade, but with\nopenstacksdk, the returned node object has most fields present but set\nto null.\n\nOne of the most obvious consequences is that provisioning fails, since\nthe \u0027Deploy to hardware - Using custom instance_info.\u0027 task tries to use\nthe instance_info value of null.\n\nThis change fixes the issue by removing the check and always getting the\ndetailed node information.\n\nChange-Id: Ia87c8332994f3b0f037ada953a299987bba246e5\nStory: 2008394\nTask: 41321\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/bifrost/commit/e64ea5c0b64721144238579f46282893643a4efb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/bifrost/commit/e64ea5c0b64721144238579f46282893643a4efb"}]},"branch":"refs/heads/master"},"71e26d17283bfce7deebb36e0980b0d92f285abf":{"kind":"REWORK","_number":3,"created":"2020-11-27 12:20:51.000000000","uploader":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"ref":"refs/changes/57/764357/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/bifrost","ref":"refs/changes/57/764357/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/bifrost refs/changes/57/764357/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/bifrost refs/changes/57/764357/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/bifrost refs/changes/57/764357/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/bifrost refs/changes/57/764357/3"}}},"commit":{"parents":[{"commit":"b5e21287a5b1d4d03c700152991374dc1bb317d6","subject":"Merge \"Support UEFI in bifrost-cli and document it\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/bifrost/commit/b5e21287a5b1d4d03c700152991374dc1bb317d6"}]}],"author":{"name":"Mark Goddard","email":"mark@stackhpc.com","date":"2020-11-26 15:34:01.000000000","tz":0},"committer":{"name":"Mark Goddard","email":"mark@stackhpc.com","date":"2020-11-27 12:19:52.000000000","tz":0},"subject":"Fix missing node facts with BIFROST_INVENTORY_SOURCE\u003dironic","message":"Fix missing node facts with BIFROST_INVENTORY_SOURCE\u003dironic\n\nIn Ussuri and earlier releases, the Bifrost custom inventory returns all\nnode fields as facts. Currently, most of these are returned as null.\nThis happened following the switch to openstacksdk. The plugin checks\nfor the presence of a properties field, and gets detailed node\ninformation if it is missing. This worked with shade, but with\nopenstacksdk, the returned node object has most fields present but set\nto null.\n\nOne of the most obvious consequences is that provisioning fails, since\nthe \u0027Deploy to hardware - Using custom instance_info.\u0027 task tries to use\nthe instance_info value of null.\n\nThis change fixes the issue by removing the check and always getting the\ndetailed node information.\n\nChange-Id: Ia87c8332994f3b0f037ada953a299987bba246e5\nStory: 2008394\nTask: 41321\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/bifrost/commit/71e26d17283bfce7deebb36e0980b0d92f285abf"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/bifrost/commit/71e26d17283bfce7deebb36e0980b0d92f285abf"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}