)]}'
{"id":"openstack%2Fbifrost~765938","triplet_id":"openstack%2Fbifrost~bugfix%2F8.2~Ia87c8332994f3b0f037ada953a299987bba246e5","project":"openstack/bifrost","branch":"bugfix/8.2","hashtags":[],"change_id":"Ia87c8332994f3b0f037ada953a299987bba246e5","subject":"Fix missing node facts with BIFROST_INVENTORY_SOURCE\u003dironic","status":"ABANDONED","created":"2020-12-08 09:28:00.000000000","updated":"2021-03-22 17:38:33.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"cherry_pick_of_change":764357,"cherry_pick_of_patch_set":3,"meta_rev_id":"850be9d64a97a1f736e3bec9931dfafe16ead1b5","_number":765938,"virtual_id_number":765938,"owner":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"tag":"autogenerated:zuul:check","value":-1,"date":"2020-12-08 09:52:33.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":32029,"name":"likui","email":"likui@yovole.com","username":"likui"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"recommended":{"_account_id":32029,"name":"likui","email":"likui@yovole.com","username":"likui"},"all":[{"value":2,"date":"2020-12-08 09:29:43.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2020-12-08 09:43:42.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":32029,"name":"likui","email":"likui@yovole.com","username":"likui"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"all":[{"value":1,"date":"2020-12-08 09:29:43.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":32029,"name":"likui","email":"likui@yovole.com","username":"likui"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"_account_id":32029,"name":"likui","email":"likui@yovole.com","username":"likui"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-12-08 09:29:43.000000000","updated_by":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"reviewer":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"state":"REVIEWER"},{"updated":"2020-12-08 09:43:42.000000000","updated_by":{"_account_id":32029,"name":"likui","email":"likui@yovole.com","username":"likui"},"reviewer":{"_account_id":32029,"name":"likui","email":"likui@yovole.com","username":"likui"},"state":"REVIEWER"},{"updated":"2020-12-08 09:52:33.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"286380073b9b59642570c79be1cbf1593ce00446","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"date":"2020-12-08 09:28:00.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"71b3eea9be0994280efc5ea5b5c218429d55be1a","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2020-12-08 09:29:43.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"e3ffa34b858730bea4e968fa32f47b53769084ed","author":{"_account_id":32029,"name":"likui","email":"likui@yovole.com","username":"likui"},"date":"2020-12-08 09:43:42.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"8f1e5e704f1c4e8ccb6b89004d528517f54eb47d","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-12-08 09:52:33.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/7fb17ec1aee4436b94afed0a4f12e01c : SUCCESS in 4m 07s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/967c6020cb924afea69be71558d3a1b1 : SUCCESS in 4m 10s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/6d4e1635fb9a4b9d86a669377eec4b15 : SUCCESS in 4m 18s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/26db355976af4dec9ddaa19223c813c4 : FAILURE in 3m 37s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/38cdb00c8bf14c9eb3ee9a0f23bbcaef : SUCCESS in 6m 23s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/a6fe0b6884f442c4a6d7e59cf2b7efb2 : SUCCESS in 4m 09s\n- bifrost-integration-tinyipa-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/bf331165becf45dc9e00a63b9929bdd5 : FAILURE in 16m 18s\n- bifrost-integration-tinyipa-centos-8 https://zuul.opendev.org/t/openstack/build/9b13e61bacce45feadd08eff7a2daba8 : FAILURE in 7m 25s\n- bifrost-integration-tinyipa-keystone-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/420ce7b7e69c4168bd3e582b505b4e07 : FAILURE in 14m 59s\n- bifrost-integration-tinyipa-keystone-centos-8 https://zuul.opendev.org/t/openstack/build/dabf528b47ab418a8a405393be0f8445 : FAILURE in 9m 20s\n- bifrost-integration-tinyipa-ubuntu-focal https://zuul.opendev.org/t/openstack/build/b36aef73a69d456ca435420fa88e5b06 : FAILURE in 15m 27s (non-voting)\n- bifrost-integration-tinyipa-opensuse-15 https://zuul.opendev.org/t/openstack/build/6532c84fc44b44d4a41f7b14c62118f8 : FAILURE in 4m 15s (non-voting)\n- bifrost-integration-tinyipa-fedora-latest https://zuul.opendev.org/t/openstack/build/22ac7f0b000e4d419ca13ec2dc68c777 : FAILURE in 6m 44s (non-voting)\n- bifrost-integration-tinyipa-debian-buster https://zuul.opendev.org/t/openstack/build/216027fd00a54cf89f9d348f1f1e0dd4 : FAILURE in 13m 26s (non-voting)\n- bifrost-integration-dhcp-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/5f62c03cfb8e4f4e8af5a2f574af3fdb : FAILURE in 17m 08s (non-voting)\n- bifrost-integration-dhcp-centos-8 https://zuul.opendev.org/t/openstack/build/4ef1c40c11bf460fa32960663be48daa : FAILURE in 7m 24s (non-voting)\n- bifrost-integration-dibipa-debian-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/0b46dcead9f84fdcb012d18b0161ed52 : FAILURE in 14m 24s (non-voting)\n- bifrost-integration-dibipa-debian-centos-8 https://zuul.opendev.org/t/openstack/build/95f5b75202454509b7a1c8aafab560ec : FAILURE in 8m 06s (non-voting)\n- bifrost-cli-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/672e72233e0c469bb4ae979b3cf23fef : FAILURE in 19m 01s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"b011921ac7dfca25e5576cdb4d03ed70c310cb25","author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"date":"2021-02-03 10:55:54.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"4af1efd7a38d7825211036e5a1b0d1f0a2508fff","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-03 11:50:56.000000000","message":"Patch Set 1:\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/5a052999227c454192c6a0f4ec40472f : SUCCESS in 3m 47s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/e99887a67d7c4a609d84c8fd03876114 : SUCCESS in 3m 55s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/dc4eb014b18e4ba691d4f5274d76f7e2 : SUCCESS in 3m 50s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/5b2328e550d047a48c262f1df2278e01 : FAILURE in 3m 52s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/da70c5409a3a4467a85f98a938f1403f : SUCCESS in 5m 30s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/ce86a6ca36fc456ab9d492a6b074d216 : SUCCESS in 3m 31s\n- bifrost-integration-tinyipa-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/1a1266370b20475d8166be97a0675c4e : FAILURE in 16m 24s\n- bifrost-integration-tinyipa-centos-8 https://zuul.opendev.org/t/openstack/build/f758edb3261143f0bfb0e358f2ee1c24 : FAILURE in 26m 55s\n- bifrost-integration-tinyipa-keystone-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/3b5660c1cd8f41f39e970d5023a8137b : FAILURE in 11m 26s\n- bifrost-integration-tinyipa-keystone-centos-8 https://zuul.opendev.org/t/openstack/build/79f95235f5844b62a1f509fb785e261a : FAILURE in 19m 59s\n- bifrost-integration-tinyipa-ubuntu-focal https://zuul.opendev.org/t/openstack/build/d05bd10734ac4eb2a6e3528a59d9cb80 : FAILURE in 15m 08s (non-voting)\n- bifrost-integration-tinyipa-opensuse-15 https://zuul.opendev.org/t/openstack/build/4362a725cdde4959922499a32de861e5 : FAILURE in 4m 02s (non-voting)\n- bifrost-integration-tinyipa-fedora-latest https://zuul.opendev.org/t/openstack/build/d3e4a48ff8a6400fbe407024bea2af3b : FAILURE in 6m 15s (non-voting)\n- bifrost-integration-tinyipa-debian-buster https://zuul.opendev.org/t/openstack/build/d2585c7ae4c941faa2a158741f648130 : FAILURE in 17m 35s (non-voting)\n- bifrost-integration-dhcp-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/3b7bd90a3d28494db06e8e75e1daa825 : FAILURE in 17m 26s (non-voting)\n- bifrost-integration-dhcp-centos-8 https://zuul.opendev.org/t/openstack/build/54b3e4582b844e9ab591b7bc9dd3a2d0 : FAILURE in 47m 03s (non-voting)\n- bifrost-integration-dibipa-debian-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/1f2f0837787941f1bed445584c06077d : FAILURE in 26m 53s (non-voting)\n- bifrost-integration-dibipa-debian-centos-8 https://zuul.opendev.org/t/openstack/build/741d75d5b6d5447d9386eb3876ed7bc1 : FAILURE in 49m 21s (non-voting)\n- bifrost-cli-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/37bf7121f1f441ccaa2a9b8a0eaea9af : FAILURE in 18m 39s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"850be9d64a97a1f736e3bec9931dfafe16ead1b5","tag":"autogenerated:gerrit:abandon","author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"date":"2021-03-22 17:38:33.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"a356d489fa3a578e0d639907ae37dd90a565ec4c","revisions":{"a356d489fa3a578e0d639907ae37dd90a565ec4c":{"kind":"REWORK","_number":1,"created":"2020-12-08 09:28:00.000000000","uploader":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"ref":"refs/changes/38/765938/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/bifrost","ref":"refs/changes/38/765938/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/bifrost refs/changes/38/765938/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/bifrost refs/changes/38/765938/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/bifrost refs/changes/38/765938/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/bifrost refs/changes/38/765938/1"}}},"commit":{"parents":[{"commit":"7bc684c2135edad592e766eb25c6e67b0ce8aa23","subject":"Add correct SELinux context for /tftpboot and fix map-file ACL","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/bifrost/commit/7bc684c2135edad592e766eb25c6e67b0ce8aa23"}]}],"author":{"name":"Mark Goddard","email":"mark@stackhpc.com","date":"2020-11-26 15:34:01.000000000","tz":0},"committer":{"name":"Mark Goddard","email":"mark@stackhpc.com","date":"2020-12-08 09:28:00.000000000","tz":0},"subject":"Fix missing node facts with BIFROST_INVENTORY_SOURCE\u003dironic","message":"Fix missing node facts with BIFROST_INVENTORY_SOURCE\u003dironic\n\nIn Ussuri and earlier releases, the Bifrost custom inventory returns all\nnode fields as facts. Currently, most of these are returned as null.\nThis happened following the switch to openstacksdk. The plugin checks\nfor the presence of a properties field, and gets detailed node\ninformation if it is missing. This worked with shade, but with\nopenstacksdk, the returned node object has most fields present but set\nto null.\n\nOne of the most obvious consequences is that provisioning fails, since\nthe \u0027Deploy to hardware - Using custom instance_info.\u0027 task tries to use\nthe instance_info value of null.\n\nThis change fixes the issue by removing the check and always getting the\ndetailed node information.\n\nChange-Id: Ia87c8332994f3b0f037ada953a299987bba246e5\nStory: 2008394\nTask: 41321\n(cherry picked from commit 71e26d17283bfce7deebb36e0980b0d92f285abf)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/bifrost/commit/a356d489fa3a578e0d639907ae37dd90a565ec4c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/bifrost/commit/a356d489fa3a578e0d639907ae37dd90a565ec4c"}]},"branch":"refs/heads/bugfix/8.2"}},"requirements":[],"submit_records":[],"submit_requirements":[]}