)]}'
{"id":"openstack%2Fbifrost~765939","triplet_id":"openstack%2Fbifrost~bugfix%2F8.3~Ia87c8332994f3b0f037ada953a299987bba246e5","project":"openstack/bifrost","branch":"bugfix/8.3","hashtags":[],"change_id":"Ia87c8332994f3b0f037ada953a299987bba246e5","subject":"Fix missing node facts with BIFROST_INVENTORY_SOURCE\u003dironic","status":"ABANDONED","created":"2020-12-08 09:29:02.000000000","updated":"2021-03-22 17:40:41.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"cherry_pick_of_change":764357,"cherry_pick_of_patch_set":3,"meta_rev_id":"ec51dbd4b83ec55d4eed9aab37719fabb37fa790","_number":765939,"virtual_id_number":765939,"owner":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"tag":"autogenerated:zuul:check","value":-1,"date":"2020-12-08 10:38:44.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":32029,"name":"likui","email":"likui@yovole.com","username":"likui"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"all":[{"value":2,"date":"2020-12-08 09:29:37.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2020-12-08 09:43:51.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":32029,"name":"likui","email":"likui@yovole.com","username":"likui"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"all":[{"value":1,"date":"2020-12-08 09:29:37.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":32029,"name":"likui","email":"likui@yovole.com","username":"likui"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},{"_account_id":32029,"name":"likui","email":"likui@yovole.com","username":"likui"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-12-08 09:29:37.000000000","updated_by":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"reviewer":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"state":"REVIEWER"},{"updated":"2020-12-08 09:43:51.000000000","updated_by":{"_account_id":32029,"name":"likui","email":"likui@yovole.com","username":"likui"},"reviewer":{"_account_id":32029,"name":"likui","email":"likui@yovole.com","username":"likui"},"state":"REVIEWER"},{"updated":"2020-12-08 10:38:44.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"0d853b149770b6f01b5032f1cd2b97f7c98a699c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"date":"2020-12-08 09:29:02.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"4aa51c7accf1b56bd97f516707dbaaeb4c517a4c","author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"date":"2020-12-08 09:29:37.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"353ea8a23c2c64b6ac7958695f819d5d50586e8c","author":{"_account_id":32029,"name":"likui","email":"likui@yovole.com","username":"likui"},"date":"2020-12-08 09:43:51.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"d10b51297a6790af875c253c28148565fd886271","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-12-08 10:38:44.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/678927a9682e4382bc4a659dd10fc204 : SUCCESS in 3m 53s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/6b3aec3481114aaea96d7999e79662e9 : SUCCESS in 4m 18s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/a40fdc91ee2e4b9e9aa6595317171972 : SUCCESS in 3m 44s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/3ee7942ccade4461846284bef21a5764 : FAILURE in 2m 58s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/bd33552a2742454496c5c95c8daf791f : SUCCESS in 6m 53s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/b7750f1b49da48639cdd05f8fc4a7438 : SUCCESS in 3m 57s\n- bifrost-integration-tinyipa-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/6d857e850233434db9dea23e11cfdb5e : SUCCESS in 21m 55s\n- bifrost-integration-tinyipa-centos-8 https://zuul.opendev.org/t/openstack/build/62ae98e29cd049faba7ba3d4113c4083 : FAILURE in 6m 21s\n- bifrost-integration-tinyipa-keystone-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/8173e4f7158145ca91ab7d4d27517888 : SUCCESS in 25m 16s\n- bifrost-integration-tinyipa-keystone-centos-8 https://zuul.opendev.org/t/openstack/build/ad473082c52f41769a29bd75cda45093 : FAILURE in 7m 14s\n- bifrost-integration-tinyipa-ubuntu-focal https://zuul.opendev.org/t/openstack/build/ac9c41da29984e2eb0c218499e081e87 : SUCCESS in 22m 43s (non-voting)\n- bifrost-integration-tinyipa-opensuse-15 https://zuul.opendev.org/t/openstack/build/8949418dacc546fa8172fb9fb3d6ec24 : FAILURE in 3m 53s (non-voting)\n- bifrost-integration-tinyipa-fedora-latest https://zuul.opendev.org/t/openstack/build/3f74f3fe20334c8fac1607e03f06d2f5 : FAILURE in 43m 41s (non-voting)\n- bifrost-integration-tinyipa-debian-buster https://zuul.opendev.org/t/openstack/build/1d83122aa5a24e4ca1d35dc05f3fa964 : SUCCESS in 22m 58s (non-voting)\n- bifrost-integration-dhcp-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/fd299b3599844e56a43f0196a390466d : SUCCESS in 20m 58s (non-voting)\n- bifrost-integration-dhcp-centos-8 https://zuul.opendev.org/t/openstack/build/f8573bd095c54c00a0dcea07619d5ba7 : FAILURE in 9m 40s (non-voting)\n- bifrost-integration-dibipa-debian-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/919069c5e52d40e4a32f95068be7e781 : FAILURE in 16m 04s (non-voting)\n- bifrost-integration-dibipa-debian-centos-8 https://zuul.opendev.org/t/openstack/build/9a4ff9d6124948d69b47d5826a30c79c : FAILURE in 7m 12s (non-voting)\n- bifrost-cli-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/da566ac7ab2541e8ae7df6d627a6259d : SUCCESS in 23m 10s (non-voting)\n- bifrost-collections-src https://zuul.opendev.org/t/openstack/build/43aed97ad02545648be3b095efa8f47b : SUCCESS in 23m 38s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"78f961afda5205351973c12e06fcebed8b1974aa","author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"date":"2020-12-17 10:56:44.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"3f6dca0f437d56af98390db874e0381bd5af3335","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-12-17 11:50:51.000000000","message":"Patch Set 1:\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/db9c52adb18340c3949b56bd22bb1a54 : SUCCESS in 5m 00s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/1c72423836c34dc98f53e61933290d1c : SUCCESS in 3m 58s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/24a85b3792d9403eace6299e35cf0fed : SUCCESS in 3m 40s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/8db5171be7944b05a352b64eef24091e : FAILURE in 2m 57s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/979b6c8b29564fcf9aa8ba5452a54b41 : SUCCESS in 6m 36s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/5b7bfc16dc45461b9d5f79b9c3fd64ba : SUCCESS in 4m 16s\n- bifrost-integration-tinyipa-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/f5441dbf160c4d91a831980281170370 : SUCCESS in 25m 54s\n- bifrost-integration-tinyipa-centos-8 https://zuul.opendev.org/t/openstack/build/2f1dfd1457cf47a0aa5286900a7ecab7 : FAILURE in 42m 06s\n- bifrost-integration-tinyipa-keystone-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/6f5f4003ee6c4112bf30c9a052b878bd : SUCCESS in 23m 41s\n- bifrost-integration-tinyipa-keystone-centos-8 https://zuul.opendev.org/t/openstack/build/bfca476a44df47f6a5adabea2e177d48 : FAILURE in 45m 33s\n- bifrost-integration-tinyipa-ubuntu-focal https://zuul.opendev.org/t/openstack/build/ecbec6a22ea24321aa5db405c9c2ba77 : SUCCESS in 26m 44s (non-voting)\n- bifrost-integration-tinyipa-opensuse-15 https://zuul.opendev.org/t/openstack/build/0a995ae75c27429d97bcabbc741bd3f1 : FAILURE in 3m 59s (non-voting)\n- bifrost-integration-tinyipa-fedora-latest https://zuul.opendev.org/t/openstack/build/dc6d528146684666b477ae2499b245cf : FAILURE in 45m 20s (non-voting)\n- bifrost-integration-tinyipa-debian-buster https://zuul.opendev.org/t/openstack/build/458e039fe0f74b27b34d38f9111a6250 : SUCCESS in 21m 15s (non-voting)\n- bifrost-integration-dhcp-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/c2868d0edbd24e89bc5c3401fd5f2e47 : SUCCESS in 22m 55s (non-voting)\n- bifrost-integration-dhcp-centos-8 https://zuul.opendev.org/t/openstack/build/88f6dedbb0954716810afa8227c07b5d : FAILURE in 26m 39s (non-voting)\n- bifrost-integration-dibipa-debian-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/813c97253d6b44a5ac262cb542812416 : SUCCESS in 32m 55s (non-voting)\n- bifrost-integration-dibipa-debian-centos-8 https://zuul.opendev.org/t/openstack/build/157df6de46b142d08abdb1916ac19246 : FAILURE in 35m 30s (non-voting)\n- bifrost-cli-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/0f0c52dee3bd4e1786247d588cf3a49f : SUCCESS in 21m 27s (non-voting)\n- bifrost-collections-src https://zuul.opendev.org/t/openstack/build/3798b13868bb4c629451c0d6094fe380 : SUCCESS in 21m 05s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"1cd7c9b2622b5da374901db0c58b3f9bc70cfe90","author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"date":"2021-01-05 11:02:12.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"31b765cf8b66d981e1eab1e8803404e54c5e7138","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-05 11:56:51.000000000","message":"Patch Set 1:\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a7a90b5da3b54519acc9dd7fd5d302de : SUCCESS in 3m 32s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/15145a1723e94d768df36a1a65ad7ce1 : SUCCESS in 3m 14s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/3304b8bae9d8441c8103a6b391c0ccd9 : SUCCESS in 4m 51s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/bcbe816aadc94129a6eeb6bbed473413 : FAILURE in 4m 07s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e2d9702c436e421b890ffda7e2b18afa : SUCCESS in 16m 05s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/4cd36c5b516348cd8389d51426eebfbb : SUCCESS in 3m 12s\n- bifrost-integration-tinyipa-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/4d10b19a1b454e679741f6c3c727d808 : SUCCESS in 25m 14s\n- bifrost-integration-tinyipa-centos-8 https://zuul.opendev.org/t/openstack/build/45bd0cd53702422e806e934d65898532 : FAILURE in 42m 02s\n- bifrost-integration-tinyipa-keystone-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/2a568a2b4c80429e8b342886b95d0493 : FAILURE in 10m 51s\n- bifrost-integration-tinyipa-keystone-centos-8 https://zuul.opendev.org/t/openstack/build/86457a70c812447ea77bb99333f8b71b : FAILURE in 52m 46s\n- bifrost-integration-tinyipa-ubuntu-focal https://zuul.opendev.org/t/openstack/build/6d8e2b5dc9434ffca08e1e834081f2af : SUCCESS in 18m 58s (non-voting)\n- bifrost-integration-tinyipa-opensuse-15 https://zuul.opendev.org/t/openstack/build/1d9a71658bfd437d94850660590bdc2f : FAILURE in 4m 44s (non-voting)\n- bifrost-integration-tinyipa-fedora-latest https://zuul.opendev.org/t/openstack/build/3c9788e654234cb88e1e15792c263858 : FAILURE in 47m 03s (non-voting)\n- bifrost-integration-tinyipa-debian-buster https://zuul.opendev.org/t/openstack/build/48264883bd0347b6a90fb757e0b7cf43 : SUCCESS in 17m 18s (non-voting)\n- bifrost-integration-dhcp-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/ccaba5d7b4e84f1ba4c8e4f7079d9310 : FAILURE in 5m 10s (non-voting)\n- bifrost-integration-dhcp-centos-8 https://zuul.opendev.org/t/openstack/build/b02df77b7cab4ed58dd858d3601e111d : FAILURE in 27m 43s (non-voting)\n- bifrost-integration-dibipa-debian-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/b7da4ea8b72e4b95945387000a9543e6 : SUCCESS in 35m 33s (non-voting)\n- bifrost-integration-dibipa-debian-centos-8 https://zuul.opendev.org/t/openstack/build/f038da90063642adbf2b81957074a0d4 : FAILURE in 35m 02s (non-voting)\n- bifrost-cli-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/1cd84025f02b4ad2ae2f785f52d34872 : SUCCESS in 23m 14s (non-voting)\n- bifrost-collections-src https://zuul.opendev.org/t/openstack/build/03f0bf58c88e44afbc732a8dd9945e83 : SUCCESS in 21m 53s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"ec51dbd4b83ec55d4eed9aab37719fabb37fa790","tag":"autogenerated:gerrit:abandon","author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"date":"2021-03-22 17:40:41.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"5b1e28dcf26836f17c86419dbbf1457a77d01c84","revisions":{"5b1e28dcf26836f17c86419dbbf1457a77d01c84":{"kind":"REWORK","_number":1,"created":"2020-12-08 09:29:02.000000000","uploader":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"ref":"refs/changes/39/765939/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/bifrost","ref":"refs/changes/39/765939/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/bifrost refs/changes/39/765939/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/bifrost refs/changes/39/765939/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/bifrost refs/changes/39/765939/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/bifrost refs/changes/39/765939/1"}}},"commit":{"parents":[{"commit":"eaa00202d5172494cd75f25a58eb95cdfdd7884a","subject":"Fix l-c testing for Ubuntu Focal (py38)","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/bifrost/commit/eaa00202d5172494cd75f25a58eb95cdfdd7884a"}]}],"author":{"name":"Mark Goddard","email":"mark@stackhpc.com","date":"2020-11-26 15:34:01.000000000","tz":0},"committer":{"name":"Mark Goddard","email":"mark@stackhpc.com","date":"2020-12-08 09:29:02.000000000","tz":0},"subject":"Fix missing node facts with BIFROST_INVENTORY_SOURCE\u003dironic","message":"Fix missing node facts with BIFROST_INVENTORY_SOURCE\u003dironic\n\nIn Ussuri and earlier releases, the Bifrost custom inventory returns all\nnode fields as facts. Currently, most of these are returned as null.\nThis happened following the switch to openstacksdk. The plugin checks\nfor the presence of a properties field, and gets detailed node\ninformation if it is missing. This worked with shade, but with\nopenstacksdk, the returned node object has most fields present but set\nto null.\n\nOne of the most obvious consequences is that provisioning fails, since\nthe \u0027Deploy to hardware - Using custom instance_info.\u0027 task tries to use\nthe instance_info value of null.\n\nThis change fixes the issue by removing the check and always getting the\ndetailed node information.\n\nChange-Id: Ia87c8332994f3b0f037ada953a299987bba246e5\nStory: 2008394\nTask: 41321\n(cherry picked from commit 71e26d17283bfce7deebb36e0980b0d92f285abf)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/bifrost/commit/5b1e28dcf26836f17c86419dbbf1457a77d01c84"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/bifrost/commit/5b1e28dcf26836f17c86419dbbf1457a77d01c84"}]},"branch":"refs/heads/bugfix/8.3"}},"requirements":[],"submit_records":[],"submit_requirements":[]}