)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1ef79c4b3d3779ad789c68c1206e0607c06b8c16","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When network mask is not specified, dnsmasq tries to guess it from given"},{"line_number":10,"context_line":"network pool. For example dnsmasq set netmask 255.0.0.0 for subnet"},{"line_number":11,"context_line":"from 10/8 network, and usually it is not what one want."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ie995d851e7e58541f0729a00c199b57493f1f970"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"79d441e9_296249d8","line":11,"updated":"2021-03-30 12:40:06.000000000","message":"Could you please add a release note for this fix? See https://docs.openstack.org/ironic/latest/contributor/faq.html#create-a-new-release-note","commit_id":"fc46386115abbccf66328a3f62be4becf1ed36b4"}],"playbooks/roles/bifrost-ironic-install/templates/dnsmasq.conf.j2":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1ef79c4b3d3779ad789c68c1206e0607c06b8c16","unresolved":false,"context_lines":[{"line_number":73,"context_line":"# router is the same machine as the one running dnsmasq."},{"line_number":74,"context_line":"{% if not (dnsmasq_router | default(True) | bool) %}"},{"line_number":75,"context_line":"{% if dnsmasq_router | ipaddr %}"},{"line_number":76,"context_line":"dhcp-option\u003d1,{{dnsmasq_netmask | default(\u0027255.255.255.0\u0027)}}"},{"line_number":77,"context_line":"dhcp-option\u003d3,{{dnsmasq_router}}"},{"line_number":78,"context_line":"{% else %}"},{"line_number":79,"context_line":"dhcp-option\u003d3"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"27cb55a9_6a3df5d0","line":76,"updated":"2021-03-30 12:40:06.000000000","message":"I\u0027m somewhat concerned about using this netmask by default, especially since the previous guessing logic could work for someone. What about this:\n\n {% if dnsmasq_netmask is defined %}\n .. your variant ..\n {% else %}\n .. old variant ..\n {% endif %}","commit_id":"fc46386115abbccf66328a3f62be4becf1ed36b4"}]}
