)]}'
{"playbooks/roles/bifrost-ironic-install/tasks/create_tftpboot.yml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f6f5f2ff9c9e62062083a0518c8b54c31840bfa1","unresolved":true,"context_lines":[{"line_number":38,"context_line":"  copy: src\u003dboot.ipxe dest\u003d/etc/ironic/boot.ipxe owner\u003dironic group\u003dironic mode\u003d0744"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"- name: \"Place tftp config file\""},{"line_number":41,"context_line":"  copy: src\u003dxinetd.tftp dest\u003d/etc/xinetd.d/tftp"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"- name: \"Download ipxe files if asked\""},{"line_number":44,"context_line":"  include: get_ipxe.yml"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7962fcbc_bbf03ff2","side":"PARENT","line":41,"updated":"2021-03-23 14:34:57.000000000","message":"Could you make sure this file is removed and xinetd (if present) is restarted? Otherwise you\u0027ll get two TFTP servers on upgrade.","commit_id":"d3cddf2b56c7f01f3f33ef05764abd4d101766c2"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"63176cdb182a40689556e11cd39b8f47d9c4813a","unresolved":true,"context_lines":[{"line_number":29,"context_line":"- name: \"Place boot.ipxe helper script /etc/ironic\""},{"line_number":30,"context_line":"  copy: src\u003dboot.ipxe dest\u003d/etc/ironic/boot.ipxe owner\u003dironic group\u003dironic mode\u003d0744"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- name: \"Find xinetd TFTP service configs\""},{"line_number":33,"context_line":"  find:"},{"line_number":34,"context_line":"    paths:"},{"line_number":35,"context_line":"    - /etc/xinetd.d"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5b449c99_f73307e7","line":32,"updated":"2021-07-30 13:25:04.000000000","message":"we should add a note to remove this at some point...","commit_id":"a2d8f81e410da197bc3e5c842d0a1d829d557e42"}],"playbooks/roles/bifrost-ironic-install/templates/dnsmasq.conf.j2":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f6f5f2ff9c9e62062083a0518c8b54c31840bfa1","unresolved":true,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"enable-tftp"},{"line_number":120,"context_line":"tftp-root\u003d/tftpboot"},{"line_number":121,"context_line":"tftp-max\u003d{{ dnsmasq_tftp_max }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"2ff5319c_1573f541","line":121,"updated":"2021-03-23 14:34:57.000000000","message":"Where is the default for this value set? And do we even need it?","commit_id":"20d55ab3bde4902d355f1de94fcb77af01f480d9"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d3f38ff800178a8b09dda4e4922c572ab70a54ac","unresolved":true,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"enable-tftp"},{"line_number":120,"context_line":"tftp-root\u003d/tftpboot"},{"line_number":121,"context_line":"tftp-max\u003d{{ dnsmasq_tftp_max | default(50) }}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"446880a8_c873ceef","line":121,"range":{"start_line":121,"start_character":12,"end_line":121,"end_character":29},"updated":"2021-06-02 15:27:10.000000000","message":"Where is dnsmasq_tftp_max coming from? I don\u0027t see it in current bifrost, nor in your patch.","commit_id":"9f71cbef619e1e393235ff4cae521530874a2ebc"}]}