)]}'
{"bifrost/cli.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"133eafbab7df207eb98be387b44e9e8752dbeed9","unresolved":false,"context_lines":[{"line_number":162,"context_line":"            developer_mode\u003dargs.develop,"},{"line_number":163,"context_line":"            enable_prometheus_exporter\u003dargs.enable_prometheus_exporter,"},{"line_number":164,"context_line":"            default_boot_mode\u003d\u0027uefi\u0027 if args.uefi else \u0027bios\u0027,"},{"line_number":165,"context_line":"            include_dhcp_server\u003dargs.disable_dhcp,"},{"line_number":166,"context_line":"            extra_vars\u003dargs.extra_vars,"},{"line_number":167,"context_line":"            **kwargs)"},{"line_number":168,"context_line":"    log(\"Ironic is installed and running, try it yourself:\\n\","}],"source_content_type":"text/x-python","patch_set":2,"id":"eda49bbb_eca21641","line":165,"updated":"2021-03-26 10:44:47.000000000","message":"not?","commit_id":"d66a3d5692b1b2f7793a04baa2880f0fb4a8ad2e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"133eafbab7df207eb98be387b44e9e8752dbeed9","unresolved":false,"context_lines":[{"line_number":256,"context_line":"                         help\u003d\u0027Enable Ironic Prometheus Exporter\u0027)"},{"line_number":257,"context_line":"    install.add_argument(\u0027--uefi\u0027, action\u003d\u0027store_true\u0027,"},{"line_number":258,"context_line":"                         help\u003d\u0027use UEFI by default\u0027)"},{"line_number":259,"context_line":"    install.add_argument(\u0027--disable-dhcp\u0027, action\u003d\u0027store_false\u0027,"},{"line_number":260,"context_line":"                         help\u003d\u0027Disable integrateed dhcp server\u0027)"},{"line_number":261,"context_line":"    install.add_argument(\u0027-e\u0027, \u0027--extra-vars\u0027, action\u003d\u0027append\u0027,"},{"line_number":262,"context_line":"                         help\u003d\u0027additional vars to pass to ansible\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"6d6d615b_09c17894","line":259,"updated":"2021-03-26 10:44:47.000000000","message":"okay, I see you logic, but it\u0027s confusing, the variable actually means the opposite thing. let\u0027s use store_true and negate the logic in install","commit_id":"d66a3d5692b1b2f7793a04baa2880f0fb4a8ad2e"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"d6551b67ef0c51b39ec52f84863d5baf5a9e748a","unresolved":false,"context_lines":[{"line_number":256,"context_line":"                         help\u003d\u0027Enable Ironic Prometheus Exporter\u0027)"},{"line_number":257,"context_line":"    install.add_argument(\u0027--uefi\u0027, action\u003d\u0027store_true\u0027,"},{"line_number":258,"context_line":"                         help\u003d\u0027use UEFI by default\u0027)"},{"line_number":259,"context_line":"    install.add_argument(\u0027--disable-dhcp\u0027, action\u003d\u0027store_false\u0027,"},{"line_number":260,"context_line":"                         help\u003d\u0027Disable integrateed dhcp server\u0027)"},{"line_number":261,"context_line":"    install.add_argument(\u0027-e\u0027, \u0027--extra-vars\u0027, action\u003d\u0027append\u0027,"},{"line_number":262,"context_line":"                         help\u003d\u0027additional vars to pass to ansible\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"b477fe5f_24590833","line":259,"in_reply_to":"6d6d615b_09c17894","updated":"2021-03-26 11:35:50.000000000","message":"ok","commit_id":"d66a3d5692b1b2f7793a04baa2880f0fb4a8ad2e"}],"playbooks/roles/bifrost-ironic-install/defaults/main.yml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"133eafbab7df207eb98be387b44e9e8752dbeed9","unresolved":false,"context_lines":[{"line_number":111,"context_line":"# By default bifrost will deploy dnsmasq to utilize as an integrated DHCP"},{"line_number":112,"context_line":"# server.  If you already have a DHCP server, you can pass --disable-dhcp"},{"line_number":113,"context_line":"# to the bifrost-cli install command to disable it."},{"line_number":114,"context_line":"include_dhcp_server: true"},{"line_number":115,"context_line":"# *_git_url can be overridden by local clones for offline installs"},{"line_number":116,"context_line":"dib_git_url: https://opendev.org/openstack/diskimage-builder"},{"line_number":117,"context_line":"ironicclient_git_url: https://opendev.org/openstack/python-ironicclient"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9e8331a9_b513377c","line":114,"updated":"2021-03-26 10:44:47.000000000","message":"This will also disable TFTP, right? Or at least once the patch making dnsmasq serve TFTP merges?","commit_id":"d66a3d5692b1b2f7793a04baa2880f0fb4a8ad2e"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"d6551b67ef0c51b39ec52f84863d5baf5a9e748a","unresolved":false,"context_lines":[{"line_number":111,"context_line":"# By default bifrost will deploy dnsmasq to utilize as an integrated DHCP"},{"line_number":112,"context_line":"# server.  If you already have a DHCP server, you can pass --disable-dhcp"},{"line_number":113,"context_line":"# to the bifrost-cli install command to disable it."},{"line_number":114,"context_line":"include_dhcp_server: true"},{"line_number":115,"context_line":"# *_git_url can be overridden by local clones for offline installs"},{"line_number":116,"context_line":"dib_git_url: https://opendev.org/openstack/diskimage-builder"},{"line_number":117,"context_line":"ironicclient_git_url: https://opendev.org/openstack/python-ironicclient"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"d65f0643_e6d5c4bf","line":114,"in_reply_to":"9e8331a9_b513377c","updated":"2021-03-26 11:35:50.000000000","message":"yes, do we want to mention it here anyway or wait for the other patch to merge? if this merges first I guess we can change the comment in the other patch","commit_id":"d66a3d5692b1b2f7793a04baa2880f0fb4a8ad2e"}]}