)]}'
{"playbooks/roles/bifrost-ironic-install/defaults/main.yml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a519596ffa7bffcd3516878058167012b3d3b71b","unresolved":false,"context_lines":[{"line_number":167,"context_line":"# since IP allocation will be static."},{"line_number":168,"context_line":"dhcp_pool_start: 192.168.1.200"},{"line_number":169,"context_line":"dhcp_pool_end: 192.168.1.250"},{"line_number":170,"context_line":"dhcp_pool_mask : \"\""},{"line_number":171,"context_line":"dhcp_lease_time: 12h"},{"line_number":172,"context_line":"dhcp_static_mask: 255.255.255.0"},{"line_number":173,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"b0a326e8_12d98023","line":170,"updated":"2021-08-18 16:07:29.000000000","message":"nit: redundant space before :","commit_id":"9f2092810a9e69805b4f0b290ea91763e59d4bfc"}],"playbooks/roles/bifrost-ironic-install/templates/dnsmasq.conf.j2":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a519596ffa7bffcd3516878058167012b3d3b71b","unresolved":false,"context_lines":[{"line_number":66,"context_line":"{% elif inventory_dhcp | bool \u003d\u003d true %}"},{"line_number":67,"context_line":"dhcp-range\u003d{{dhcp_pool_start}},static,{{dhcp_static_mask}},{{dhcp_lease_time}}"},{"line_number":68,"context_line":"{% else %}"},{"line_number":69,"context_line":"dhcp-range\u003d{{dhcp_pool_start}},{{dhcp_pool_end}},{% if dhcp_pool_mask | length \u003e 0 %}{{dhcp_mask}},{% endif %}{{dhcp_lease_time}}"},{"line_number":70,"context_line":"{% endif %}"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"# Override the default route supplied by dnsmasq, which assumes the"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"a13fb84b_9eb38c47","line":69,"updated":"2021-08-18 16:07:29.000000000","message":"s/dhcp_mask/dhcp_pool_mask/\n\nalso a nit: maybe remove the default value and use `if dhcp_pool_mask is defined`?","commit_id":"9f2092810a9e69805b4f0b290ea91763e59d4bfc"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6c95af83d8102ae94cdaf0ce2dfd1c20e6d9f48b","unresolved":true,"context_lines":[{"line_number":66,"context_line":"{% elif inventory_dhcp | bool \u003d\u003d true %}"},{"line_number":67,"context_line":"dhcp-range\u003d{{dhcp_pool_start}},static,{{dhcp_static_mask}},{{dhcp_lease_time}}"},{"line_number":68,"context_line":"{% else %}"},{"line_number":69,"context_line":"dhcp-range\u003d{{dhcp_pool_start}},{{dhcp_pool_end}},{% if dhcp_pool_mask is defined}{{dhcp_pool_mask}},{% endif %}{{dhcp_lease_time}}"},{"line_number":70,"context_line":"{% endif %}"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"# Override the default route supplied by dnsmasq, which assumes the"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"ba71f533_c1656769","line":69,"updated":"2021-08-26 12:18:04.000000000","message":"Oh, missed one thing: there is only a single } after \"defined\", has to be %}","commit_id":"78c9ade2144b5abc5f4dfb58362893f2218c554e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"5c79a9af12a96a276b49ae440594ca52a839b8a8","unresolved":true,"context_lines":[{"line_number":66,"context_line":"{% elif inventory_dhcp | bool \u003d\u003d true %}"},{"line_number":67,"context_line":"dhcp-range\u003d{{dhcp_pool_start}},static,{{dhcp_static_mask}},{{dhcp_lease_time}}"},{"line_number":68,"context_line":"{% else %}"},{"line_number":69,"context_line":"dhcp-range\u003d{{dhcp_pool_start}},{{dhcp_pool_end}},{% if dhcp_pool_mask is defined}{{dhcp_pool_mask}},{% endif %}{{dhcp_lease_time}}"},{"line_number":70,"context_line":"{% endif %}"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"# Override the default route supplied by dnsmasq, which assumes the"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"a1205239_f5dde445","line":69,"in_reply_to":"ba71f533_c1656769","updated":"2021-08-26 12:33:13.000000000","message":"Damn, me blind...","commit_id":"78c9ade2144b5abc5f4dfb58362893f2218c554e"}]}