)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"4d6aef066154df4cf04cc013172c798dc149e94c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"acf013e9_17aa89ec","updated":"2021-11-22 04:30:35.000000000","message":"recheck","commit_id":"32bafdc12e1d9150c5cd5a98e3eaf6a0b89d8a6c"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"97175123836eef08d3f7ea344cb24ca2c31c5f87","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"c9cac0c1_881a4507","updated":"2021-11-25 00:19:56.000000000","message":"recheck","commit_id":"b5b077c4d64e21b7b62b22ba74ef2e884b5063a0"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"cc771e44957192e6836e0ca242871297a239780b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"a2391a68_ff52c59a","updated":"2021-12-01 03:47:42.000000000","message":"recheck","commit_id":"1fa4bd61cf0ee1816dd0ea23bffa35c4d2b1c72f"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"cee67e87b2c19218ea93f5395da31740d861ee9f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"ce32d5d2_45e7c215","updated":"2021-12-02 01:05:46.000000000","message":"recheck","commit_id":"1fa4bd61cf0ee1816dd0ea23bffa35c4d2b1c72f"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"ee8f7501f0531da5565c500862ecb07cb685edcd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"048a011b_4ff2591b","updated":"2021-12-07 02:31:57.000000000","message":"Success! bifrost-integration-redfish-uefi-fedora-latest is green with grub network boot","commit_id":"07c2478da94169a62e605802777435021dbe780c"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"50570d6b7ee40a033182e47ccbddf8b99d8b5b36","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"b0d31e43_fc6ab600","updated":"2022-05-16 03:15:41.000000000","message":"From bifrost-integration-redfish-uefi-fedora-latest, this is close to working:\nhttps://zuul.opendev.org/t/openstack/build/f61b4a60718040f0aeccf705487e85cc/log/logs/dnsmasq.log#79\n\nI think the -2 can be removed now, this is a standalone change with no privsep","commit_id":"60b5dfa5111048fd7b15b17e4171c24706ebb6b5"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"b9d5d8bfce3f1782d74c144de3d14b326bd2bded","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"725825b6_44b4c121","in_reply_to":"2bdf9b89_b5dfb6c6","updated":"2022-05-17 22:10:14.000000000","message":"Fixed now","commit_id":"60b5dfa5111048fd7b15b17e4171c24706ebb6b5"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"cbff6917801ba474cb7987966735ed429cea902b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"2bdf9b89_b5dfb6c6","in_reply_to":"b0d31e43_fc6ab600","updated":"2022-05-17 22:09:44.000000000","message":"Its a selinux denial, I thought moving tftpboot to /var/lib would avoid this:\nhttps://zuul.opendev.org/t/openstack/build/f61b4a60718040f0aeccf705487e85cc/log/logs/all/messages#7310","commit_id":"60b5dfa5111048fd7b15b17e4171c24706ebb6b5"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"363dfa797b669046e1f51d8136998db1f1dc2504","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":42,"id":"b72e0ea7_c81c00d0","updated":"2022-08-01 13:23:44.000000000","message":"Looks good, one minor change needed I believe based upon the question Steve has left on the dnsmasq template.","commit_id":"baf43ee3dd2883ae6395ef533c4933819d40f188"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"10cfe1cc26d97712fa6ade85606cdc7b5f8c4443","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":42,"id":"7bec0b89_2c1cdaf7","updated":"2022-09-07 21:30:51.000000000","message":"This is pretty cool, thanks!","commit_id":"baf43ee3dd2883ae6395ef533c4933819d40f188"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"42642ffda7c2719a5587c2272f58b0ee2ade6e7c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":45,"id":"d4dbc26d_a4f61af3","updated":"2022-12-12 23:16:58.000000000","message":"Did you intend to remove the release note here Steve?","commit_id":"eb922141d8a948e7fc2275f91b4bfce03ada9cbb"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"734defbfd67775fb6330b264ea5aecb7db5a46e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":45,"id":"973204c0_41bb5ae1","in_reply_to":"d4dbc26d_a4f61af3","updated":"2023-01-19 00:07:19.000000000","message":"Release not has been restored","commit_id":"eb922141d8a948e7fc2275f91b4bfce03ada9cbb"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"32320c33c47a7ad47248849e3b09d17a162b10f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":46,"id":"85a30fe4_0a9fe731","updated":"2023-01-25 23:21:57.000000000","message":"recheck bifrost-upgrade-keystone-centos9","commit_id":"51d988af5408a5c0a63c1f0562d614e3112c1a79"}],"playbooks/roles/bifrost-ironic-install/defaults/required_defaults_Debian_family.yml":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"177d2b96c14b91ad9c6681728ed72cd3f5c1a46d","unresolved":true,"context_lines":[{"line_number":6,"context_line":"mysql_service_name: mysql"},{"line_number":7,"context_line":"tftp_service_name: tftpd-hpa"},{"line_number":8,"context_line":"efi_distro: debian"},{"line_number":9,"context_line":"grub_efi_binary: /usr/lib/grub/x86_64-efi-signed/grubx64.efi.signed"},{"line_number":10,"context_line":"shim_efi_binary: /usr/lib/shim/shimx64.efi.signed"},{"line_number":11,"context_line":"grub_tftp_dir: grub"},{"line_number":12,"context_line":"required_packages:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"e9689362_4280af69","line":9,"updated":"2021-09-03 02:30:01.000000000","message":"According to trying both options in this change[1], network book really needs to be done with grubnetx64.efi.signed, not grubx64.efi.signed\n\n[1] https://review.opendev.org/c/openstack/ironic/+/806808","commit_id":"583c9c9679fff2c3e4a5e21cdf40bfeda2345fe4"}],"playbooks/roles/bifrost-ironic-install/tasks/hw_types.yml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"603c9ff7226674daba173b33dd8cbf50bfa30ac7","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    default_boot_interface: pxe"},{"line_number":43,"context_line":"  when:"},{"line_number":44,"context_line":"    - default_boot_interface is undefined"},{"line_number":45,"context_line":"    - not enable_uefi_ipxe | bool"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"- name: \"Configure management interfaces if required\""},{"line_number":48,"context_line":"  set_fact:"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"03559a72_a1347ee1","line":45,"updated":"2022-05-17 15:12:38.000000000","message":"I\u0027d like to get rid of this option. Maybe use default_boot_interface in the testing scripts instead?\n\nUPD: probably impossible because of dnsmasq.conf","commit_id":"93e71dbcaa2384f874a3cbe2d213fd2ed6b01bf9"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"a33ec52680bd76dc572c2bb3f322e60d21b5738c","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    default_boot_interface: pxe"},{"line_number":43,"context_line":"  when:"},{"line_number":44,"context_line":"    - default_boot_interface is undefined"},{"line_number":45,"context_line":"    - not enable_uefi_ipxe | bool"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"- name: \"Configure management interfaces if required\""},{"line_number":48,"context_line":"  set_fact:"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"1c476edd_bb823e14","line":45,"in_reply_to":"03559a72_a1347ee1","updated":"2022-07-12 02:53:56.000000000","message":"The change before this one now removes the enable_uefi_ipxe variable","commit_id":"93e71dbcaa2384f874a3cbe2d213fd2ed6b01bf9"}],"playbooks/roles/bifrost-ironic-install/templates/dnsmasq.conf.j2":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"177d2b96c14b91ad9c6681728ed72cd3f5c1a46d","unresolved":true,"context_lines":[{"line_number":102,"context_line":"dhcp-boot\u003dtag:efi,tag:!ipxe,/{{ ipxe_efi_binary }}"},{"line_number":103,"context_line":"{% else %}"},{"line_number":104,"context_line":"# Client is PXE booting over EFI, boot with the grub shim"},{"line_number":105,"context_line":"dhcp-boot\u003dtag:efi,tag:!ipxe,/bootx64.efi"},{"line_number":106,"context_line":"{% endif %}"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"{% if testing | bool \u003d\u003d true %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"35aa0619_f189442e","line":105,"range":{"start_line":105,"start_character":23,"end_line":105,"end_character":27},"updated":"2021-09-03 02:30:01.000000000","message":"Possibly in virtualized test environments it is always iPXE running first, so this should be taken out for the grub case.","commit_id":"583c9c9679fff2c3e4a5e21cdf40bfeda2345fe4"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"603c9ff7226674daba173b33dd8cbf50bfa30ac7","unresolved":false,"context_lines":[{"line_number":97,"context_line":"dhcp-match\u003dset:efi,option:client-arch,7"},{"line_number":98,"context_line":"dhcp-match\u003dset:efi,option:client-arch,9"},{"line_number":99,"context_line":"dhcp-match\u003dset:efi,option:client-arch,11"},{"line_number":100,"context_line":"{% if enable_uefi_ipxe | bool \u003d\u003d true %}"},{"line_number":101,"context_line":"# Client is PXE booting over EFI without iPXE ROM; send EFI version of iPXE chainloader"},{"line_number":102,"context_line":"dhcp-boot\u003dtag:efi,tag:!ipxe,/{{ ipxe_efi_binary }}"},{"line_number":103,"context_line":"{% else %}"}],"source_content_type":"text/x-jinja2","patch_set":32,"id":"5ad099a7_1cde62e0","line":100,"updated":"2022-05-17 15:12:38.000000000","message":"We need to be able to support iPXE and PXE in the same installation. I wonder if it\u0027s possible at all... Maybe we finally need a standalone network interface.","commit_id":"93e71dbcaa2384f874a3cbe2d213fd2ed6b01bf9"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"cbff6917801ba474cb7987966735ed429cea902b","unresolved":false,"context_lines":[{"line_number":97,"context_line":"dhcp-match\u003dset:efi,option:client-arch,7"},{"line_number":98,"context_line":"dhcp-match\u003dset:efi,option:client-arch,9"},{"line_number":99,"context_line":"dhcp-match\u003dset:efi,option:client-arch,11"},{"line_number":100,"context_line":"{% if enable_uefi_ipxe | bool \u003d\u003d true %}"},{"line_number":101,"context_line":"# Client is PXE booting over EFI without iPXE ROM; send EFI version of iPXE chainloader"},{"line_number":102,"context_line":"dhcp-boot\u003dtag:efi,tag:!ipxe,/{{ ipxe_efi_binary }}"},{"line_number":103,"context_line":"{% else %}"}],"source_content_type":"text/x-jinja2","patch_set":32,"id":"7a1c2b1e_2a1be2b6","line":100,"in_reply_to":"5ad099a7_1cde62e0","updated":"2022-05-17 22:09:44.000000000","message":"How about we implement a dnsmasq based BaseDHCP? There could be a dnsmasq.d enabled with dhcp-optsdir and per-node files written which match on the MAC, tag with the node UUID, then do a dhcp-boot specific to the boot interface. Then send dnsmasq a SIGHUP.\n\nThis would bring parity with neutron based dhcp. It would require a dnsmasq new enough to support dhcp-optsdir.","commit_id":"93e71dbcaa2384f874a3cbe2d213fd2ed6b01bf9"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"0b0f087313144ddcebd7889af84e850e539033f8","unresolved":false,"context_lines":[{"line_number":97,"context_line":"dhcp-match\u003dset:efi,option:client-arch,7"},{"line_number":98,"context_line":"dhcp-match\u003dset:efi,option:client-arch,9"},{"line_number":99,"context_line":"dhcp-match\u003dset:efi,option:client-arch,11"},{"line_number":100,"context_line":"{% if enable_uefi_ipxe | bool \u003d\u003d true %}"},{"line_number":101,"context_line":"# Client is PXE booting over EFI without iPXE ROM; send EFI version of iPXE chainloader"},{"line_number":102,"context_line":"dhcp-boot\u003dtag:efi,tag:!ipxe,/{{ ipxe_efi_binary }}"},{"line_number":103,"context_line":"{% else %}"}],"source_content_type":"text/x-jinja2","patch_set":32,"id":"9277f4a1_707a9d7c","line":100,"in_reply_to":"7a1c2b1e_2a1be2b6","updated":"2022-05-18 22:11:58.000000000","message":"Reading the dnsmasq man page again, changing file inside the dhcp-optsdir directory does *not* require a SIGHUP, which I realise now would make this approach impractical","commit_id":"93e71dbcaa2384f874a3cbe2d213fd2ed6b01bf9"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"04f89ddf643bf68600af6c9dab635fc30020fb1f","unresolved":false,"context_lines":[{"line_number":97,"context_line":"dhcp-match\u003dset:efi,option:client-arch,7"},{"line_number":98,"context_line":"dhcp-match\u003dset:efi,option:client-arch,9"},{"line_number":99,"context_line":"dhcp-match\u003dset:efi,option:client-arch,11"},{"line_number":100,"context_line":"{% if enable_uefi_ipxe | bool \u003d\u003d true %}"},{"line_number":101,"context_line":"# Client is PXE booting over EFI without iPXE ROM; send EFI version of iPXE chainloader"},{"line_number":102,"context_line":"dhcp-boot\u003dtag:efi,tag:!ipxe,/{{ ipxe_efi_binary }}"},{"line_number":103,"context_line":"{% else %}"}],"source_content_type":"text/x-jinja2","patch_set":32,"id":"ae5bb2ef_077876aa","line":100,"in_reply_to":"9277f4a1_707a9d7c","updated":"2022-05-18 23:44:26.000000000","message":"We\u0027ve kind of been brushing up a need to just do it for a long time...","commit_id":"93e71dbcaa2384f874a3cbe2d213fd2ed6b01bf9"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"8dc1fb36db5ebffff88f2d58dd06c33c300fa771","unresolved":false,"context_lines":[{"line_number":97,"context_line":"dhcp-match\u003dset:efi,option:client-arch,7"},{"line_number":98,"context_line":"dhcp-match\u003dset:efi,option:client-arch,9"},{"line_number":99,"context_line":"dhcp-match\u003dset:efi,option:client-arch,11"},{"line_number":100,"context_line":"{% if enable_uefi_ipxe | bool \u003d\u003d true %}"},{"line_number":101,"context_line":"# Client is PXE booting over EFI without iPXE ROM; send EFI version of iPXE chainloader"},{"line_number":102,"context_line":"dhcp-boot\u003dtag:efi,tag:!ipxe,/{{ ipxe_efi_binary }}"},{"line_number":103,"context_line":"{% else %}"}],"source_content_type":"text/x-jinja2","patch_set":32,"id":"34151bd6_f1d2e49b","line":100,"in_reply_to":"97f2fe4d_b8bb91de","updated":"2022-08-01 00:47:42.000000000","message":"I had a crack at doing this, but I hope grub-network-boot can merge on its own first:\n\nhttps://review.opendev.org/c/openstack/ironic/+/851681\nhttps://review.opendev.org/c/openstack/bifrost/+/851682","commit_id":"93e71dbcaa2384f874a3cbe2d213fd2ed6b01bf9"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"a33ec52680bd76dc572c2bb3f322e60d21b5738c","unresolved":false,"context_lines":[{"line_number":97,"context_line":"dhcp-match\u003dset:efi,option:client-arch,7"},{"line_number":98,"context_line":"dhcp-match\u003dset:efi,option:client-arch,9"},{"line_number":99,"context_line":"dhcp-match\u003dset:efi,option:client-arch,11"},{"line_number":100,"context_line":"{% if enable_uefi_ipxe | bool \u003d\u003d true %}"},{"line_number":101,"context_line":"# Client is PXE booting over EFI without iPXE ROM; send EFI version of iPXE chainloader"},{"line_number":102,"context_line":"dhcp-boot\u003dtag:efi,tag:!ipxe,/{{ ipxe_efi_binary }}"},{"line_number":103,"context_line":"{% else %}"}],"source_content_type":"text/x-jinja2","patch_set":32,"id":"97f2fe4d_b8bb91de","line":100,"in_reply_to":"ae5bb2ef_077876aa","updated":"2022-07-12 02:53:56.000000000","message":"Done","commit_id":"93e71dbcaa2384f874a3cbe2d213fd2ed6b01bf9"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"c86f861088893092b3dc6c88e2a67ab23bb84576","unresolved":true,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"dhcp-match\u003dset:ipxe,175 # iPXE sends a 175 option."},{"line_number":97,"context_line":"{% if \u0027ipxe\u0027 in enabled_boot_interfaces.split(\u0027,\u0027) %}"},{"line_number":98,"context_line":"dhcp-match\u003dset:efi,option:client-arch,7"},{"line_number":99,"context_line":"dhcp-match\u003dset:efi,option:client-arch,9"},{"line_number":100,"context_line":"dhcp-match\u003dset:efi,option:client-arch,11"},{"line_number":101,"context_line":"# Client is PXE booting over EFI without iPXE ROM; send EFI version of iPXE chainloader"},{"line_number":102,"context_line":"dhcp-boot\u003dtag:efi,tag:!ipxe,/{{ ipxe_efi_binary }}"},{"line_number":103,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":39,"id":"ea3b21e5_3291b5be","side":"PARENT","line":100,"range":{"start_line":98,"start_character":0,"end_line":100,"end_character":40},"updated":"2022-07-12 05:37:23.000000000","message":"I think it is OK to move these 3 lines to be outside this if block? I\u0027ll need to anyway","commit_id":"90157aeca21d7b30bdd3c1f134b8107bfdef962f"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"363dfa797b669046e1f51d8136998db1f1dc2504","unresolved":true,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"dhcp-match\u003dset:ipxe,175 # iPXE sends a 175 option."},{"line_number":97,"context_line":"{% if \u0027ipxe\u0027 in enabled_boot_interfaces.split(\u0027,\u0027) %}"},{"line_number":98,"context_line":"dhcp-match\u003dset:efi,option:client-arch,7"},{"line_number":99,"context_line":"dhcp-match\u003dset:efi,option:client-arch,9"},{"line_number":100,"context_line":"dhcp-match\u003dset:efi,option:client-arch,11"},{"line_number":101,"context_line":"# Client is PXE booting over EFI without iPXE ROM; send EFI version of iPXE chainloader"},{"line_number":102,"context_line":"dhcp-boot\u003dtag:efi,tag:!ipxe,/{{ ipxe_efi_binary }}"},{"line_number":103,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":39,"id":"e73ed5c5_0f89e1dc","side":"PARENT","line":100,"range":{"start_line":98,"start_character":0,"end_line":100,"end_character":40},"in_reply_to":"ea3b21e5_3291b5be","updated":"2022-08-01 13:23:44.000000000","message":"Yes, that should be fine.","commit_id":"90157aeca21d7b30bdd3c1f134b8107bfdef962f"}],"scripts/test-bifrost.sh":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3521eb9e45db6cf5831c00f3476d1069dc48613f","unresolved":true,"context_lines":[{"line_number":121,"context_line":"    CLOUD_CONFIG+\u003d\" -e default_boot_interface\u003dpxe\""},{"line_number":122,"context_line":"fi"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"if [[ -n \"$TEST_VM_NODE_DRIVER\" ]]; then"},{"line_number":125,"context_line":"    VM_SETUP_EXTRA+\u003d\" --driver $TEST_VM_NODE_DRIVER\""},{"line_number":126,"context_line":"    CLOUD_CONFIG+\u003d\" -e enabled_hardware_types\u003d$TEST_VM_NODE_DRIVER\""},{"line_number":127,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":41,"id":"0d375eb5_89000796","line":124,"range":{"start_line":124,"start_character":2,"end_line":124,"end_character":40},"updated":"2022-07-20 18:29:00.000000000","message":"I think this is failing because not every test has this defined, and it is an unbound variable when referenced without the value being populated. Setting a default value (of no value) to return with will likely fix this right up.","commit_id":"2be11c046cff1159722d0e26b68c6d0ff4d1645a"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"e4673a8b55d797fe2d7f2ad603b7605005b5f62b","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    CLOUD_CONFIG+\u003d\" -e default_boot_interface\u003dpxe\""},{"line_number":122,"context_line":"fi"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"if [[ -n \"$TEST_VM_NODE_DRIVER\" ]]; then"},{"line_number":125,"context_line":"    VM_SETUP_EXTRA+\u003d\" --driver $TEST_VM_NODE_DRIVER\""},{"line_number":126,"context_line":"    CLOUD_CONFIG+\u003d\" -e enabled_hardware_types\u003d$TEST_VM_NODE_DRIVER\""},{"line_number":127,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":41,"id":"7d3bd87d_3dd55560","line":124,"range":{"start_line":124,"start_character":2,"end_line":124,"end_character":40},"in_reply_to":"0d375eb5_89000796","updated":"2022-08-01 00:47:54.000000000","message":"Done","commit_id":"2be11c046cff1159722d0e26b68c6d0ff4d1645a"}]}