)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"0fe060a2066e54c896fcc04a22dcafabbdc17294","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"2b8c1e3f_03b2866a","updated":"2021-11-29 14:37:59.000000000","message":"recheck","commit_id":"a4444f3006741900fbe25d182e8801efa0079ad4"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"39483afd557b7c3c7a309a87a7f52b8190406c91","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"b3974f01_2dc09c0e","updated":"2022-01-07 10:32:46.000000000","message":"Great, thank you!","commit_id":"ed8056925f7ec5c989943fad110b0c1e59e20c63"}],"bindep.txt":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"227525cb595e09c99d0d73d0f75ec9631e0abec0","unresolved":false,"context_lines":[{"line_number":11,"context_line":"libssl-dev          [platform:dpkg]"},{"line_number":12,"context_line":"lsb-release         [platform:suse platform:dpkg]"},{"line_number":13,"context_line":"# NOTE(rpittau): lsb-release is not maintained anymore for centos 9 stream"},{"line_number":14,"context_line":"redhat-lsb          [platform:redhat !platform:centos-9]"},{"line_number":15,"context_line":"make"},{"line_number":16,"context_line":"python3              [platform:rpm]"},{"line_number":17,"context_line":"python3-apt          [platform:dpkg]"}],"source_content_type":"text/plain","patch_set":7,"id":"91a6f9be_8247b502","line":14,"updated":"2021-11-29 15:54:48.000000000","message":"I think you need to use brackets for an AND operation, otherwise it\u0027s OR","commit_id":"a4444f3006741900fbe25d182e8801efa0079ad4"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"00151ec38a89bb1c7ed8fe02d5a29c82a80d0f66","unresolved":false,"context_lines":[{"line_number":11,"context_line":"libssl-dev          [platform:dpkg]"},{"line_number":12,"context_line":"lsb-release         [platform:suse platform:dpkg]"},{"line_number":13,"context_line":"# NOTE(rpittau): lsb-release is not maintained anymore for centos 9 stream"},{"line_number":14,"context_line":"redhat-lsb          [platform:redhat !platform:centos-9]"},{"line_number":15,"context_line":"make"},{"line_number":16,"context_line":"python3              [platform:rpm]"},{"line_number":17,"context_line":"python3-apt          [platform:dpkg]"}],"source_content_type":"text/plain","patch_set":7,"id":"c335d691_1305c977","line":14,"in_reply_to":"91a6f9be_8247b502","updated":"2021-11-30 16:05:29.000000000","message":"right, I\u0027ll fix it","commit_id":"a4444f3006741900fbe25d182e8801efa0079ad4"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"39483afd557b7c3c7a309a87a7f52b8190406c91","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# NOTE(rpittau): the EPEL repository for centos 9 stream should be"},{"line_number":2,"context_line":"# epel-next but it\u0027s not ready yet"},{"line_number":3,"context_line":"epel-release        [(platform:centos !platform:centos-9) (platform:rhel !platform:centos-9)]"},{"line_number":4,"context_line":"gcc"},{"line_number":5,"context_line":"git"},{"line_number":6,"context_line":"libffi-devel        [platform:redhat platform:suse]"}],"source_content_type":"text/plain","patch_set":18,"id":"95065467_68162100","line":3,"updated":"2022-01-07 10:32:46.000000000","message":"I wonder if \"rhel\" is even correct here, we use redhat below","commit_id":"ed8056925f7ec5c989943fad110b0c1e59e20c63"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"78b9eeedbaab0b3444b94ad44ae92923c75cb8fc","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# NOTE(rpittau): the EPEL repository for centos 9 stream should be"},{"line_number":2,"context_line":"# epel-next but it\u0027s not ready yet"},{"line_number":3,"context_line":"epel-release        [(platform:centos !platform:centos-9) (platform:rhel !platform:centos-9)]"},{"line_number":4,"context_line":"gcc"},{"line_number":5,"context_line":"git"},{"line_number":6,"context_line":"libffi-devel        [platform:redhat platform:suse]"}],"source_content_type":"text/plain","patch_set":18,"id":"199e2ab9_b82e6d10","line":3,"in_reply_to":"95065467_68162100","updated":"2022-01-10 08:57:34.000000000","message":"redhat is probably better\nI realized I overlooked a couple of things, I\u0027m going to submit a followup before adding the keystone job","commit_id":"ed8056925f7ec5c989943fad110b0c1e59e20c63"}],"playbooks/roles/bifrost-create-vm-nodes/defaults/required_defaults_CentOS.yml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"227525cb595e09c99d0d73d0f75ec9631e0abec0","unresolved":false,"context_lines":[{"line_number":22,"context_line":" - pkgconfig"},{"line_number":23,"context_line":" - libvirt-devel"},{"line_number":24,"context_line":"# NOTE(rpittau): not available in centos 9 stream for the time being"},{"line_number":25,"context_line":"# - trousers"},{"line_number":26,"context_line":" - edk2-ovmf"},{"line_number":27,"context_line":"test_vm_emulator: \"/usr/libexec/qemu-kvm\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"f6ba1464_f0fc8f9a","line":25,"updated":"2021-11-29 15:54:48.000000000","message":"I wonder what it even is Oo","commit_id":"a4444f3006741900fbe25d182e8801efa0079ad4"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"00151ec38a89bb1c7ed8fe02d5a29c82a80d0f66","unresolved":false,"context_lines":[{"line_number":22,"context_line":" - pkgconfig"},{"line_number":23,"context_line":" - libvirt-devel"},{"line_number":24,"context_line":"# NOTE(rpittau): not available in centos 9 stream for the time being"},{"line_number":25,"context_line":"# - trousers"},{"line_number":26,"context_line":" - edk2-ovmf"},{"line_number":27,"context_line":"test_vm_emulator: \"/usr/libexec/qemu-kvm\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"c42ecd83_fad08ffe","line":25,"in_reply_to":"f6ba1464_f0fc8f9a","updated":"2021-11-30 16:05:29.000000000","message":"I\u0027m pretty sure we can remove it, I don\u0027t see why it\u0027s installed","commit_id":"a4444f3006741900fbe25d182e8801efa0079ad4"}],"playbooks/roles/bifrost-ironic-install/files/dnsmasq_t_watch.te":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"578ff8cb64ce6d049a6cde01b82db95b9d337d5c","unresolved":false,"context_lines":[{"line_number":8,"context_line":"}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"#\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d dnsmasq_t \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":11,"context_line":"allow dnsmasq_t dnsmasq_etc_t:dir watch;"}],"source_content_type":"application/octet-stream","patch_set":13,"id":"b4fb7d02_9a3c979d","line":11,"updated":"2021-12-05 20:14:26.000000000","message":"I\u0027m no selinux expert, but this does not look right to me. I would expect dnsmasq to already have access to its directories, I suspect we just don\u0027t tag our created directory with the right context.","commit_id":"8ecf10aee4139a3b2b17dc2bd2a2ff6e298ec0ed"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"f2caa7279c43796e4e00b4e589e45cf2cce340c2","unresolved":true,"context_lines":[{"line_number":8,"context_line":"}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"#\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d dnsmasq_t \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":11,"context_line":"allow dnsmasq_t dnsmasq_etc_t:dir watch;"}],"source_content_type":"application/octet-stream","patch_set":13,"id":"c028a9f1_6ea261fa","line":11,"in_reply_to":"494b17cb_87c8690b","updated":"2021-12-16 08:21:27.000000000","message":"the fix will be in selinux-policy-34.1.20-1.el9 which is not published yet","commit_id":"8ecf10aee4139a3b2b17dc2bd2a2ff6e298ec0ed"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"425300897958a9e22d7ea5dd4fb4e7b9dd0cca6d","unresolved":true,"context_lines":[{"line_number":8,"context_line":"}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"#\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d dnsmasq_t \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":11,"context_line":"allow dnsmasq_t dnsmasq_etc_t:dir watch;"}],"source_content_type":"application/octet-stream","patch_set":13,"id":"494b17cb_87c8690b","line":11,"in_reply_to":"85b2bb43_f2aebfa4","updated":"2021-12-07 13:52:31.000000000","message":"reported on BZ https://bugzilla.redhat.com/show_bug.cgi?id\u003d2029866","commit_id":"8ecf10aee4139a3b2b17dc2bd2a2ff6e298ec0ed"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9396401cda6464ed78271c3c2b61ad593a479030","unresolved":true,"context_lines":[{"line_number":8,"context_line":"}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"#\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d dnsmasq_t \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":11,"context_line":"allow dnsmasq_t dnsmasq_etc_t:dir watch;"}],"source_content_type":"application/octet-stream","patch_set":13,"id":"85b2bb43_f2aebfa4","line":11,"in_reply_to":"ab085dcf_270f9493","updated":"2021-12-07 13:23:48.000000000","message":"Hmm, maybe at least report it? I don\u0027t think we should be fixing dnsmasq permissions (although we can do it as a temporary workaround).","commit_id":"8ecf10aee4139a3b2b17dc2bd2a2ff6e298ec0ed"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"444bd29d68f439ec4fa11caa9e123f9c72ec9043","unresolved":true,"context_lines":[{"line_number":8,"context_line":"}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"#\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d dnsmasq_t \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":11,"context_line":"allow dnsmasq_t dnsmasq_etc_t:dir watch;"}],"source_content_type":"application/octet-stream","patch_set":13,"id":"ab085dcf_270f9493","line":11,"in_reply_to":"b4fb7d02_9a3c979d","updated":"2021-12-07 10:05:54.000000000","message":"I tested this on a CentOS Stream 9 system and unfortunately it seems that the \"watch\" permission is missing on the dnsmasq_etc_t label, which is the one assigned from selinux policy to the etc dir assigned to dnsmasq (/etc/dnsmasq.d/).\nAll other permissions are correct, only \"watch\" is missing.\nIt could be a regression as I found an old BZ mentioning the same issue for an older version of Fedora, also on CentOS Stream 8 works just fine.","commit_id":"8ecf10aee4139a3b2b17dc2bd2a2ff6e298ec0ed"}],"playbooks/roles/bifrost-prepare-for-test-dynamic/tasks/main.yml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"39483afd557b7c3c7a309a87a7f52b8190406c91","unresolved":true,"context_lines":[{"line_number":57,"context_line":"- name: \"Allow ssh-rsa algorithm for CentOS Stream 9\""},{"line_number":58,"context_line":"  block:"},{"line_number":59,"context_line":"    - name: \"Add ssh-rsa algorithm to ssh config\""},{"line_number":60,"context_line":"      shell: echo \"PubkeyAcceptedKeyTypes +ssh-rsa\" \u003e\u003e ~/.ssh/config"},{"line_number":61,"context_line":"    - name: \"Set correct permissions for ssh config\""},{"line_number":62,"context_line":"      file:"},{"line_number":63,"context_line":"        path: ~/.ssh/config"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"a190eaee_3b538828","line":60,"range":{"start_line":60,"start_character":21,"end_line":60,"end_character":22},"updated":"2022-01-07 10:32:46.000000000","message":"nit: https://docs.ansible.com/ansible/latest/collections/ansible/builtin/lineinfile_module.html","commit_id":"ed8056925f7ec5c989943fad110b0c1e59e20c63"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"78b9eeedbaab0b3444b94ad44ae92923c75cb8fc","unresolved":false,"context_lines":[{"line_number":57,"context_line":"- name: \"Allow ssh-rsa algorithm for CentOS Stream 9\""},{"line_number":58,"context_line":"  block:"},{"line_number":59,"context_line":"    - name: \"Add ssh-rsa algorithm to ssh config\""},{"line_number":60,"context_line":"      shell: echo \"PubkeyAcceptedKeyTypes +ssh-rsa\" \u003e\u003e ~/.ssh/config"},{"line_number":61,"context_line":"    - name: \"Set correct permissions for ssh config\""},{"line_number":62,"context_line":"      file:"},{"line_number":63,"context_line":"        path: ~/.ssh/config"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"c6d6a9ac_31326027","line":60,"range":{"start_line":60,"start_character":21,"end_line":60,"end_character":22},"in_reply_to":"a190eaee_3b538828","updated":"2022-01-10 08:57:34.000000000","message":"Ack","commit_id":"ed8056925f7ec5c989943fad110b0c1e59e20c63"}],"releasenotes/notes/centos9-16c9853d1dd0554b.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"39483afd557b7c3c7a309a87a7f52b8190406c91","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds basic support for running bifrost on CentOS Stream 9."}],"source_content_type":"text/x-yaml","patch_set":18,"id":"807b7e99_d1b18a7d","line":2,"updated":"2022-01-07 10:32:46.000000000","message":"nit: feature","commit_id":"ed8056925f7ec5c989943fad110b0c1e59e20c63"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"78b9eeedbaab0b3444b94ad44ae92923c75cb8fc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds basic support for running bifrost on CentOS Stream 9."}],"source_content_type":"text/x-yaml","patch_set":18,"id":"e68e4f74_0865012a","line":2,"in_reply_to":"807b7e99_d1b18a7d","updated":"2022-01-10 08:57:34.000000000","message":"Ack","commit_id":"ed8056925f7ec5c989943fad110b0c1e59e20c63"}],"zuul.d/project.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"39483afd557b7c3c7a309a87a7f52b8190406c91","unresolved":true,"context_lines":[{"line_number":7,"context_line":"    check:"},{"line_number":8,"context_line":"      jobs:"},{"line_number":9,"context_line":"        - bifrost-tox-linters"},{"line_number":10,"context_line":"        - bifrost-integration-tinyipa-centos-9"},{"line_number":11,"context_line":"        - bifrost-integration-tinyipa-ubuntu-focal"},{"line_number":12,"context_line":"        - bifrost-integration-tinyipa-centos-8"},{"line_number":13,"context_line":"        - bifrost-integration-tinyipa-keystone-ubuntu-focal"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"11d5b9d4_a59a7a64","line":10,"updated":"2022-01-07 10:32:46.000000000","message":"As the next step, we should try adding a Keystone job.","commit_id":"ed8056925f7ec5c989943fad110b0c1e59e20c63"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"78b9eeedbaab0b3444b94ad44ae92923c75cb8fc","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    check:"},{"line_number":8,"context_line":"      jobs:"},{"line_number":9,"context_line":"        - bifrost-tox-linters"},{"line_number":10,"context_line":"        - bifrost-integration-tinyipa-centos-9"},{"line_number":11,"context_line":"        - bifrost-integration-tinyipa-ubuntu-focal"},{"line_number":12,"context_line":"        - bifrost-integration-tinyipa-centos-8"},{"line_number":13,"context_line":"        - bifrost-integration-tinyipa-keystone-ubuntu-focal"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"fc107a8c_f269c82d","line":10,"in_reply_to":"11d5b9d4_a59a7a64","updated":"2022-01-10 08:57:34.000000000","message":"Ack","commit_id":"ed8056925f7ec5c989943fad110b0c1e59e20c63"}]}