)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"e4a1a66df7c7097e5e3183e4fc3f0b7907ad5ded","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a119f54d_126d466a","updated":"2022-02-09 09:13:55.000000000","message":"\u003e Patch Set 5: Code-Review+1\n\u003e \n\u003e Bonus point for making scripts/collect-test-info.sh collect this log.\n\u003e \n\u003e Also a thought on the usage of /tmp: are we sure it\u0027s not going to expose any private information to other users of the same machine?\n\nthere are no any credentials in it.\nit safe, and needed only for debugging purposes.\nno need to collect it.","commit_id":"647cdf6c0202f276db2a6b3fa42a295c02b51332"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"b2662e8ea68d512c520e779d5d917946aea2d115","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"65cce533_36c06937","updated":"2023-04-26 09:55:50.000000000","message":"recheck","commit_id":"b0ae1ecee23a92dc83ee57308582bac6b5ab09bc"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"8a1cad91ee0d21dca7841e9f198c224b98de8cf5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"a519fc7f_a2df701a","updated":"2023-04-26 21:33:36.000000000","message":"recheck","commit_id":"b0ae1ecee23a92dc83ee57308582bac6b5ab09bc"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"bab02bcc8caf9e6aa63776fca567ee86e8e84d46","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"f65dec57_2c0ec3ff","updated":"2023-08-02 10:20:38.000000000","message":"I\u0027m still not fond of using /tmp, but I\u0027ll let the other team members vote.","commit_id":"e3fb8c54d03232fc06c0d06ac76cf178331ce0c9"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"469441c4b46f80143d37afc7f3ae0694321cc09e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"216bee48_6958128a","updated":"2023-08-10 13:07:39.000000000","message":"recheck CI workaround merged","commit_id":"e3fb8c54d03232fc06c0d06ac76cf178331ce0c9"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"aadefd338d198c4854b0374731903adcd3498981","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"8ccd6e2c_2e35e547","updated":"2023-08-08 15:13:09.000000000","message":"recheck gate timeouts","commit_id":"e3fb8c54d03232fc06c0d06ac76cf178331ce0c9"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"77db1ba7521de00193c0fb30a21921ffd6cb8996","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"15ac15a7_dc54ac8c","updated":"2023-08-08 18:18:06.000000000","message":"recheck timeouts","commit_id":"e3fb8c54d03232fc06c0d06ac76cf178331ce0c9"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"47b36a02f91751c12413ac028a86804f0ee65291","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"ca6331dc_cf9a559f","updated":"2023-08-08 21:05:59.000000000","message":"recheck timeouts","commit_id":"e3fb8c54d03232fc06c0d06ac76cf178331ce0c9"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"1e8b9fab0829ce0b7a40cc9a05a2a6d8862aee4f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"146b83cf_4c087981","updated":"2023-05-30 16:09:15.000000000","message":"up","commit_id":"e3fb8c54d03232fc06c0d06ac76cf178331ce0c9"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"291e6f820652348b594212520728ae6bbece949e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"3c107312_85f6b194","in_reply_to":"f65dec57_2c0ec3ff","updated":"2023-08-02 13:49:17.000000000","message":"it used here: https://review.opendev.org/c/openstack/bifrost/+/822895/10/scripts/collect-test-info.sh#74","commit_id":"e3fb8c54d03232fc06c0d06ac76cf178331ce0c9"}],"playbooks/roles/bifrost-create-dib-image/tasks/main.yml":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"b80830bb69f8e11e83e3fd1ca5bc35f92772547f","unresolved":true,"context_lines":[{"line_number":182,"context_line":"      {{ dib_os_element }}"},{"line_number":183,"context_line":"      {{ dib_elements|default(\u0027\u0027) }}"},{"line_number":184,"context_line":"- name: \"Initiate image build\""},{"line_number":185,"context_line":"  shell: |"},{"line_number":186,"context_line":"    set -o pipefail"},{"line_number":187,"context_line":"    disk-image-create {{ dib_arglist }} | tee /var/log/disk-image-create.log"},{"line_number":188,"context_line":"  args:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"4ed671fe_4bfd7388","line":185,"updated":"2022-01-03 12:04:40.000000000","message":"any way to keep using the command module instead?","commit_id":"2643ff7ef7a3cd6bf99dc2811d7b6f2fd33ea677"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"789246b11ce8e55a30480d77bf27dd05053efca6","unresolved":false,"context_lines":[{"line_number":182,"context_line":"      {{ dib_os_element }}"},{"line_number":183,"context_line":"      {{ dib_elements|default(\u0027\u0027) }}"},{"line_number":184,"context_line":"- name: \"Initiate image build\""},{"line_number":185,"context_line":"  shell: |"},{"line_number":186,"context_line":"    set -o pipefail"},{"line_number":187,"context_line":"    disk-image-create {{ dib_arglist }} | tee /var/log/disk-image-create.log"},{"line_number":188,"context_line":"  args:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"fe0e9c9c_89922e4b","line":185,"in_reply_to":"4ed671fe_4bfd7388","updated":"2022-01-17 23:24:23.000000000","message":"pipe can\u0027t be used in the command module!\nhttps://docs.ansible.com/ansible/latest/collections/ansible/builtin/command_module.html","commit_id":"2643ff7ef7a3cd6bf99dc2811d7b6f2fd33ea677"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b294c8180e40ecb17c986d06f979b4329e98dbac","unresolved":false,"context_lines":[{"line_number":183,"context_line":"      {{ dib_elements|default(\u0027\u0027) }}"},{"line_number":184,"context_line":"- name: \"Initiate image build\""},{"line_number":185,"context_line":"  shell: |"},{"line_number":186,"context_line":"    set -o pipefail"},{"line_number":187,"context_line":"    disk-image-create {{ dib_arglist }} | tee /var/log/disk-image-create.log"},{"line_number":188,"context_line":"  args:"},{"line_number":189,"context_line":"    executable: /bin/bash"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"0144fc6d_231bd650","line":186,"updated":"2022-01-07 13:19:29.000000000","message":"I think you also need to add -e to make the script actually fail","commit_id":"2643ff7ef7a3cd6bf99dc2811d7b6f2fd33ea677"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"67b85b941144d5cdf964fdc4933758eec9ebd5ba","unresolved":false,"context_lines":[{"line_number":183,"context_line":"      {{ dib_elements|default(\u0027\u0027) }}"},{"line_number":184,"context_line":"- name: \"Initiate image build\""},{"line_number":185,"context_line":"  shell: |"},{"line_number":186,"context_line":"    set -o pipefail"},{"line_number":187,"context_line":"    disk-image-create {{ dib_arglist }} | tee /var/log/disk-image-create.log"},{"line_number":188,"context_line":"  args:"},{"line_number":189,"context_line":"    executable: /bin/bash"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"90a73d7b_79b06b68","line":186,"in_reply_to":"0144fc6d_231bd650","updated":"2022-01-08 23:11:06.000000000","message":"I think it shouldn\u0027t fail if can\u0027t create/write log file. The \u0027pipefail\u0027 fix is only to skip CI linting job. may be good idea to disable the check globally and use simple command with pipe? Riccardo Pittau ask too.","commit_id":"2643ff7ef7a3cd6bf99dc2811d7b6f2fd33ea677"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b294c8180e40ecb17c986d06f979b4329e98dbac","unresolved":false,"context_lines":[{"line_number":184,"context_line":"- name: \"Initiate image build\""},{"line_number":185,"context_line":"  shell: |"},{"line_number":186,"context_line":"    set -o pipefail"},{"line_number":187,"context_line":"    disk-image-create {{ dib_arglist }} | tee /var/log/disk-image-create.log"},{"line_number":188,"context_line":"  args:"},{"line_number":189,"context_line":"    executable: /bin/bash"},{"line_number":190,"context_line":"  environment: \"{{ dib_env_vars_final | combine(bifrost_venv_env) }}\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"b4a5415f_0ae8b933","line":187,"updated":"2022-01-07 13:19:29.000000000","message":"I think the log location should be configurable and probably default to the current directory or /tmp. There is no guarantee that /var/log is writable by us (or will stay writable in the future)","commit_id":"2643ff7ef7a3cd6bf99dc2811d7b6f2fd33ea677"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"789246b11ce8e55a30480d77bf27dd05053efca6","unresolved":false,"context_lines":[{"line_number":184,"context_line":"- name: \"Initiate image build\""},{"line_number":185,"context_line":"  shell: |"},{"line_number":186,"context_line":"    set -o pipefail"},{"line_number":187,"context_line":"    disk-image-create {{ dib_arglist }} | tee /var/log/disk-image-create.log"},{"line_number":188,"context_line":"  args:"},{"line_number":189,"context_line":"    executable: /bin/bash"},{"line_number":190,"context_line":"  environment: \"{{ dib_env_vars_final | combine(bifrost_venv_env) }}\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"6589121b_2c05e77b","line":187,"in_reply_to":"488a98e7_525e59da","updated":"2022-01-17 23:24:23.000000000","message":"done","commit_id":"2643ff7ef7a3cd6bf99dc2811d7b6f2fd33ea677"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"67b85b941144d5cdf964fdc4933758eec9ebd5ba","unresolved":false,"context_lines":[{"line_number":184,"context_line":"- name: \"Initiate image build\""},{"line_number":185,"context_line":"  shell: |"},{"line_number":186,"context_line":"    set -o pipefail"},{"line_number":187,"context_line":"    disk-image-create {{ dib_arglist }} | tee /var/log/disk-image-create.log"},{"line_number":188,"context_line":"  args:"},{"line_number":189,"context_line":"    executable: /bin/bash"},{"line_number":190,"context_line":"  environment: \"{{ dib_env_vars_final | combine(bifrost_venv_env) }}\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"488a98e7_525e59da","line":187,"in_reply_to":"b4a5415f_0ae8b933","updated":"2022-01-08 23:11:06.000000000","message":"nice idea. will do.","commit_id":"2643ff7ef7a3cd6bf99dc2811d7b6f2fd33ea677"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"fdf43ecfa4db7ab7f2629941389f396c01dfed01","unresolved":false,"context_lines":[{"line_number":179,"context_line":"- name: \"Initiate image build\""},{"line_number":180,"context_line":"  shell: |"},{"line_number":181,"context_line":"    set -o pipefail"},{"line_number":182,"context_line":"    disk-image-create {{ dib_arglist }} | tee {{ disk_image_create_log }}"},{"line_number":183,"context_line":"  args:"},{"line_number":184,"context_line":"    executable: /bin/bash"},{"line_number":185,"context_line":"  environment: \"{{ dib_env_vars_final | combine(bifrost_venv_env) }}\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"90bc1ec8_aa78016f","line":182,"updated":"2023-04-25 14:29:50.000000000","message":"I wonder if you want to also do 2\u003e\u00261 to capture stderr","commit_id":"2ee88a8817ca06ba9f8121ec57a15a985829f80b"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"ae9951ab1e9faa5a5519e79e30dc2e23cde6fdec","unresolved":false,"context_lines":[{"line_number":179,"context_line":"- name: \"Initiate image build\""},{"line_number":180,"context_line":"  shell: |"},{"line_number":181,"context_line":"    set -o pipefail"},{"line_number":182,"context_line":"    disk-image-create {{ dib_arglist }} | tee {{ disk_image_create_log }}"},{"line_number":183,"context_line":"  args:"},{"line_number":184,"context_line":"    executable: /bin/bash"},{"line_number":185,"context_line":"  environment: \"{{ dib_env_vars_final | combine(bifrost_venv_env) }}\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"18c197f9_d166bd55","line":182,"in_reply_to":"90bc1ec8_aa78016f","updated":"2023-04-25 17:32:42.000000000","message":"\u003e I wonder if you want to also do 2\u003e\u00261 to capture stderr\ndon\u0027t really needed. but ok, done.","commit_id":"2ee88a8817ca06ba9f8121ec57a15a985829f80b"}]}