)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"61bc1fcbff7533be84d4f686fe50f1ff4da5637d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"04187218_e3f34d98","updated":"2022-02-08 12:37:50.000000000","message":"recheck","commit_id":"bcc3a2c5a2e25b4086b5ce9979f9424ca18df71a"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"7ad243c6dfbe2270923e588574acdb9b1c426032","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"4364cb0a_77805002","updated":"2022-02-08 11:09:10.000000000","message":"recheck","commit_id":"bcc3a2c5a2e25b4086b5ce9979f9424ca18df71a"}],"playbooks/install.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"63ac87860ff112ed2b3bde666c308133f7896709","unresolved":true,"context_lines":[{"line_number":27,"context_line":"      dib_imagename: \"{{ http_boot_folder }}/ipa\""},{"line_number":28,"context_line":"      build_ramdisk: false"},{"line_number":29,"context_line":"      dib_os_element: \"{{ ipa_dib_os_element|default(\u0027debian\u0027) }}\""},{"line_number":30,"context_line":"      dib_elements: \"ironic-python-agent-ramdisk block-device-efi {{ ipa_extra_dib_elements | default(\u0027\u0027) }}\""},{"line_number":31,"context_line":"      when: create_ipa_image | bool"},{"line_number":32,"context_line":"    - role: bifrost-create-dib-image"},{"line_number":33,"context_line":"      dib_imagename: \"{{ deploy_image }}\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"56f6b6ff_784f972c","line":30,"updated":"2022-02-15 09:31:54.000000000","message":"This is IPA, it does not need a block device","commit_id":"e243ca7e1bfd9112022ce222f5d847507d3761dc"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"b3c09b7f6600b92e876b31410e452566b394dc15","unresolved":false,"context_lines":[{"line_number":27,"context_line":"      dib_imagename: \"{{ http_boot_folder }}/ipa\""},{"line_number":28,"context_line":"      build_ramdisk: false"},{"line_number":29,"context_line":"      dib_os_element: \"{{ ipa_dib_os_element|default(\u0027debian\u0027) }}\""},{"line_number":30,"context_line":"      dib_elements: \"ironic-python-agent-ramdisk block-device-efi {{ ipa_extra_dib_elements | default(\u0027\u0027) }}\""},{"line_number":31,"context_line":"      when: create_ipa_image | bool"},{"line_number":32,"context_line":"    - role: bifrost-create-dib-image"},{"line_number":33,"context_line":"      dib_imagename: \"{{ deploy_image }}\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"852a5b97_3b3c44ef","line":30,"in_reply_to":"56f6b6ff_784f972c","updated":"2022-02-15 14:49:22.000000000","message":"Ack","commit_id":"e243ca7e1bfd9112022ce222f5d847507d3761dc"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"eefcbca064051129ec44bcb17856b4e32f0dcecc","unresolved":true,"context_lines":[{"line_number":34,"context_line":"      dib_imagetype: \"qcow2\""},{"line_number":35,"context_line":"      dib_elements: \u003e"},{"line_number":36,"context_line":"        {{ dib_image_type|default(\u0027vm\u0027) }}"},{"line_number":37,"context_line":"        block-device-efi"},{"line_number":38,"context_line":"        enable-serial-console"},{"line_number":39,"context_line":"        {{ dib_init_element|default(\u0027simple-init\u0027) }}"},{"line_number":40,"context_line":"        {{ extra_dib_elements|default(\u0027\u0027) }}"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"ddf08cab_efc93fc9","line":37,"updated":"2022-02-15 09:32:35.000000000","message":"Also, could you make this conditional on `default_boot_mode !\u003d \"bios\"`?","commit_id":"e243ca7e1bfd9112022ce222f5d847507d3761dc"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"b3c09b7f6600b92e876b31410e452566b394dc15","unresolved":false,"context_lines":[{"line_number":34,"context_line":"      dib_imagetype: \"qcow2\""},{"line_number":35,"context_line":"      dib_elements: \u003e"},{"line_number":36,"context_line":"        {{ dib_image_type|default(\u0027vm\u0027) }}"},{"line_number":37,"context_line":"        block-device-efi"},{"line_number":38,"context_line":"        enable-serial-console"},{"line_number":39,"context_line":"        {{ dib_init_element|default(\u0027simple-init\u0027) }}"},{"line_number":40,"context_line":"        {{ extra_dib_elements|default(\u0027\u0027) }}"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"a18d5922_338cba66","line":37,"in_reply_to":"ddf08cab_efc93fc9","updated":"2022-02-15 14:49:22.000000000","message":"Ack","commit_id":"e243ca7e1bfd9112022ce222f5d847507d3761dc"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0e908806ae70df30600f13abedd05d916f6b85d4","unresolved":true,"context_lines":[{"line_number":34,"context_line":"      dib_imagetype: \"qcow2\""},{"line_number":35,"context_line":"      dib_elements: \u003e"},{"line_number":36,"context_line":"        {{ dib_image_type|default(\u0027vm\u0027) }}"},{"line_number":37,"context_line":"        {% if default_boot_mode !\u003d \"bios\" %}block-device-efi{% endif %}"},{"line_number":38,"context_line":"        enable-serial-console"},{"line_number":39,"context_line":"        {{ dib_init_element|default(\u0027simple-init\u0027) }}"},{"line_number":40,"context_line":"        {{ extra_dib_elements|default(\u0027\u0027) }}"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"aa0e2991_a4f033b7","line":37,"range":{"start_line":37,"start_character":14,"end_line":37,"end_character":31},"updated":"2022-02-15 18:46:14.000000000","message":"This is defined in roles, ideally we should use a default\n\n default_boot_mode|default(\u0027uefi\u0027)","commit_id":"bb43fd8b7574b2eacdd4d6472fed1c1d97f88ab3"}]}