)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14885,"name":"Daniel Mellado","email":"dmellado@redhat.com","username":"daniel-mellado"},"change_message_id":"7dd4b0c3f4293172b277859f0b7b5d67dd06313e","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Erik Berg \u003copenstack@slipsprogrammor.no\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-04-13 12:32:08 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow for almalinux and rocky installations"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"With the changes to bifrost-ironic-install required_defaults for"},{"line_number":10,"context_line":"the RedHat_family, we can now try to not get in the way of"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3b1218fc_78ba911f","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":43},"updated":"2022-04-13 10:56:46.000000000","message":"I\u0027d change the commit message, as it\u0027s a bit misleading. TL;DR although it\u0027s cool that we remove EOL distros I\u0027d rephrase that in the opposite way, like. Dropping Fedora 32 support.","commit_id":"ecd62b0e100676cfe76c8e54d17e5cc14e634234"},{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"cd328543d6f89db67a900568c27a35c8f43d684a","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Erik Berg \u003copenstack@slipsprogrammor.no\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-04-13 12:32:08 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow for almalinux and rocky installations"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"With the changes to bifrost-ironic-install required_defaults for"},{"line_number":10,"context_line":"the RedHat_family, we can now try to not get in the way of"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"d08e7c57_fb0514bc","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":43},"in_reply_to":"3b1218fc_78ba911f","updated":"2022-04-13 11:16:59.000000000","message":"It\u0027s just a check for fedora higher than 32, (which has been eol for some time). We\u0027re not dropping support for fedora 32 by removing it, just assuming that nobody\u0027s trying to deploy on anything older than 32.\n\nBut we are deprecating support for fedora [1] https://review.opendev.org/c/openstack/bifrost/+/818780\n\nBut yes, I\u0027m open to suggestions for wording to make that clearer 😊","commit_id":"ecd62b0e100676cfe76c8e54d17e5cc14e634234"},{"author":{"_account_id":14885,"name":"Daniel Mellado","email":"dmellado@redhat.com","username":"daniel-mellado"},"change_message_id":"aa3a2aebd7a67883904a70f0aff663ef05959faa","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Erik Berg \u003copenstack@slipsprogrammor.no\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-04-13 12:32:08 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow for almalinux and rocky installations"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"With the changes to bifrost-ironic-install required_defaults for"},{"line_number":10,"context_line":"the RedHat_family, we can now try to not get in the way of"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"b6287b4e_e4781153","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":43},"in_reply_to":"d08e7c57_fb0514bc","updated":"2022-04-19 11:00:29.000000000","message":"Done","commit_id":"ecd62b0e100676cfe76c8e54d17e5cc14e634234"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"e15a21465b33cb82c143754390f4cdb0d47635b6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"569fb45a_952cf817","updated":"2022-04-11 14:02:07.000000000","message":"recheck\n\nerror: pathspec \u0027stable/xena\u0027 did not match any file(s) known to git\n2022-04-10 21:39:11.795310 | ubuntu-focal | ok: Item: {\u0027canonical_hostname\u0027: \u0027opendev.org\u0027, \u0027canonical_name\u0027: \u0027opendev.org/opendev/bindep\u0027, \u0027checkout\u0027: \u0027master\u0027, \u0027checkout_description\u0027: \u0027zuul branch\u0027, \u0027commit\u0027: \u0027550f72926e660864540de9bb68e3180b5912bafc\u0027, \u0027name\u0027: \u0027opendev/bindep\u0027, \u0027required\u0027: False, \u0027short_name\u0027: \u0027bindep\u0027, \u0027src_dir\u0027: \u0027src/opendev.org/opendev/bindep\u0027} Result: 1","commit_id":"12e21e0ab37453e94c452c19f8a4b814db092b48"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e669c611c7fb368815610611842f0ada180341c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4d38b586_6b19ee60","updated":"2022-04-13 07:55:21.000000000","message":"I don\u0027t find this addition controversial, but would it be possible to add a non-voting CI job? I guess it depends on whether the infra team has images for either of these.","commit_id":"5d6f9805deeb5f9d34c0a6bfe0aedcfd35652d1b"},{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"8e5089a6956497a66ba11e4e55327c501f98d6c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f1887355_aebac5a4","updated":"2022-04-12 10:23:28.000000000","message":"Not support, more like not get in the way of running on other EL8 platforms. I\u0027ll bring it up on the next meeting.","commit_id":"5d6f9805deeb5f9d34c0a6bfe0aedcfd35652d1b"},{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"de88a66388d604685a9e9890dcca71b84bcc6a31","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"94806fbc_636bbfe3","updated":"2022-04-11 18:38:28.000000000","message":"Not sure if the fix in zuul.d/bifrost-jobs.yaml belongs here, or if it should be in a separate change.","commit_id":"5d6f9805deeb5f9d34c0a6bfe0aedcfd35652d1b"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"8ba65b4702c60ee493c347e1ffd864a6eb76a706","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e22f9f12_a48a6a9c","updated":"2022-04-12 06:47:04.000000000","message":"hi! Thank you for the patch.\nWe tried to reach to you on IRC unfortunately with no reply.\nThe topic of adding support to new distributions should we brought up to the community, I invite you to add this as an argument of discussion to one of the next ironic weekly meetings.\nYou can find more info here: https://wiki.openstack.org/wiki/Meetings/Ironic","commit_id":"5d6f9805deeb5f9d34c0a6bfe0aedcfd35652d1b"},{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"cd328543d6f89db67a900568c27a35c8f43d684a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8a3ac6f5_18c1ac90","updated":"2022-04-13 11:16:59.000000000","message":"I am also tempted to add \u0027ol\u0027 for oraclelinux, incase some soul tries to install on that distro.","commit_id":"ecd62b0e100676cfe76c8e54d17e5cc14e634234"},{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"6e042400d653d7be45040721d27f415890feebc7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2a56cb41_89083c88","updated":"2022-04-13 11:00:25.000000000","message":"I have changed the wording from support to allow. If it works on rhel or centos, I pretty much expect it to work on alma or rocky, don\u0027t see the need for adding an additional test-job.","commit_id":"ecd62b0e100676cfe76c8e54d17e5cc14e634234"},{"author":{"_account_id":14885,"name":"Daniel Mellado","email":"dmellado@redhat.com","username":"daniel-mellado"},"change_message_id":"aa3a2aebd7a67883904a70f0aff663ef05959faa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2c3e7630_48842db1","updated":"2022-04-19 11:00:29.000000000","message":"I\u0027m fine with the patch, besides Dmitry\u0027s comments regarding the ansible condition. Thanks!","commit_id":"157b7140ed35b1ee591e9a8eba03b4a00157ce33"},{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"85077cb2638ec2e42c3361e1ff112a09165f69fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"46625e1f_3cb83507","updated":"2022-04-19 12:33:23.000000000","message":"Simplified to true 😄","commit_id":"24b6a39a9cb980589e1b7f206c3a74b5772ae417"},{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"c0ded25dadb0e1ff6c3f7fe386e016a93da75872","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"43f9b115_cb47d595","updated":"2022-04-19 13:34:33.000000000","message":"Apparently didn\u0027t pay attention to which file this was and went overboard. Commit message is still correct though. Assume firewalld on ansible_os_family \u003d \u0027RedHat\u0027.","commit_id":"7640a231a84f87939d3242b062f4ca1e89bcfa4a"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"c468661ed7ea6ce5c4f4a28edb5f462869ea4abb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"7f4db533_68cda7c0","updated":"2022-04-19 15:23:12.000000000","message":"looks good","commit_id":"7640a231a84f87939d3242b062f4ca1e89bcfa4a"}],"playbooks/roles/bifrost-ironic-install/defaults/main.yml":[{"author":{"_account_id":14885,"name":"Daniel Mellado","email":"dmellado@redhat.com","username":"daniel-mellado"},"change_message_id":"7dd4b0c3f4293172b277859f0b7b5d67dd06313e","unresolved":true,"context_lines":[{"line_number":56,"context_line":"internal_interface: \"{{ hostvars[inventory_hostname][\u0027ansible_\u0027 + ans_network_interface][\u0027ipv4\u0027] }}\""},{"line_number":57,"context_line":"internal_ip: \"{{ internal_interface[\u0027address\u0027] }}\""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"# Fedora 30 did not use firewalld, 32 started relying on it."},{"line_number":60,"context_line":"use_firewalld: \u003e-"},{"line_number":61,"context_line":"  {{ ansible_distribution in [\u0027RedHat\u0027, \u0027CentOS\u0027]"},{"line_number":62,"context_line":"     or (ansible_os_family \u003d\u003d \u0027RedHat\u0027"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"29fe1fff_cef233de","line":59,"updated":"2022-04-13 10:56:46.000000000","message":"This comment is no longer relevant","commit_id":"ecd62b0e100676cfe76c8e54d17e5cc14e634234"},{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"cd328543d6f89db67a900568c27a35c8f43d684a","unresolved":false,"context_lines":[{"line_number":56,"context_line":"internal_interface: \"{{ hostvars[inventory_hostname][\u0027ansible_\u0027 + ans_network_interface][\u0027ipv4\u0027] }}\""},{"line_number":57,"context_line":"internal_ip: \"{{ internal_interface[\u0027address\u0027] }}\""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"# Fedora 30 did not use firewalld, 32 started relying on it."},{"line_number":60,"context_line":"use_firewalld: \u003e-"},{"line_number":61,"context_line":"  {{ ansible_distribution in [\u0027RedHat\u0027, \u0027CentOS\u0027]"},{"line_number":62,"context_line":"     or (ansible_os_family \u003d\u003d \u0027RedHat\u0027"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"e2fe1551_e5d535fe","line":59,"in_reply_to":"29fe1fff_cef233de","updated":"2022-04-13 11:16:59.000000000","message":"Ack","commit_id":"ecd62b0e100676cfe76c8e54d17e5cc14e634234"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c6ec136c8cd96f38f408b4eab989a9e81acaa65e","unresolved":false,"context_lines":[{"line_number":59,"context_line":"use_firewalld: \u003e-"},{"line_number":60,"context_line":"  {{ ansible_distribution in [\u0027RedHat\u0027, \u0027CentOS\u0027]"},{"line_number":61,"context_line":"     or (ansible_os_family \u003d\u003d \u0027RedHat\u0027"},{"line_number":62,"context_line":"         and ansible_distribution_major_version|int \u003e\u003d 8) }}"},{"line_number":63,"context_line":"# Our own firewalld zone, only applies when testing is false."},{"line_number":64,"context_line":"firewalld_internal_zone: bifrost"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"8d9af872_b38a92f8","line":62,"updated":"2022-04-19 10:53:32.000000000","message":"We don\u0027t support RHEL 7 (for many reasons, including Python 3), so this may be further simplified?\n\nAlso, RHEL is covered by the condition on line 60, so I\u0027m not sure what this is doing?","commit_id":"157b7140ed35b1ee591e9a8eba03b4a00157ce33"},{"author":{"_account_id":14885,"name":"Daniel Mellado","email":"dmellado@redhat.com","username":"daniel-mellado"},"change_message_id":"aa3a2aebd7a67883904a70f0aff663ef05959faa","unresolved":false,"context_lines":[{"line_number":59,"context_line":"use_firewalld: \u003e-"},{"line_number":60,"context_line":"  {{ ansible_distribution in [\u0027RedHat\u0027, \u0027CentOS\u0027]"},{"line_number":61,"context_line":"     or (ansible_os_family \u003d\u003d \u0027RedHat\u0027"},{"line_number":62,"context_line":"         and ansible_distribution_major_version|int \u003e\u003d 8) }}"},{"line_number":63,"context_line":"# Our own firewalld zone, only applies when testing is false."},{"line_number":64,"context_line":"firewalld_internal_zone: bifrost"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"b1853dbb_92495abf","line":62,"in_reply_to":"8d9af872_b38a92f8","updated":"2022-04-19 11:00:29.000000000","message":"Yep, probably line 61 can just be removed","commit_id":"157b7140ed35b1ee591e9a8eba03b4a00157ce33"}],"zuul.d/bifrost-jobs.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6d431a9dcc29774ebe6f9073e4b7ca51540dc190","unresolved":true,"context_lines":[{"line_number":210,"context_line":"    vars:"},{"line_number":211,"context_line":"      upgrade_from: stable/xena"},{"line_number":212,"context_line":"      skip_upgrade:"},{"line_number":213,"context_line":"        - opendev/bindep"},{"line_number":214,"context_line":"        - openstack/diskimage-builder"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"- job:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"c4146873_25bb4dbc","line":213,"updated":"2022-04-13 07:57:07.000000000","message":"While it won\u0027t hurt, it\u0027s only needed here because of your Depends-On. And your Depends-On won\u0027t actually work because bindep is installed from a package. TL;DR please remove when ready.","commit_id":"5d6f9805deeb5f9d34c0a6bfe0aedcfd35652d1b"},{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"6e042400d653d7be45040721d27f415890feebc7","unresolved":false,"context_lines":[{"line_number":210,"context_line":"    vars:"},{"line_number":211,"context_line":"      upgrade_from: stable/xena"},{"line_number":212,"context_line":"      skip_upgrade:"},{"line_number":213,"context_line":"        - opendev/bindep"},{"line_number":214,"context_line":"        - openstack/diskimage-builder"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"- job:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bfa716f9_f48ed05d","line":213,"in_reply_to":"c4146873_25bb4dbc","updated":"2022-04-13 11:00:25.000000000","message":"Done","commit_id":"5d6f9805deeb5f9d34c0a6bfe0aedcfd35652d1b"}]}