)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"7ba7a98276c2db3d220cefcfdda4ff7a7c7a2975","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d13b6aa2_d9430c3f","updated":"2022-07-25 13:54:06.000000000","message":"Testproject: https://review.opendev.org/c/openstack/ansible-collections-openstack/+/850876","commit_id":"0cda3e438a4c2bc879f7532c4b8b83f098cc5a51"}],"playbooks/roles/bifrost-create-vm-nodes/tasks/main.yml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"188a1799fa9d54e56b845c3b815f0e4aab67314a","unresolved":true,"context_lines":[{"line_number":92,"context_line":"    group: \"{{ ansible_user_gid }}\""},{"line_number":93,"context_line":"  when: copy_from_local_path | bool"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"# FIXME(dtantsur): downgrade openstacksdk since ansible-collections-openstack"},{"line_number":96,"context_line":"# before 2.0.0 cannot work with 0.99.0. Remove when we use \u003e\u003d2.0.0."},{"line_number":97,"context_line":"- name: downgrade openstacksdk in upper constraints"},{"line_number":98,"context_line":"  lineinfile:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7307a48c_ae4c68f0","line":95,"updated":"2022-07-25 11:48:11.000000000","message":"I think there is another copy of this code in another role.","commit_id":"3517d61879726f56024c91b8dc45f3fa2617a00c"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"4b1ae62ee58d1674756ee10edca5b5c46019116e","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    group: \"{{ ansible_user_gid }}\""},{"line_number":93,"context_line":"  when: copy_from_local_path | bool"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"# FIXME(dtantsur): downgrade openstacksdk since ansible-collections-openstack"},{"line_number":96,"context_line":"# before 2.0.0 cannot work with 0.99.0. Remove when we use \u003e\u003d2.0.0."},{"line_number":97,"context_line":"- name: downgrade openstacksdk in upper constraints"},{"line_number":98,"context_line":"  lineinfile:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"c74c7c5c_666393bb","line":95,"in_reply_to":"7307a48c_ae4c68f0","updated":"2022-07-25 12:07:25.000000000","message":"Done","commit_id":"3517d61879726f56024c91b8dc45f3fa2617a00c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"188a1799fa9d54e56b845c3b815f0e4aab67314a","unresolved":true,"context_lines":[{"line_number":99,"context_line":"    path: \"{{ upper_constraints_file }}\""},{"line_number":100,"context_line":"    regexp: \"^openstacksdk\u003d\""},{"line_number":101,"context_line":"    line: \"openstacksdk\u003d\u003d\u003d0.61.0\""},{"line_number":102,"context_line":"  when: zuul.projects[\u0027opendev.org/openstack/ansible-collections-openstack\u0027].checkout|default(\u0027\u0027) !\u003d \u0027master\u0027"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"- include: prepare_libvirt.yml"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"a79a943e_b4fc88a9","line":102,"updated":"2022-07-25 11:48:11.000000000","message":"zuul may be undefined (and I don\u0027t really like CI-specific assumptions here).\n\nCan we check the collection version instead?","commit_id":"3517d61879726f56024c91b8dc45f3fa2617a00c"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"34c7b5ed7793396cc73a3dee4452731fb172a507","unresolved":true,"context_lines":[{"line_number":99,"context_line":"    path: \"{{ upper_constraints_file }}\""},{"line_number":100,"context_line":"    regexp: \"^openstacksdk\u003d\""},{"line_number":101,"context_line":"    line: \"openstacksdk\u003d\u003d\u003d0.61.0\""},{"line_number":102,"context_line":"  when: zuul.projects[\u0027opendev.org/openstack/ansible-collections-openstack\u0027].checkout|default(\u0027\u0027) !\u003d \u0027master\u0027"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"- include: prepare_libvirt.yml"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ca46ad0b_e25182c7","line":102,"in_reply_to":"18de24c9_b14d3b39","updated":"2022-07-25 13:46:48.000000000","message":"The \u0027zuul\u0027 variable is not available here because this role is not called from the playbook run by Zuul but from test-bifrost.yaml which is run in scripts/test-bifrost.sh ... \n\nWhat do we do now?","commit_id":"3517d61879726f56024c91b8dc45f3fa2617a00c"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"4b1ae62ee58d1674756ee10edca5b5c46019116e","unresolved":true,"context_lines":[{"line_number":99,"context_line":"    path: \"{{ upper_constraints_file }}\""},{"line_number":100,"context_line":"    regexp: \"^openstacksdk\u003d\""},{"line_number":101,"context_line":"    line: \"openstacksdk\u003d\u003d\u003d0.61.0\""},{"line_number":102,"context_line":"  when: zuul.projects[\u0027opendev.org/openstack/ansible-collections-openstack\u0027].checkout|default(\u0027\u0027) !\u003d \u0027master\u0027"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"- include: prepare_libvirt.yml"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"18de24c9_b14d3b39","line":102,"in_reply_to":"a79a943e_b4fc88a9","updated":"2022-07-25 12:07:25.000000000","message":"The default() helps against undefined variables.\n\nAnsible collection \u0027community.general\u0027 has a module which allows us to query a collection version [1] but this is available only since Ansible 5.3.\n\nElse we would have find where AOC was installed locally and then parse the MANIFEST (when installed through Ansible Galaxy) or galaxy.yml (when installed from git). Definitely a lot more work and only makes that hack more dirty imho.\n\nAny other ideas?\n\n[1] https://docs.ansible.com/ansible/latest/collections/community/general/collection_version_lookup.html","commit_id":"3517d61879726f56024c91b8dc45f3fa2617a00c"}]}