)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"b849e10e59cdeab8870c23405d4f43a9b348256f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a6430901_2856c0e9","updated":"2022-08-18 11:02:05.000000000","message":"Indeed, thanks for the pointers 👍","commit_id":"673318cf57e5b0675fcd7bb1832eec68d1f6f490"}],"bifrost/cli.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3e2f24ad8136a32b3c74a4ccddb5b31cfa4cecdf","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        if \u0027extra_kernel_options\u0027 in item and re.search(\u0027\\\\s\u0027, item):"},{"line_number":57,"context_line":"            # \\w is to catch inspector_extra_kernel_options"},{"line_number":58,"context_line":"            regex_match \u003d re.search(\u0027(?P\u003ckey\u003e^\\\\w*extra_kernel_options)\u003d\u0027"},{"line_number":59,"context_line":"                                    \u0027(?P\u003cvalue\u003e.*)$\u0027, item)"},{"line_number":60,"context_line":"            item \u003d (regex_match.group(\u0027key\u0027) + \u0027\u003d\"\u0027 +"},{"line_number":61,"context_line":"                    regex_match.group(\u0027value\u0027) + \u0027\"\u0027)"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"05b971ea_1e1ef596","line":59,"updated":"2022-08-16 09:34:38.000000000","message":"It feels like a bit of an overkill to use regular expressions here\n\n if item.startswith(\u0027extra_kernel_options\u0027):\n    key, value \u003d item.split(\u0027\u003d\u0027, 1)\n\n(you don\u0027t need to check for spaces - quotes will work anyway, but ideally you need to gracefully handle missing \"\u003d\")","commit_id":"e82aab5148167b4886933cfecbe85ad0a4e30bd4"},{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"b849e10e59cdeab8870c23405d4f43a9b348256f","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        if \u0027extra_kernel_options\u0027 in item and re.search(\u0027\\\\s\u0027, item):"},{"line_number":57,"context_line":"            # \\w is to catch inspector_extra_kernel_options"},{"line_number":58,"context_line":"            regex_match \u003d re.search(\u0027(?P\u003ckey\u003e^\\\\w*extra_kernel_options)\u003d\u0027"},{"line_number":59,"context_line":"                                    \u0027(?P\u003cvalue\u003e.*)$\u0027, item)"},{"line_number":60,"context_line":"            item \u003d (regex_match.group(\u0027key\u0027) + \u0027\u003d\"\u0027 +"},{"line_number":61,"context_line":"                    regex_match.group(\u0027value\u0027) + \u0027\"\u0027)"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"751a0fe7_f920ce7c","line":59,"in_reply_to":"05b971ea_1e1ef596","updated":"2022-08-18 11:02:05.000000000","message":"I\u0027ve made the comparison `extra_kernel_options\u003d` with `\u003d` at the end, that way we\u0027re sure there\u0027s atleast one `\u003d` before attempting to split on it. Not sure if that\u0027s the missing `\u003d` that needed some handling.","commit_id":"e82aab5148167b4886933cfecbe85ad0a4e30bd4"}]}