)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"3931ed68ab17d8937bf1703bdb3207dde1569ecb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d671917b_5b90e9c0","updated":"2022-09-14 12:34:51.000000000","message":"I\u0027ll remove the one you pointed out, as it does seem covered by the distribution_major_version. (I\u0027ve also started the process to have this redundancy removed from openstack-ansible roles aswell.)","commit_id":"595f18b406d47a44b033dffbc220deeffe69b5a1"},{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"34f63cc4b898ef037cf61dba403c18b2fff924e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9c9dbcdc_c9f833d1","updated":"2022-09-04 17:36:00.000000000","message":"recheck centos9","commit_id":"595f18b406d47a44b033dffbc220deeffe69b5a1"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b5b6b16e9d72e99e2e01e19d0528cdbee599f7c3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"dbe6ffd7_bf1c2e15","updated":"2022-10-27 18:17:32.000000000","message":"LGTM","commit_id":"d97567c3613bd90a44faa7911783a1f2364c4ad9"},{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"d592fa86a2daab426c69736fac6fc6c19fc7a9fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"06bfc35d_d108b044","updated":"2023-02-28 12:18:13.000000000","message":"lgtm","commit_id":"1e305873305ef70317b47f3455c3422ece80addd"},{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"dd02fff138a2230bcce30024e9dcb5a73d4e6123","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"195d9e09_20ea7922","updated":"2023-03-02 18:57:28.000000000","message":"Wonder if I should have just pressed the rebase button here instead of rebasing and uploading?","commit_id":"645aba57861935f24f22b4d79edf85430647759a"},{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"bf9591f32a3bed006f6e939748e0ff104c642722","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"24e4a2fe_8118103f","updated":"2023-03-03 07:12:26.000000000","message":"recheck bifrost-integration-tinyipa-centos-9","commit_id":"645aba57861935f24f22b4d79edf85430647759a"}],"playbooks/roles/bifrost-ironic-install/tasks/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"eb62f16cc2297e480301ca6bb7afedb25b2374cd","unresolved":true,"context_lines":[{"line_number":15,"context_line":"---"},{"line_number":16,"context_line":"- name: Gather variables for each operating system"},{"line_number":17,"context_line":"  include_vars: \"{{ item }}\""},{"line_number":18,"context_line":"  with_first_found:"},{"line_number":19,"context_line":"    - \"{{ ansible_facts[\u0027distribution\u0027] | lower }}-{{ ansible_facts[\u0027distribution_version\u0027] | lower }}.yml\""},{"line_number":20,"context_line":"    - \"{{ ansible_facts[\u0027distribution\u0027] | lower }}-{{ ansible_facts[\u0027distribution_major_version\u0027] | lower }}.yml\""},{"line_number":21,"context_line":"    - \"{{ ansible_facts[\u0027os_family\u0027] | lower }}-{{ ansible_facts[\u0027distribution_major_version\u0027] | lower }}.yml\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"44e764fb_ced21b6d","line":18,"updated":"2022-09-13 08:50:25.000000000","message":"Seems like just distribution or os_family would be enough here","commit_id":"595f18b406d47a44b033dffbc220deeffe69b5a1"},{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"3931ed68ab17d8937bf1703bdb3207dde1569ecb","unresolved":true,"context_lines":[{"line_number":15,"context_line":"---"},{"line_number":16,"context_line":"- name: Gather variables for each operating system"},{"line_number":17,"context_line":"  include_vars: \"{{ item }}\""},{"line_number":18,"context_line":"  with_first_found:"},{"line_number":19,"context_line":"    - \"{{ ansible_facts[\u0027distribution\u0027] | lower }}-{{ ansible_facts[\u0027distribution_version\u0027] | lower }}.yml\""},{"line_number":20,"context_line":"    - \"{{ ansible_facts[\u0027distribution\u0027] | lower }}-{{ ansible_facts[\u0027distribution_major_version\u0027] | lower }}.yml\""},{"line_number":21,"context_line":"    - \"{{ ansible_facts[\u0027os_family\u0027] | lower }}-{{ ansible_facts[\u0027distribution_major_version\u0027] | lower }}.yml\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"b2e2b279_46219730","line":18,"in_reply_to":"44e764fb_ced21b6d","updated":"2022-09-14 12:34:51.000000000","message":"Yeah, family is enough for now, just figured we\u0027d keep the options open if \"complications\" ever need to arise again, and I picked the \"tried and tested\" versioning openstack-ansible landed on.","commit_id":"595f18b406d47a44b033dffbc220deeffe69b5a1"},{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"5f26a3d0318c0e1fed6f4ecbdd86170eeb2ec686","unresolved":false,"context_lines":[{"line_number":15,"context_line":"---"},{"line_number":16,"context_line":"- name: Gather variables for each operating system"},{"line_number":17,"context_line":"  include_vars: \"{{ item }}\""},{"line_number":18,"context_line":"  with_first_found:"},{"line_number":19,"context_line":"    - \"{{ ansible_facts[\u0027distribution\u0027] | lower }}-{{ ansible_facts[\u0027distribution_version\u0027] | lower }}.yml\""},{"line_number":20,"context_line":"    - \"{{ ansible_facts[\u0027distribution\u0027] | lower }}-{{ ansible_facts[\u0027distribution_major_version\u0027] | lower }}.yml\""},{"line_number":21,"context_line":"    - \"{{ ansible_facts[\u0027os_family\u0027] | lower }}-{{ ansible_facts[\u0027distribution_major_version\u0027] | lower }}.yml\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"30a33eb6_bd5a2fdb","line":18,"in_reply_to":"b2e2b279_46219730","updated":"2022-09-14 12:46:20.000000000","message":"Ack","commit_id":"595f18b406d47a44b033dffbc220deeffe69b5a1"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"eb62f16cc2297e480301ca6bb7afedb25b2374cd","unresolved":true,"context_lines":[{"line_number":18,"context_line":"  with_first_found:"},{"line_number":19,"context_line":"    - \"{{ ansible_facts[\u0027distribution\u0027] | lower }}-{{ ansible_facts[\u0027distribution_version\u0027] | lower }}.yml\""},{"line_number":20,"context_line":"    - \"{{ ansible_facts[\u0027distribution\u0027] | lower }}-{{ ansible_facts[\u0027distribution_major_version\u0027] | lower }}.yml\""},{"line_number":21,"context_line":"    - \"{{ ansible_facts[\u0027os_family\u0027] | lower }}-{{ ansible_facts[\u0027distribution_major_version\u0027] | lower }}.yml\""},{"line_number":22,"context_line":"    - \"{{ ansible_facts[\u0027distribution\u0027] | lower }}.yml\""},{"line_number":23,"context_line":"    - \"{{ ansible_facts[\u0027os_family\u0027] | lower }}-{{ ansible_facts[\u0027distribution_version\u0027].split(\u0027.\u0027)[0] }}.yml\""},{"line_number":24,"context_line":"    - \"{{ ansible_facts[\u0027os_family\u0027] | lower }}.yml\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5b2bafbf_d9fb3fe5","line":21,"updated":"2022-09-13 08:50:25.000000000","message":"This seems less specific than L23","commit_id":"595f18b406d47a44b033dffbc220deeffe69b5a1"},{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"3931ed68ab17d8937bf1703bdb3207dde1569ecb","unresolved":true,"context_lines":[{"line_number":18,"context_line":"  with_first_found:"},{"line_number":19,"context_line":"    - \"{{ ansible_facts[\u0027distribution\u0027] | lower }}-{{ ansible_facts[\u0027distribution_version\u0027] | lower }}.yml\""},{"line_number":20,"context_line":"    - \"{{ ansible_facts[\u0027distribution\u0027] | lower }}-{{ ansible_facts[\u0027distribution_major_version\u0027] | lower }}.yml\""},{"line_number":21,"context_line":"    - \"{{ ansible_facts[\u0027os_family\u0027] | lower }}-{{ ansible_facts[\u0027distribution_major_version\u0027] | lower }}.yml\""},{"line_number":22,"context_line":"    - \"{{ ansible_facts[\u0027distribution\u0027] | lower }}.yml\""},{"line_number":23,"context_line":"    - \"{{ ansible_facts[\u0027os_family\u0027] | lower }}-{{ ansible_facts[\u0027distribution_version\u0027].split(\u0027.\u0027)[0] }}.yml\""},{"line_number":24,"context_line":"    - \"{{ ansible_facts[\u0027os_family\u0027] | lower }}.yml\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"c174e43a_6b619028","line":21,"in_reply_to":"5b2bafbf_d9fb3fe5","updated":"2022-09-14 12:34:51.000000000","message":"Yeah, I thought it was oddly placed aswell, but figured it might be for opensuse or some other distro, looks like it came from Ib339cd0657f7008fa48bf74f8d6ddd4b8add2ea1 for centos-7, which doesn\u0027t make much sense other than maybe ansible reported versions differently at the time?","commit_id":"595f18b406d47a44b033dffbc220deeffe69b5a1"},{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"5f26a3d0318c0e1fed6f4ecbdd86170eeb2ec686","unresolved":false,"context_lines":[{"line_number":18,"context_line":"  with_first_found:"},{"line_number":19,"context_line":"    - \"{{ ansible_facts[\u0027distribution\u0027] | lower }}-{{ ansible_facts[\u0027distribution_version\u0027] | lower }}.yml\""},{"line_number":20,"context_line":"    - \"{{ ansible_facts[\u0027distribution\u0027] | lower }}-{{ ansible_facts[\u0027distribution_major_version\u0027] | lower }}.yml\""},{"line_number":21,"context_line":"    - \"{{ ansible_facts[\u0027os_family\u0027] | lower }}-{{ ansible_facts[\u0027distribution_major_version\u0027] | lower }}.yml\""},{"line_number":22,"context_line":"    - \"{{ ansible_facts[\u0027distribution\u0027] | lower }}.yml\""},{"line_number":23,"context_line":"    - \"{{ ansible_facts[\u0027os_family\u0027] | lower }}-{{ ansible_facts[\u0027distribution_version\u0027].split(\u0027.\u0027)[0] }}.yml\""},{"line_number":24,"context_line":"    - \"{{ ansible_facts[\u0027os_family\u0027] | lower }}.yml\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fdf8698_03dd44e0","line":21,"in_reply_to":"c174e43a_6b619028","updated":"2022-09-14 12:46:20.000000000","message":"Done","commit_id":"595f18b406d47a44b033dffbc220deeffe69b5a1"}]}
