)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e5234479bdcc5eb698fde9935a7da7ce68819a2c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"93ecbc98_e5dffd82","updated":"2022-09-13 08:45:39.000000000","message":"\u003e Patch Set 1:\n\u003e \n\u003e The reasoning here was to have two options (firewalld and no firewalld) in the same place, so that we don\u0027t forget to update one when updating the other. I\u0027m not sure how I feel about this change. IIRC setup_firewalld was about firewalld itself, not the rules.\n\nAgree that firewall config for services should live next to the other config for those services.\n\nIf anything, setup_firewalld is the outlier here, and could be moved to a host setup role.","commit_id":"09521e1c331159ba8f7d5d642e931329d114b959"},{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"fd9313c1768ba52f1f1f83817d6661cd264c15dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ba58aaf3_fd049574","updated":"2022-09-07 09:30:43.000000000","message":"\u003e Patch Set 1:\n\u003e \n\u003e The reasoning here was to have two options (firewalld and no firewalld) in the same place, so that we don\u0027t forget to update one when updating the other. I\u0027m not sure how I feel about this change. IIRC setup_firewalld was about firewalld itself, not the rules.\n\nYep, I kinda agree, and was thinking of adding a second commit moves the iptables tasks into a file similar to the one for firewalld. Would that be suitable?\n\nAnd one last addition I\u0027d like to get in here which is to add the firewalld_zone to the connection in networkmanager.","commit_id":"09521e1c331159ba8f7d5d642e931329d114b959"}]}