)]}'
{"id":"openstack%2Fbifrost~855808","triplet_id":"openstack%2Fbifrost~master~I5a7e53bf191d286ccc2608c3a77eaea93f797492","project":"openstack/bifrost","branch":"master","topic":"firewalld","attention_set":{"25600":{"account":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"last_update":"2022-09-13 08:45:39.000000000","reason":"\u003cGERRIT_ACCOUNT_14826\u003e replied on the change","reason_account":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"}}},"removed_from_attention_set":{},"hashtags":[],"change_id":"I5a7e53bf191d286ccc2608c3a77eaea93f797492","subject":"move firewalld tasks to setup_firewalld.yml","status":"NEW","created":"2022-09-04 07:11:23.000000000","updated":"2022-09-13 08:45:39.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":false,"submittable":false,"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"e5234479bdcc5eb698fde9935a7da7ce68819a2c","_number":855808,"virtual_id_number":855808,"owner":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},{"tag":"autogenerated:zuul:check","value":1,"date":"2022-09-04 08:24:05.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"all":[{"value":-1,"date":"2022-09-07 09:30:43.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"}],"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-09-04 08:24:05.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-09-07 08:22:34.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"CC"},{"updated":"2022-09-13 08:45:39.000000000","updated_by":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"reviewer":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"state":"CC"}],"messages":[{"id":"d2f7f93737bc0b9051d60b6606bc27fd952cc55e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"date":"2022-09-04 07:11:23.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"cbe55da80ba86340b1dc6d8ce785869cd27b2c80","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-09-04 08:24:05.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/bfc3703b40474b4da63d0af55a4c5a80\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b1e1971b73704bdeb71e4077a72a8a39 : SUCCESS in 2m 17s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/c5c6e914ad5646f4a4cb01284ac16e6c : SUCCESS in 3m 00s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/c1b4588176db4a3c967d050ceeb21b31 : SUCCESS in 4m 40s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/fd478b07b8324a4281b000a9c1188bc6 : SUCCESS in 4m 07s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/021450eb79d2450f9a5794265f6bbacb : SUCCESS in 7m 09s\n- bifrost-tox-linters https://zuul.opendev.org/t/openstack/build/1b865351adf4494b9e7d3d2e692ff722 : SUCCESS in 6m 30s\n- bifrost-integration-tinyipa-centos-9 https://zuul.opendev.org/t/openstack/build/be5b479a19d14d1696dce121008bc6b6 : SUCCESS in 42m 46s\n- bifrost-integration-tinyipa-ubuntu-focal https://zuul.opendev.org/t/openstack/build/5eecc11e7c23473ca2a585ff156a32eb : SUCCESS in 33m 58s\n- bifrost-integration-tinyipa-keystone-ubuntu-focal https://zuul.opendev.org/t/openstack/build/1586210b1577407d876210d74addfde7 : SUCCESS in 33m 40s\n- bifrost-integration-tinyipa-keystone-centos-9 https://zuul.opendev.org/t/openstack/build/1649492e7263499d91d64c65a2e6692f : SUCCESS in 39m 32s\n- bifrost-integration-tinyipa-debian-bullseye https://zuul.opendev.org/t/openstack/build/02d1561842c142a697728f3dddde9e37 : SUCCESS in 32m 19s\n- bifrost-integration-redfish-vmedia-uefi-ubuntu-focal https://zuul.opendev.org/t/openstack/build/8949b79d39df452e8fd456e1ad05a011 : SUCCESS in 31m 06s\n- bifrost-integration-redfish-vmedia-uefi-centos-9 https://zuul.opendev.org/t/openstack/build/58cabd912c234ca7bdd9fcc709603178 : SUCCESS in 34m 34s\n- bifrost-upgrade-ubuntu-focal https://zuul.opendev.org/t/openstack/build/7e5e398cca4240ada37decbce04432a2 : SUCCESS in 50m 45s\n- bifrost-upgrade-keystone-centos9 https://zuul.opendev.org/t/openstack/build/0e07780e784b451b8232e5feb3a4e7d4 : SUCCESS in 1h 11m 15s\n- bifrost-integration-tinyipa-fedora-latest https://zuul.opendev.org/t/openstack/build/be7fa9e603494229a25c1ff7da544e9f : SUCCESS in 42m 03s (non-voting)\n- bifrost-integration-redfish-uefi-fedora-latest https://zuul.opendev.org/t/openstack/build/198b8837cd2a473abe90fa3e955da937 : SUCCESS in 40m 01s (non-voting)\n- bifrost-integration-dhcp-ubuntu-focal https://zuul.opendev.org/t/openstack/build/32fcecdeace644c398832ff0bad23d52 : SUCCESS in 38m 55s (non-voting)\n- bifrost-integration-dhcp-centos-9 https://zuul.opendev.org/t/openstack/build/6b113b18f4504ec2843e1edf2f1c561d : SUCCESS in 48m 42s (non-voting)\n- bifrost-integration-dibipa-debian-ubuntu-focal https://zuul.opendev.org/t/openstack/build/e2f762c6f0194af1946b6eb430cedc3c : SUCCESS in 33m 49s (non-voting)\n- bifrost-integration-dibipa-debian-centos-9 https://zuul.opendev.org/t/openstack/build/d02b83159929411389d758b373649f22 : FAILURE in 9m 44s (non-voting)\n- bifrost-cli-ubuntu-focal https://zuul.opendev.org/t/openstack/build/22ac3b34658b437e858abf8b29ffae40 : SUCCESS in 40m 11s (non-voting)\n- bifrost-collections-src https://zuul.opendev.org/t/openstack/build/af6d4505ed524396be0ad84c21099e96 : SUCCESS in 31m 25s (non-voting)\n- bifrost-keystone-collections-src https://zuul.opendev.org/t/openstack/build/9fd4bf00f0ed4a2c9ca0898b602f7352 : SUCCESS in 33m 54s (non-voting)\n- kolla-ansible-ubuntu-source-bifrost https://zuul.opendev.org/t/openstack/build/199ff139e45c4206afdddf3115ceda66 : SUCCESS in 29m 09s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"54ad61b3b75864ff6601a5027f20e019eacb915f","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2022-09-07 08:22:34.000000000","message":"Patch Set 1:\n\nThe reasoning here was to have two options (firewalld and no firewalld) in the same place, so that we don\u0027t forget to update one when updating the other. I\u0027m not sure how I feel about this change. IIRC setup_firewalld was about firewalld itself, not the rules.","accounts_in_message":[],"_revision_number":1},{"id":"fd9313c1768ba52f1f1f83817d6661cd264c15dc","author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"date":"2022-09-07 09:30:43.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"e5234479bdcc5eb698fde9935a7da7ce68819a2c","author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"date":"2022-09-13 08:45:39.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"09521e1c331159ba8f7d5d642e931329d114b959","revisions":{"09521e1c331159ba8f7d5d642e931329d114b959":{"kind":"REWORK","_number":1,"created":"2022-09-04 07:11:23.000000000","uploader":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"ref":"refs/changes/08/855808/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/bifrost","ref":"refs/changes/08/855808/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/bifrost refs/changes/08/855808/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/bifrost refs/changes/08/855808/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/bifrost refs/changes/08/855808/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/bifrost refs/changes/08/855808/1"}}},"commit":{"parents":[{"commit":"ed1ce203aeaf3ee24c7e4311472bfa70bd4954a6","subject":"Merge \"make sure we quote extra_kernel_options\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/bifrost/commit/ed1ce203aeaf3ee24c7e4311472bfa70bd4954a6"}]}],"author":{"name":"Erik Berg","email":"openstack@slipsprogrammor.no","date":"2022-09-04 04:21:56.000000000","tz":120},"committer":{"name":"Erik Berg","email":"openstack@slipsprogrammor.no","date":"2022-09-04 04:21:56.000000000","tz":120},"subject":"move firewalld tasks to setup_firewalld.yml","message":"move firewalld tasks to setup_firewalld.yml\n\nsetup_firewalld.yml seems like a good place for these stragglers.\n\nChange-Id: I5a7e53bf191d286ccc2608c3a77eaea93f797492\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/bifrost/commit/09521e1c331159ba8f7d5d642e931329d114b959"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/bifrost/commit/09521e1c331159ba8f7d5d642e931329d114b959"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"}},{"label":"Workflow","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}